Re: [RFC PATCH 03/23] Allow glibc to be compiled without EXEC_PAGESIZE

2024-04-22 Thread Samuel Thibault
Hello, Sergey Bugaev, le lun. 25 mars 2024 15:24:14 +0300, a ecrit: > On Mon, Mar 25, 2024 at 2:58 PM Florian Weimer wrote: > > > I think the intent here is to initialize _dl_pagesize with a > > > conservative default, to avoid initialization ordering issues. > > > EXEC_PAGESIZE is supposed to

Re: [PATCH 9/9] Add a test for thread state

2024-04-16 Thread Samuel Thibault
Sergey Bugaev, le mar. 16 avril 2024 10:10:11 +0300, a ecrit: > On Tue, Apr 16, 2024 at 4:01 AM Samuel Thibault > wrote: > > Ah, no, I mis read the result. It does stay stuck on x86_64. > > Indeed, thanks. Reproduced and fixed; I was accidentally using rsp > (instead

Re: [PATCH 0/9] AArch64 Mach public headers

2024-04-15 Thread Samuel Thibault
Hello, Thanks! I applied the series except the patch adding the test, since it fails on x86_64. Most probably it's the test that needs fixing. Samuel Sergey Bugaev, le lun. 15 avril 2024 12:01:40 +0300, a ecrit: > Hello! > > This patchset contains public headers for AArch64 support in GNU

Re: [PATCH 9/9] Add a test for thread state

2024-04-15 Thread Samuel Thibault
Samuel Thibault, le mar. 16 avril 2024 02:59:39 +0200, a ecrit: > Sergey Bugaev, le lun. 15 avril 2024 12:01:49 +0300, a ecrit: > > This tests generating and handling exceptions, thread_get_state(), > > thread_set_state(), and newly added thread_set_self_state(). It does >

Re: [PATCH 9/9] Add a test for thread state

2024-04-15 Thread Samuel Thibault
Sergey Bugaev, le lun. 15 avril 2024 12:01:49 +0300, a ecrit: > This tests generating and handling exceptions, thread_get_state(), > thread_set_state(), and newly added thread_set_self_state(). It does > many of the same things that glibc does when handling a signal. > --- > Note that I only

Re: [PATCH] 2024 q1 qoth file.

2024-04-07 Thread Samuel Thibault
published, thanks! Nathan Dehnel, le dim. 07 avril 2024 03:38:04 -0500, a ecrit: > I made edits to your patch. > From 7c8852217dfcee0a8623320afd3d96be7abcfb51 Mon Sep 17 00:00:00 2001 > From: Nathan Dehnel <5498361+gooberpatro...@users.noreply.github.com> > Date: Sun, 7 Apr 2024 03:26:39 -0500 >

Re: [PATCH 1/3] vm: Fix use-after-free in vm_map_pageable_scan()

2024-04-05 Thread Samuel Thibault
Hello, Applied, thanks so much! Samuel Sergey Bugaev, le ven. 05 avril 2024 18:18:48 +0300, a ecrit: > When operating on the kernel map, vm_map_pageable_scan() does what > the code itself describes as "HACK HACK HACK HACK": it unlocks the map, > and calls vm_fault_wire() with the map unlocked.

Re: [PATCH gnumach 1/2] Add MACH_MSG_TYPE_COPY_SEND_ONCE

2024-04-01 Thread Samuel Thibault
Applied, thanks! Samuel Sergey Bugaev, le lun. 01 avril 2024 12:00:17 +0300, a ecrit: > Mach allows messages to carry port rights along with data; the rights > contained in a message are transferred from the sender's IPC space to > the receiver. The sender has to specify exactly how a right

Re: [PATCH] elf-load: Respect PT_GNU_STACK

2024-03-28 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le jeu. 28 mars 2024 09:40:50 +0300, a ecrit: > On Wed, Mar 27, 2024 at 9:37 PM Samuel Thibault > wrote: > > But it's not getting used anywhere? > > Indeed, I forgot to extract the kern/bootstrap.c part of the change. > Ooops :) Thank

Re: [PATCH 17/17] tests: Create tests/ in the build tree before trying to use it

2024-03-27 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le mer. 27 mars 2024 19:18:41 +0300, a ecrit: > --- > tests/user-qemu.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/user-qemu.mk b/tests/user-qemu.mk > index fd5ae1ab..4f8390b6 100644 > --- a/tests/user-qemu.mk > +++ b/tests/user-qemu.mk > @@

Re: [PATCH 16/17] tests: Don't ask for executable stack

2024-03-27 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le mer. 27 mars 2024 19:18:40 +0300, a ecrit: > --- > tests/start.S| 2 ++ > tests/syscalls.S | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/tests/start.S b/tests/start.S > index b795bfbd..15970fb9 100644 > --- a/tests/start.S > +++

Re: [PATCH 15/17] tests: Make exception subcode a long

2024-03-27 Thread Samuel Thibault
Applied, thansks! Sergey Bugaev, le mer. 27 mars 2024 19:18:39 +0300, a ecrit: > --- > tests/test-syscalls.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/test-syscalls.c b/tests/test-syscalls.c > index 63c2690a..fbfecd9c 100644 > --- a/tests/test-syscalls.c >

Re: [PATCH 14/17] tests: Use vm_page_size

2024-03-27 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le mer. 27 mars 2024 19:18:38 +0300, a ecrit: > --- > tests/testlib_thread_start.c | 19 +++ > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a/tests/testlib_thread_start.c b/tests/testlib_thread_start.c > index fa8af0ea..df4b19ab

Re: [PATCH 13/17] tests: Add vm_page_size

2024-03-27 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le mer. 27 mars 2024 19:18:37 +0300, a ecrit: > --- > tests/include/testlib.h | 2 ++ > tests/testlib.c | 13 + > 2 files changed, 15 insertions(+) > > diff --git a/tests/include/testlib.h b/tests/include/testlib.h > index d2367124..035fdc28

Re: [PATCH 12/17] tests: Add a more serious mach_msg_server() routine

2024-03-27 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le mer. 27 mars 2024 19:18:36 +0300, a ecrit: > --- > tests/include/testlib.h | 16 ++ > tests/test-syscalls.c | 40 + > tests/testlib.c | 123 > 3 files changed, 142 insertions(+), 37

Re: [PATCH 11/17] tests: Fix halt()

2024-03-27 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le mer. 27 mars 2024 19:18:35 +0300, a ecrit: > Mark it as noreturn, and make sure to halt, not reboot. > --- > tests/include/testlib.h | 2 +- > tests/testlib.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH 10/17] Make -fno-PIE etc. architecture-dependent

2024-03-27 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le mer. 27 mars 2024 19:18:34 +0300, a ecrit: > There might be good reasons why Mach on x86 shouldn't be built as PIC/ > PIE, but there are also very good reasons to support PIE on other > architectures. Potentially implementing KASLR is one such reason; but > also

Re: [PATCH 09/17] Move copy{in,out}msg declarations to copy_user.h

2024-03-27 Thread Samuel Thibault
Sergey Bugaev, le mer. 27 mars 2024 19:18:33 +0300, a ecrit: > Since they are implemented in copy_user.c > --- > i386/i386/locore.h | 4 > ipc/copy_user.h| 15 +++ > kern/exception.c | 1 + > 3 files changed, 16 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH 08/17] ipc: Turn ipc_entry_lookup_failed() into a macro

2024-03-27 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le mer. 27 mars 2024 19:18:32 +0300, a ecrit: > ipc_entry_lookup_failed() is used with both mach_msg_user_header_t and > mach_msg_header_t arguments, which are different types. Make it into a > macro, so it works with both. > --- > ipc/ipc_space.h | 22

Re: [PATCH 07/17] kern/rdxtree: Fix undefined behavior

2024-03-27 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le mer. 27 mars 2024 19:18:31 +0300, a ecrit: > Initializing a variable with itself is undefined, and GCC 14 rightfully > produces a warning about the variable being used (to initialize itself) > prior to initialization. X15 sets the variables to 0 instead, so do

Re: [PATCH 06/17] kern/syscall_subr.c: Use copyin()/copyout() to access user memory

2024-03-27 Thread Samuel Thibault
Sergey Bugaev, le mer. 27 mars 2024 19:18:30 +0300, a ecrit: > It's not always possible to directly access user memory from kernel > mode. While it's in theory a lot more expensive to fetch each character > to be printed separately, mach_print() is only a debugging facility, and > it's not

Re: [PATCH 05/17] gsync: Use copyin()/copyout() to access user memory

2024-03-27 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le mer. 27 mars 2024 19:18:29 +0300, a ecrit: > Depending on the architecture and setup, it may not be possible to > access user memory directly, for example, due to user mode mappings not > being accessible from kernel mode (x86 SMAP, AArch64 PAN). There are >

Re: [PATCH 04/17] Load 64-bit ELFs on all 64-bit ports

2024-03-27 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le mer. 27 mars 2024 19:18:28 +0300, a ecrit: > Not only on x86_64. > --- > include/mach/exec/elf.h | 4 ++-- > kern/exception.c| 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/mach/exec/elf.h b/include/mach/exec/elf.h >

Re: [PATCH 03/17] Use the x86_64 message ABI on all 64-bit ports

2024-03-27 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le mer. 27 mars 2024 19:18:27 +0300, a ecrit: > --- > include/mach/message.h | 10 +- > ipc/ipc_kmsg.c | 4 ++-- > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/include/mach/message.h b/include/mach/message.h > index

Re: [PATCH 02/17] Disable host_kernel_version() everywhere but on i386

2024-03-27 Thread Samuel Thibault
Applied, thanks! Sergey Bugaev, le mer. 27 mars 2024 19:18:26 +0300, a ecrit: > It's not only x86_64, none of new architectures are going to have it. > --- > include/mach/mach_host.defs | 6 +++--- > kern/host.c | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) > >

Re: [PATCH 01/17] elf-load: Respect PT_GNU_STACK

2024-03-27 Thread Samuel Thibault
Hello, Sergey Bugaev, le mer. 27 mars 2024 19:18:25 +0300, a ecrit: > diff --git a/include/mach/exec/exec.h b/include/mach/exec/exec.h > index 94b234b0..29fa897d 100644 > --- a/include/mach/exec/exec.h > +++ b/include/mach/exec/exec.h > @@ -51,6 +51,8 @@ typedef struct exec_info > /* (ELF)

Re: [PATCH v12 0/2 hurd] Add irqhelp library and clean up ddekit

2024-03-26 Thread Samuel Thibault
Hello, Applied, thanks for your patience! Samuel Damien Zammit, le mar. 26 mars 2024 04:59:00 +, a ecrit: > Hi, > > This patchset adds a new library irqhelp for assisting the attachment > of irq handlers in userspace. > > The previous problem was that calling a function with a local param

Re: ntpdate : Depends: ntpsec-ntpdate but it is not installable

2024-03-24 Thread Samuel Thibault
Hello, Jose Luis Alarcon Sanchez, le dim. 24 mars 2024 13:31:22 +0100, a ecrit: > What's the situation with the package ntpsec-ntpdate?. Is there a fix > possible?. I volunteer, if i am able. Waiting for instructions to follow. Fixing the build to at least support the step adjustment should be

Re: [PATCH v11 0/2 hurd] Add irqhelp library and clean up ddekit

2024-03-24 Thread Samuel Thibault
Damien Zammit, le dim. 24 mars 2024 11:40:27 +, a ecrit: > \ Original Message > On 24 Mar 2024, 9:32 pm, Samuel Thibault > >... Your version 11 is however still accessing the \`irq\` local parameter, > >so it's still only by luck that it's working. Y

Re: [PATCH v11 0/2 hurd] Add irqhelp library and clean up ddekit

2024-03-24 Thread Samuel Thibault
Damien Zammit, le dim. 24 mars 2024 10:08:30 +, a ecrit: > The previous problem was that calling a function with a global param > from inside the wrapped_server_loop was crashing netdde > due to a bogus stack offset. This is fixed. Ah, it's not a global param, but a local param. Passing a

Re: [PATCH v2 00/20] aarch64-gnu port & GNU/Hurd on AArch64 progress

2024-03-23 Thread Samuel Thibault
Hello, Sergey Bugaev, le sam. 23 mars 2024 20:32:41 +0300, a ecrit: > This is v2 of my work on the aarch64-gnu port, aka GNU/Hurd on 64-bit > ARM. v1 is here [0]. Thanks! I applied the easy parts: patches 1-6 and 18 for now. Samuel

Re: [PATCH 01/10] term: Fix function prototype

2024-03-23 Thread Samuel Thibault
Sergey Bugaev, le sam. 23 mars 2024 15:12:21 +0300, a ecrit: > On Sat, Mar 23, 2024 at 3:06 PM Samuel Thibault > wrote: > > Applied the whole series, thanks! > > Looks like "[PATCH 07/10] exec: Add support for AArch64 executables" > fell through the cracks

Re: [PATCH 01/10] term: Fix function prototype

2024-03-23 Thread Samuel Thibault
Hello, Applied the whole series, thanks! Samuel

Re: Hard Disk size limits on GNU Hurd

2024-03-22 Thread Samuel Thibault
Hello, Tanguy LE CARROUR, le ven. 22 mars 2024 13:33:59 +0100, a ecrit: > Quoting Samuel Thibault (2024-03-22 12:37:33) > > Jose Luis Alarcon Sanchez, le ven. 22 mars 2024 12:31:04 +0100, a ecrit: > > > Several years ago there was a limit in the size of the hard disks that >

Re: Hard Disk size limits on GNU Hurd

2024-03-22 Thread Samuel Thibault
Hello, Jose Luis Alarcon Sanchez, le ven. 22 mars 2024 12:31:04 +0100, a ecrit: > Several years ago there was a limit in the size of the hard disks that Hurd > could manage. If i'm not wrong, i think it was 5 Gb. or so. > > Is still this limit working right now?, or can i create a disk image

Re: How connect Translator /hurd/ftpfs with a non anonimous ftp account with user and passwd

2024-03-17 Thread Samuel Thibault
Jose Luis Alarcon Sanchez, le dim. 17 mars 2024 20:13:13 +0100, a ecrit: > On Sun, Mar 17, 2024 at 06:48:17PM +0100, Samuel Thibault wrote: > > Hello, > > > > Jose Luis Alarcon Sanchez, le dim. 17 mars 2024 18:34:29 +0100, a ecrit: > > > The 'test' work exactly

Re: How connect Translator /hurd/ftpfs with a non anonimous ftp account with user and passwd

2024-03-17 Thread Samuel Thibault
Alexandre Garreau-Capitanio, le dim. 17 mars 2024 19:29:56 +0100, a ecrit: > On 17/03/2024 18:48, Samuel Thibault wrote: > > SERVER can be a hostname, in which case anonymous ftp is used, or may > > include a user and password like `USER:PASSWORD@HOST' (the `:PASSWORD' >

Re: How connect Translator /hurd/ftpfs with a non anonimous ftp account with user and passwd

2024-03-17 Thread Samuel Thibault
Hello, Jose Luis Alarcon Sanchez, le dim. 17 mars 2024 18:34:29 +0100, a ecrit: > The 'test' work exactly as the text say, and i did ls on the GNU FTP, but i > want to introduce here my > question: Can this be done also with a ftp server that requires an user name > and password?. I have my

Re: [PATCH 1/3 gnumach] vm_map: Fix deadlock in vm code

2024-03-17 Thread Samuel Thibault
Hello, Thanks for your answers, Sergey Bugaev, le mer. 21 févr. 2024 22:22:32 +0300, a ecrit: > On Wed, Feb 21, 2024 at 9:44 PM Samuel Thibault > wrote: > > > + * > > >* HACK HACK HACK HACK > > >*/ > > >

Re: [PATCH v10 0/2 hurd] Add irqhelp library and clean up ddekit

2024-03-17 Thread Samuel Thibault
Damien Zammit, le sam. 16 mars 2024 23:11:12 +, a ecrit: > The previous problem was that return(NULL) was crashing netdde while > pthread_exit(NULL) works for exiting the irq thread cleanly. That's not clean, actually. Since the thread is created with ddekit_thread_create, it needs to be

Re: [PATCH] console-client: Add another missing error check

2024-03-12 Thread Samuel Thibault
Applied both, thanks! Etienne Brateau, le mar. 12 mars 2024 23:08:42 +0100, a ecrit: > --- > console-client/trans.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/console-client/trans.c b/console-client/trans.c > index 0c961c2f..b7d56cb0 100644 > --- a/console-client/trans.c > +++

Re: [PATCH gnumach] x86_64: avoid iterating over the message twice in copyoutmsg/copyinmsg for faster RPCs.

2024-03-11 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le lun. 19 févr. 2024 23:58:00 -0500, a ecrit: > This is a follow up to > https://git.savannah.gnu.org/cgit/hurd/gnumach.git/commit/?id=69620634858b2992e1a362e33c95d9a8ee57bce7 > where we made inlined ports 8 bytes long to avoid resizing. > > The last thing that

Re: Package error in Debian GNU/Hurd daily image

2024-03-11 Thread Samuel Thibault
Hello, Almudena Garcia, le lun. 11 mars 2024 18:46:28 +0100, a ecrit: > Trying the latest daily, i got a new error, this time in chroot > > imagen.png > > imagen.png Those are harmless. > And the installation is stopped with this another package failure > > imagen.png It seems that

Re: [PATCH v9 0/2 hurd] Add irqhelp and clean up ddekit

2024-03-10 Thread Samuel Thibault
Hello, Damien Zammit, le dim. 10 mars 2024 02:32:48 +, a ecrit: > No, and I'm glad you asked me to. It seems that there is a bug in > mach_msg_server(), > it does not exit the while(1) loop if the irq->port is deallocated. Was that really the last reference to the port. > Is this server

Re: [PATCH web] faq: Add doc about recent SMP support and how to test

2024-03-09 Thread Samuel Thibault
Applied, thanks! Damien Zammit, le dim. 10 mars 2024 00:08:38 +, a ecrit: > --- > faq/smp.mdwn | 31 ++- > 1 file changed, 22 insertions(+), 9 deletions(-) > > diff --git a/faq/smp.mdwn b/faq/smp.mdwn > index c0133b80..ee0bf53f 100644 > --- a/faq/smp.mdwn > +++

Re: Package error in Debian GNU/Hurd daily image

2024-03-09 Thread Samuel Thibault
Almudena Garcia, le dim. 10 mars 2024 00:32:07 +0100, a ecrit: > > I don't know, but it'll probably be much simpler to debug from an installed > system. > > But, how can I install the system in real hardware without using the > installer? >   > I tried to install it in a harddisk through a VM,

Re: Package error in Debian GNU/Hurd daily image

2024-03-09 Thread Samuel Thibault
Almudena Garcia, le dim. 10 mars 2024 00:21:51 +0100, a ecrit: > Ok. Then I will wait some time until get a more stable image. I'm making some > test to check the rumpdisk support. > In Qemu and VirtualBox, rumpdisk detect the SATA CDROM and HDD successfully, > but in my Thinkpad laptops the CDROM

Re: Package error in Debian GNU/Hurd daily image

2024-03-09 Thread Samuel Thibault
Samuel Thibault, le dim. 10 mars 2024 00:11:52 +0100, a ecrit: > Almudena Garcia, le dim. 10 mars 2024 00:04:33 +0100, a ecrit: > > Trying to install the latest daily image, I've just found this error in the > > "Base system installation" step. > > > > imagen.

Re: Package error in Debian GNU/Hurd daily image

2024-03-09 Thread Samuel Thibault
Hello, Almudena Garcia, le dim. 10 mars 2024 00:04:33 +0100, a ecrit: > Trying to install the latest daily image, I've just found this error in the > "Base system installation" step. > > imagen.png > > The log show some errors > > imagen.png > > Could you fix it? Yes. ntpdate will indeed

Re: [PATCH] console-client: use xkbcommon instead of x11 for xkb extended support

2024-03-09 Thread Samuel Thibault
Hello, > 19 files changed, 547 insertions(+), 5803 deletions(-) Yay, nice cleanup :D Did you try to run Xorg with this patch applied? Did you check that it builds when xkb_common is not available? Did you try to use compose? Do you have a patch for debian's /etc/default/hurd-console file?

Re: [PATCH v9 0/2 hurd] Add irqhelp and clean up ddekit

2024-03-09 Thread Samuel Thibault
Hello, Damien Zammit, le sam. 09 mars 2024 01:18:37 +, a ecrit: > So having discussed this, we allow the irq thread to be called one more time, > but not actually call the user irq handler if the shutdown flag is set. > We acknowledge the interrupt has been handled, however. > > I tested

Re: [PATCH 3/3] move x86 copy_user.[ch] to ipc/ and make it arch-indipendent

2024-03-09 Thread Samuel Thibault
Applied, thanks! Luca Dariz, le sam. 09 mars 2024 15:02:44 +0100, a ecrit: > From: LD > > --- > Makefrag.am| 2 ++ > i386/Makefrag.am | 1 - > {x86_64 => ipc}/copy_user.c| 7 +-- > {i386/i386 => ipc}/copy_user.h | 18 +- >

Re: [PATCH 2/3] remove machine/machspl.h as it duplicates machine/spl.h

2024-03-09 Thread Samuel Thibault
Applied, thanks! Luca Dariz, le sam. 09 mars 2024 15:02:43 +0100, a ecrit: > From: LD > > --- > device/chario.c | 2 +- > device/ds_routines.c | 4 ++-- > device/net_io.c | 4 ++-- > i386/Makefrag_x86.am | 1 - >

Re: [PATCH 1/3] x86_64: split SET_KERNEL_SEGMENTS() for NCPU > 1

2024-03-09 Thread Samuel Thibault
Applied, thanks! Luca Dariz, le sam. 09 mars 2024 15:02:42 +0100, a ecrit: > This allows 32on64 to work again. Also, it's a clearer indication of a > missing part. > --- > x86_64/locore.S | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/x86_64/locore.S

Re: [PATCH 1/5] console-client: use constant value instead of magic number

2024-03-09 Thread Samuel Thibault
Hello, We however didn't receive the other 4 patches? Samuel

Re: [PATCH 1/5] console-client: use constant value instead of magic number

2024-03-08 Thread Samuel Thibault
Applied, thanks :) Etienne Brateau, le sam. 09 mars 2024 01:38:40 +0100, a ecrit: > --- > console-client/pc-kbd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/console-client/pc-kbd.c b/console-client/pc-kbd.c > index afd3411e..aa5f1103 100644 > ---

Re: [PATCH v2 hurd] MAKEDEV: when creating devices, ensure the underlying files are either block/char devices or directories

2024-03-08 Thread Samuel Thibault
Applied, thanks a lot for fixing the perl testsuite! :) Flavio Cruz, le mer. 06 mars 2024 00:32:44 -0500, a ecrit: > The perl test suite has a test where it reads all the block or char devices > under /dev without following the translators. Then it compares it against a > list of devices that

Re: [PATCH hurd] rumpdisk: do not open device if block size is 0

2024-03-08 Thread Samuel Thibault
Flávio Cruz, le jeu. 29 févr. 2024 22:01:41 -0500, a ecrit: > I could be wrong but if you look at this build log  > [3]https://buildd.debian.org > /status/fetch.php?pkg=perl=hurd-i386=5.38.2-3=1705087520=0 > it fails on t/op/stat: > > > t/op/stat

Re: [PATCH v8 0/2 hurd] Add irqhelp and clean up ddekit

2024-03-08 Thread Samuel Thibault
Damien Zammit, le ven. 08 mars 2024 06:57:47 +, a ecrit: > I think we need to allow the irq handler to be called one more time, > because we don't know if there is a pending interrupt until we need > to handle one. > Once we enable the irq one more time, it is necessary > to handle the last

Re: [PATCH hurd] MAKEDEV: when creating devices, ensure the underlying files are either block/char devices or directories

2024-03-05 Thread Samuel Thibault
Hello, Flavio Cruz, le mar. 05 mars 2024 02:13:57 -0500, a ecrit: > The perl test suite has a test where it reads all the block or char devices > under /dev without following the translators. Then it compares it against a > list of devices that read the translated nodes stat info. > > The patch

Re: [PATCH 1/1 hurd] ext2fs: New default: use xattrs to store translator records

2024-03-04 Thread Samuel Thibault
Applied, thanks! Damien Zammit, le dim. 03 mars 2024 01:00:53 +, a ecrit: > Replaces experimental option --x-xattr-translator-records > with --no-xattr-translator-records to allow rolling back to > previous behaviour. > > NB: > - Legacy records still work with either setting. > - Adding

Re: [PATCH v7 1/2 hurd] libirqhelp: Add library

2024-03-03 Thread Samuel Thibault
Damien Zammit, le sam. 02 mars 2024 10:31:50 +, a ecrit: > +static error_t > +get_acpi(void) > +{ > + error_t err = 0; > + mach_port_t tryacpi, device_master; > + > + acpidev = MACH_PORT_NULL; This looks odd. If we had a previous port in acpidev, we want to deallocate it, not forget it. >

Re: [PATCH 0/1 hurd] ext2fs - new translator entries in xattrs

2024-03-03 Thread Samuel Thibault
Damien Zammit, le dim. 03 mars 2024 01:00:48 +, a ecrit: > Do we allow a soft migration where translator entries are kept as is, > but new ones are migrated only upon creation. That will be fine for now, as we test it. > Or do we write a script that will migrate all translator entries so >

Re: [PATCH 1/1 hurd] ext2fs: New default: use xattrs to store translator records

2024-03-03 Thread Samuel Thibault
Damien Zammit, le dim. 03 mars 2024 01:00:53 +, a ecrit: > - Legacy records still work with either setting. Just to confirm: did you try to make an ext2fs built before this use the xattr record? I.e. we can go back between previous hurd package and next hurd package? Also, if

Re: [PATCH hurd] libps: update ps_emit_nice_size_t to handle arbitrarily large size_t

2024-03-03 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le dim. 03 mars 2024 12:38:19 -0500, a ecrit: > Update argument types for sprint_frac_value to reflect how big they > actually are so that GCC doesn't think it needs a larger buffer than > necessary. > --- > libps/spec.c | 22 +- > 1 file

Re: [PATCH hurd] rumpdisk: do not open device if block size is 0

2024-03-03 Thread Samuel Thibault
Flávio Cruz, le jeu. 29 févr. 2024 22:01:41 -0500, a ecrit: > On Thu, Feb 29, 2024 at 7:29 PM Samuel Thibault <[1]samuel.thiba...@gnu.org> > wrote: > > I could be wrong but if you look at this build log  > [3]https://buildd.debian.org > /status/fetch.php?pkg=perl=hurd-i3

Re: [PATCH gcc] Hurd x86_64: add unwind support for signal trampoline code

2024-02-29 Thread Samuel Thibault
lavio Cruz Reviewed-by: Samuel Thibault Thanks!! > --- > libgcc/config/i386/gnu-unwind.h | 97 - > 1 file changed, 94 insertions(+), 3 deletions(-) > > diff --git a/libgcc/config/i386/gnu-unwind.h b/libgcc/config/i386/gnu-unwind.h > index 0751b55

Re: [PATCH hurd] rumpdisk: do not open device if block size is 0

2024-02-29 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le mer. 28 févr. 2024 22:39:10 -0500, a ecrit: > The computer seems to get stuck, caused by the divide by 0 in the > rumpdisk server in device_get_status. I noticed that if we have no disk in the > cdrom device, we can still open it but block and media size will be 0

Re: [PATCH gnumach] Check for null ports in task_set_essential, task_set_name and thread_set_name.

2024-02-28 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le dim. 25 févr. 2024 01:46:38 -0500, a ecrit: > Otherwise, it is easy to crash the kernel if userland passes arbitrary port > names. > --- > kern/task.c | 6 ++ > kern/thread.c | 3 +++ > 2 files changed, 9 insertions(+) > > diff --git a/kern/task.c

Re: [PATCH v3 gnumach] smp: Rearrange IPI sending mechanism

2024-02-23 Thread Samuel Thibault
Damien Zammit, le ven. 23 févr. 2024 08:14:53 +, a ecrit: > Wait for ICR then just assert the signal. > Linux and NetBSD does it this way, assume they know better. But also possibly not. IIRC Almudena had good reasons to set the code this way. What problem does this actually solve? Remember

Re: [PATCH gnumach] pmap: Add assert_splsched calls to ensure at SPL7

2024-02-23 Thread Samuel Thibault
Reworked a differnt way :) Damien Zammit, le ven. 23 févr. 2024 08:14:32 +, a ecrit: > --- > i386/intel/pmap.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/i386/intel/pmap.c b/i386/intel/pmap.c > index e43b06c1..cf075a43 100644 > --- a/i386/intel/pmap.c > +++

Re: [PATCH v2 gnumach] vm_map: Add comment and assert for vm_map_delete

2024-02-23 Thread Samuel Thibault
Applied, thanks! Damien Zammit, le ven. 23 févr. 2024 08:15:11 +, a ecrit: > This will prevent calling vm_map_delete without the map locked > unless ref_count is zero. > --- > vm/vm_map.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/vm/vm_map.c b/vm/vm_map.c > index

Re: [PATCH gnumach] kern: Use _nocheck variants of locks taken at splsched()

2024-02-23 Thread Samuel Thibault
Fixed and applied, thanks! Damien Zammit, le ven. 23 févr. 2024 08:14:10 +, a ecrit: > Fixes assertion errors when LDEBUG is compiled in. > --- > kern/machine.c| 6 -- > kern/sched_prim.c | 38 -- > 2 files changed, 28 insertions(+), 16

Re: [PATCH gnumach] kern/processor: Do not set default_pset.empty on bootstrap

2024-02-23 Thread Samuel Thibault
Applied, thanks! Damien Zammit, le ven. 23 févr. 2024 08:04:13 +, a ecrit: > This is not needed because cpu_up does this when it comes online, > it calls pset_add_processor(). > --- > kern/processor.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/kern/processor.c

Re: [PATCH gnumach] kern: Use _irq variant of lock and disable interrupts

2024-02-23 Thread Samuel Thibault
Applied, thanks! Damien Zammit, le ven. 23 févr. 2024 08:09:55 +, a ecrit: > During quantum adjustment, disable interrupts and call appropriate lock. > --- > kern/priority.c | 4 ++-- > kern/processor.c | 2 +- > kern/processor.h | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) >

Re: Are you doing this too for GNU/Hurd?

2024-02-22 Thread Samuel Thibault
Svante Signell, le jeu. 22 févr. 2024 18:13:50 +0100, a ecrit: > On Thu, 2024-02-22 at 17:43 +0100, Samuel Thibault wrote: > > Svante Signell, le jeu. 22 févr. 2024 17:36:15 +0100, a ecrit: > > > Changes: > > > ... > > >  gcc-13 (13.2.0-14) experimental; urgency

Re: Are you doing this too for GNU/Hurd?

2024-02-22 Thread Samuel Thibault
Svante Signell, le jeu. 22 févr. 2024 17:36:15 +0100, a ecrit: > Changes: > ... > gcc-13 (13.2.0-14) experimental; urgency=medium > * Pass -D_TIME_BITS=64 together with -D_FILE_OFFSET_BITS=64 by default > on the 32bit architectures armel, armhf, hppa, m68k, mips, mipsel, > powerpc (-m32

Re: [PATCH v2 3/3 gnumach] kern/gsync: Use vm_map_lookup with keep_map_locked

2024-02-22 Thread Samuel Thibault
Looks much nicer indeed, applied, thanks! Damien Zammit, le jeu. 22 févr. 2024 08:24:39 +, a ecrit: > This prevents a deadlock in smp where a read lock on the map > is taken in gsync and then the map is locked again inside > vm_map_lookup() but another thread had a pre-existing write lock, >

Re: [PATCH v2 1/3 gnumach] vm_map: Add comment and assert for vm_map_delete

2024-02-22 Thread Samuel Thibault
Hello, Damien Zammit, le jeu. 22 févr. 2024 08:24:25 +, a ecrit: > + /* > + * Must be called with map lock taken unless refcount is zero > + */ > + assert((map->ref_count > 0 && map->lock.want_write) || (map->ref_count > == 0)); Please rather use have_write_lock().

Re: [PATCH 1/3 gnumach] vm_map: Fix deadlock in vm code

2024-02-21 Thread Samuel Thibault
Damien Zammit, le mer. 21 févr. 2024 13:45:59 +, a ecrit: > Authored-by: Sergey Bugaev > --- > vm/vm_map.c | 32 ++-- > 1 file changed, 22 insertions(+), 10 deletions(-) > > diff --git a/vm/vm_map.c b/vm/vm_map.c > index f221c532..e4672260 100644 > ---

Re: [PATCH 0/3 gnumach] vm_map and gsync changes

2024-02-21 Thread Samuel Thibault
Damien Zammit, le mer. 21 févr. 2024 13:45:55 +, a ecrit: > gnumach source code to be compiled on 7 cores without faults, using: > ./smp /bin/bash > make -j7 Oh!!! We definitely want to try to deploy this on the buildds :D Could you also try to benchmark a bit, to get an idea of

Re: [PATCH 2/3 gnumach] vm_map_lookup: Add parameter for exiting with map locked

2024-02-21 Thread Samuel Thibault
(sorry my mail server kept the first mails for itself for some time...) Damien Zammit, le mer. 21 févr. 2024 13:46:05 +, a ecrit: > diff --git a/vm/vm_map.c b/vm/vm_map.c > index e4672260..090a5c9c 100644 > --- a/vm/vm_map.c > +++ b/vm/vm_map.c > @@ -4627,7 +4627,8 @@ vm_map_t

Re: [PATCH 3/3 gnumach] kern/gsync: Use vm_map_lookup with exit_map_locked as appropriate

2024-02-21 Thread Samuel Thibault
Damien Zammit, le mer. 21 févr. 2024 13:46:10 +, a ecrit: > This refactors gsync functions so that the read lock on vm map > is only taken once and extended throughout appropriate calls. Please also explain here the "why": the deadlock scenario that was found otherwise. > Co-Authored-By:

Re: [PATCH hurd] Add proc_getchildren_rusage RPC and track rusage for children and descendants

2024-02-17 Thread Samuel Thibault
Flávio Cruz, le sam. 17 févr. 2024 16:56:48 -0500, a ecrit: > Thanks for the reviews, Samuel! Did you forget to push this change? :) For this one, perhaps, but with the second one, both went in :) Samuel

Re: [PATCH glibc] Implement setcontext/getcontext/makecontext/swapcontext for Hurd x86_64

2024-02-17 Thread Samuel Thibault
Applied, thanks!! Flavio Cruz, le sam. 17 févr. 2024 15:25:35 -0500, a ecrit: > Tested with the tests provided by glibc plus some other toy examples. > --- > sysdeps/mach/hurd/x86_64/Makefile | 4 + > sysdeps/mach/hurd/x86_64/__start_context.S | 49 + >

Re: [PATCH glibc] Use proc_getchildren_rusage when available in getrusage and times.

2024-02-17 Thread Samuel Thibault
Looks much nicer, applied, thanks! :D Flavio Cruz, le sam. 17 févr. 2024 11:48:46 -0500, a ecrit: > --- > config.h.in| 3 + > sysdeps/mach/hurd/configure| 174 + > sysdeps/mach/hurd/configure.ac | 19 > sysdeps/mach/hurd/getrusage.c

Re: [PATCH glibc] Use proc_getchildren_rusage when available in getrusage and times.

2024-02-16 Thread Samuel Thibault
Flavio Cruz, le ven. 16 févr. 2024 13:26:30 -0500, a ecrit: > diff --git a/sysdeps/mach/configure.ac b/sysdeps/mach/configure.ac > index 730fb25d..db1e453f 100644 > --- a/sysdeps/mach/configure.ac > +++ b/sysdeps/mach/configure.ac Mach is not necessarily about hurd :) Better put it in

Re: [PATCH hurd] Add proc_getchildren_rusage RPC and track rusage for children and descendants

2024-02-16 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le ven. 16 févr. 2024 13:26:29 -0500, a ecrit: > --- > hurd/process.defs | 6 ++ > proc/info.c | 8 > proc/proc.h | 4 +++- > proc/wait.c | 2 ++ > 4 files changed, 19 insertions(+), 1 deletion(-) > > diff --git a/hurd/process.defs

Re: [PATCH v2] Port GDB to Hurd x86_64.

2024-02-15 Thread Samuel Thibault
Seems now to work fine with libraries indeed, thanks! I have uploaded fixed packages to debian-ports, to be available within a few hours. Samuel Flavio Cruz, le jeu. 15 févr. 2024 01:56:14 -0500, a ecrit: > This port extends the existing i686 port to support x86_64 by trying to > reuse existing

Re: [PATCH] Port GDB to Hurd x86_64.

2024-02-14 Thread Samuel Thibault
FI, I have uploaded updated gdb packages to debian-ports. I noticed that we get warnings about libraries and the backtrace indeed gets wrong in libraries, so that probably needs some more fixes. Samuel Flavio Cruz, le lun. 12 févr. 2024 23:31:00 -0500, a ecrit: > This port extends the existing

Re: [PATCH gnumach] smp: Set processor set to non-empty when adding a processor

2024-02-12 Thread Samuel Thibault
Applied, thanks! Damien Zammit, le lun. 12 févr. 2024 05:38:24 +, a ecrit: > This allows the slave_pset to be used for actual tasks > with the processor_set RPCs. > --- > kern/processor.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kern/processor.c b/kern/processor.c > index

Re: [PATCH 2/2] Add thread_set_name RPC.

2024-02-12 Thread Samuel Thibault
Applied, thanks! Flavio Cruz, le lun. 12 févr. 2024 01:26:34 -0500, a ecrit: > Like task_set_name, we use the same size as the task name and will > inherit the task name, whenever it exists. This will be used to > implement pthread_setname_np. > --- > ddb/db_print.c| 9 + >

Re: [PATCH gnumach] smp: Create AP processor set and put all APs inside it

2024-02-11 Thread Samuel Thibault
Samuel Thibault, le dim. 11 févr. 2024 16:50:51 +0100, a ecrit: > Almudena Garcia, le dim. 11 févr. 2024 16:23:17 +0100, a ecrit: > > But, how can I add the processors to the pset from userspace? > > Using processor set RPCs > > Probably we are missing an RPC to get th

Re: [PATCH gnumach] smp: Create AP processor set and put all APs inside it

2024-02-11 Thread Samuel Thibault
Almudena Garcia, le dim. 11 févr. 2024 16:23:17 +0100, a ecrit: > But, how can I add the processors to the pset from userspace? Using processor set RPCs Probably we are missing an RPC to get the pset containing APs, but that's not hard to add. Samuel

Re: [PATCH gnumach] smp: Create AP processor set and put all APs inside it

2024-02-11 Thread Samuel Thibault
Samuel Thibault, le dim. 11 févr. 2024 15:13:51 +0100, a ecrit: > By being able to select which block gets exposed to parallelism, you can > selectively check which blocks work and which don't. (while also being already useful to be able to run make in parallel ;) Samuel

Re: [PATCH gnumach] Enable MACH_HOST and fix non-addressable bitfields

2024-02-11 Thread Samuel Thibault
Samuel Thibault, le dim. 11 févr. 2024 15:01:43 +0100, a ecrit: > Damien Zammit, le dim. 11 févr. 2024 11:30:31 +, a ecrit: > > On 2/11/24 10:07 PM, Samuel Thibault wrote: > > > Damien Zammit, le dim. 11 févr. 2024 10:55:26 +, a ecrit: > > >>>> di

Re: [PATCH gnumach] smp: Create AP processor set and put all APs inside it

2024-02-11 Thread Samuel Thibault
Almudena Garcia, le dim. 11 févr. 2024 11:17:01 +, a ecrit: > With this old patch I got to boot and executive a bunch of threads splitting > in multiple cpus > > https://git.zammit.org/gnumach-sv.git/commit/?h=fixes=0fe92b6b52726bcd2976863d344117dad8d19694 > > With the patch I quote and

Re: [PATCH v2 gnumach] Enable MACH_HOST and fix non-addressable bitfields

2024-02-11 Thread Samuel Thibault
fixed and applied, thanks! Damien Zammit, le dim. 11 févr. 2024 12:00:29 +, a ecrit: > This is only enabled when NCPUS > 1. > Enables some older code paths that allows userspace > to manage cpu resources via processor set RPCs. > > Size of struct task is preserved while making 4 bitfields >

Re: [PATCH v2 gnumach] smp: Create AP processor set and put all APs inside it

2024-02-11 Thread Samuel Thibault
Applied, thanks! Damien Zammit, le dim. 11 févr. 2024 12:00:57 +, a ecrit: > This has the effect of running with one cpu only with smp, > but has the ability to enable APs in userspace with the right > processor set RPCs. > --- > ddb/db_print.c | 10 +++--- > kern/machine.c | 13

Re: [PATCH v2 gnumach] smp: Fix unable to enter kdb during boot

2024-02-11 Thread Samuel Thibault
Applied, thanks! Damien Zammit, le dim. 11 févr. 2024 12:00:04 +, a ecrit: > --- > i386/i386at/kd.c | 1 + > i386/i386at/kd_event.c | 2 -- > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/i386/i386at/kd.c b/i386/i386at/kd.c > index 984d62e3..2bea3c8c 100644 > ---

  1   2   3   4   5   6   7   8   9   10   >