Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Sat, 25 May 2024 23:55:01 -0700
Subject: [PATCH] Use gnulib select module.
* ftp/Makefile.am (LDADD): Add $(SELECT_LIB).
* ping/Makefile.am (LDADD): Likewise.
* src/Makefile.am (rexec_LDADD, rsh_LADD, traceroute_LDADD)
(inetd_LDADD, rexecd_LDADD
Hi Simon,
On 5/12/24 3:56 AM, Simon Josefsson via Bug reports for the GNU Internet
utilities wrote:
> I have committed the attached patches giving us reproducible tarballs.
>
> The particular logic to verify this continously is in the
> 000-reproducibility pipeline job, code here:
Cool!
A bit
On 5/12/24 12:23 AM, Simon Josefsson wrote:
>> With an exception for some Kerberos 4 stuff, which I cannot test. I
>> assume the plan is still to remove that as mentioned in TODO?
>
> Let's keep that question open for a while more...
Sounds good.
>> In any case, I could test telnet commands
Hi Simon,
On 5/12/24 12:20 AM, Simon Josefsson wrote:
> I enabled c23 build for gcc-14.1 now, and it passes:
>
> https://gitlab.com/gsasl/inetutils/-/jobs/6830704753
Nice, Thanks!
> I see we weren't using the warnings module from gnulib at all. I recall
> we were worried that if we are going
(2)
CollinFrom 380bbda03648b8f2f2b1590547d4afa4b40152af Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Fri, 10 May 2024 20:51:53 -0700
Subject: [PATCH] telnet: Make function declarations C23 compatible.
* NEWS: Mention C23 support.
* telnet/commands.c (Sendlist, Togglelist, Setlist, ModeList, SlcL
On 5/10/24 6:52 AM, Simon Josefsson wrote:>> $ ./configure CC="gcc-14.1"
CFLAGS="-std=c23 -Wstrict-prototypes" --enable-authentication
--enable-encryption --with-krb5
>
> Ah, you answered my request from the earlier email already :-)
:)
> Looks good, and yes let's improve the compiler warning
~^~
CollinFrom 25816697e6c79ae0e009b4762d8f325dfad6e99e Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Thu, 9 May 2024 21:10:57 -0700
Subject: [PATCH] libtelnet: Make encryption decls compatible with C23.
* libtelnet/enc-proto.h (findencryption, finddecryption): Add
prototypes.
saying Inetutils can be compiled in
C23 mode for whenever there is a release.
CollinFrom dd4c077b3407b7fc0bd88313ee54c7c9200e2498 Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Thu, 9 May 2024 18:51:54 -0700
Subject: [PATCH] maint: Fix most instances of '-Wstrict-prototypes'.
* libinetutils/des_rw.c
On 5/9/24 12:32 AM, Simon Josefsson wrote:
> These looks good to me, thank you! Please push them.
Done.
> Btw, if you are used to working on gitlab -- to get feedback from CI/CD
> testing directly -- you can push test branches to your personal fork of
> https://gitlab.com/gsasl/inetutils and
e...
[1]
https://github.com/NetBSD/src/commit/797d779cf1e0fea886f40c274a5e87d72e1d4b77
[2]
https://github.com/NetBSD/src/commit/b87e54c002f7345d281ff7ab0c325d0336a8a8a2
CollinFrom e5a9384c928f853eefba28435d63cb8337d30b13 Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Wed, 8 May 2024 20:20:
Hi Simon and Gulliem,
On 5/8/24 1:06 PM, Simon Josefsson via Bug reports for the GNU Internet
utilities wrote:
> Hi Guillem. I added the bootstrap files to the tarball now.
>
> I'm not convinced that this is a good idea, so let's consider this an
> experiment. First, this is not recommended
On 5/7/24 12:25 AM, Simon Josefsson wrote:
> Yes please indent code and write a NEWS entry about fixing some ASAN
> alarms.
I've pushed the attached patch. Now 'make syntax-check' should be
happy.
CollinFrom cd3a8b26fba59ef62905dbfa19bf07be0a61e993 Mon Sep 17 00:00:00 2001
From: Colli
On 5/6/24 6:03 PM, Collin Funk wrote:
> So I am confident it is a bug. I've applied the attached patch which
> seems to fix the issue. This is based on a quick glance of the code so
> I would appreciate others looking it over. Thanks!
Oops, I forgot to run 'make indent', sorry...
I'll j
e applied the attached patch which
seems to fix the issue. This is based on a quick glance of the code so
I would appreciate others looking it over. Thanks!
CollinFrom 45d5900c9ee8d03554f28d698fc8533c7dcb321b Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Mon, 6 May 2024 17:57:11 -0700
Subject:
On 5/6/24 5:26 AM, Simon Josefsson wrote:
> Looks good to me, feel free to push.
Done, with some slight changes to the fist patch now that some checks
are in Gnulib.
> I do mostly agree, however there is another concern: frivolious changes
> like this makes it harder to align code with BSD
' and 'rindex' vs 'strrchr'.
That stuff probably hinders portability more than it helps as the
years go on. :)
CollinFrom 17afd1df789db615f9a6867688a54e18b8e2f316 Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Sun, 5 May 2024 18:26:21 -0700
Subject: [PATCH 1/2] cfg.mk: Add checks for 'caddr_t'.
* cfg.mk
On 5/4/24 2:03 PM, Collin Funk wrote:
> I've sent a 'request for inclusion' to the Inetutils group on
> Savannah.
I got added, so I just pushed those 2 patches + the one I sent
previously removing unessecary 'extern char **environ' decls.
Collin
On 5/4/24 10:41 AM, Simon Josefsson wrote:
>> But they forgot to do u_int. Patch 0001 adds one for u_int and patch
>> 0002 removes them.
>
> Thank you -- looks good to me, feel free to push.
Thanks!
I've sent a 'request for inclusion' to the Inetutils group on
Savannah.
I assume committer rules
GW define these, so it would work fine in 99% of
places.
CollinFrom 90f512bb93d9aa5b9b1c1c38991c0b53283db45d Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Sat, 4 May 2024 01:34:39 -0700
Subject: [PATCH 1/2] cfg.mk: Add checks for 'u_int'.
* cfg.mk (sc_unsigned_int): New rule.
(sc_unsigned_short): Cor
On 5/2/24 11:46 PM, Simon Josefsson wrote:
> Nice catch. It doesn't make sense for maint.mk's indentation to be
> influenced by ~/.indent.pro -- the style has to be a per-project
> setting. I pushed the patch below.
Thanks. Inetutils now runs 'make syntax-check' and passes for me.
Collin
Hi Simon,
On 5/2/24 11:25 AM, Simon Josefsson via Bug reports for the GNU Internet
utilities wrote:
>> Sadly, I cannot do this, at least not easily. After installing GNU
>> indent, "make syntax-check" complains about many files:
>>
>> $ indent --version
>> GNU indent 2.2.12
> You need
Hi Simon,
On 5/2/24 10:55 AM, Simon Josefsson wrote:
>> Specifically, are these items still true?
>
> I think you should pretty much assume very little is up to date or
> correct in inetutils.
Haha, good to know. :)
>>> generally use gnulib for portability more than we use today:
>>> -
no need
to include stdbool.h. If the compiler doesn't support bool stuff as a
keyword the header is included in config.h.
[1] https://www.gnu.org/software/gnulib/manual/html_node/environ.html
CollinFrom 079eb20eb805a1411e082364762eb7973c402098 Mon Sep 17 00:00:00 2001
From: Collin Funk
Date: Thu, 2 May 2
Hi Simon,
On 4/24/24 6:22 AM, Simon Josefsson wrote:
> I think this was fairly common before. If there had been a 'make
> syntax-check' rule for this, we would have caught it! I have removed
> use of HAVE_CONFIG_H and fixed telnetd.h in Inetutils now, thanks.
Thanks! It showed up from some
On 3/22/24 2:18 PM, Simon Josefsson wrote:
> Upgrading inetutils to use gnulib-tool.py would be nice. As a start, I
> bumped the gnulib submodule.
Bruno and I are still working on it with a test suite. We want the
file output and stdout output to be the same before we recommend using
it. Then we
Hi Simon,
On 3/22/24 12:51 PM, Simon Josefsson wrote:
> Hi. Nice catch, thank you. I have added a CI/CD job to catch -lsystemd
> regressions in the future:
Nice, looks good to me.
> Thank you for details -- I think this is somewhat subjective, but I do
> prefer to augment as specific LDADD's
From: Collin Funk
Date: Thu, 21 Mar 2024 21:55:47 -0700
Subject: [PATCH] maint: Allow gnulib's readutmp module to use systemd.
* src/Makefile.am (LDADD): Link to $(READUTMP_LIB).
* talkd/Makefile.am (LDADD): Likewise.
* tests/Makefile.am (LDADD): Likewise.
---
src/Makefile.am | 3 ++-
talkd
2001
From: Collin Funk
Date: Sun, 7 Jan 2024 12:09:43 -0800
Subject: [PATCH] Fixed for a few compiler warnings.
Fixed shadowed local variables in ftp/ftpd.c, ifconfig/changif.c,
and ifconfig/options.c.
Converted size_t to idx_t to match function declarations in
src/syslogd.c and talkd/process.c
28 matches
Mail list logo
