Re: fixing the ftp crashes found via fuzzer (was: Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.)

Hi, On 25.09.22 14:52, Erik Auerswald wrote: On Tue, Sep 20, 2022 at 11:11:06PM +0200, Erik Auerswald wrote: On Mon, Sep 19, 2022 at 10:31:15PM +0200, Erik Auerswald wrote: On Sat, Sep 03, 2022 at 07:07:52PM +0200, Erik Auerswald wrote: On Sat, Sep 03, 2022 at 05:39:45PM +0200, Simon

Re: fixing the ftp crashes found via fuzzer (was: Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.)

Hi, On Tue, Sep 20, 2022 at 11:11:06PM +0200, Erik Auerswald wrote: > On Mon, Sep 19, 2022 at 10:31:15PM +0200, Erik Auerswald wrote: > > On Sat, Sep 03, 2022 at 07:07:52PM +0200, Erik Auerswald wrote: > > > On Sat, Sep 03, 2022 at 05:39:45PM +0200, Simon Josefsson wrote: > > > > [...] > > > >

fixing the ftp crashes found via fuzzer (was: Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.)

Hi, On Mon, Sep 19, 2022 at 10:31:15PM +0200, Erik Auerswald wrote: > On Sat, Sep 03, 2022 at 07:07:52PM +0200, Erik Auerswald wrote: > > On Sat, Sep 03, 2022 at 05:39:45PM +0200, Simon Josefsson wrote: > > > [...] > > > did you notice some fuzzing report that wasn't fixed? > > > > I think the

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Hi Simon, On Sat, Sep 03, 2022 at 07:07:52PM +0200, Erik Auerswald wrote: > On Sat, Sep 03, 2022 at 05:39:45PM +0200, Simon Josefsson wrote: > > [...] > > did you notice some fuzzing report that wasn't fixed? > > I think the following reports have not yet been addressed: > > * Problems found in

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Erik Auerswald writes: >> You might want to take a look at: >> >> > > Thanks for pointing out that patch. Without it telnet crashes when > it starts the

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Hi Guillem, On 03.09.22 20:08, Guillem Jover wrote: [ Removed Erik from To, as last time my mail was rejected by the mail server, and might then not get delivered by mailman as duplicate. ] :-( I have sent this email to bug-inetutils@gnu.org only to avoid this kind of problem. You might

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

[ Removed Erik from To, as last time my mail was rejected by the mail server, and might then not get delivered by mailman as duplicate. ] Hi! On Sat, 2022-09-03 at 19:07:52 +0200, Erik Auerswald wrote: > AFAIK the other fuzzer-based crash reports have already been addressed > before the

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Hello Simon, On Sat, Sep 03, 2022 at 05:39:45PM +0200, Simon Josefsson wrote: > Erik Auerswald writes: > > >> Please test commit access by pushing the patch, after writing > >> a suitable NEWS entry. > > > > I have just committed and pushed the telnetd crash fix patch[1], > > including a NEWS

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Erik Auerswald writes: >> Please test commit access by pushing the patch, after writing >> a suitable NEWS entry. > > I have just committed and pushed the telnetd crash fix patch[1], > including a NEWS entry. > > [1] https://lists.gnu.org/archive/html/bug-inetutils/2022-08/msg2.html Looks

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Hello Simon, On Fri, Sep 02, 2022 at 10:14:52PM +0200, Simon Josefsson wrote: > fre 2022-09-02 klockan 20:37 +0200 skrev Erik Auerswald: > > On Sat, Jul 09, 2022 at 04:23:20PM +0200, Simon Josefsson wrote: > > > [...] > > > What's your savannah username? > > > [...] > > > > My Savannah username

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

fre 2022-09-02 klockan 20:37 +0200 skrev Erik Auerswald: > Hello Simon, > > On Sat, Jul 09, 2022 at 04:23:20PM +0200, Simon Josefsson wrote: > > [...] > > What's your savannah username? > > [...] > > My Savannah username is "auerswal" > . Welcome!

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Hello Simon, On Sat, Jul 09, 2022 at 04:23:20PM +0200, Simon Josefsson wrote: > [...] > What's your savannah username? > [...] My Savannah username is "auerswal" . Br, Erik

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Hi Simon, On 05.08.22 20:24, Simon Josefsson wrote: Erik Auerswald writes: [...] I'm not that familiar with NixOS but noticed now that builds fail. The NixOS build fails because of too old Automake: I don't know how to modify the NixOS build rules -- if you have time to engage with the

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Erik Auerswald writes: > The Debian 11 build fails because it attempts to create a release with > a bogus version number. The error is: > > ... > GEN release-prep > announce-gen: ./NEWS: no news item found for '42.4711' > make[3]: *** [maint.mk:1422: announcement] Error

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Hi Simon, On Thu, Jul 14, 2022 at 04:06:47PM +0200, Erik Auerswald wrote: > On Fri, Jul 08, 2022 at 11:49:57AM +0200, Simon Josefsson wrote: > > [...] > > You may want to look at NixOS or GitLab CI/CD for build failures: > > https://hydra.nixos.org/jobset/gnu/inetutils-master > > [...] > > I'm

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Hello Simon, On Fri, Jul 08, 2022 at 11:49:57AM +0200, Simon Josefsson wrote: > Erik Auerswald writes: > > > I want to look at your new tests, perhaps I can learn how to add some > > tests to verify the genget() functionality. > > The test suite today is rather limited, as you probably have

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Erik Auerswald writes: > Hello Simon, > > On Sat, Jul 09, 2022 at 02:36:41PM +0200, Simon Josefsson wrote: >> Erik Auerswald writes: >> > On Fri, Jul 08, 2022 at 08:55:18AM +0200, Erik Auerswald wrote: >> >> On Fri, Jul 08, 2022 at 12:58:37AM +0200, Simon Josefsson wrote: >> >> >> >> > Thanks

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Hello Simon, On Sat, Jul 09, 2022 at 02:36:41PM +0200, Simon Josefsson wrote: > Erik Auerswald writes: > > On Fri, Jul 08, 2022 at 08:55:18AM +0200, Erik Auerswald wrote: > >> On Fri, Jul 08, 2022 at 12:58:37AM +0200, Simon Josefsson wrote: > >> > >> > Thanks for preparing these [...] > >> >

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Erik Auerswald writes: > Hello Simon, > > On Fri, Jul 08, 2022 at 08:55:18AM +0200, Erik Auerswald wrote: >> On Fri, Jul 08, 2022 at 12:58:37AM +0200, Simon Josefsson wrote: >> >> > Thanks for preparing these, I should have read through all posts >> > before started working on them

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Hello Simon, On Fri, Jul 08, 2022 at 08:55:18AM +0200, Erik Auerswald wrote: > On Fri, Jul 08, 2022 at 12:58:37AM +0200, Simon Josefsson wrote: > > > Thanks for preparing these, I should have read through all posts > > before started working on them separately... so this patch no longer > >

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Erik Auerswald writes: > I want to look at your new tests, perhaps I can learn how to add some > tests to verify the genget() functionality. The test suite today is rather limited, as you probably have noticed, but going forward it would really help if we created a self-check that triggers a

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Hi Simon, On Fri, Jul 08, 2022 at 09:51:28AM +0200, Simon Josefsson wrote: > Erik Auerswald writes: > > > I'll try to look into this over the weekend, but I cannot promise > > anything. But this patch series should just address the same issues > > as the patches I sent before, perhaps with

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Erik Auerswald writes: > I'll try to look into this over the weekend, but I cannot promise > anything. But this patch series should just address the same issues > as the patches I sent before, perhaps with some smaller differences. > It's been some time and I do not remember all the details. I

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Hello Simon, On Fri, Jul 08, 2022 at 12:58:37AM +0200, Simon Josefsson wrote: > Thanks for preparing these, I should have read through all posts before > started working on them separately... so this patch no longer applies > as is. Would you like to re-review these, to see if anything more > is

Re: [PATCH 3/3] telnet: Avoid command evaluation crashes.

Thanks for preparing these, I should have read through all posts before started working on them separately... so this patch no longer applies as is. Would you like to re-review these, to see if anything more is still needed after I applied some changes? Maybe it is just the NEWS entries. Btw,