Re: DOC: Correcting spelling of Harmonia Sacra in NR 1.1.4 Shape note heads

[Carl Sorensen]

On 9/30/17 4:46 PM, "David Kastrup"  wrote:

>Karlin High  writes:
>
>> This is a nitpick. The places in the documentation that reference the
>> "Harmonia Sacra" songbook by Joseph Funk have the spelling Harmonica
>> Sacra. Harmonia does not have a "c" here. A few references are below.
>> There are enough of them that a Google search for "Joseph Funk
>> Harmonica Sacra" gets auto-corrected.
>>
>> http://harmoniasacra.org/index.html
>> http://gameo.org/index.php?title=Harmonia_Sacra
>> https://www.amazon.com/Harmonia-Sacra-Joseph-Funk/dp/1932676155
>>
>> The attached patch has proposed corrections. Translated docs would be
>> affected; I do not know the process for that. Possible actions:
>>
>> * Forget it. Anyone who would be bothered by this is probably beyond
>>help.
>> * Fix directly in git like other typos
>> * Go through review and tracker like other patches
>
>I'd use option 2 here (of course, push to staging rather than master)
>after carefully reading the diff and making sure that no chapter/node
>names are affected (which would constitute a structural change and thus
>should be checked doing "make doc" before possibly inconveniencing
>others by a broken staging, either by checking yourself or creating an
>issue after all).
>
>We have had a fair share of "this could not possibly break compilation"
>kind of changes breaking compilation.
>
>Also any possibility for contention is worth a review.  This here seems
>solid enough to me.

I agree with David.

Thanks,

Carl


___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Wrong glissando for notes with duration longa

[Thomas Morley]

2017-10-03 18:18 GMT+02:00 David Kastrup :
> Thomas Morley  writes:
>
>> Version: 2.16.2: longa-note-head-stencil Y-extent: (-0.550006 . 0.550006)
>> Version: 2.19.65: longa-note-head-stencil Y-extent: (-0.72 . 3.519982)
>>
>> It's caused by:
>>
>> commit f494ef0afc8aed378bd778cd51a294804a8ee5d4
>> Author: Phil Holmes 
>> Date:   Mon Jul 29 16:09:29 2013 +0100
>>
>> Corrects bounding box for longa (Issue 826)
>>
>> related is:
>>
>> commit b27354f5fd0df898310a354c4031c2c701ecebaa
>> Author: Phil Holmes 
>> Date:   Mon Jul 29 15:21:46 2013 +0100
>>
>> Fixes bounding boxes for breves, improves longas (Issue 3480)
>>
>> Those patches tackle the skyline-problem, which causes the cut off previews.
>> So it's no good option to revert them.
>>
>> Maybe glissando should look at staff-position?
>
> That sounds sensible.


I'm afraid this will mean C++ work beyond my capabilities.

Nevertheless, I tested all noteheads for their bounding-boxes by
putting them in box-markup.
Below the code I used (here limited to default-heads and the various
mensural-note-heads).

It looks only the default was changed not the mensural-heads.
Image attached.

Cheers,
  Harm


%% after
%% Documentation/included/font-table.ly
\version "2.19.65"

\pointAndClickOff

#(define noteheads
  (filter
(lambda (s) (string-contains s "noteheads"))
(ly:otf-glyph-list (ly:system-font-load "emmentaler-20"

#(define box-glyphs
  (lambda (n)
(markup
  #:line (
#:pad-to-box '(0 . 5) '(0 . 0)
#:box
#:musicglyph n
#:fontsize -1 n

#(define (tst nh-strg)
  (make-line-markup
(list
  (make-box-markup (string-upcase nh-strg))
  (make-override-markup '(baseline-skip . 1)
(make-column-markup
  (map
box-glyphs
(filter
  (lambda (nh) (string-contains nh nh-strg))
  noteheads)))

%% Default Noteheads
$(make-line-markup
   (list
 (make-box-markup (string-upcase "default heads"))
 (make-override-markup '(baseline-skip . 1)
   (make-column-markup
 (map
   box-glyphs
   '("noteheads.uM2"
 "noteheads.dM2"
 "noteheads.sM1"
 "noteheads.sM1double"
 "noteheads.s0"
 "noteheads.s1"
 "noteheads.s2"))

%% including:
%% mensural, neomensural, ligmensural, semimensural, blackmensural
$(tst "mensural")

%% all ok with:
% $(tst "vaticana")
% $(tst "medicaea")
% $(tst "hufnagel")
% $(tst "petrucci")
% $(tst "solesmes")
% $(tst "kievan")

%% The following are not tested above, nothing fishy to be expected, though
%% NR A.8 The Emmentaler font:
%% Special Notehead glyphs
%% Shape-note Notehead glyphs

%% Testing all noteheads:
%% \pageBreak $(map box-glyphs noteheads)


atest-63.pdf
Description: Adobe PDF document
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: tabs with lyrics

[Simon Albrecht]

On 03.10.2017 16:27, bb wrote:

One more silly question, tabs with lyrics.

I did not find any help in the archives.

I tried it this way:

\version "2.19.2"


This does not, for several reasons, belong on the bug list.  When in 
doubt, ask on -user.


Best, Simon

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Wrong glissando for notes with duration longa

[David Kastrup]

Thomas Morley  writes:

> Version: 2.16.2: longa-note-head-stencil Y-extent: (-0.550006 . 0.550006)
> Version: 2.19.65: longa-note-head-stencil Y-extent: (-0.72 . 3.519982)
>
> It's caused by:
>
> commit f494ef0afc8aed378bd778cd51a294804a8ee5d4
> Author: Phil Holmes 
> Date:   Mon Jul 29 16:09:29 2013 +0100
>
> Corrects bounding box for longa (Issue 826)
>
> related is:
>
> commit b27354f5fd0df898310a354c4031c2c701ecebaa
> Author: Phil Holmes 
> Date:   Mon Jul 29 15:21:46 2013 +0100
>
> Fixes bounding boxes for breves, improves longas (Issue 3480)
>
> Those patches tackle the skyline-problem, which causes the cut off previews.
> So it's no good option to revert them.
>
> Maybe glissando should look at staff-position?

That sounds sensible.

-- 
David Kastrup

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Wrong glissando for notes with duration longa

[David Kastrup]

Thomas Morley  writes:

> 2017-10-03 13:14 GMT+02:00 David Kastrup :
>> Thomas Morley  writes:
>>
>>> Hi all,
>>>
>>> in Staff-context glissando is wrongly positioned if between notes with
>>> duration \longa
>>>
>>> \version "2.19.65"
>>> \new Staff { c''\longa \glissando c'' }
>>>
>>> Bug is present for 2.18.2 up to current master.
>>> Worked in 2.16.2
>>
>> Stem for a longa is treated differently I think.  It's part of the
>> notehead or something?
>
> Yep, the longa-"Stem" is part of the note-head.
>
> But why did it work back in 2.16.2?

Change from metric-based spacing to skyline-based spacing?

-- 
David Kastrup

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Wrong glissando for notes with duration longa

[Thomas Morley]

2017-10-03 17:04 GMT+02:00 Thomas Morley :
> 2017-10-03 13:14 GMT+02:00 David Kastrup :
>> Thomas Morley  writes:
>>
>>> Hi all,
>>>
>>> in Staff-context glissando is wrongly positioned if between notes with
>>> duration \longa
>>>
>>> \version "2.19.65"
>>> \new Staff { c''\longa \glissando c'' }
>>>
>>> Bug is present for 2.18.2 up to current master.
>>> Worked in 2.16.2
>>
>> Stem for a longa is treated differently I think.  It's part of the
>> notehead or something?
>
> Yep, the longa-"Stem" is part of the note-head.
>
> But why did it work back in 2.16.2?
> I compared glissando-engraver.cc of current master and 2.16.2 and
> found nothing suspicious.
> Ofcourse, I don't really know C++, so I may overlook relevant stuff pretty 
> fast.
>
>> There is the problem of longa stems getting cut
>> off for preview images as well if I remember correctly.  Maybe it's
>> related?
>
> Well, no clue.
>
> Cheers,
>   Harm

Ok, the following code returns different values for 2.16.2 and 2.18.2 ff

{
  \override NoteHead #'after-line-breaking =
#(lambda (grob)
  (format
#t
"\nVersion: ~a: longa-note-head-stencil Y-extent: ~a"
(lilypond-version)
(ly:stencil-extent (ly:grob-property grob 'stencil) Y)))
  c'\longa
}

->
Version: 2.16.2: longa-note-head-stencil Y-extent: (-0.550006 . 0.550006)
Version: 2.19.65: longa-note-head-stencil Y-extent: (-0.72 . 3.519982)

It's caused by:

commit f494ef0afc8aed378bd778cd51a294804a8ee5d4
Author: Phil Holmes 
Date:   Mon Jul 29 16:09:29 2013 +0100

Corrects bounding box for longa (Issue 826)

related is:

commit b27354f5fd0df898310a354c4031c2c701ecebaa
Author: Phil Holmes 
Date:   Mon Jul 29 15:21:46 2013 +0100

Fixes bounding boxes for breves, improves longas (Issue 3480)

Those patches tackle the skyline-problem, which causes the cut off previews.
So it's no good option to revert them.

Maybe glissando should look at staff-position?


Cheers,
  Harm

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Wrong glissando for notes with duration longa

[Thomas Morley]

2017-10-03 13:14 GMT+02:00 David Kastrup :
> Thomas Morley  writes:
>
>> Hi all,
>>
>> in Staff-context glissando is wrongly positioned if between notes with
>> duration \longa
>>
>> \version "2.19.65"
>> \new Staff { c''\longa \glissando c'' }
>>
>> Bug is present for 2.18.2 up to current master.
>> Worked in 2.16.2
>
> Stem for a longa is treated differently I think.  It's part of the
> notehead or something?

Yep, the longa-"Stem" is part of the note-head.

But why did it work back in 2.16.2?
I compared glissando-engraver.cc of current master and 2.16.2 and
found nothing suspicious.
Ofcourse, I don't really know C++, so I may overlook relevant stuff pretty fast.

> There is the problem of longa stems getting cut
> off for preview images as well if I remember correctly.  Maybe it's
> related?

Well, no clue.

Cheers,
  Harm

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: tabs with lyrics

[Phil Holmes]

"bb"  wrote in message 
news:054ad4b5-cd65-9e9e-74bf-1e554376b...@telecolumbus.net...

One more silly question, tabs with lyrics.

I did not find any help in the archives.

I tried it this way:

\version "2.19.2"

tune = {\clef "treble_8" a b c d e f g }
\score {
<<
\new Staff { \tune }

\new TabStaff = tab \relative c'' { \tune }
\new Lyrics { \lyricsto "tab" { Here are the words } }
>>
}


Did you look at the error message this produces?

warning: cannot find Voice `tab'

\new Lyrics {
 \lyricsto "tab" { Here are the words } }

A good hint that lyrics work with voices:

\new TabStaff { \new TabVoice = tab { \relative c'' { \tune } } }


--
Phil Holmes



___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

tabs with lyrics

[bb]

One more silly question, tabs with lyrics.

I did not find any help in the archives.

I tried it this way:

\version "2.19.2"

tune = {\clef "treble_8" a b c d e f g }
\score {
  <<
    \new Staff { \tune }

    \new TabStaff = tab \relative c'' { \tune }
    \new Lyrics { \lyricsto "tab" { Here are the words }    }
  >>
}

Another trial was with

    \new Voice = "hidden" {
  \hideNotes {\clef "treble_8" a b c d e f g }
    }
  \lyricsto "hidden" { Here are the words }
    }


Regards BB
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Wrong glissando for notes with duration longa

[David Kastrup]

Thomas Morley  writes:

> Hi all,
>
> in Staff-context glissando is wrongly positioned if between notes with
> duration \longa
>
> \version "2.19.65"
> \new Staff { c''\longa \glissando c'' }
>
> Bug is present for 2.18.2 up to current master.
> Worked in 2.16.2

Stem for a longa is treated differently I think.  It's part of the
notehead or something?  There is the problem of longa stems getting cut
off for preview images as well if I remember correctly.  Maybe it's
related?

> All other tested durations are working as long as a suitable notehead
> can be found:
> \new Staff { c''8 \glissando c'' }
> \new Staff { c''4 \glissando c'' }
> \new Staff { c''2 \glissando c'' }
> \new Staff { c''1 \glissando c'' }
> \new Staff { c''1*2 \glissando c'' }
> \new Staff { c''1*4 \glissando c'' }
> \new Staff { c''1*8 \glissando c'' }
> \new Staff { c''\breve \glissando c'' }
> % works in MensuralStaff
> \new MensuralStaff { c''\longa \glissando c'' }
> % no notehead in Staff, glissando is correct, though
> % works in MensuralStaff
> \new Staff { c''\maxima \glissando c'' }
> \new MensuralStaff { c''\maxima \glissando c'' }

-- 
David Kastrup

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Wrong glissando for notes with duration longa

[Thomas Morley]

Hi all,

in Staff-context glissando is wrongly positioned if between notes with
duration \longa

\version "2.19.65"
\new Staff { c''\longa \glissando c'' }

Bug is present for 2.18.2 up to current master.
Worked in 2.16.2

All other tested durations are working as long as a suitable notehead
can be found:
\new Staff { c''8 \glissando c'' }
\new Staff { c''4 \glissando c'' }
\new Staff { c''2 \glissando c'' }
\new Staff { c''1 \glissando c'' }
\new Staff { c''1*2 \glissando c'' }
\new Staff { c''1*4 \glissando c'' }
\new Staff { c''1*8 \glissando c'' }
\new Staff { c''\breve \glissando c'' }
% works in MensuralStaff
\new MensuralStaff { c''\longa \glissando c'' }
% no notehead in Staff, glissando is correct, though
% works in MensuralStaff
\new Staff { c''\maxima \glissando c'' }
\new MensuralStaff { c''\maxima \glissando c'' }


Cheers,
  Harm

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond