Re: Volta makes breath mark position wrong

2018-05-23 Thread Thomas Morley 
2018-05-23 1:27 GMT+02:00 Thomas Morley :
> 2018-05-23 0:54 GMT+02:00 David Kastrup :
>> Thomas Morley  writes:
>>
>>> 2018-05-22 15:12 GMT+02:00 Arkhipenko Alexey :
 Wow! Thanks a lot for your reply!

 Is it a new bug or existing one?

 Do you think that fixing this volta position bug will fix breath mark
 position? Can you run my code in the version that does not have volta
 position bug?

 Best regards,
 Alexey Arkhipenko.
>>>
>>> I didn't find something directly related on the bug tracker.
>>>
>>> Your code compiled with 2.12.3 will return correctly placed
>>> VoltaBracket and BreathingSign.
>>
>> I doubt that this is really traceable by dissection on this particular
>> case: the problem occurs when the line containing the breath mark is
>> getting extensively stretched and the breath mark gets pulled forward
>> across the note it should be preceding.
>>
>> So you need an extreme line break situation to show the problem, and
>> different versions pack the lines differently.  So I doubt that the
>> "right" or "wrong" outcome you see depends on an actual breath-related
>> code passage but rather on how this particularly example is spread
>> across lines (or not) in the different LilyPond versions.
>>
>> --
>> David Kastrup
>
>
> You may be right for the BreathingSign, not sure for the wrongly
> placed VoltaBracket, though.
> I'll do more experiments tomorrow.
>
> Cheers,
>   Harm

The code below doesn't stretch anything nor is there a line-break at
all (the colored notes should be covered by the VoltaBracket):

\relative c
<<
  \new Staff \repeat unfold 2 c'1
  \new Staff {
 \repeat volta 1 { f2. \breathe }
 \alternative {
   {
   \override NoteHead.color = #red
\repeat unfold 4 b16
b2
\revert NoteHead.color
   }
 }
 \repeat unfold 8 f16
  }
>>

One could argue it does not make much sense to code like this without
moving the relevant engravers from Score to Staff, though.

Would it be possible to throw a warning if the content covered by the
VoltaBracket doesn't match (regarding it's length) in all Staffs?

Cheers,
  Harm

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Volta makes breath mark position wrong

2018-05-22 Thread Thomas Morley 
2018-05-23 0:54 GMT+02:00 David Kastrup :
> Thomas Morley  writes:
>
>> 2018-05-22 15:12 GMT+02:00 Arkhipenko Alexey :
>>> Wow! Thanks a lot for your reply!
>>>
>>> Is it a new bug or existing one?
>>>
>>> Do you think that fixing this volta position bug will fix breath mark
>>> position? Can you run my code in the version that does not have volta
>>> position bug?
>>>
>>> Best regards,
>>> Alexey Arkhipenko.
>>
>> I didn't find something directly related on the bug tracker.
>>
>> Your code compiled with 2.12.3 will return correctly placed
>> VoltaBracket and BreathingSign.
>
> I doubt that this is really traceable by dissection on this particular
> case: the problem occurs when the line containing the breath mark is
> getting extensively stretched and the breath mark gets pulled forward
> across the note it should be preceding.
>
> So you need an extreme line break situation to show the problem, and
> different versions pack the lines differently.  So I doubt that the
> "right" or "wrong" outcome you see depends on an actual breath-related
> code passage but rather on how this particularly example is spread
> across lines (or not) in the different LilyPond versions.
>
> --
> David Kastrup


You may be right for the BreathingSign, not sure for the wrongly
placed VoltaBracket, though.
I'll do more experiments tomorrow.

Cheers,
  Harm

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Volta makes breath mark position wrong

2018-05-22 Thread David Kastrup 
Thomas Morley  writes:

> 2018-05-22 15:12 GMT+02:00 Arkhipenko Alexey :
>> Wow! Thanks a lot for your reply!
>>
>> Is it a new bug or existing one?
>>
>> Do you think that fixing this volta position bug will fix breath mark
>> position? Can you run my code in the version that does not have volta
>> position bug?
>>
>> Best regards,
>> Alexey Arkhipenko.
>
> I didn't find something directly related on the bug tracker.
>
> Your code compiled with 2.12.3 will return correctly placed
> VoltaBracket and BreathingSign.

I doubt that this is really traceable by dissection on this particular
case: the problem occurs when the line containing the breath mark is
getting extensively stretched and the breath mark gets pulled forward
across the note it should be preceding.

So you need an extreme line break situation to show the problem, and
different versions pack the lines differently.  So I doubt that the
"right" or "wrong" outcome you see depends on an actual breath-related
code passage but rather on how this particularly example is spread
across lines (or not) in the different LilyPond versions.

-- 
David Kastrup

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Volta makes breath mark position wrong

2018-05-22 Thread Thomas Morley 
2018-05-22 15:12 GMT+02:00 Arkhipenko Alexey :
> Wow! Thanks a lot for your reply!
>
> Is it a new bug or existing one?
>
> Do you think that fixing this volta position bug will fix breath mark
> position? Can you run my code in the version that does not have volta
> position bug?
>
> Best regards,
> Alexey Arkhipenko.

I didn't find something directly related on the bug tracker.

Your code compiled with 2.12.3 will return correctly placed
VoltaBracket and BreathingSign.
In newer versions you may workaround by using
\once \override Score.VoltaBracket.shorten-pair = 
I think it will fix placement of BreathingSign as well.


But mostly I tried to locate the first bad commit for the code below:

>> \relative c
>> <<
>>   \new Staff \repeat unfold 3 c'1
>>   \new Staff {
>>  \repeat volta 1 {
>>\autoBeamOff
>>R1
>>\break
>>f2.
>>  }
>>  \alternative {
>>{
>> \repeat unfold 4 b16
>> \repeat unfold 8 b16
>>}
>>  }
>>   \repeat unfold 8 f16
>>   }
>> >>

For now I can say it's before
cad8bec93311f8cbcc0b420fb5c93c0311df8979
which was in 2.13.4.

To get this version compiled I used old LilyDev2, with
gcc (Ubuntu 4.4.3-4ubuntu5.1) 4.4.3

But I failed to compile earlier versions
For example, checking out
47ca10364f3b6f64e2ecc5001be09753d509edfa
and running autogen.sh returns:

harm@harm-laptop ~/lilypond-git ((47ca103...))$ sh autogen.sh --noconfigure
processing .
Running autoconf ...
configure.in:59: warning: AC_REQUIRE: `AC_PROG_CC' was expanded before
it was required
../../lib/autoconf/c.m4:429: AC_LANG_COMPILER(C) is expanded from...
../../lib/autoconf/lang.m4:316: AC_LANG_COMPILER_REQUIRE is expanded from...
../../lib/autoconf/general.m4:2573: AC_COMPILE_IFELSE is expanded from...
aclocal.m4:167: STEPMAKE_COMPILE is expanded from...
configure.in:59: the top level
Skipping configure process.

So I'm stuck.

Any way to get this work?

Cheers,
  Harm

___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Volta makes breath mark position wrong

2018-05-22 Thread Arkhipenko Alexey 
Wow! Thanks a lot for your reply!

Is it a new bug or existing one?

Do you think that fixing this volta position bug will fix breath mark
position? Can you run my code in the version that does not have volta
position bug?

Best regards,
Alexey Arkhipenko.
http://arkhipenko.weebly.com


On Tue, May 22, 2018 at 4:03 PM Thomas Morley 
wrote:

> 2018-05-22 9:04 GMT+02:00 Arkhipenko Alexey :
> > % SORRY FOR LONG BUG REPORT! I COULDN'T MAKE IT SHORTER
> > % While score is taking 2 lanes, adding volta to measure 6 makes breath
> > sign in measure 6 move one note forward
> > % Screenshot of result: https://i.imgur.com/aqL5GS9.png
> > % Can be "fixed" by removing first voice or by removing volta
> >
> > \version "2.18.2"
> > \language "english"
> >
> > <<
> > \new Staff {
> >   \clef "treble" \key d \minor
> >   {
> > d'1 e'1 f'1 g'1
> > \glissando
> > c''1 bf'1 c'' d'' e''
> >   }
> > }
> > \new Staff {
> >   \clef "bass" \key d \minor
> >   {
> > r4 d4 e4 f4 g4 a4
> > \breathe
> > f4 g4 a4 c'4 d'4 c'4 bf4 d4 g4 f4 e4 c4 bf,4
> > \breathe
> > a,4 g,4 a,4 g,4
> > \breathe
> > \set Score.repeatCommands = #'((volta "1"))
> > f,4 e,4 g,4 a,4 b,4 cs4
> > \set Score.repeatCommands = #'((volta #f))
> > e4 f4 e4 d1
> >
> >   }
> > }
> >>>
> >
> > Best regards,
> > Alexey Arkhipenko.
> > http://arkhipenko.weebly.com
>
> Hi,
>
> I think the wrongly positioned BreathingSign is only a symptom of the
> underlying bug.
>
> It's the VoltaBracket being off.
>
> Below I made some code to highlight it more clearly.
>
> \relative c
> <<
>   \new Staff \repeat unfold 3 c'1
>   \new Staff {
>  \repeat volta 1 {
>\autoBeamOff
>R1
>\break
>f2.
>  }
>  \alternative {
>{
> \repeat unfold 4 b16
> \repeat unfold 8 b16
>}
>  }
>   \repeat unfold 8 f16
>   }
> >>
>
> I tested it from 2.21.0 downwards. 2.12.3 was the last stable version
> without this bug, see attached.
>
> Cheers,
>   Harm
>
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Re: Volta makes breath mark position wrong

2018-05-22 Thread Thomas Morley 
2018-05-22 9:04 GMT+02:00 Arkhipenko Alexey :
> % SORRY FOR LONG BUG REPORT! I COULDN'T MAKE IT SHORTER
> % While score is taking 2 lanes, adding volta to measure 6 makes breath
> sign in measure 6 move one note forward
> % Screenshot of result: https://i.imgur.com/aqL5GS9.png
> % Can be "fixed" by removing first voice or by removing volta
>
> \version "2.18.2"
> \language "english"
>
> <<
> \new Staff {
>   \clef "treble" \key d \minor
>   {
> d'1 e'1 f'1 g'1
> \glissando
> c''1 bf'1 c'' d'' e''
>   }
> }
> \new Staff {
>   \clef "bass" \key d \minor
>   {
> r4 d4 e4 f4 g4 a4
> \breathe
> f4 g4 a4 c'4 d'4 c'4 bf4 d4 g4 f4 e4 c4 bf,4
> \breathe
> a,4 g,4 a,4 g,4
> \breathe
> \set Score.repeatCommands = #'((volta "1"))
> f,4 e,4 g,4 a,4 b,4 cs4
> \set Score.repeatCommands = #'((volta #f))
> e4 f4 e4 d1
>
>   }
> }
>>>
>
> Best regards,
> Alexey Arkhipenko.
> http://arkhipenko.weebly.com

Hi,

I think the wrongly positioned BreathingSign is only a symptom of the
underlying bug.

It's the VoltaBracket being off.

Below I made some code to highlight it more clearly.

\relative c
<<
  \new Staff \repeat unfold 3 c'1
  \new Staff {
 \repeat volta 1 {
   \autoBeamOff
   R1
   \break
   f2.
 }
 \alternative {
   {
\repeat unfold 4 b16
\repeat unfold 8 b16
   }
 }
  \repeat unfold 8 f16
  }
>>

I tested it from 2.21.0 downwards. 2.12.3 was the last stable version
without this bug, see attached.

Cheers,
  Harm
___
bug-lilypond mailing list
bug-lilypond@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-lilypond