RE: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-07 Thread Pavel Fedin
Hello! This is what I'd expect. Good then. 2. PATH_SEPARATOR on Cygwin is ':' and on pure DOS/Windows is ';'. This is true, but how is this relevant to the issue at hand? 'abspath' does not deal with PATH-style directory lists, it accepts a single file name as its argument. What am I

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-07 Thread Eli Zaretskii
From: Pavel Fedin p.fe...@samsung.com Cc: m...@cgf.cx, bug-make@gnu.org Date: Wed, 07 Aug 2013 10:22:31 +0400 2. PATH_SEPARATOR on Cygwin is ':' and on pure DOS/Windows is ';'. This is true, but how is this relevant to the issue at hand? 'abspath' does not deal with PATH-style

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-07 Thread Christopher Faylor
On Wed, Aug 07, 2013 at 04:38:22PM +0300, Eli Zaretskii wrote: From: Pavel Fedin p.fe...@samsung.com Cc: m...@cgf.cx, bug-make@gnu.org Date: Wed, 07 Aug 2013 10:22:31 +0400 2. PATH_SEPARATOR on Cygwin is ':' and on pure DOS/Windows is ';'. This is true, but how is this relevant to the

RE: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-07 Thread Pavel Fedin
Hello! Are you saying that if a Cygwin Make uses DOS style file names with drive letters, it also expects the PATH-style directory lists to use a semi-colon as a separator? I don't think I'd expect that. There is a default in make.h: --- cut --- /* Handle other OSs. */ #ifndef

RE: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-06 Thread Pavel Fedin
Hello! In that case, we need to fix 'abspath', not disable this feature. Ok. If you don't mind, i can try new approach on this. Will it be OK ? Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia ___ Bug-make

RE: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-06 Thread Pavel Fedin
Hello! In that case, we need to fix 'abspath', not disable this feature. I have came up with another implementation, currently testing it. My new implementation should allow DOS and UNIX paths to coexist. However there's still two differences: 1. abspath on Cygwin returns UNIX-style paths

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-06 Thread Eli Zaretskii
From: Pavel Fedin p.fe...@samsung.com Cc: m...@cgf.cx, bug-make@gnu.org Date: Tue, 06 Aug 2013 17:46:14 +0400 1. abspath on Cygwin returns UNIX-style paths and on pure DOS/Windows - DOS-style. This is what I'd expect. If DOS-style absolute path is already supplied, it will leave it as

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-05 Thread Eli Zaretskii
From: Pavel Fedin p.fe...@samsung.com Date: Mon, 05 Aug 2013 09:19:18 +0400 IMHO it's a little bit inconvenient that you have to use config.cache trick in order to build a fully working Make for Cygwin, and this is not documented anywhere. First time, when i didn't know about this, i've

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-05 Thread Christopher Faylor
[Reply-to set to bug-make] On Mon, Aug 05, 2013 at 09:19:18AM +0400, Pavel Fedin wrote: Hello! Right. Because I knew I could just turn if off for the Cygwin release. There is no reason to nuke the feature for people who want to roll their own version of make with DOS paths turned on. Then

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-05 Thread Paul Smith
On Mon, 2013-08-05 at 10:56 -0400, Christopher Faylor wrote: Then maybe really add something like --enable-dos-paths which defaults to no on Cygwin and Yes on MinGW ? ac_cv_dos_paths=no configure works just fine and does not require a command-line switch. If this is a common/necessary

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-05 Thread Pavel Fedin
Hello, Eli. Monday, August 5, 2013, 18:44:17 you wrote: I don't yet understand why you have a problem in the first place. It sounds like the single issue is with the 'abspath' function, is that correct? Yes, correct. 2 Christopher Faylor: ac_cv_dos_paths=no configure works just fine

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-05 Thread Eli Zaretskii
Date: Mon, 5 Aug 2013 22:04:44 +0400 From: Pavel Fedin pavel_fe...@mail.ru CC: m...@cgf.cx, bug-make@gnu.org I don't yet understand why you have a problem in the first place. It sounds like the single issue is with the 'abspath' function, is that correct? Yes, correct. In that

RE: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-04 Thread Pavel Fedin
Hello! Right. Because I knew I could just turn if off for the Cygwin release. There is no reason to nuke the feature for people who want to roll their own version of make with DOS paths turned on. Then maybe really add something like --enable-dos-paths which defaults to no on Cygwin and

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-08-02 Thread Christopher Faylor
On Wed, Jul 31, 2013 at 10:11:40AM -0400, Paul Smith wrote: On Wed, 2013-07-31 at 10:37 +0400, Pavel Fedin wrote: Looks like, if you want DOS paths, and running under Cygwin, an explicit conversion has to be performed on getcwd() result using cygwin_conv_path(). However i did not test this

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-07-31 Thread Paul Smith
On Wed, 2013-07-31 at 10:37 +0400, Pavel Fedin wrote: Looks like, if you want DOS paths, and running under Cygwin, an explicit conversion has to be performed on getcwd() result using cygwin_conv_path(). However i did not test this further because i follow official Cygwin way of doing things,

[PATCH 2/2] Do not use DOS paths on Cygwin

2013-07-30 Thread Pavel Fedin
Currently make's configure suggests that it should use DOS-style paths on Cygwin. This is not true, and this assumption makes path-related mechanisms to work incorrectly. Currently Cygwin package supplies manual hint in config.cache in order to work around this. I think we should also ask MinGW

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-07-30 Thread Eli Zaretskii
From: Pavel Fedin p.fe...@samsung.com Date: Tue, 30 Jul 2013 14:44:58 +0400 Currently make's configure suggests that it should use DOS-style paths on Cygwin. This is not true, and this assumption makes path-related mechanisms to work incorrectly. Currently Cygwin package supplies manual

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-07-30 Thread Roland Schwingel
Hi... bug-make-bounces+roland.schwingel=onevision@gnu.org wrote on 30.07.2013 17:43:10: Currently make's configure suggests that it should use DOS-style paths on Cygwin. This is not true, and this assumption makes path-related mechanisms to work incorrectly. Currently Cygwin

Re: [PATCH 2/2] Do not use DOS paths on Cygwin

2013-07-30 Thread Eli Zaretskii
Cc: bug-make@gnu.org, Pavel Fedin p.fe...@samsung.com From: Roland Schwingel roland.schwin...@onevision.com Date: Tue, 30 Jul 2013 18:29:07 +0200 I clearly think the DOS paths mode should remain in even for cygwin. I know that there are objections in cygwins top level management against