Re: [bug-myserver] Test for class File, not tested :D

2009-03-23 Thread ivailo ilionov
Giuseppe, I hope i followed the instructions correctly : ) You said that using the default constructor may leave the file descriptor in the object inconsistent, but now I explicitly open and close the file I'm working with. From what I saw in the source for openFile(), I should be either getting

Re: [bug-myserver] Test for class File, not tested :D

2009-03-23 Thread Giuseppe Scrivano
Hello, You said that using the default constructor may leave the file descriptor in the object inconsistent, but now I explicitly open and close the file I'm working with. From what I saw in the source for openFile(), I should be either getting the right descriptor or getting an error.

[bug-myserver] Bug fix in file.cpp + test

2009-03-23 Thread ivailo ilionov
I forgot to mention that under windows, the code seems to work okay : ) So, only the non-windows code has the problem...

Re: [bug-myserver] Bug fix in file.cpp + test

2009-03-23 Thread Giuseppe Scrivano
Thank you Ivailo! I can't add your file yet as there is need of copyright assignments, as soon as we will get them I will add the file to the repository. I am going to apply the patch instead, openFile must return non-zero if the file wasn't opened correctly, as you patch is doing. Giuseppe