On Thu, Sep 21, 2023 at 06:24:01PM +0200, Patrice Dumas wrote:
> Hello,
>
> On Wed, Sep 20, 2023 at 08:44:34PM +0100, Gavin Smith wrote:
> > Perhaps we should keep on resetting CFLAGS and LDFLAGS (in line with
> > the autoconf manual), but leave CPPFLAGS alone due to gnulib's special
> > use of
Hello,
On Wed, Sep 20, 2023 at 08:44:34PM +0100, Gavin Smith wrote:
> Perhaps we should keep on resetting CFLAGS and LDFLAGS (in line with
> the autoconf manual), but leave CPPFLAGS alone due to gnulib's special
> use of it.
Since we need to avoid resetting CPPFLAGS to get the libunistring
On Wed, Sep 20, 2023 at 08:44:34PM +0100, Gavin Smith wrote:
> One change at a time please. Any gnulib tests should be run
> with the same compiler flags as used to compile the shared library.
On that subject, and independently of the main issue of CPPFLAGS, this
is not what is actually done.
Patrice wrote:
> I think that the first one is not such an issue, as it is set quite
> early, the libunistring module is called afterwards.
I agree with this.
Bruno wrote:
> I first did it like this with libintl, ca. 25 years ago, and this approach
> to modify CPPFLAGS works fine, except there
On Tue, Sep 19, 2023 at 08:33:08PM +0100, Gavin Smith wrote:
>
> This shows how using new gnulib modules can lead to problems, especially
> under the tp/Texinfo/XS directory.
We need to use libunistring quite a bit to be on par with the perl code
on everything related to unicode.
> I don't know
On Tue, Sep 19, 2023 at 07:43:26PM +0200, Patrice Dumas wrote:
> Hello,
>
> Thanks for the analysis!
>
> On Tue, Sep 19, 2023 at 04:22:42PM +0200, Bruno Haible wrote:
> > * But you can see from the log above that no -I option is in use that
> > allows the compiler to find the *installed* .
> >
On Tue, Sep 19, 2023 at 04:22:42PM +0200, Bruno Haible wrote:
> The origin of the bug is here:
> $ grep -n CPPFLAGS= tp/Texinfo/XS/configure.ac /dev/null
> tp/Texinfo/XS/configure.ac:100: CPPFLAGS=$PERL_EXT_CPPFLAGS
> tp/Texinfo/XS/configure.ac:152:CPPFLAGS=$PERL_EXT_CPPFLAGS
Here is a proposal
Hi Patrice,
> As a side note, it would have been better to have a specific variable
> like LTLIBUNISTRING instead of using the global CPPFLAGS, but it is not
> a big deal either.
The absence of such a variable INCLIBUNISTRING is a trade-off between
convenience and complexity.
-L and -Wl options
Hello,
Thanks for the analysis!
On Tue, Sep 19, 2023 at 04:22:42PM +0200, Bruno Haible wrote:
> * But you can see from the log above that no -I option is in use that
> allows the compiler to find the *installed* .
> * The 'libunistring' module puts the necessary -I options into the CPPFLAGS
>
On NetBSD 9.0, with a GNU libiconv 1.0 installed, I see this build failure:
$ gmake
...
/bin/sh ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I.
-I../../../../../../tp/Texinfo/XS/gnulib/lib -I../.. -Wno-cast-qual
-Wno-conversion -Wno-float-equal -Wno-sign-compare -Wno-undef
10 matches
Mail list logo
