Re: texi2dvi: fix support for whitespace in working directory

2016-04-27 Thread Gavin Smith
On 27 April 2016 at 08:53, Andreas Schwab wrote: > Mattias Andrée writes: > >> Whether my patch fixes an error in texi2dvi or works around >> a bug in bash's sh is unimportant. The patch is tiny, does >> not decrease maintainability > > Adding

Re: texi2dvi: fix support for whitespace in working directory

2016-04-27 Thread Mattias Andrée
On Wed, 27 Apr 2016 14:02:58 +0200 Andreas Schwab wrote: > Mattias Andrée writes: > > > Have you tested it with bash 4.3.42 as sh > > It doesn't matter. > > Andreas. > I look into it further. It appears that this issue as already been

Re: texi2dvi: fix support for whitespace in working directory

2016-04-27 Thread Andreas Schwab
Mattias Andrée writes: > Have you tested it with bash 4.3.42 as sh It doesn't matter. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different."

Re: texi2dvi: fix support for whitespace in working directory

2016-04-27 Thread Mattias Andrée
On Wed, 27 Apr 2016 13:42:24 +0200 Andreas Schwab wrote: > Mattias Andrée writes: > > > On Wed, 27 Apr 2016 12:38:17 +0200 > > Andreas Schwab wrote: > > > >> Mattias Andrée writes: > >> > >>

Re: texi2dvi: fix support for whitespace in working directory

2016-04-27 Thread Andreas Schwab
Mattias Andrée writes: > On Wed, 27 Apr 2016 12:38:17 +0200 > Andreas Schwab wrote: > >> Mattias Andrée writes: >> >> > It creates splits the path at white space, and trys >> >> Neither case nor assignments do word

Re: texi2dvi: fix support for whitespace in working directory

2016-04-27 Thread Mattias Andrée
On Wed, 27 Apr 2016 12:38:17 +0200 Andreas Schwab wrote: > Mattias Andrée writes: > > > It creates splits the path at white space, and trys > > Neither case nor assignments do word splitting. > > > to create all results paths, as directories,

Re: texi2dvi: fix support for whitespace in working directory

2016-04-27 Thread Andreas Schwab
Mattias Andrée writes: > It creates splits the path at white space, and trys Neither case nor assignments do word splitting. > to create all results paths, as directories, successful > with the first but fails with the rest of course. As > a result script fails. Your

Re: texi2dvi: fix support for whitespace in working directory

2016-04-27 Thread Mattias Andrée
On Wed, 27 Apr 2016 09:53:18 +0200 Andreas Schwab wrote: > Mattias Andrée writes: > > > Whether my patch fixes an error in texi2dvi or works > > around a bug in bash's sh is unimportant. The patch is > > tiny, does not decrease maintainability

Re: texi2dvi: fix support for whitespace in working directory

2016-04-27 Thread Andreas Schwab
Mattias Andrée writes: > Whether my patch fixes an error in texi2dvi or works around > a bug in bash's sh is unimportant. The patch is tiny, does > not decrease maintainability Adding unnecessary quotes without justification decreases maintainability because everyone

Re: texi2dvi: fix support for whitespace in working directory

2016-04-26 Thread Norbert Preining
Sorry Gavin for the stupid email - one should not write emails before breakfast and coffee. -- Sent from my mobile device. Please excuse my brevity.

Re: texi2dvi: fix support for whitespace in working directory

2016-04-26 Thread Mattias Andrée
On Wed, 27 Apr 2016 06:45:05 +0900 Norbert Preining wrote: > On Tue, 26 Apr 2016, Gavin Smith wrote: > > "...the Bourne shell does not systematically split > > variables and back-quoted expressions, in particular on > > the right-hand side of assignments and in the argument >

Re: texi2dvi: fix support for whitespace in working directory

2016-04-26 Thread Karl Berry
You cannot expect bash behaviour then. It's bourne behavior not bash behavior. As you know, we go to great lengths to avoid bash dependencies in texi2dvi (and in all other core GNU shell scripts). However, as I recall, there is a bug in some versions of bash that require case "$foo"

Re: texi2dvi: fix support for whitespace in working directory

2016-04-26 Thread Norbert Preining
On Tue, 26 Apr 2016, Gavin Smith wrote: > "...the Bourne shell does not systematically split variables and > back-quoted expressions, in particular on the right-hand side of > assignments and in the argument of case." Gavin, texi2dvi starts with /bin/sh that means it can be *any* shell

Re: texi2dvi: fix support for whitespace in working directory

2016-04-26 Thread Gavin Smith
On 25 April 2016 at 21:31, Mattias Andrée wrote: > Fix support for whitespace in working directory. > > Keep me CC:ed, I'm not subscribed to the mailing-list. I don't think this change does anything? Reference

Re: texi2dvi: fix support for whitespace in working directory

2016-04-26 Thread Mattias Andrée
On Tue, 26 Apr 2016 22:35:36 +0100 Gavin Smith wrote: > On 25 April 2016 at 21:31, Mattias Andrée > wrote: > > Fix support for whitespace in working directory. > > > > Keep me CC:ed, I'm not subscribed to the mailing-list. > > I don't think