On Thu, Nov 20, 2014 at 1:26 PM, Ángel González keis...@gmail.com wrote:
On 20/11/14 06:13, Darshit Shah wrote:
@Tim: Please just add that include statement one line above, or else I'll
make the required change and push it.
You can copy that block from my patch if that's easier for you, but
How does this look for another attempt at the configure file?
On Tue, Nov 18, 2014 at 3:55 PM, Darshit Shah dar...@gmail.com wrote:
On 11/18, Tim Rühsen wrote:
On Tuesday 18 November 2014 09:51:18 Darshit Shah wrote:
On 11/17, Tim Rühsen wrote:
On Monday 17 November 2014 19:39:12 Darshit
On 11/20, Tim Rühsen wrote:
On Thursday 20 November 2014 11:52:40 Darshit Shah wrote:
On 11/19, Tim Rühsen wrote:
Am Mittwoch, 19. November 2014, 22:07:28 schrieb Darshit Shah:
On 11/18, Tim Rühsen wrote:
This patch fixes most C89 warnings for me (-std=c89 -pedantic) since
these
may prevent
On Thursday 20 November 2014 14:08:27 Darshit Shah wrote:
On 11/20, Tim Rühsen wrote:
On Thursday 20 November 2014 11:52:40 Darshit Shah wrote:
On 11/19, Tim Rühsen wrote:
Am Mittwoch, 19. November 2014, 22:07:28 schrieb Darshit Shah:
On 11/18, Tim Rühsen wrote:
This patch fixes most
On Thursday 20 November 2014 11:18:07 Darshit Shah wrote:
Excepting perhaps init.c, all .c files at src/ are in fact expecting a
C-locale str(n)casecmp
(they all deal with network protocols).
But URLs can be in non-ASCII characters. And similarly, if I remember
correctly, the HTTP headers
On Thursday 20 November 2014 00:12:08 Ángel González wrote:
On 18/11/14 17:12, Tim Ruehsen wrote:
I amended three tests to fail when run with turkish locale.
I fixed these issues (using c_strcasecmp/c_strncasecmp) and also replaced
strcasecmp/strncasecmp by c_strcasecmp/c_strncasecmp at
On Thursday 20 November 2014 10:43:11 Darshit Shah wrote:
On 11/19, Daniel Stenberg wrote:
On Wed, 19 Nov 2014, Tim Rühsen wrote:
I won't change my toolchain just to see these formfeeds. Looks like
I had luck so far... but now, really, how can I work on Wget's
sources from now on ? I have to
On 11/20, Darshit Shah wrote:
How does this look for another attempt at the configure file?
Here's another patch that uses pkg-config to check for libpsl
Also, if there are no objections, I'll also push the patch that adds -Wextra to
the default CFLAGS.
--
Thanking You,
Darshit Shah
From
On Wednesday 19 November 2014 22:51:10 Gisle Vanem wrote:
Tim Rühsen wrote:
This patch fixes most C89 warnings for me (-std=c89 -pedantic) since these
may prevent from compiling with MSVC.
That's really good news to me. But there are still lots
more C99 errors. Espesially in main.c.
I
Darshit Shah dar...@gmail.com writes:
On 11/20, Darshit Shah wrote:
How does this look for another attempt at the configure file?
Here's another patch that uses pkg-config to check for libpsl
Also, if there are no objections, I'll also push the patch that adds
-Wextra to the default
Tim Ruehsen tim.rueh...@gmx.de writes:
On Thursday 20 November 2014 10:43:11 Darshit Shah wrote:
On 11/19, Daniel Stenberg wrote:
On Wed, 19 Nov 2014, Tim Rühsen wrote:
I won't change my toolchain just to see these formfeeds. Looks like
I had luck so far... but now, really, how can I work on
On Wednesday 19 November 2014 23:36:40 Daniel Stenberg wrote:
On Wed, 19 Nov 2014, Tim Rühsen wrote:
I won't change my toolchain just to see these formfeeds. Looks like I had
luck so far... but now, really, how can I work on Wget's sources from now
on ? I have to stop here and now...
Stop
Tim Ruehsen tim.rueh...@gmx.de writes:
On Wednesday 19 November 2014 23:36:40 Daniel Stenberg wrote:
On Wed, 19 Nov 2014, Tim Rühsen wrote:
I won't change my toolchain just to see these formfeeds. Looks like I had
luck so far... but now, really, how can I work on Wget's sources from now
On 11/20, Tim Rühsen wrote:
On Wednesday 19 November 2014 23:01:22 Darshit Shah wrote:
On 11/09, Ángel González wrote:
On 07/11/14 06:12, Darshit Shah wrote:
Because real life is catching up, I've very little time till the end of
this year. But I'm going to try and debug this issue and fix it
Hi Gisle,
please always answer to the mailing list.
You don't have the latest git version, at least your diff isn't based on it.
I pushed the C89 changes right before I asked you to give me the compiler
output.
I guess MSVC 16 can be used on WinXP while MSVC 18 is for Win7 and up ?
Please
Based on comments from various packagers, I've set assertions to be the disabled
by default.
Anybody who is interested in hacking on Wget *should* configure their Wget
builds with --enable-assert. This patch will change the configure file and cause
autoreconf to run for everybody. This
On Thursday 20 November 2014 15:36:57 Darshit Shah wrote:
On 11/20, Darshit Shah wrote:
How does this look for another attempt at the configure file?
Here's another patch that uses pkg-config to check for libpsl
Also, if there are no objections, I'll also push the patch that adds -Wextra
Tim Ruehsen wrote:
You don't have the latest git version, at least your diff isn't based on it.
Okay. I was too quick. It builds fine with MSVC v16 except
for http.c and the rubbish in progress.c. See [1] below.
Diffs for http.c:
--- ../Git-latest/src/http.c2014-11-20 15:39:55 +
+++
On Thursday 20 November 2014 15:06:26 Gisle Vanem wrote:
Tim Ruehsen wrote:
You don't have the latest git version, at least your diff isn't based on
it.
Okay. I was too quick. It builds fine with MSVC v16 except
for http.c and the rubbish in progress.c. See [1] below.
Diffs for http.c:
On Thursday 20 November 2014 12:12:59 Giuseppe Scrivano wrote:
If everybody agrees, I would like to remove the form feeds once and for
all. Attached is a patch.
FYI:
to count form feeds
grep -c `echo -e \014` filename
to remove form feeds
sed -i 's/'`echo -e \014`'//g' filename
Tim Ruehsen wrote:
[1]:
#else
# define count_cols(mbs) ((int)(strlen(mbs)))
# define cols_to_bytes(mbs, cols, *ncols) do { \
*ncols = cols; \
bytes = cols; \
}while (0)
#endif
(I forgot to add
Hi,
Am 20.11.2014 um 08:55 schrieb Ángel González keis...@gmail.com:
On 20/11/14 07:34, Darshit Shah wrote:
And talking about legalities, I'm hoping you already have signed the
assignment papers because otherwise that's even more work, before we can add
this to the source. :-)
Come on,
Tim Rühsen tim.rueh...@gmx.de writes:
Am Mittwoch, 19. November 2014, 22:07:28 schrieb Darshit Shah:
On 11/18, Tim Rühsen wrote:
This patch fixes most C89 warnings for me (-std=c89 -pedantic) since these
may prevent from compiling with MSVC.
There are still some warnings ISO C forbids
Am Donnerstag, 20. November 2014, 17:22:24 schrieb Dagobert Michelsen:
Hi,
Am 20.11.2014 um 08:55 schrieb Ángel González keis...@gmail.com:
On 20/11/14 07:34, Darshit Shah wrote:
And talking about legalities, I'm hoping you already have signed the
assignment papers because otherwise
Darshit Shah wrote:
In short, I;m not sure if we want to use c_strcasecmp for in http.c or
recur.c since domain names allowed to be non-ASCII. And if I'm not
wrong, even the HTTP headers may contain non-ASCII data. In such cases
would c_strcasecmp work correctly?
I expect them to be in
Am Donnerstag, 20. November 2014, 15:42:22 schrieb Tim Ruehsen:
On Thursday 20 November 2014 15:36:57 Darshit Shah wrote:
On 11/20, Darshit Shah wrote:
How does this look for another attempt at the configure file?
Here's another patch that uses pkg-config to check for libpsl
Also,
On 20/11/14 16:56, Gisle Vanem wrote:
FYI. the error from MSVC was:
progress.c(844) : error C2010: '*' : unexpected in macro formal
parameter list
progress.c(978) : error C2059: syntax error : 'do'
Here is a patch:
--- ../Git-latest/src/progress.c2014-11-20 15:39:55 +
+++
Am Donnerstag, 20. November 2014, 15:56:00 schrieb Gisle Vanem:
Tim Ruehsen wrote:
[1]:
#else
# define count_cols(mbs) ((int)(strlen(mbs)))
# define cols_to_bytes(mbs, cols, *ncols) do { \
*ncols = cols; \
bytes = cols;
On 11/20, Ángel González wrote:
On 20/11/14 16:56, Gisle Vanem wrote:
FYI. the error from MSVC was:
progress.c(844) : error C2010: '*' : unexpected in macro formal
parameter list
progress.c(978) : error C2059: syntax error : 'do'
Here is a patch:
--- ../Git-latest/src/progress.c
On 11/20, Ãngel González wrote:
On 20/11/14 15:29, Darshit Shah wrote:
--- a/src/progress.c
+++ b/src/progress.c
@@ -992,6 +992,7 @@ create_image (struct bar_progress *bp, double
dl_total_time, bool done)
{
int percentage = 100.0 * size / bp-total_length;
assert
On 11/20, Tim Rühsen wrote:
On Thursday 20 November 2014 15:36:57 Darshit Shah wrote:
On 11/20, Darshit Shah wrote:
How does this look for another attempt at the configure file?
Here's another patch that uses pkg-config to check for libpsl
Also, if there are no objections, I'll also push the
On 11/20, Tim Rühsen wrote:
On Thursday 20 November 2014 12:12:59 Giuseppe Scrivano wrote:
If everybody agrees, I would like to remove the form feeds once and for
all. Attached is a patch.
FYI:
to count form feeds
grep -c `echo -e \014` filename
to remove form feeds
sed -i 's/'`echo -e
32 matches
Mail list logo
