Hi Paul,
Paul Schreiber writes:
> wget crashes mirroring.
>
> Reproducibility: always
> Config: Ubuntu 12.10, GNU Wget 1.13.4, Linux 3.2.0-32-generic x86_64
> To reproduce: wget —mirror -p --adjust-extension --no-parent --convert-links
> http://nrtee-trnee.ca/
I am not sure if it will solve y
is that on? I can't find any mention of it in the
> manual, and it doesn't appear to work on 1.14
>
>
>
> - Original Message -----
>
> From: Giuseppe Scrivano
>
> Sent: 03/23/13 06:49 PM
>
> To: CCC DDD
>
"CCC DDD" writes:
> An option for wget to download content after non-200 HTTP code would be very
> useful.
Does --content-on-error solve your problem?
--
Giuseppe
Hi,
I couldn't reproduce it here, wget seems to terminate when the TCP
connection is closed.
Are you sure the server doesn't intentionally leave the TCP connection
opened? Could you use use a packet analyzer to see if it is closed?
Thanks
joep writes:
> Hi,
> I'm using wget to access the
Hi Darshit,
Darshit Shah writes:
> I have implemented a --method command along with --body-data and --body-file
> commands for HTTP Scripting.
>
> Have attached the patch alongwith this mail. However, this is not complete,
> not to my satisfaction atleast.
> There is redundant code that execut
Alex writes:
> Greetings
> Thanks for correting and testing.
before proceeding to accept your patches, it is necessary to complete
the copyright assignment process to the FSF. I will send you a separate
email explaining how.
Giuseppe
Darshit Shah writes:
> The original patch caused a SIGABRT that I missed.
> wget now returns with an exit status of 3.
>
> Uploading the updated patch file and another with the test to ensure the
> correct return code.
Thanks! I have amended some small changes (missing ChangeLog, trailing
whit
Thanks for your your patch! Some comments:
Darshit Shah writes:
> Attaching a patch to make wget abort instead of sending an empty request if
> the file pointed to in --post-file does not exist.
+ return FILEBADFILE;
what exit status will be returned by the wget process?
I am
Darshit Shah writes:
>Also, alongwith implementing --body-data and --body-file should I mark
>the --post-data and --post-file commands as deprecated? Or is there a
>different protocol to follow before marking a command as deprecated?
I don't see any real value to mark them as depreca
Darshit Shah writes:
>Reusing post-data and post-file is not intuitive enough when we support
>more options through --method.
>Say, someone wished to use --method=PUT. In that case using --post-data
>or --post-file is counter intuitive. Hence the need to unify them all
>under
Darshit Shah writes:
> please don't add these. I don't think we would like to add a new
> pair
> of --FOO-data, --FOO-file for any method we will implement. As
> already
> suggested by Hrvoje, just add --body-data and --body-file that are
> synonyms for --post-data
Ángel González writes:
> On 08/03/13 19:18, Darshit Shah wrote:
>> Okay gathering inputs from all the replies above., I think the best way to
>> move forward would be to implement a --method=
>> followed by --post-data or --post-file in case of POST and --put-data
>> --put-file in case of the PUT
Darshit Shah writes:
> Taking this forward. I figured it would be best to merge --post-data and
> --post-file commands into --method=HTTPMethod
>
> I intend to use the following logic in merging them:
>
> wget --method=POST [data/file] URL
If a method (like OPTIONS) includes an entity-body then
Daniel Stenberg writes:
> On Tue, 5 Mar 2013, Ángel González wrote:
>
>>> wget --delete
>
>> I would prefer something like --method=delete, which would also
>> allow other methods (eg. OPTIONS, TRACE, PROPFIND...)
>
> Which incidentally is how curl does it (just with a differently named option):
ctory for both local and remote servers???
>
> Thanks
>
> On Sun, Jan 27, 2013 at 1:49 PM, Ángel González wrote:
>
> On 27/01/13 22:33, Giuseppe Scrivano wrote:
> > sorry now I see what you mean...
> >
> > I am not very familiar with the FTP impl
Ángel González writes:
> On 27/01/13 22:33, Giuseppe Scrivano wrote:
>> sorry now I see what you mean...
>>
>> I am not very familiar with the FTP implementation but I am afraid it
>> will need some changes in the way it works now and avoid any operation
>> i
sorry now I see what you mean...
I am not very familiar with the FTP implementation but I am afraid it
will need some changes in the way it works now and avoid any operation
in the directory after you set the mtime. Can anyone with more
experience in the FTP implementation confirm this?
Cheers,
It works well here. Can you specify what version are you using and on
what system?
Giuseppe
Ravi Sharma writes:
> Hello All,
>
> We are using wget to sync external FTP site with local copy with options
>
> wget -m -np --directory prefix= --no-host-directories ftp://
> **
Tim Ruehsen writes:
> -VERS-TLS-ALL also removes VERS-SSL3.0.
>
> Regards, Tim
>
> From 018e8a4f0490f61c41d2e8df6ae5c9d56ea3039c Mon Sep 17 00:00:00 2001
> From: Tim Ruehsen
> Date: Thu, 20 Dec 2012 13:07:30 +0100
> Subject: [PATCH] fix --secure-protocol=SSLv2/SSLv3
Thanks, applied.
Giuseppe
maybe you want to filter the output with grep or sed?
Giuseppe
Catia B writes:
> I already changed my script to match this new output
> My question hère isn't about my script it's about the options of wget
> Is anyone having the issue?
> Because i don't understand why it´s not working as IT is
7;/tmp/edt_cookies.txt' \
> -O '/dev/null' -nv -a "$log" --config="$wget_config"
indeed it is a bug. I have pushed a patch that should fix it:
commit b56a528aea6287a9fe5b7b339a4b5ba5d0b9b470
Author: Giuseppe Scrivano
Date: Sun Dec 9 17:04:39 2012 +0100
Do not honor --config only when used as first long argument
Thanks to have reported it!
Giuseppe
Thanks for your patch! I have added a ChangeLog entry and pushed it.
Cheers,
Giuseppe
Michael Stapelberg writes:
> Hi,
>
> attached you can find a patch which fixes a double free() in wget when
> accessing a URL which uses IDN and redirects.
>
> --
> Best regards,
> Michael
>
> From 9573173
7382...@gmail.com writes:
> I think wget should HTTP compression (Accept-Encoding: gzip, deflate). It
> would put less strain on servers being downloading from, and use less of
> their bandwidth. Is it okay to add this idea to the
> http://wget.addictivecode.org/FeatureSpecifications page?
I don'
Ángel González writes:
> On 26/11/12 00:04, Giuseppe Scrivano wrote:
>> that is a good idea, we can add something like:
>>
>> #define MAX_INT_TO_STRING_LEN(x) (sizeof(x) * 24082 / 1) + 2
>>
>> where `x' in our case will be off_t.
>>
>&g
Ángel González writes:
> On 24/11/12 12:32, Giuseppe Scrivano wrote:
>> I have pushed the following patch:
>
>> + char content_length[22];
> The 22 is a magic number, based in the fact
> that 1e21 > INT64_MAX
>
> I think it should be #defined in wget.h
>
>
Tim Ruehsen writes:
> As the subject says.
>
> A person called Avinash directly contacted me to implement RFC2617 MD5-sess
> algorithm. Avinash's test server seemed to be a Microsoft-IIS/7.5.
>
> Regards, Tim
>
> From 657ed1c6da6efb7728ee7677528c1fda0c23e560 Mon Sep 17 00:00:00 2001
> From: Tim
Ángel González writes:
> Stephanie Rühsen schrieb:
>> Am Samstag, 24. November 2012 schrieb Ángel González:
>>> The 22 is a magic number, based in the fact
>>> that 1e21 > INT64_MAX
>>>
>>> I think it should be #defined in wget.h
>>>
>>> It could be defined variable depending on the
>>> different
Tim Rühsen writes:
> Am Donnerstag, 22. November 2012 schrieb Hrvoje Niksic:
>> Giuseppe Scrivano writes:
>>
>> > Let's be realistic, is there any platform/system (with more than 3
>> > users) where C99 is a problem?
>> >
>> > Visual
Gijs van Tulder writes:
> Giuseppe Scrivano writes:
>> From 1e229375aa89cdc0bba07335fbe10d4f66180f68 Mon Sep 17 00:00:00 2001
>> Subject: [PATCH] warc: fix format string for off_t
>
> Good to see that that's fixed. However, there's another instance of
> this pr
on't think is a good idea.
>
> Any chance that the original bug will be fixed?
I have pushed the following patch:
>From 1e229375aa89cdc0bba07335fbe10d4f66180f68 Mon Sep 17 00:00:00 2001
From: Giuseppe Scrivano
Date: Sat, 24 Nov 2012 12:27:16 +0100
Subject: [PATCH] warc: fix
Tim Ruehsen writes:
> BTW, I had a private discussion with Guiseppe at April 13th 2012.
> It was about C99/POSIX and using getline().
> Guiseppe's last words were:
>
> "I had to check it better before give an answer, but yeah, the answer is:
> let's use C99 and POSIX-2008."
>
> @Guiseppe: can you
Ángel González writes:
> Your change is equivalent to mine, but as you are defining 1 as a good
> return code, you
> should change the «In case of any other error, 1 is returned.» text in
> the comment.
thanks to have noticed it. I have pushed another patch to adjust the
comment.
Cheers,
Giuse
Torsten Scheck writes:
> Your change prevents the error message, but the file seems to be fully
> retrieved rather than continued (see below).
>
> For my yocto check it doesn't matter, of course. Nevertheless, I would
> expect the message "The file is already fully retrieved; nothing to do.".
th
Thanks for the report. The code you have reverted seems correct to me.
I think the proper patch should be this:
diff --git a/src/retr.c b/src/retr.c
index 6204839..5bbae80 100644
--- a/src/retr.c
+++ b/src/retr.c
@@ -376,7 +376,7 @@ fd_read_body (int fd, FILE *out, wgint toread, wgint
startpos,
Tim Ruehsen writes:
> Sorry, here it comes.
thanks, I have squashed the patches so it is a complete one with a
changelog included.
Giuseppe
Tim Ruehsen writes:
> To check wget for NOT sending a request header, I patched HTTPServer.pm.
> Here is an example taken from the patched Test-cookies.px (see below):
> ...
> request_headers => {
> "!Cookie" => qr|foo=bar|,
> },
> ...
>
> That means: return an error,
Thanks for the patch!
Just a curiosity, I have never seen this before:
> Copyright-paperwork-exempt: yes
are other GNU projects using it?
Cheers,
Giuseppe
Rohit writes:
> Hi,
>
> I sent in a patch about a couple of months back because wget doesn't handle
> shorthand urls in a file. Is there a reason why the patch was not accepted? I
> couldn't find any mail on the mailing list talking about it though I may have
> missed it.
sorry for the delay
Hi Joel,
I have cloned your repository but I couldn't find that commit. Could
you please double check if you have pushed everything?
Thanks,
Giuseppe
"Joel Nothman" writes:
> wgetting a list of URLs on STDIN requires reading the entire file into
> memory before extracting a linked list of U
Hi,
I have just pushed a new branch to the git repository: parallel-wget.
It contains the project İlim has worked on this summer.
My plan is to merge it as soon as the new experimental features can be
easily disabled at configure time without interfere at all with the
current wget master code ba
Leinier Cruz Salfranc writes:
> hello wget staff.
>
> i want to ask a feature to implement in future releases of wget.
>
> - ability to specify total of threads to work in parallel in order to
> download
> the archive (every download manager have this ability). this can be usefull
> when our i
Ray Satiro writes:
> src/ChangeLog
> src/url.c
>
> @ src/url.c:
>
> Any function directly writing to the members of a growable string
> object must call append_null(). Functions that already do this I've
> changed to call append_null(): shorten_length(), append_char(),
> append_string(), append_u
Ray Satiro writes:
> Attached is a patch relative to commit e9845d2. I propose that base
> should always be null terminated. tail represents the length of the
> string and does not include the terminating null. Any function
> directly writing to the members of a growable string object must call
>
Nikolay Merinov writes:
> From 2fff576be8988382f06ddecdf839b347e418a8e8 Mon Sep 17 00:00:00 2001
> From: Nikolay Merinov
> Date: Wed, 3 Oct 2012 21:31:25 +0600
> Subject: [PATCH] Recieve ftp listing even when .listing file exist and
> --no-clobber option is given.
thanks for the patch, I have
Tim Ruehsen writes:
>> I couldn't build 6e4c3ab for MinGW without reverting the recent commit
>> 67e6027 "Add support for file names longer than MAX_FILE" from Tim
>> Ruehsen. I have no pathconf() here and it looks like gnulib doesn't offer
>> it for mingw or msvc. I'm not suggesting it should be
Dmitry Bogatov writes:
> In my previous patch(not applied yet), I refactored some code,
> but did not fixed mistake in this line:
>
> sprintf (path, "%s/%s", home, NETRC_FILE_NAME);
>
> Unfortunately, we do not live in a perfect world, and there is OS,
> where separator is different. There is a
tent_disposition)
> send_head_first = false;
>
>/* Send preliminary HEAD request if -N is given and we have an existing
> [/code]
> Data about original patch :
> revno: 2377
> committer: Giuseppe Scrivano
> branch nick: wget
> timestamp: Thu 2010-06-03
Николай Меринов writes:
> The problem in the parser for winnt listing format. Some of the new
> windows FTP servers write listing like
>>06-01-2011 03:01PM 7038 file.txt
>>04-28-2010 07:21PM folder
> where filename starts from 42th symbol instead of standart form
Nikolay Merinov writes:
> AC_DEFUN([WGET_FNMATCH], [
>AC_MSG_CHECKING([for working fnmatch.h])
> - AC_COMPILE_IFELSE([#include
> -], [
> + AC_COMPILE_IFELSE([AC_LANG_SOURCE([#include
> +])], [
> AC_MSG_RESULT(yes)
> AC_DEFINE([HAVE_WORKIN
good work, but it seems you haven't copyright assignment to the FSF for
wget, I will send you a separate email.
Cheers,
Giuseppe
illusionoflife writes:
> Hello again. Sorry, was short on time, and it tooked me time to
> learn flex and bison.
>
> So, this is beta version of patch, that reimpl
Tim Ruehsen writes:
>
> Dear maintainers, please update bootstrap !
I have just pushed a change that sync our versions of the bootstrap
script.
Thanks,
Giuseppe
Nguyễn Thái Ngọc Duy writes:
> ---
> ChangeLog | 5 +
> po/POTFILES.in | 5 +
> src/main.c | 2 +-
> src/mswindows.c | 6 +++---
> src/recur.c | 2 +-
> 5 files changed, 15 insertions(+), 5 deletions(-)
thanks for the patch, I have done some trivial changes and pushed it
Hi Tim,
Tim Ruehsen writes:
> While working on Mget I stepped over some little things in Wget ...
I have cleaned these patches a bit and applied them!
Thanks,
Giuseppe
Mike Frysinger writes:
> Newer versions of these packages ship with pkg-config files, so if we can
> detect it via those, do so. If that fails, fall back to the old methods.
>
> Signed-off-by: Mike Frysinger
> ---
> configure.ac | 110
> +--
Mike Frysinger writes:
> On Monday 21 May 2012 19:05:59 Mike Frysinger wrote:
>> The current cleanup_html_url code warns because it's marked static
>> but no one calls it. Reading the code base, we see it only gets
>> called when DEBUG_MALLOC is defined, so change the static markings
>> to check
Hi Mike,
Mike Frysinger writes:
>> lemme know which way you want to go, and i can send out an update that also
>> checks for zlib/pcre/uuid/gnutls via pkg-config.
we have just released, so we can experiment new stuff without be too
much afraid :-) Since we are going to use pkg-config anyway, I
writes:
> Hello, GNU wget maintainer.
>
> I run "configure" script with --disable-ipv6 switch,
> but compler barfs that AF_INET6 is undefined.
> Enjoy the follwing patch.
Thanks for the patch! I have applied it.
Giuseppe
Jeremy Nicoll - ml wget users writes:
> The number of lines in the file is irrelevant; clarity is what matters.
but the number of lines of a function is not irrelevant. Huge functions
cannot be properly tested.
Giuseppe
illusionoflife writes:
> So, first of all, parse_netrc is huge. >200 lines. Well-commented, but still
> huge. And have strange standalone application in source. So I have idea to
> make some sort of api -- move routines of parsing netrc to `libwget'. I am
> not
> very familiar with code, but
illusionoflife writes:
> From c88f47fa91b9b77e14882b8083c1e730de16709c Mon Sep 17 00:00:00 2001
> From: illusionoflife
> Date: Wed, 8 Aug 2012 10:38:45 +0400
> Subject: [PATCH] Moved list reversion into static function.
The patch seems ok. Could you please include a ChangeLog entry? Take a
lo
"Tony Lewis" writes:
> I think you meant:
> ** Accept the arguments --accept-regex and --reject-regex.
absolutely, good eye! The same error is in the NEWS file.
Giuseppe
Hello,
I am pleased to announce the new version of GNU wget.
It is available for download here:
ftp://ftp.gnu.org/gnu/wget/wget-1.14.tar.gz
ftp://ftp.gnu.org/gnu/wget/wget-1.14.tar.xz
and the GPG detached signatures using the key C03363F4:
ftp://ftp.gnu.org/gnu/wget/wget-1.14.tar.gz.sig
ftp://
"mancha" writes:
> Attached please find your request. Please write
> up the Changelog entry as you find most appropriate.
>
> Note: patch against HEAD@22f016ca3ac.
thanks, I have added a ChangeLog entry and pushed it.
Cheers,
Giuseppe
"mancha" writes:
> The patch applies cleanly to 1.13.4.
the patch seems ok, would you mind to send it using "git format-patch"
so to preserve the commit author? (I could do that myself but it is not
clear from the name you used in the e-mail). Extra bonus if you also
include the ChangeLog entry
Hi Noël,
I am checking last stuff, there is just another open bug that I would
like to check before a release. Hopefully it will happen next week.
Regards,
Giuseppe
Noël Köthe writes:
> Hello Giuseppe,
>
> Am Samstag, den 14.07.2012, 18:29 +0200 schrieb Giuseppe Scrivano:
>
&g
yes, that is a bug in wget but it is fixed in the development repository.
The alpha version hosted here will most likely be the new wget version:
ftp://alpha.gnu.org/gnu/wget/wget-1.13.4.79-22f0.tar.bz2
Cheers,
Giuseppe
Mark Cunningham writes:
> Using wget 1.13
>
> I'm not sure if this is a
Hello,
I have just uploaded a new tarball based on the git master branch:
ftp://alpha.gnu.org/gnu/wget/wget-1.13.4.79-22f0.tar.bz2
Please let me know if you encounter big issues with this version.
Thanks!
Giuseppe
Tim Ruehsen writes:
> Hi,
>
> it is a quicky, but I just tested it with Apache2.
>
> * http.c (digest_authentication_encode): added rudimentary support for RFC
> 2617 qop='auth'
>
> @Michael: maybe you can apply the patch and test it with your server. But i'm
> pretty confident that it works.
Petr Pisar writes:
> # FIXME: Double dot
> #: src/http.c:3121
> msgid "Cannot write to WARC file..\n"
>
> # FIXME: missing space after comma
> #: src/main.c:1197
> #, c-format
> msgid ""
> "Both --no-clobber and --convert-links were specified,only --convert-links "
> "will be used.\n"
Thanks! I
Micah Cowan writes:
> Maybe Giuseppe hasn't been updating them locally for a while? Might it
> be a good idea to do an "git clean -fx" and re-do the bootstrap and
> everything just prior to a release, Giuseppe?
yes, I am going to prepare a new alpha release in the next days but
before I would li
Hi,
please report these problems to the translation project[1], translation
files are not maintained by us but we just distribute them.
Thanks,
Giuseppe
1) http://translationproject.org
Jan Engelhardt writes:
> From: Jan Engelhardt
> Date: 2012-06-01 16:51:04.974233292 +0200
>
> Some local
Micah Cowan writes:
> The error message it's reporting seems to correspond to ENOENT
> instead... wonder if it's mistakenly getting that error from normal
> gettext() lookups, rather than any messages actually related to the
> close... the actual close(1) from the strace log in my first message,
Hi Micah,
Micah Cowan writes:
> At first, I assumed wget was using errno improperly. Imagine my
> surprise, though, when running wget under a debugger, to find that at
> the tail end of main(), exit() gets called with an argument value of 0.
> But gdb then still reports a non-zero exit status -
Tim Ruehsen writes:
> Am Thursday 07 June 2012 schrieb Giuseppe Scrivano:
>> Tim Ruehsen writes:
>> > Do you care about the docs ?
>>
>> it will be good to have this feature documented too.
>
> ;-) I meant 'Do you document the feature'
Tim Ruehsen writes:
> Do you care about the docs ?
it will be good to have this feature documented too.
Giuseppe
Tim Ruehsen writes:
> Am Wednesday 06 June 2012 schrieb Hrvoje Niksic:
>> Tim Ruehsen writes:
>> [...]
>>
>> > How do you like that ?
>>
>> I like the extensibility of --report-speed, which is why I proposed it
>> in preference to adding more options. The extended proposal does feel
>> close
Tim Ruehsen writes:
> please consider Hrvoje's and mine last mails about --report-speed.
I have just seen them :) --report-speed sounds like the proper name,
but the new feature needs a bit more work than just replacing the name
as I have done for --report-bps. I am not sure if it is a good id
Hi Hrvoje,
Hrvoje Niksic writes:
> I'd like to suggest that the new --bit option be named --bps instead.
> The use case for this option is reporting of download speed in [gmk]bps,
> not expressing all quantities in bits. Besides, the word "bit" has
> other meanings (small piece), while "bps" is
Tim Ruehsen writes:
> Hopefully, the patch goes into the pending release...
>
> + * main.c (main): Check for filename != NULL
> + * warc.c (warc_process_cdx_line): Fix memory leak
> + * utils.c (match_posix_regex, compile_posix_regex): Remove dead
> + assignment
> + * op
Ángel González writes:
> From 9f3182017c16769b56a17bf70878fd566c1c6f79 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?=C3=81ngel=20Gonz=C3=A1lez?=
> Date: Thu, 31 May 2012 22:57:41 +0200
> Subject: [PATCH] fix segfault on wrong urls (bug 36570)
my previous email got lost but I have replied that the
Hello,
I have just uploaded a new alpha version with the few changes of the
last days:
ftp://alpha.gnu.org/gnu/wget/wget-1.13.4.59-2b1dd.tar.bz2
If nothing horrible happens, then I will make an official release in few
days.
Cheers,
Giuseppe
"Steven M. Schweda" writes:
>Do you mean like this?:
>
> [...]
> ALP $ gdiff -du src/connect.c_orig src/connect.c
> [...]
>
> http://lists.gnu.org/archive/html/bug-wget/2012-05/msg00086.html
>
> Or is something else needed?
is that enough to solve the problem?
I am going to include th
Mike Frysinger writes:
> that doesn't make sense here. the zlib API has always defined gzFile, and
> has
> operated on that. it has never utilized gzFile*. the fact that it didn't
> warn in the past was due to the zlib API not containing code that'd
> implicitly
> check it, and the reason
Ángel González writes:
> On 22/05/12 22:49, Steven M. Schweda wrote:
>>There's a new problem on systems (like VMS) where size_t is unsigned:
> getline() returns a ssize_t, there's a bug in defining line_length as size_t
>
> Giuseppe, can you add the missing 's'? (src/warc.c line 933)
Done an
"Steven M. Schweda" writes:
>Obviously not, or we wouldn't be having this discussion. For Wget
> 1.13.4 on VMS, I added these modifications to src/connect.c, because, as
> I recall, the argument that HAVE_SYS_SOCKET existed for some reason was
> unsuccessful. I never understood why, so I th
Ray Satiro writes:
> Do you have in your wget gnulib dir lib\sys\ those includes? I was under the
> impression those were used.
> This goes back to
> http://lists.gnu.org/archive/html/bug-wget/2012-03/msg00082.html
>
> If you're going to use those then AC_CHECK_HEADERS or something needs to
>
Gijs van Tulder writes:
> Hi,
>
> There's a problem if you combine --output-document with --recursive or
> --page-requisites. --output-document breaks the recursion.
>
> First you get a warning:
>
> WARNING: combining -O with -r or -p will mean that all downloaded
> content will be placed in
Mike Frysinger writes:
> On Thursday 24 May 2012 16:09:31 Giuseppe Scrivano wrote:
>> Then we should check, trough the configure script, that the zlib version
>> used supports this new type. I don't think there are problems to force
>> the zlib version >= the las
Mike Frysinger writes:
> Newer versions of openssl ship with pkg-config files, so if we can detect
> it via those, do so. If that fails, fall back to the classic method.
thanks for your contribution. It seems like a big change in the way
configure will work. I think that if we want to use pkg
Mike Frysinger writes:
> The gz* API from zlib takes a "gzFile", not a "gzFile*". Older
> versions of zlib didn't trigger a warning due to how the funcs
> were written, but newer ones do. So tweak the type (which in
> reality shouldn't change anything since it's a typedefed pointer)
> to work w
Mike Frysinger writes:
> The current cleanup_html_url code warns because it's marked static
> but no one calls it. Reading the code base, we see it only gets
> called when DEBUG_MALLOC is defined, so change the static markings
> to check that ifdef.
>
> The spider_cleanup has a similar problem.
Giuseppe Scrivano writes:
> thanks again for your contribution! The patch seems ok to me. Could
> you please also provide a complete entry for the ChangeLog file?
I have amended the ChangeLog entry in your patch and pushed it. I think
this is the last big change before the new relea
illusionoflife writes:
> Here is the patch.
Thanks, applied.
Giuseppe
thanks again for your contribution! The patch seems ok to me. Could
you please also provide a complete entry for the ChangeLog file?
> Subject: [PATCH] * gnutls.c fix infinite read timeout
As a side note, if you would like to include the ChangeLog entry in the
commit message, please keep a simp
Hi!
illusionoflife writes:
> Hello! Here is very little patch, that fix unused parameter warning and
> make 2 functions to not take not-used parameter. I am very new to big
> projects, so any feedback is very welcome.
> I do not know, whether inline diff or attach prefered,
> so I used linux s
Sasikanth babu writes:
> +/lib/.deps/
> +/lib/.gitignore
> +/lib/Makefile
> +/lib/Makefile.in
> +/lib/arg-nonnull.h
> +/lib/arpa/
> +/lib/asnprintf.o
> +/lib/base32.o
> +/lib/basename-lgpl.o
> +/lib/c++defs.h
> +/lib/c-ctype.o
> +/lib/c-strcasecmp.o
> +/lib/c-strncasecmp.o
> +/lib/charset.alias
>
Hrvoje Niksic writes:
> I for one welcome this move.
>
> I noticed, as did others, that the repository appears to be quite large
> (179MB .git after running git gc), larger than one would intuitively
> expect from a project of Wget's size. Is it an artifact of the
> migration(s) or am I underest
Tim Ruehsen writes:
> No functional changes, just removed warnings.
>
> * hash.c/hash.h: Removed 'discards const qualifier' warnings
> warc.c/warc.h: Likewise
> http.c: Likewise
> url.c: Likewise
pushed!
Thanks,
Giuseppe
Hi Tim,
Tim Ruehsen writes:
> There are three obvious ways to fix the issue once and for all:
> a)
> when given the timeout value 0, use INFINITY and special handle this value in
> select_fd() to call select with timeout NULL.
> - INFINITY is defined in math.h which needs to be included in conn
Thanks for the patch!
Just some little comments, which I will amend before push it:
Tim Ruehsen writes:
> From 1787847c8e285024e46c130c2bce7fd4184a69f2 Mon Sep 17 00:00:00 2001
> From: Tim Ruehsen
> Date: Mon, 14 May 2012 14:52:44 +0200
> Subject: [PATCH] * gnutls.c: wgnutls_read_timeout: rem
501 - 600 of 908 matches
Mail list logo
