Re: [Bug-wget] [PATCH] Trivial changes in HSTS

Am Dienstag, 24. Mai 2016, 14:11:15 schrieb Ander Juaristi: > Hi, > > On 11/04/16 16:51, Tim Ruehsen wrote: > > Did you consider Giuseppe's suggestion ? > > "can the file_exists_p check just be moved to hsts_file_access_valid that > > doesn't return an error on ENOENT? In other words, just have

Re: [Bug-wget] pod2man --utf8 -> wget build failure

Am Dienstag, 24. Mai 2016, 09:24:44 schrieb Ryan Schmidt: > On May 24, 2016, at 5:55 AM, Tim Ruehsen wrote: > > Hi Karl, > > > > thanks for pointing out those issue(s). > > > >> Perl... Exactly which version does not matter. > > > > It matters. AFAICS, Perl 5.8 introduced UTF-8 in 2002. > > So

Re: [Bug-wget] pod2man --utf8 -> wget build failure

On May 24, 2016, at 5:55 AM, Tim Ruehsen wrote: > Hi Karl, > > thanks for pointing out those issue(s). > >> Perl... Exactly which version does not matter. > > It matters. AFAICS, Perl 5.8 introduced UTF-8 in 2002. > So perhaps your system is even older !? > (Just out of curiosity, what is it

Re: [Bug-wget] 'Saving HSTS entries to' bug

Tim On Tuesday 24 May 2016 14:01:36 Ander Juaristi wrote: > Hi Tim, > > On 24/05/16 13:15, Tim Ruehsen wrote: > > Hi Ander, > > > > after applying your patch I still see changes in store->table (resp. > > changes of the contents of the entries) without tagging store as changed. > > > >

Re: [Bug-wget] [PATCH] Trivial changes in HSTS

Hi, On 11/04/16 16:51, Tim Ruehsen wrote: > > Did you consider Giuseppe's suggestion ? > "can the file_exists_p check just be moved to hsts_file_access_valid that > doesn't return an error on ENOENT? In other words, just have here: > if (hsts_file_access_valid (filename))" New patch attached.

Re: [Bug-wget] 'Saving HSTS entries to' bug

Hi Tim, On 24/05/16 13:15, Tim Ruehsen wrote: > Hi Ander, > > after applying your patch I still see changes in store->table (resp. changes > of the contents of the entries) without tagging store as changed. > > Everywhere you change something that gets dumped to the disk database *must* > set

[Bug-wget] Fwd: Re: wget different from browser

Just for the record. -- Forwarded Message -- Subject: Re: [Bug-wget] wget different from browser Date: Tuesday 24 May 2016, 11:56:17 From: Marco Barbieri To: Tim Ruehsen many many thanks, yesterday night i was really tired, thanks for

Re: [Bug-wget] 'Saving HSTS entries to' bug

Hi Ander, after applying your patch I still see changes in store->table (resp. changes of the contents of the entries) without tagging store as changed. Everywhere you change something that gets dumped to the disk database *must* set the store->changed flag. For example: Executing

Re: [Bug-wget] pod2man --utf8 -> wget build failure

Hi Karl, thanks for pointing out those issue(s). > Perl... Exactly which version does not matter. It matters. AFAICS, Perl 5.8 introduced UTF-8 in 2002. So perhaps your system is even older !? (Just out of curiosity, what is it ?) That lets me ask why are you sticking around with old software

Re: [Bug-wget] 'Saving HSTS entries to' bug

Yes, I guess you're right. Have a look at this. On 24/05/16 11:48, Tim Ruehsen wrote: >> But >> again, I don't think it pays off for the sole reason of removing a debug >> message. > > Sorry, I forgot to mention, that it is about writing the database when it is > not needed. Just think of

Re: [Bug-wget] 'Saving HSTS entries to' bug

> But > again, I don't think it pays off for the sole reason of removing a debug > message. Sorry, I forgot to mention, that it is about writing the database when it is not needed. Just think of someone having a larg HSTS database in combination with lot's of short-live invocations of wget.

Re: [Bug-wget] 'Saving HSTS entries to' bug

Tim On Tuesday 24 May 2016 11:23:42 Ander Juaristi wrote: > Hi Tim, > > On 24/05/16 10:24, Tim Ruehsen wrote: > > Hi Ander, > > > > IMO, another possibility is to add a flag to 'struct hsts_store' that > > indicates any change made. hsts_store_save() could be skipped if that flag > > is not

Re: [Bug-wget] 'Saving HSTS entries to' bug

Sorry, in main.c it should have been if (filename && hsts_store->changed) On 24/05/16 11:23, Ander Juaristi wrote: > Hi Tim, > > On 24/05/16 10:24, Tim Ruehsen wrote: >> Hi Ander, >> >> IMO, another possibility is to add a flag to 'struct hsts_store' that >> indicates any change made.

Re: [Bug-wget] 'Saving HSTS entries to' bug

Hi Tim, On 24/05/16 10:24, Tim Ruehsen wrote: > Hi Ander, > > IMO, another possibility is to add a flag to 'struct hsts_store' that > indicates any change made. hsts_store_save() could be skipped if that flag is > not set. > > At the same time the debug info has to be moved from

Re: [Bug-wget] 'Saving HSTS entries to' bug

On Monday 23 May 2016 23:59:45 Ander Juaristi wrote: > Hi, > > I would leave it unchanged. For me this is a WONTFIX, for the following > reasons: > > 1. The message is only printed when debug output (-d) is enabled. That > is disabled by default. Any user who enables it is expected to be wise >

Re: [Bug-wget] wget different from browser

Did you enclose the URL by " or ' ? Like in wget 'http://data.icecat.biz/xml_s3/xml_server3.cgi?prod_id=4347B007,8576B064;vendor=canon;lang=IT;output=productcsv' Tim On Monday 23 May 2016 22:52:27 Marco Barbieri wrote: > hi , my name is Marco, > > i'm trying to download the csv

Re: [Bug-wget] LIST command supported by WGET

Hi, wget tries "LIST -a" first. If the FTP server doesn't understand it (=returns an error message), wget falls back to "LIST". Tim On Monday 23 May 2016 15:46:51 李明 wrote: > Hi, I use wget-1.11.4 to download the file successfully from my FTP server > which wrote by myself. When I updated wget