Re: [Bug-wget] FTP PORT command code in v1.16.3?

Tim Ruehsen writes: > On Tuesday 11 August 2015 17:24:42 Giuseppe Scrivano wrote: >> Tim Ruehsen writes: >> > * src/ftp.c (getftp): Do not use PORT when PASV fails. >> > * tests/FTPServer.px: Add pasv_not_supported server flag. >> > * tests/Makefile.am

Re: [Bug-wget] FTP PORT command code in v1.16.3?

Tim Ruehsen writes: > From d8d545994be399705c483ea924e71c3e6348d99d Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Tim=20R=C3=BChsen?= > Date: Tue, 11 Aug 2015 16:48:08 +0200 > Subject: [PATCH] Fix IP address exposure in FTP code > > * src/ftp.c (getftp): Do not use PORT when PASV fails. > * tests/F

[Bug-wget] [bug #20398] Save a list of the links that were not followed

Update of bug #20398 (project wget): Assigned to: tdlewis77 => gscrivano Open/Closed:Open => Closed Planned Release: 1.12.x => None _

Re: [Bug-wget] [PATCH 2/2] Rewrite the --rejected-log test using the new framework.

Jookia <166...@gmail.com> writes: > * tests/Test--rejected-log.px: Remove old test. > * testenv/Test--rejected-log.py: Create new test. > --- > testenv/Makefile.am | 1 + > testenv/Test--rejected-log.py | 104 +++ > tests/Makefile.am | 1 - >

Re: [Bug-wget] [PATCH 1/2] Replace variables before comparing expected files.

Jookia <166...@gmail.com> writes: > * expected_files.py: Use formatted_content instead of file.content. > --- > testenv/conf/expected_files.py | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/testenv/conf/expected_files.py b/testenv/conf/expected_files.py > index 2c8d

Re: [Bug-wget] [PATCH] Add option to write URL rejections to a tab-delimited CSV log.

Jookia <166...@gmail.com> writes: > * main.c: Add "--rejected-log" option. > * init.c: Add "rejectedlog" command. > * options.h: Add "rejected_log" parameter string. > * wget.texi: Add brief documentation on new --rejected-log option. > * recur.c: Optionally log details of URLs not traversed.

Re: [Bug-wget] WGET version for SFTP Connection + ftp-callback functionality

Pravin B Kudle writes: > Thanks a lot Daniel for your response. > > Is there any possibility in future to add SFTP Connection + ftp-callback > functionality in WGET Utility? to my knowledge nobody is working on that. The easiest way to get it done is either write it or hire someone to do it.

Re: [Bug-wget] [PATCH] rejected-log: Add option to dump URL rejections to a log.

Jookia <166...@gmail.com> writes: > This allows you to figure out why URLs are being rejected and some context > around it. > --- > doc/wget.texi | 5 ++ > src/init.c| 2 + > src/main.c| 3 ++ > src/options.h | 2 + > src/recur.c | 149 >

Re: [Bug-wget] cannot get 'wget --recursive' to work

Dave Ohlsson writes: > I have tried several wget options, with no luck. > > What could be the problem? what happens when you also specify -e robots=off in the command? Regards, Giuseppe

Re: [Bug-wget] [bug #20398] Save a list of the links that were not followed

Jookia <166...@gmail.com> writes: > On Mon, Jul 20, 2015 at 09:31:45AM +0200, Giuseppe Scrivano wrote: >> Jookia <166...@gmail.com> writes: >> >> > Hello again! >> > >> > A few days ago I was informed that my assignment letter was recei

Re: [Bug-wget] Metalink support

Hubert Tarasiuk writes: > W dniu 04.07.2015 o 00:15, Anthony Bryan pisze: >>> >>> Of course it works for me, but we are not talking about me :-) >>> >>> The main question is: what does the typical wget user expect ? >>> I would thinks (s)he expects the download of the file described by the >>> .m

Re: [Bug-wget] HSTS ready

Giuseppe Scrivano writes: > I am going to push these patches, together with the Metalink work in a > while to master. done! Giuseppe

Re: [Bug-wget] HSTS ready

Ander Juaristi writes: > Hi, > > I've reworked my patch according to Tim's suggestions: > > - Removed the countchars() function. > - Removed the macros SEPARATOR, SETPARAM and COPYPARAM. > - Fixed some issues detected by Valgrind. > > I also include the second patch with the test 'Tes

Re: [Bug-wget] [bug #20398] Save a list of the links that were not followed

Jookia <166...@gmail.com> writes: > Hello again! > > A few days ago I was informed that my assignment letter was received by the > FSF. > > Is it possible to move forward with this patch now that any work I create for > Wget can be legally included? I'm happy to make modifications as needed. cou

Re: [Bug-wget] the libidn problem

Daniel Stenberg writes: > On Tue, 30 Jun 2015, Ander Juaristi wrote: > >> the library user (me, us, in this case) doesn't have to know >> anything about UTF-8, so we should rely on the library for >> everything UTF-8-related. > > I fully agree with this and I will stand by this rule. That's why I

Re: [Bug-wget] the libidn problem

Daniel, Daniel Stenberg writes: > On Tue, 30 Jun 2015, Ander Juaristi wrote: > >> the library user (me, us, in this case) doesn't have to know >> anything about UTF-8, so we should rely on the library for >> everything UTF-8-related. > > I fully agree with this and I will stand by this rule. Tha

Re: [Bug-wget] Metalink support

Hubert Tarasiuk writes: > I have prepared a Metalink patch for Wget. The two main features are: > > - support Metalink v3 and Metalink v4 XML files: > https://tools.ietf.org/html/rfc5854 > using libmetalink parser: https://launchpad.net/libmetalink > > - support Metalink in HTTP headers: http://t

Re: [Bug-wget] TCP Fast Open for HTTP

Hubert Tarasiuk writes: > W dniu 28.05.2015 o 10:26, Giuseppe Scrivano pisze:> Hubert Tarasiuk >> I wouldn't even have an option for --tcp-fast-open and avoid adding such >> low level details to the command line. I would rather go for an env >> variable like TCP

Re: [Bug-wget] TCP Fast Open for HTTP

Hubert Tarasiuk writes: > I have talked with Giuseppe and he suggested that we might not do TCP > Fast Open support for FTP at this time (he argued that FTP is slow > either way :). > > Instead I might focus on implementing some basics of Metalink protocol > for HTTP and FTP resources in Wget. >

Re: [Bug-wget] Conditional GET requests

Hubert Tarasiuk writes: > Thank you for review. I tuned my patches based on your suggestions. > Please let me know if you have any further comments. pushed! Regards, Giuseppe

Re: [Bug-wget] Conditional GET requests

y ok to have variable declaration and > initialization in one >> line instead of two consecutive lines. Like in >> > > W dniu 19.05.2015 o 10:41, Giuseppe Scrivano pisze: >> few minor comments: >> > > Thank you for review. I tuned my patches based on your sugges

Re: [Bug-wget] Conditional GET requests

few minor comments: Hubert Tarasiuk writes: > From af5f411a699484482bc951d6b4efb6a90575f653 Mon Sep 17 00:00:00 2001 > From: Hubert Tarasiuk > Date: Sat, 9 May 2015 22:47:24 +0200 > Subject: [PATCH 5/6] Prototype of If-Modified-Since. > > @@ -1723,6 +1776,21 @@ initialize_request (struct url *u

Re: [Bug-wget] Conditional GET requests

Tim Rühsen writes: >> would not be better to not enable it by default? At least this is what >> we do with --timestamping and having --if-modified-since by default will >> break the use case of downloading successive files as .1, .2, .3 > > One GET including If-modified-since simply should r

Re: [Bug-wget] Conditional GET requests

Tim Rühsen writes: > Am Donnerstag, 14. Mai 2015, 15:43:54 schrieb Hubert Tarasiuk: >> W dniu 13.05.2015 o 13:28, Ander Juaristi pisze: >> > And second, I'm not really sure whether --condget is the best name for >> > the switch. >> > Requests that include any of If-Unmodified-Since, If-Match, >>

[Bug-wget] [bug #45037] wget -O foo ftp://ftp.funet.fi/pub/Linux/mirrors/debian/README deletes README symlink

Follow-up Comment #1, bug #45037 (project wget): slightly related bug.. $ ln -s /etc/passwd README $ wget -O README http://foo.bar README: Permission denied ___ Reply to this item at: __

Re: [Bug-wget] bootstrap problem

Ander Juaristi writes: > On 05/06/2015 02:31 AM, Ángel González wrote: >> A really clean solution :) >>> test $(echo y) = y || exit 1 >> >> It would be simple to add to bootstrap a line like >> > test $(echo y) = y || die 'No $() support. Please use a POSIX shell.' >> > Why don't we just add Bas

Re: [Bug-wget] [GSoC 2015] Basic HTTP/2 support

Daniel Stenberg writes: > On Fri, 1 May 2015, Miquel Llobet wrote: > >> Do you suggest starting off with HTTPS first then? > > Yes sure if you want to get something going first, and then using both > NPN and ALPN for maximum compliance at least for now. > >> It seems like most client/browsers onl

Re: [Bug-wget] [PATCH] Simultaneous timestamping and continue with ftp

Nikolay Merinov writes: > Hello, > > Previously you created code for processing simultaneous options "-N" and > "-c" with HTTP protocol: > > > I attached patch with same changes for FTP. > > --- > Nikolay Merinov > > > From dd947

Re: [Bug-wget] bootstrap problem

Mariusz Balewski writes: > On Wed, Apr 29, 2015 at 08:37:49PM +0200, Ángel González wrote: >>Onl 29/04/15 15:03, m_balewski wrote: >>>Hi, >>>It's my first mail here, so I would like to welcome you all! wget >>> isgreat (I'm using it for years) and I wish to try to look into >>> it's codeand maybe

Re: [Bug-wget] avoiding a large number of HEAD reqs when resuming

gob...@uukgoblin.net (User Goblin) writes: > The situation: I'm trying to resume a large recursive download of a site > with many files (-r -l 10 -c) > > The problem: When resuming, wget issues a large number of HEAD requests > for each file that it already downloaded. This triggers the upstream f

Re: [Bug-wget] no_proxy env ip address range support

Hi Aníbal, Aníbal Limón writes: > Hi guys, > > I noticed that wget only support domain names entries into no_proxy > env-var, i think will be good to > add support for IPs and IP ranges. > > I reviewed the code and i think can be added to > src/retr.c:no_proxy_match , that will be resolv > the h

Re: [Bug-wget] [PATCH] Please review

Tim Ruehsen writes: > Hi, > > Two patches to WARC code and one for the Perl test suite for reviewing. > > BTW, we have no tests for the WARC code, do we ? > Any ideas for an implementation ? ACK to the patches. Unfortunately we have no tests for WARC, and I think we also need a bit better abstr

Re: [Bug-wget] [Patch] fix bug #44628 not honoring RFC 6266 in --content-disposition

Miquel Llobet writes: > Thanks for the review and git tips! I made all the changes you > suggested. thanks to have worked on it. I am going to push it with few tweaks. Regards, Giuseppe

Re: [Bug-wget] Wget 1.16.3 v. VMS

"Steven M. Schweda" writes: > From: Giuseppe Scrivano > >Thanks for the prompt response. > >> could you please send the patch as git format-patch output? Please also >> add the ChangeLog log style to the commit message. I have no objections >>

Re: [Bug-wget] [Patch] fix bug #44628 not honoring RFC 6266 in --content-disposition

Miquel Llobet writes: > From d71c7cc43689fc752dedb2a3500673f9981f7fc9 Mon Sep 17 00:00:00 2001 > From: Miquel Llobet > Date: Wed, 1 Apr 2015 17:32:50 +0200 > Subject: [PATCH] Fixed #44628 honoring RFC 6266 content-disposition > > src/http.c (parse_content_disposition): stores filename* and filen

Re: [Bug-wget] gethttp cleanup

Hubert Tarasiuk writes: > I have identified a potential drawback with the function > `establish_connection`. > > [Patch #3] > On error, it would free the `req` variable, but it never zeroed > `*req_ref`. As the matter of fact, it only wrote to `req_ref` on > successful exit (when it did not actua

Re: [Bug-wget] [Patch] fix bug #44628 not honoring RFC 6266 in --content-disposition

Miquel Llobet writes: > The problem was that parse_content_disposition treated the values > "filename" and "filename*" as the same and concatenated both values. RFC > 6266 states that if both are present, "filename*" should have preference. > > Now, the patch is tricky, because in this case: > >

Re: [Bug-wget] Wget 1.16.3 v. VMS

"Steven M. Schweda" writes: >I haven't looked at the documentation, but the following code > changes seem plausible to me: could you please send the patch as git format-patch output? Please also add the ChangeLog log style to the commit message. I have no objections to the patch itself. T

Re: [Bug-wget] gethttp cleanup

Hi Hubert, Hubert Tarasiuk writes: > I have identified a potential drawback with the function > `establish_connection`. > > [Patch #3] > On error, it would free the `req` variable, but it never zeroed > `*req_ref`. As the matter of fact, it only wrote to `req_ref` on > successful exit (when it d

Re: [Bug-wget] [GSOC] Bugfixes

for example, looks like: $ cat ~/.gitconfig [user] name = Giuseppe Scrivano email = gscriv...@gnu.org > Date: Fri, 27 Mar 2015 14:00:33 +0100 > Subject: [PATCH 1/2] Factor out set_content_type function from gethttp > > --- > src/http.c | 37 ++---

Re: [Bug-wget] [GSOC] Bugfixes

Hubert Tarasiuk writes: > Hello to everyone, > > My name is Hubert Tarasiuk and I am a CS student at the University of > Warsaw, Poland (expected graduation date July 2015, B.Sc.). > > I am working on my Google Summer of Code proposal for two of the GNU > wget ideas': >> Speed up Wget's Download

Re: [Bug-wget] gethttp cleanup

Giuseppe Scrivano writes: > Hi, > > spring is coming and it is time for some cleanup. > > I have refactored a bit gethttp and moved some code to other functions. > It is mostly mechanical code movements, and I hope to do some more work > on this (if other people want to jum

Re: [Bug-wget] [PATCH] Trust on first use

Thanks for your contribution! I've some comments on the code: Molnár Géza writes: > diff --git a/src/gnutls.c b/src/gnutls.c > index 5a89e06..38bf2af 100644 > --- a/src/gnutls.c > +++ b/src/gnutls.c > @@ -76,6 +76,85 @@ key_type_to_gnutls_type (enum keyfile_type type) > preprocessor macro.

Re: [Bug-wget] [PATCH] UTF-8-ify contributors' names in wget.texi (#40472)

Rohan Prinja writes: > Yes, I encountered it, sorry for not checking first. > > Turns out some more changes were required. Attached is a new patch > that also touches doc/texi2pod.pl and doc/Makefile.am, and builds > without errors. I commit-amended before creating this patch instead of > creatin

Re: [Bug-wget] [PATCH] Corrected documentation

self. > > There it goes! I made some small changes and pushed it. Thanks for your first contribution! Please fix your .gitconfig to properly include your name (it is used by git to set the patch author), mine looks like (just relevant section): $ cat ~/.gitconfig [user] name

Re: [Bug-wget] [PATCH] UTF-8-ify contributors' names in wget.texi (#40472)

Rohan Prinja writes: > Done, thank you for the pointers. I get this problem now when I run "make": ./texi2pod.pl -D VERSION="1.16.3.6-b74a-dirty" ./wget.texi wget.pod /usr/bin/pod2man --center="GNU Wget" --release="GNU Wget 1.16.3.6-b74a-dirty" wget.pod > wget.1 Wide character in printf at /us

Re: [Bug-wget] [PATCH] Corrected documentation

"Ander Juaristi Alamos" writes: > As per Wget 1.16.3, the default SSL backend is GnuTLS, so the docs are lying. > The default SSL backend is the one that gets compiled by make if ./configure > is run without '--with-ssl'. > > diff --git a/ChangeLog b/ChangeLog > index e69de29..0e6974a 100644 > -

Re: [Bug-wget] [PATCH] UTF-8-ify contributors' names in wget.texi (#40472)

Rohan Prinja writes: > Updated patch file, this time using git-diff. > > On 15 March 2015 at 10:15, Rohan Prinja wrote: >> Hi everyone, >> >> This is my first time submitting a patch (I'm used to contributing to >> projects via Github) so I hope I'm not making any mistakes. Attached >> is a patc

[Bug-wget] gethttp cleanup

eans local variables must be properly initialized as they could be cleaned-up before they were supposed to be). Cheers, Giuseppe >From f61530279b5d59d0ae3a954420ac6c64288b98ff Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano Date: Sun, 15 Mar 2015 22:59:29 +0100 Subject: [PATCH 1/6] Fa

Re: [Bug-wget] [Patch] fix bug #39175 Header value length limited with 256

Miquel Llobet writes: > Could this be dinamically allocated? > > Indeed it can! Thanks Giuseppe and Darshit for pointing out. Ideally > we should change all the resp_header_copy calls to resp_header_strdup > (dynamic resp header copy). There is a bit to code to change, as the > function retur

Re: [Bug-wget] [Patch] fix bug #44516, -o- log to stdout

Miquel Llobet writes: > Yeah, I'll be using git format patch from now on. Do you prefer > pasting the commit on the message or attaching a file? shouldn't make a difference, but just attach it, less risky to be changed by the mail client. Thanks, Giuseppe

Re: [Bug-wget] [Patch] fix bug #44516, -o- log to stdout

Miquel Llobet writes: > It seems like the correct thing to do. Could you please just use > as > ChangeLog-style like commit message? > > Yes! Sorry about that, here is the patch with the new commit message. > Let me know if this is correct. > > Fixed #44516 -o- not logging to stdout

Re: [Bug-wget] [Patch] fix bug #40426, wget hangs with -r and -O -

Miquel Llobet writes: > When wget is called with -r or -p it will look for resource tags in the > output file, and since -O- redirects to stdout, the program hangs, waiting > for input. The same happens with pipes or FIFO files. > > My proposed solution is to disallow calling wget with '-p' or '-

Re: [Bug-wget] [Patch] fix bug #44516, -o- log to stdout

Miquel Llobet writes: > removed braces from the second if statement, as per GNU's coding standards > > --- src/log.c.origin 2015-03-13 01:32:27.0 +0100 > +++ src/log.c 2015-03-13 02:28:25.0 +0100 > @@ -598,11 +598,16 @@ > { >if (file) > { > - logfp = fopen (file, ap

Re: [Bug-wget] [Patch] fix bug #39175 Header value length limited with 256

Miquel Llobet writes: > Increased the header buffer to 8Kb, as there are no limits to the size of > field name, values or headers themselves. While the current value is big > enough, other projects such as Apache [1] or nginx have limits of 4-8Kb. > > If we want to allow for arbitrary size header

Re: [Bug-wget] How can I help

Anderson Goulart writes: > My questions: > >- Is there any default sandbox to test the code? you can run "make check" to run our tests suite. >- How do you build new test cases? add a new file in testenv/ (you can start by copying an existing one there) and adding it to the TESTS varia

Re: [Bug-wget] Trust On First Use & GSoC 2015 participation

Ander Juaristi writes: > On 03/09/2015 09:22 PM, Molnár Géza wrote: >> Also, do you guys think it would be a good project idea to implement basic >> HTTP2 support for Wget? > > Other projects, such as Apache HttpComponents are starting to work on it. Why > not Wget? Any updates on this? no upda

Re: [Bug-wget] [PATCH] maint: update copyright year ranges to include 2015

Daniel Stenberg writes: > On Mon, 9 Mar 2015, Ángel González wrote: > >> Unless the file was changed in that year (with copyrightable >> changes), AFAIK the copyright year wouldn't change, no matter what >> the label says. > > I would agree would you, but the GNU policy is different[1]: > > "It

[Bug-wget] [PATCH] maint: update copyright year ranges to include 2015

FYI, I am going to push the result of running: git ls-files doc contrib msdos src testenv/ tests util vms | xargs gnulib/build-aux/update-copyright on the repository to mass update copyright years. Regards, Giuseppe

Re: [Bug-wget] Issue with --content-on-error and --convert-links

Yousong Zhou writes: > I noticed that wget v1.16.2 has been released. Is it okay that this > series can be reviewed again and applied? FYI, attachments can be > found at link [1] > > [1] Re: [Bug-wget] Issue with --content-on-error and --convert-links, > https://lists.gnu.org/archive/html/bug-

Re: [Bug-wget] [Bug-Wget] Add some documentation

Darshit Shah writes: > From aaedc68bcff5a9311ed806d972ce88a1d2c12a96 Mon Sep 17 00:00:00 2001 > From: Darshit Shah > Date: Fri, 6 Mar 2015 22:00:24 +0530 > Subject: [PATCH] Docs: --post-file is binary data > > Wget considers the file mentioned in the --post-file argument as a > binary file and d

[Bug-wget] GNU wget 1.16.3 released

Hello, I am pleased to announce the new version of GNU wget. It is available for download here: ftp://ftp.gnu.org/gnu/wget/wget-1.16.3.tar.gz ftp://ftp.gnu.org/gnu/wget/wget-1.16.3.tar.xz and the GPG detached signatures using the key E163E1EA: ftp://ftp.gnu.org/gnu/wget/wget-1.16.3.tar.gz.sig

Re: [Bug-wget] How to switch off the status bar?

Noël Köthe writes: > Hello, > > Am Samstag, den 07.03.2015, 09:58 + schrieb Thomas Sefzick: >> When calling wget via the 'catch' command from inside a (Tcl-)script the >> script detects an error. >> This started with wget version 1.16.2 and seems to be caused by the status >> bar which is alw

Re: [Bug-wget] A possible bug with wget 1.16.1?

George R Goffe writes: > Hi, > First of all, I have built this wget from your repositories AND used the > "latest" GCC (with the intention of "furthering the cause" of open source > software by reporting bugs. So far I have found none... until, possibly, now. > I'm using wget with the "-c" opti

Re: [Bug-wget] Want to participate in Google summer of code 2015

Hi Shanti, Shanti Swarup Tunga writes: > Sir, > I am Shanti Swarup Tunga ,a third year undergraduate student in stream > Computer science. I have a good knowledge in C programming and thread > concept. I want to work on GNU Wget . Please let me know how to start. the best way is to fetch t

[Bug-wget] GNU wget 1.16.2 released

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, I am pleased to announce the new version of GNU wget. It is available for download here: ftp://ftp.gnu.org/gnu/wget/wget-1.16.2.tar.gz ftp://ftp.gnu.org/gnu/wget/wget-1.16.2.tar.xz and the GPG detached signatures using the key E163E1EA: ftp

Re: [Bug-wget] Final error on Solaris: libintl missing during "make check"

Dagobert Michelsen writes: >> Dagobert Michelsen writes: Am 30.01.2015 um 18:39 schrieb Darshit Shah : Giuseppe is the maintainer of Wget and has stated that he will tag a beta release of Wget 1.16.2 sometime in the next week. A week or so later, we will tag the final r

Re: [Bug-wget] [patch] uuid generation in warc.c

Eli Zaretskii writes: > [Please CC me directly, as I'm not subscribed to the list.] > >> Date: Sat, 14 Feb 2015 14:33:20 +0100 >> From: Gisle Vanem >> CC: bug-wget@gnu.org >> >> Eli Zaretskii wrote: >> >> > + if (rpc_uuid_avail == -1) >> > +{ >> > + HMODULE hm_rpcrt4 = LoadLibrary ("

Re: [Bug-wget] wget-1.16.1.46-3d8e7 missing hint in the tarball

Darshit Shah writes: > Not really. Because README.checkout contains information that would be > confusing to the average user who downloads a tarball. README.checkout > should contain specific information that is required by those who > clone the git repositories. It needs to enumerate the additi

Re: [Bug-wget] wget-1.16.1.46-3d8e7 missing hint in the tarball

Tim Rühsen writes: > Hi Darshit, > > Am Mittwoch, 18. Februar 2015, 22:39:18 schrieb Darshit Shah: >> Readme.checkout is a file that is only available in the git >> repository. I guess this is a side effect of having >> gitlog-to-changelog generate out changelogs. A reference to this file >> has

Re: [Bug-wget] Final error on Solaris: libintl missing during "make check"

Dagobert Michelsen writes: > Hi Darshit, > >> Am 30.01.2015 um 18:39 schrieb Darshit Shah : >> >> Giuseppe is the maintainer of Wget and has stated that he will tag a >> beta release of Wget 1.16.2 sometime in the next week. A week or so >> later, we will tag the final release for 1.16.2. > > So

Re: [Bug-wget] [PATCH] Fix for #43785

Tim Rühsen writes: >> # define ngettext(Msgid1, Msgid2, N) \ >> ((N) == 1 \ >> ? ((void) (Msgid2), (const char *) (Msgid1)) \ >> >> : ((void) (Msgid1), (const char *) (Msgid2))) > > This does not work (Kiyoshi wrote a private Mail to me). > >> Or can't we just "#include " on all pl

Re: [Bug-wget] [PATCH] Fix for #43785

Tim Ruehsen writes: > Fix #43785 for another Solaris issue. > > I would like to see this in the next bugfix release. > > Do you agree ? > > Tim > > From 518ed8d07c0a6e441e0a919ba1967d89e0061898 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Tim=20R=C3=BChsen?= > Date: Thu, 5 Feb 2015 16:05:24 +0100

Re: [Bug-wget] Issue with --content-on-error and --convert-links

Yousong Zhou writes: > On 29 January 2015 at 21:26, Tim Ruehsen wrote: >> Hi Yousong, >> >>> > this patch seems to be incomplete. Do you have a complete patch (e.g. +new >>> > option, + docs) or are you going to work on it ? >>> >>> That patch was only intended as a ephemeral one to see if it ca

[Bug-wget] [PATCH] make syntax-check fixes

FYI, I have pushed these two trivial patches: >From 875d0819c4f6c48f3712433f973b6a811cf76a1d Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano Date: Sat, 31 Jan 2015 00:30:26 +0100 Subject: [PATCH 1/2] * cfg.mk (VC_LIST_ALWAYS_EXCLUDE_REGEX): Add ChangeLog-2014-12-10. --- cfg.mk | 2 +- 1 f

Re: [Bug-wget] [PATCH] Mention libio-socket-ssl-perl in README.checkout

Tim Ruehsen writes: > From 2ec661cd3fe727e9e75a894de907aa2efd2a9b2b Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Tim=20R=C3=BChsen?= > Date: Fri, 2 Jan 2015 13:47:03 +0100 > Subject: [PATCH] README.checkout: Mention libio-socket-ssl-perl to be > installed > > --- > README.checkout | 10 +

Re: [Bug-wget] [PATCH] wget -nv doesn't show enough errors

Tim Ruehsen writes: > On Friday 09 January 2015 14:51:00 Darshit Shah wrote: >> I don't see any issue with this patch. No-verbose does need to print a >> little bit more information I think. >> >> However, @giuseppe, @Tim, do you'll see any issues with scripts >> parsing Wget's --nv output if we

Re: [Bug-wget] [PATCH] Generate changelog from the git commit messages

Tim Rühsen writes: > Cool ! It works for me. > > Two little (cosmetic) things that popped up: > > There is a date failure in the old tests/ChangeLog (it is the first entry in > ChangeLog-2014-12-10: 2014-40-22 should be 2014-04-22). > > And there should be an empty line between between the 'git

Re: [Bug-wget] some remarks about the changed help text

Benno Schulenberg writes: > If not, then please apply some of the upcoming patches. The first one > makes all option descriptions start with a lowercase letter, like most > of them already do. And it spell URL consistently in all uppercase. I have added the changelog entry in the commit messag

Re: [Bug-wget] some remarks about the changed help text

> @Giuseppe: You know how to do that !? I don't. yes, maybe for next time we can plan a RC before the release and announce it to TP (it is just an email with the link to the tarball). Regards, Giuseppe

Re: [Bug-wget] [PATCH] Update-README.checkout-to-libpcre-pkg-config-GnuTLS

Tim Ruehsen writes: > Please review. > > Tim > > From 959fbbe23d329e3aa60110ab384bf8ebc2b71620 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Tim=20R=C3=BChsen?= > Date: Thu, 11 Dec 2014 12:24:43 +0100 > Subject: [PATCH] Update README.checkout to libpcre, pkg-config, GnuTLS > > --- > ChangeLog

Re: [Bug-wget] Wget 1.16.1 detection of non-system openssl broken on MacOSX.

Tim Ruehsen writes: >> OK, that worked, thanks; indeed, all I had to do was >> 'PKG_CONFIG_PATH=/usr/local/ssl/lib/pkgconfig ./configure blah blah'. Easy >> enough. (That's the default location for a built-from-source openssl; is >> openssl not putting its .pc file where it should?) > > I guess

[Bug-wget] GNU wget 1.16.1 released

Hello, I am pleased to announce the new version of GNU wget. It is available for download here: ftp://ftp.gnu.org/gnu/wget/wget-1.16.1.tar.gz ftp://ftp.gnu.org/gnu/wget/wget-1.16.1.tar.xz and the GPG detached signatures using the key E163E1EA: ftp://ftp.gnu.org/gnu/wget/wget-1.16.1.tar.gz.sig

Re: [Bug-wget] [PATCH] Script to check Wget status (for developers)

Tim Ruehsen writes: > +for CC in gcc clang-3.6; do could we replace clang-3.6 with just clang? Regards, Giuseppe

Re: [Bug-wget] [PATCH] Fix-message-in-configure.ac-for-when-GnuTLS-has-not-been-found

Tim Ruehsen writes: > If GnuTLS is not available a simple ./configure prints > configure: error: --with-ssl=gnutls was given, but GNUTLS is not available. > > This seems misleading, so I changed it to > configure: error: GnuTLS has not been found. Use --with-ssl=openssl if you > explicitly want

Re: [Bug-wget] [PATCH] Replace-compatibility-functions-by-gnulib-functions

Tim Ruehsen writes: > As the name says... > > src/cmpt.c has been removed and bootstrap.conf extended. > > Please review & comment. > > Tim > > From 94447e31a6576511b7d0aadc6296221bfdd570a2 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Tim=20R=C3=BChsen?= > Date: Fri, 5 Dec 2014 11:57:28 +0100 > Su

Re: [Bug-wget] [RFC] Reverse scrolling direction

Tim Ruehsen writes: > On Tuesday 02 December 2014 17:52:48 Darshit Shah wrote: >> On 11/27, Darshit Shah wrote: >> >A couple of days ago, Giuseppe suggested (on IRC) that maybe we should >> >reverse the direction in which the filename in the progressbar >> >scrolls. >> > >> >His reasoning was tha

Re: [Bug-wget] [PATCH] OpenSSL TLSv1+ regression in wget-1.16

j...@wxcvbn.org (Jérémie Courrèges-Anglas) writes: > From 4142db8a2ba462cd2d764c09d0e4996e23ca13c2 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?J=C3=A9r=C3=A9mie=20Courr=C3=A8ges-Anglas?= > Date: Mon, 1 Dec 2014 13:43:22 +0100 > Subject: [PATCH 2/2] openssl backend: detect the availability of RAND_

Re: [Bug-wget] [PATCH] Fix #41235

Tim Ruehsen writes: > Fix some issues found by 'parfait' static analysis scanner. > Even if these are not 'real' bugs, the changes look like good programming. > > Please review. > > Tim > > From aa34caf27a2d6a4bf245aa4b94518b0ee47d648b Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Tim=20R=C3=BChsen?

Re: [Bug-wget] [PATCH] Replaced-xfree_null-by-xfree-and-nullify-argument-aftfer-freeing

Tim Rühsen writes: > This patch removes xfree_null() and replaces it by xfree(). > xfree() automatically nullifies the argument after freeing to reduce dangling > pointer problems like double frees. > > I also cleaned up code like > if (p) > xfree (p); > > and > xfree(p); >

Re: [Bug-wget] [PATCH] Let's get rid of gettext.h

Tim Ruehsen writes: > From e194c1dfd32583c57540ebc96aa0341db1007f1d Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Tim=20R=C3=BChsen?= > Date: Fri, 28 Nov 2014 11:27:58 +0100 > Subject: [PATCH] Get rid of gettext.h > > --- > src/ChangeLog | 8 ++ > src/gettext.h | 272 > -

Re: [Bug-wget] [PATCH] Let Wget select strongest auth challenge

Tim Rühsen writes: > Am Samstag, 22. November 2014, 16:24:18 schrieb Darshit Shah: >> Another reason why I never got around to implementing this feature is that >> it is required by almost no one. The issue at hand is that when a Server >> responds with two possible authentication methods, the cl

Re: [Bug-wget] [PATCH] Added missing TLSV1_1 and TLSV1_2 code to gnutls.c

Tim Ruehsen writes: > case secure_protocol_tlsv1: >allowed_protocols[0] = GNUTLS_TLS1_0; >allowed_protocols[1] = GNUTLS_TLS1_1; >allowed_protocols[2] = GNUTLS_TLS1_2; >err = gnutls_protocol_set_priority (session, allowed_protocols); >break; > - > +

Re: [Bug-wget] Check for flex before compiling

Darshit Shah writes: > On 11/24, Darshit Shah wrote: >>Good point. I'll amend this check and add it to bootstrap >> >>Thanking You, >>Darshit Shah >>Sent from mobile device. Please excuse my brevity >>On 24-Nov-2014 7:07 pm, "Giuseppe Scrivano&quo

Re: [Bug-wget] Fix various compiler warnings

Darshit Shah writes: > This is a new set pf patches to eliminate some more compiler warnings. > > [PATCH 1/8] Mark unused paramter in utils.c > [PATCH 2/8] Add extern declaration for version.c strings > [PATCH 3/8] Fix missing extern declaration error for build_info.pl > [PATCH 4/8] Declare exter

Re: [Bug-wget] [PATCH 6/8] Add extern declaration for program_arsgstring

Darshit Shah writes: > In test.c, this patch changes the type of program_argstring to char * > from a const char *. This is because, we use a char * string in the rest > of the program and declare an extern accordingly. Removing the const > type helps in keeping the code cleaner at no extra cost.

Re: [Bug-wget] Check for flex before compiling

Darshit Shah writes: > Damn.. I didn't think of searching for that. > > We should use AC_PROG_LEX I don't think we should check for it. As we distribute the .c file with the tarball, it is not needed for building wget. It is only needed from a git checkout, so the place for such a check should

Re: [Bug-wget] [PATCH] Fixing C89 warnings

Tim Rühsen writes: > Am Mittwoch, 19. November 2014, 22:07:28 schrieb Darshit Shah: >> On 11/18, Tim Rühsen wrote: >> >This patch fixes most C89 warnings for me (-std=c89 -pedantic) since these >> >may prevent from compiling with MSVC. >> > >> >There are still some warnings "ISO C forbids convers

Re: [Bug-wget] Removing form feeds from sources

Tim Ruehsen writes: > On Wednesday 19 November 2014 23:36:40 Daniel Stenberg wrote: >> On Wed, 19 Nov 2014, Tim Rühsen wrote: >> > I won't change my toolchain just to see these formfeeds. Looks like I had >> > luck so far... but now, really, how can I work on Wget's sources from now >> > on ? I h

Re: [Bug-wget] [PATCH] Fix possible issues running in a turkish locale

Tim Ruehsen writes: > On Thursday 20 November 2014 10:43:11 Darshit Shah wrote: >> On 11/19, Daniel Stenberg wrote: >> >On Wed, 19 Nov 2014, Tim Rühsen wrote: >> >>I won't change my toolchain just to see these formfeeds. Looks like >> >>I had luck so far... but now, really, how can I work on Wget

<    1   2   3   4   5   6   7   8   9   10   >