Re: [Bug-wget] wget 1.19.4 - possible double free in url.c

2018-03-01 Thread Tim Rühsen
On 03/01/2018 03:01 PM, Volkmar Klatt wrote: > Dear wget maintainer, > > 1) in wget 1.19.4 (and probably earlier) > please check carefully > > static char * convert_fname (char *fname) > in > src/url.c > > I run a OpenBSD machine, x86, ABI=32 > and I guess there's a double free when using

Re: [Bug-wget] segment fault while downloading .tar.gz file

2018-02-23 Thread Tim Rühsen
Hi Jay, it seems related to https://gitlab.com/gnuwget/wget2/merge_requests/353. Maybe you like to drop in there... In short: the server ignores 'Accept-Encoding: identity' and gives us a 'Content-Type: gzip'. If you build wget2 with libz (just install zlib1-dev and ./configure again), the

Re: [Bug-wget] "make check" fails in "Test-iri-disabled" on Mac OS X, after "./configure" and "make" of wget-1.19.4 complete

2018-02-20 Thread Tim Rühsen
The charset conversion has an issue on OSX since a while (OSX changed something). And we have no OSX developer, so there is nothing to do for us. In the past I had several contacts with charset issues on OSX, who found configuration/installation issues after a while and then silenced (problem

Re: [Bug-wget] How to remove a header?

2018-02-09 Thread Tim Rühsen
Hi, On 02/09/2018 12:40 AM, Peng Yu wrote: > Hi, > > wget sets some headers. Is there a way to remove some headers, e.g., > Accept-Encoding? Thanks. No, you can change headers and add headers. But it looks like nobody ever needed/asked for an option to remove headers. With Best Regards, Tim

Re: [Bug-wget] no data downloaded

2018-02-06 Thread Tim Rühsen
; layout.css for the colors?). > > Always something new to learn when I think I have seen it all, Jos > > > Op 05-Feb-18 om 17:32 schreef Tim Rühsen: >> Either it's missing credentials (do you have to login with Firefox ?) or >> cookies. >> Some servers deliver

Re: [Bug-wget] no data downloaded

2018-02-05 Thread Tim Rühsen
On 02/05/2018 12:03 PM, jos vaessen wrote: > Hello, > > I am downloading the home-webpage from my solar-power-converter using > WIFI and its IP adress 160.190.0.1 with WGET. No problem beside that the > page is zipped as 7ZIP. After unzipping it shows the content of > index.html like a

Re: [Bug-wget] wget 1.19.2 fails on Test-metalink-http.py and Test-metalink-http-quoted.py

2018-01-31 Thread Tim Rühsen
Thanks, slightly amended and pushed. With Best Regards, Tim On 01/30/2018 09:42 AM, Arkadiusz Miśkiewicz wrote: > On Monday 30 of October 2017, Tim Rühsen wrote: >> On 10/30/2017 12:49 PM, Arkadiusz Miśkiewicz wrote: >>> On Monday 30 of October 2017, Tim Rühsen wrote: >

Re: [Bug-wget] Testsuite summary for wget 1.19.4: # FAIL: 8

2018-01-25 Thread Tim Rühsen
Thanks for the report. This happens because we try to print a numeric IP address: warn "Failed to resolve $$addr, using $srcdir/certs/wgethosts\n"; But then this is printed only if 'localhost' can't be resolved to 127.0.0.1. What is it in your case ? Could you apply this patch and see what

Re: [Bug-wget] nettle-3.4.tar.gz isn't actually compressed

2018-01-19 Thread Tim Rühsen
On 01/19/2018 02:23 AM, Thomas Deutschmann wrote: > Hi, > >> sorry, I lost focus on this issue while waiting for >> more examples. > > In Gentoo we hit this several times: > > https://bugs.gentoo.org/640930 > https://bugs.gentoo.org/639752 > https://bugs.gentoo.org/636238 >

Re: [Bug-wget] Unexpected result with -H and -D

2018-01-17 Thread Tim Rühsen
Hi, this is not a PSL matching, so no libpsl is needed. Just sufmatch() has to be fixed to do (sub)domain matching. Attached is a fix. With Best Regards, Tim On 01/17/2018 03:01 PM, Darshit Shah wrote: > Hi, > > This is a bug in Wget, apparently a really old one! Seems like the bug has >

Re: [Bug-wget] nettle-3.4.tar.gz isn't actually compressed

2018-01-10 Thread Tim Rühsen
e. I can't reproduce that issue > > Thank you. > > Regards, > Tomas > > On 20.11.2017 17:07, Tim Rühsen wrote: >> There already has been a discussion about that (starting here: >> http://lists.gnu.org/archive/html/bug-wget/2017-11/msg0.html). >> >>

Re: [Bug-wget] Failing to compile without depricated features from openssl

2017-12-04 Thread Tim Rühsen
On 12/04/2017 01:13 AM, Matthew Thode wrote: > Yep, confirmed that this fixed a possible issue, also tested it with > openssl-1.1. > > We are currently using the attached patch. Thanks, I already pushed your patch (with my small changes) to master yesterday. If there is any issue with it, let me

Re: [Bug-wget] Patch: Make url_file_name also convert remote path to local encoded

2017-11-12 Thread Tim Rühsen
On Donnerstag, 2. November 2017 21:09:46 CET YX Hao wrote: > Dear Tim, > > > > The 2nd patch is attached. Please take a review :) Hmmm, is this a stand-alone patch and working without your patch #1 (Fix printing...) ? Please give at least one example (better more) to show what your patch

Re: [Bug-wget] Support for HTTP 308 (Permanent Redirect)

2017-11-03 Thread Tim Rühsen
On Sonntag, 29. Oktober 2017 00:35:54 CET Vasya Pupkin wrote: > Hello, > > Some websites started using HTTP 308 redirects > (https://tools.ietf.org/html/rfc7538) and Wget fails to follow such > redirects currently. I'm not sure if this can be considered a bug, though. > Anyway, would be nice if

Re: [Bug-wget] New wget (1.19.2): Unexpected download behaviour for gzip-compressed tarballs (HTTP-header dependent)

2017-11-03 Thread Tim Rühsen
On 11/03/2017 09:30 AM, Daniel Stenberg wrote: > On Thu, 2 Nov 2017, Tim Rühsen wrote: > >> How would you (or curl) handle >>  Content-Type: application/x-tar >>  Content-Encoding: gzip > >> when downloading 'x.tar.gz' or 'x.tgz' ? Save the file compres

Re: [Bug-wget] New wget (1.19.2): Unexpected download behaviour for gzip-compressed tarballs (HTTP-header dependent)

2017-11-03 Thread Tim Rühsen
On 11/03/2017 06:37 AM, James Cloos wrote: >>>>>> "TR" == Tim Rühsen <tim.rueh...@gmx.de> writes: > > TR> I downloaded/tested thousands of web pages and they behave as if 'Content- > TR> Encoding: gzip' is a compression for the transport. U

Re: [Bug-wget] New wget (1.19.2): Unexpected download behaviour for gzip-compressed tarballs (HTTP-header dependent)

2017-11-02 Thread Tim Rühsen
On Mittwoch, 1. November 2017 22:21:38 CET Daniel Stenberg wrote: > On Wed, 1 Nov 2017, Tim Rühsen wrote: > > Content-Encoding: gzip means that the data has been compressed for > > transportation purposes only. > > That's actually not what it means. There's transfer-encodi

Re: [Bug-wget] New wget (1.19.2): Unexpected download behaviour for gzip-compressed tarballs (HTTP-header dependent)

2017-11-01 Thread Tim Rühsen
Hi Jens, On Mittwoch, 1. November 2017 17:27:58 CET Jens Schleusener wrote: > Hi, > > the new "wget" release 1.19.2 has got a new feature: > > "gzip Content-Encoding decompression" > > But that feature - at least for my self-conmpiled binary - leads to a > problem if one downloads

Re: [Bug-wget] Self test results on OS X 10.9

2017-10-30 Thread Tim Rühsen
On Montag, 30. Oktober 2017 12:28:23 CET Jeffrey Walton wrote: > Hi Everyone, > > I'm building 1.19.2 from sources. Does anyone have an idea about the > "Use of uninitialized value $addr in concatenation ..."? Looks like a copy misuse of an uninitialized value :-) E.g. in Test-https-pfs.px is

Re: [Bug-wget] wget 1.19.2 fails on Test-metalink-http.py and Test-metalink-http-quoted.py

2017-10-30 Thread Tim Rühsen
On 10/30/2017 12:49 PM, Arkadiusz Miśkiewicz wrote: > On Monday 30 of October 2017, Tim Rühsen wrote: >> On 10/29/2017 09:39 PM, Arkadiusz Miśkiewicz wrote: >>> On Sunday 29 of October 2017, Tim Rühsen wrote: >>>> On Sonntag, 29. Oktober 2017 21:00:35

Re: [Bug-wget] wget 1.19.2 fails on Test-metalink-http.py and Test-metalink-http-quoted.py

2017-10-29 Thread Tim Rühsen
On Sonntag, 29. Oktober 2017 21:00:35 CET Arkadiusz Miśkiewicz wrote: > On Sunday 29 of October 2017, Tim Rühsen wrote: > > On Sonntag, 29. Oktober 2017 13:45:53 CET Arkadiusz Miśkiewicz wrote: > > > Hi. > > > > > > Test suite for wget fails here on Test-meta

Re: [Bug-wget] Patch: Avoid unnecessary UTF-8 encoded fallback

2017-10-25 Thread Tim Rühsen
Thanks, applied. With Best Regards, Tim On 10/25/2017 12:56 PM, YX Hao wrote: > Dear there, > > Things are clear as the patch shows. ☺ > > == > diff --git a/src/retr.c b/src/retr.c > index a27d58af..c1bc600e 100644 > --- a/src/retr.c > +++

Re: [Bug-wget] one strlen on loop

2017-10-25 Thread Tim Rühsen
On 10/25/2017 01:10 AM, Rodgger Bruno wrote: > right? Not quite >> And there seems to be two buffer underflow issues in the old code. >> Please consider fixing it as well: >> >>> if (!c_strncasecmp((tok + (tok_len - 4)), ".DIR", 4)) >> >>> else if (!c_strncasecmp ((tok + (tok_len -

Re: [Bug-wget] one strlen on loop

2017-10-23 Thread Tim Rühsen
Hi Rodgger, thanks for your contribution ! Could you please amend a few things !? Not compilable here: > if (tok_len < 12) && (strchr( tok, '-') != NULL)) If you are about to touch the code, please also add a space where it is missing (between tok and +): > *(tok+ (tok_len - 4)) = '\0'; /*

Re: [Bug-wget] cipher_list string when using OpenSSL

2017-10-20 Thread Tim Rühsen
On 10/19/2017 11:49 AM, Jeffrey Walton wrote: > On Thu, Oct 19, 2017 at 5:35 AM, Tim Rühsen <tim.rueh...@gmx.de> wrote: >> Hi Jeffrey, >> >> thanks for heads up ! >> >> Does OpenSSL meanwhile have a PFS for their cipher list ? >> >> Currently it

Re: [Bug-wget] cipher_list string when using OpenSSL

2017-10-19 Thread Tim Rühsen
Hi Jeffrey, thanks for heads up ! Does OpenSSL meanwhile have a PFS for their cipher list ? Currently it looks like that each and every client has to amend their cipher list from time to time. Instead, this should be done in the library. So that new versions automatically make the client code

Re: [Bug-wget] Wget cannot validate https://ftp.gnu.org?

2017-10-16 Thread Tim Rühsen
Hi Jeffrey, I can't reproduce your issue on the first try (Debian unstable here). That means the issuers cert (DST Root CA X3,O=Digital Signature Trust Co.) is part of the systems's CA cert store. $ ls -la /etc/ssl/certs/*X3* lrwxrwxrwx 1 root root 53 27-10-11 09:39:52

Re: [Bug-wget] lex compile problem on AIX 7.1

2017-10-03 Thread Tim Rühsen
On Dienstag, 3. Oktober 2017 18:31:45 CEST Avinash Sonawane wrote: > On Mon, Oct 2, 2017 at 8:56 PM, Tim Rühsen <tim.rueh...@gmx.de> wrote: > > On 10/02/2017 10:00 AM, l...@langs.se wrote: > >> Hi! > >> > >> I get the following error when compiling wget

Re: [Bug-wget] lex compile problem on AIX 7.1

2017-10-02 Thread Tim Rühsen
On 10/02/2017 10:00 AM, l...@langs.se wrote: > Hi! > > I get the following error when compiling wget 1.19.1 on AIX 7.1: > > make all-am > CC connect.o > CC convert.o > CC cookies.o > CC ftp.o > lex -ocss.c > 0: Warning: 1285-300 The o flag is not valid. > 0: Warning: 1285-300 The s flag is not

Re: [Bug-wget] Problems building wget2

2017-09-27 Thread Tim Rühsen
Hi Josef, please see README.md on how to build wget2. If you installed from git repo (https://gitlab.com/gnuwget/wget2.git) then ./bootstrap ./configure make make check With Best Regards, Tim On 09/27/2017 02:41 PM, Josef Moellers wrote: > I was trying to see if a bug I fixed in wget

Re: [Bug-wget] http server responding with 416 but file was not transferred completely

2017-09-18 Thread Tim Rühsen
Tim Rühsen wrote: >> On 09/14/2017 12:11 PM, Josef Moellers wrote: >>> On 14.09.2017 10:12, Tim Rühsen wrote: >>>> On 09/14/2017 09:53 AM, Josef Moellers wrote: >>>>> Hi, >>>>> >>>>> We have seen (at least) one server who has &

Re: [Bug-wget] http server responding with 416 but file was not transferred completely

2017-09-14 Thread Tim Rühsen
On 09/14/2017 12:11 PM, Josef Moellers wrote: > On 14.09.2017 10:12, Tim Rühsen wrote: >> On 09/14/2017 09:53 AM, Josef Moellers wrote: >>> Hi, >>> >>> We have seen (at least) one server who has >>> Accept-Ranges: bytes >>> in his header but, u

Re: [Bug-wget] Signature verification support in wget?

2017-08-30 Thread Tim Rühsen
On 08/30/2017 05:14 PM, Darshit Shah wrote: > * Unknown PGP keys are always an interesting problem due to the > various differences in how people would like to deal with it. By > default, I would suggest that Wget reports a warning about a missing > key and continues. There would

Re: [Bug-wget] Signature verification support in wget?

2017-08-30 Thread Tim Rühsen
Hi Ludo, thanks for heads up :-) Darshit just opened an issue at https://gitlab.com/gnuwget/wget2/issues/266. If you don't mind, I would add your suggestions there. With Best Regards, Tim On 08/30/2017 02:52 PM, Ludovic Courtès wrote: > Hello! > > Following the GNU Hackers Meeting there

Re: [Bug-wget] Compiling against libwget built with ubsan

2017-08-29 Thread Tim Rühsen
On 08/29/2017 05:03 PM, Avinash Sonawane wrote: > Hello! > > $ cat foo.c > #include > #include > > int main(int argc, char **argv) > { > char foo[] = "FOO"; > printf("%s\n", wget_strtolower(foo)); > > return 0; > } > > $ gcc -lwget foo.c -o foo > //usr/local/lib/libwget.so:

Re: [Bug-wget] [bug #51666] Please hash the hostname in ~/.wget-hsts files

2017-08-18 Thread Tim Rühsen
On Freitag, 18. August 2017 14:51:12 CEST Ander Juaristi wrote: > Follow-up Comment #2, bug #51666 (project wget): > > I'm not generally against these kind of small tweaks that don't harm and > slightly improve user's privacy. > > If Firefox doesn't do it, we don't care: it's their business and

Re: [Bug-wget] Errors-only mode

2017-08-11 Thread Tim Rühsen
On Donnerstag, 10. August 2017 22:26:44 CEST Dale R. Worley wrote: > Tim Rühsen <tim.rueh...@gmx.de> writes: > > wget -o/dev/null URL > > > > You can check for errors via the $? (on Linux, there should be something > > comparable on other systems). > > Yes,

Re: [Bug-wget] Errors-only mode

2017-08-10 Thread Tim Rühsen
On Mittwoch, 9. August 2017 22:08:12 CEST Dale R. Worley wrote: > Is there a way of invoking wget that produces no output if the operation > is successful (let's assuming that I'm fetching exactly one URL) and > produces appropriate error messages if it is not? > > I would have thought this was

Re: [Bug-wget] Gzip Content-Encoding Patches

2017-08-04 Thread Tim Rühsen
Hi Tim, sorry for the delay. I just pushed your patches. Thanks gain for your work ! With Best Regards, Tim signature.asc Description: OpenPGP digital signature

Re: [Bug-wget] wget Tutorial

2017-08-02 Thread Tim Rühsen
Hi Frederick, please always write to the mailing list, private mail only if it is about private things ;-) I read a bit the ISO/IEC 23009-1:2014 spec (Information technology -- Dynamic adaptive streaming over HTTP (DASH) -- Part 1: Media presentation description and segment formats). In short:

Re: [Bug-wget] Gzip Content-Encoding Patches

2017-08-01 Thread Tim Rühsen
On Montag, 31. Juli 2017 23:17:42 CEST Tim Schlueter wrote: > Hi, > > Please see the attached patches which add automatic gzip decompression > for HTTP files with the Content-Encoding response header set correctly. > > It also adjusts a downloaded file's extension for br, compress, and > deflate

Re: [Bug-wget] Code installation issues

2017-07-11 Thread Tim Rühsen
Hi Michael, On 07/11/2017 03:37 PM, Michael wrote: > Hello there, > > I have installed the wget2 code on a Raspberry pi machine. > > The make check report error on the unit tests: " > test_buffer_printf: Failed with format ('%hhd','-1'): '255' != '-1' > test_buffer_printf: Failed with format

Re: [Bug-wget] Test certificate host name verification fails with GnuTLS 3.5.12+

2017-07-09 Thread Tim Rühsen
On Samstag, 8. Juli 2017 15:32:44 CEST Ludovic Courtès wrote: > Hello, > > I experienced the test failure reported at > for > ‘testenv/Test--https.py’ and related tests with: > > The certificate's owner does not match hostname

Re: [Bug-wget] Adoption to content management systems

2017-07-07 Thread Tim Rühsen
Hello Michael, On Freitag, 7. Juli 2017 12:17:18 CEST Michael wrote: > Hello, > > I intend to do some changes to the wget program so it will fit the WordPress > and other content management systems. I will send you the revised code when > I am done. > > These are very important changes as it

Re: [Bug-wget] [GSoC Update] Week 2

2017-06-17 Thread Tim Rühsen
On Samstag, 17. Juni 2017 13:53:06 CEST Didik Setiawan wrote: > On Tue, Jun 13, 2017 at 06:37:27PM +0200, Darshit Shah wrote: > > > - http_server_port still hardcoded. > > > > This is important. The port should be a random number. Usually, passing 0 > > in the port number makes the kernel

Re: [Bug-wget] Shouldn't wget strip leading spaces from a URL?

2017-06-14 Thread Tim Rühsen
On Mittwoch, 14. Juni 2017 11:49:59 CEST L A Walsh wrote: > Dale R. Worley wrote: > > But of course, no [RFC3986-conforming] URL > > contains an embedded space because that's what it > > says in RFC 3986, which is "what *defines* what a > > URL *is*"[sic; should read "is one definition of > >

Re: [Bug-wget] overwrite

2017-06-13 Thread Tim Rühsen
Hi Ansgar, On 06/13/2017 09:40 AM, taschenberggr...@streber24.de wrote: >Hi, > >a common question online is how to properly force wget to make an >overwrite of an existing file name. > >The existing options are quite confusing and I am under the impression >that even taking

Re: [Bug-wget] wget and srcset tag

2017-06-13 Thread Tim Rühsen
gt; > The version is 'GNU Wget 1.19.1 built on linux-gnu.' > > cheers > Chris > > > On 12 June 2017 at 15:35, Tim Rühsen <tim.rueh...@gmx.de> wrote: > >> On 06/12/2017 10:27 AM, chris wrote: >>> Hi Tim, >>> >>> Thanks for your

Re: [Bug-wget] wget and srcset tag

2017-06-12 Thread Tim Rühsen
-) With Best Regards, Tim > > cheers > Chris > > On 12 June 2017 at 15:35, Tim Rühsen <tim.rueh...@gmx.de> wrote: > > On 06/12/2017 10:27 AM, chris wrote: > > > Hi Tim, > > > > > > Thanks for your reply, I notice the foll

Re: [Bug-wget] What are the tests testing?

2017-06-12 Thread Tim Rühsen
Hi Josef, On 06/12/2017 09:23 AM, Josef Moellers wrote: > Hello Tim, > > Thanks for the reply. > > On 10.06.2017 13:36, Tim Rühsen wrote: >> On Freitag, 9. Juni 2017 17:02:15 CEST Josef Moellers wrote: >>> Hi, >> >> Hi Josef, >> >>> I'm

Re: [Bug-wget] HTTPS Python tests fail if localhost resolves to ::1

2017-06-05 Thread Tim Rühsen
Hi Tomas, On Freitag, 2. Juni 2017 11:38:42 CEST Tomas Hozza wrote: > Hi. > > In Fedora 26+ the /etc/hosts lists "localhost" as a domain for both > 127.0.0.1 and ::1. This makes wget's testsuite to fail during build. > > Failing tests: > Test--https.py > Test-pinnedpubkey-der-https.py >

Re: [Bug-wget] Wget reports : This version does not have support for IRIs

2017-05-31 Thread Tim Rühsen
On 05/31/2017 12:42 PM, Darshit Shah wrote: > On 31 May 2017 at 10:15, Tim Rühsen <tim.rueh...@gmx.de> wrote: > >> On 05/31/2017 09:48 AM, Cos Chan wrote: >>> On Tue, May 30, 2017 at 4:03 PM, Darshit Shah <dar...@gmail.com> wrote: >>> >>>>

Re: [Bug-wget] Output no longer going to stderr

2017-05-22 Thread Tim Rühsen
On 05/22/2017 05:19 AM, Barry Kauler wrote: > On 5/21/17, Tim Rühsen <tim.rueh...@gmx.de> wrote: >> On Sonntag, 21. Mai 2017 10:06:28 CEST Barry Kauler wrote: >>> Hi guys, >>> I recently upgraded wget to 1.19.1, but have discovered that it

Re: [Bug-wget] [PATCH 3/3] Add command line option to disable use of .netrc

2017-05-16 Thread Tim Rühsen
On 05/16/2017 01:42 PM, Giuseppe Scrivano wrote: > Tomas Hozza writes: > >> The option to turn off reading .netrc by configuration in .wgetrc is >> still there. This command line option was supposed to be just >> something extra. Anyway Tim already merged the change. Do you

Re: [Bug-wget] [PATCH 1/3] Added tests for HTTP authentication using credentials from .netrc

2017-05-16 Thread Tim Rühsen
ot; > LC_ADDRESS="en_US.UTF-8" > LC_TELEPHONE="en_US.UTF-8" > LC_MEASUREMENT=sk_SK.UTF-8 > LC_IDENTIFICATION="en_US.UTF-8" > LC_ALL= > > Thanks. > > Regards, > Tomas > > On 15.05.2017 15:52, Tim Rühsen wrote: >> Hi Tomas, >> &

Re: [Bug-wget] [PATCH 1/3] Added tests for HTTP authentication using credentials from .netrc

2017-05-15 Thread Tim Rühsen
> LC_NUMERIC=sk_SK.UTF-8 > LC_TIME=sk_SK.UTF-8 > LC_COLLATE="en_US.UTF-8" > LC_MONETARY=sk_SK.UTF-8 > LC_MESSAGES="en_US.UTF-8" > LC_PAPER=sk_SK.UTF-8 > LC_NAME="en_US.UTF-8" > LC_ADDRESS="en_US.UTF-8" > LC_TELEPHONE="en_US.UTF-8&qu

Re: [Bug-wget] [PATCH 1/3] Added tests for HTTP authentication using credentials from .netrc

2017-05-15 Thread Tim Rühsen
P.S.: Just saw that the byte seems a bit random, on a second run I got: 'utf-8' codec can't decode byte 0xc3 in position 18: invalid continuation byte With Best Regards, Tim On 05/15/2017 05:04 PM, Tim Rühsen wrote: > Hi Tomas, > > my locale looks similar: > > $ locale >

Re: [Bug-wget] [PATCH 1/3] Added tests for HTTP authentication using credentials from .netrc

2017-05-15 Thread Tim Rühsen
Hi Tomas, thank you very much for the fixes and the new tests ! Currently, patch 1/3 breaks two Metalink tests: FAIL: Test-metalink-http.py FAIL: Test-metalink-http-quoted.py I am still investigating, but it has something to do with the environment that you reset in testenv/test/base_test.py:

Re: [Bug-wget] Wget keeps crashing on me

2017-05-14 Thread Tim Rühsen
On Sonntag, 14. Mai 2017 21:34:22 CEST Eli Zaretskii wrote: > > From: Tim Rühsen <tim.rueh...@gmx.de> > > Cc: William Higgs <whiggs.it...@gmail.com>, 'Darshit Shah' > > <dar...@gmail.com>, Eli Zaretskii <e...@gnu.org> Date: Sun, 14 May 2017 > >

Re: [Bug-wget] [PATCH] Script to create certs & keys

2017-05-14 Thread Tim Rühsen
On Samstag, 13. Mai 2017 22:29:42 CEST Vijo Cherian wrote: > Script to re-generate all certs & keys for testing That is simply great ! I just used it to re-generated those certs with invalid date fields and that made it possible to remove the OpenSSL requirement from Test-https-badcerts.px. We

Re: [Bug-wget] PATCH: tests for SSL

2017-05-09 Thread Tim Rühsen
m last patch : >- Skip if the name cannot be resolved >- skip if not using openssl as a temp work around till I figure out > gnutls-openssl cert issues. > > Best, > Vijo. > > On Thu, May 4, 2017 at 8:01 AM, Tim Rühsen <tim.rueh...@gmx.de> wrote: > >>

Re: [Bug-wget] PATCH: tests for SSL

2017-05-03 Thread Tim Rühsen
7 at 8:06 AM, Vijo Cherian <coderv...@gmail.com> wrote: > > Sorry about that Tim. > > I reworked the patches again. > > This time, I ran 'make check -j4" in a loop overnight. > > > > Best, > > Vijo. > > > > On Sun, Apr 30, 2017 at 5:49 AM,

Re: [Bug-wget] Last modified dates from archive.org's Wayback Machine

2017-05-03 Thread Tim Rühsen
Hi Greg, was a pleasure to implement this. The change has been pushed to our git repository and will be part of the next release. Also opened an issue for Wget2 as a task for our GSOC students :-) With Best Regards, Tim On 05/03/2017 03:25 AM, Gregory R Fellow wrote: > Hi. I greatly

Re: [Bug-wget] PATCH: tests for SSL

2017-05-02 Thread Tim Rühsen
May 2, 2017 at 8:06 AM, Vijo Cherian <coderv...@gmail.com> wrote: > > Sorry about that Tim. > > I reworked the patches again. > > This time, I ran 'make check -j4" in a loop overnight. > > > > Best, > > Vijo. > > > > On Sun

Re: [Bug-wget] PATCH: tests for SSL

2017-04-30 Thread Tim Rühsen
gards, Tim On Samstag, 29. April 2017 13:21:04 CEST Vijo Cherian wrote: > Thank you for your review and comments, Tim. > > Attached is the revised set of patches for the same tests. > > > Best, > Vijo. > > On Fri, Apr 28, 2017 at 3:42 AM, Tim Rühsen <tim.rueh...@gmx.de&

Re: [Bug-wget] PATCH: tests for SSL

2017-04-28 Thread Tim Rühsen
will apply these to wget2 and start working on wget2 from now. > > Best, > Vijo. > > > On Wed, Apr 19, 2017 at 4:12 AM, Tim Rühsen <tim.rueh...@gmx.de> wrote: > >> Hi Vijo, >> >> On 04/18/2017 06:56 PM, Vijo Cherian wrote: >>> Added

Re: [Bug-wget] PATCH: tests for SSL

2017-04-19 Thread Tim Rühsen
Hi Vijo, On 04/18/2017 06:56 PM, Vijo Cherian wrote: > Added a framework for perl based SSL tests, and some tests to start with. > In case this is of interest, I will add more tests for SSL: client > certificates, CRLs, negative tests etc. > Also not included : making these tests a part of "make

Re: [Bug-wget] Too verbose version information

2017-04-18 Thread Tim Rühsen
On 04/18/2017 04:40 AM, Mojca Miklavec wrote: > Hello, > > I find it a bit annoying that I end up with all of the following > information after building wget: > >> ./src/wget --version > GNU Wget 1.19.1.25-92bf-dirty built on darwin10.8.0. > > -cares +digest -gpgme -https +ipv6 -iri

Re: [Bug-wget] Problems with (not) building wget against libiconv

2017-04-18 Thread Tim Rühsen
On 04/18/2017 12:57 PM, Tim Rühsen wrote: > On 04/18/2017 04:27 AM, Mojca Miklavec wrote: >> I copiled a folder with bootstrapped wget to the Solaris box, but as >> expected I ended up with: >> >>> ldd src/wget >> libsocket.so.1 =>/li

Re: [Bug-wget] Problems with (not) building wget against libiconv

2017-04-18 Thread Tim Rühsen
Hi Mojca, On 04/18/2017 04:27 AM, Mojca Miklavec wrote: > On 16 April 2017 at 18:54, Tim Rühsen wrote: >> >> Please make sure, you test with latest wget git. > > I have some problems with bootstrapping. > > On Solaris it's: > >> ./bootstrap > ./b

Re: [Bug-wget] Problems with (not) building wget against libiconv

2017-04-16 Thread Tim Rühsen
On Sonntag, 16. April 2017 10:00:05 CEST Mojca Miklavec wrote: > On 16 April 2017 at 09:27, Tim Rühsen wrote: > > The question was more on which OpenCWS machine did you test (you said you > > are using the same build platform !? on 'unstable10x' was my test, > > libraries ha

Re: [Bug-wget] Problems with (not) building wget against libiconv

2017-04-16 Thread Tim Rühsen
On Sonntag, 16. April 2017 10:00:05 CEST Mojca Miklavec wrote: > On 16 April 2017 at 09:27, Tim Rühsen wrote: > > The question was more on which OpenCWS machine did you test (you said you > > are using the same build platform !? on 'unstable10x' was my test, > > libraries ha

Re: [Bug-wget] Problems with (not) building wget against libiconv

2017-04-16 Thread Tim Rühsen
On Sonntag, 16. April 2017 00:24:22 CEST Mojca Miklavec wrote: > On 16 April 2017 at 00:07, Tim Rühsen wrote: > > On Samstag, 15. April 2017 22:36:33 CEST Mojca Miklavec wrote: > >> Hi, > >> > >> I'm experiencing a recent regression in wget builds. I

Re: [Bug-wget] Problems with (not) building wget against libiconv

2017-04-15 Thread Tim Rühsen
On Samstag, 15. April 2017 22:36:33 CEST Mojca Miklavec wrote: > Hi, > > I'm experiencing a recent regression in wget builds. It worked fine in > version 1.17.1 and it fails now with 1.19.1. > > I can do some bisection, but I guess I could blame at least the > following commit: > >

Re: [Bug-wget] Misuse of idn2_free()

2017-04-09 Thread Tim Rühsen
On Samstag, 8. April 2017 18:55:12 CEST Gisle Vanem wrote: > > Ups, I was sure that we already reallocate the idn2 memory in iri.c/ > > idn_encode(), but we don't do that yet. > > You're confusing Wget with Wget2 :-) Yes, I guess so too :-) > > Could you please try this patch (on top of the

Re: [Bug-wget] Misuse of idn2_free()

2017-04-08 Thread Tim Rühsen
} I can also see that idn_decode() can be resurrected with the new libidn2 2.0.0 functionality. I'll do that within the next days. Regards, Tim On Samstag, 8. April 2017 11:52:59 CEST Gisle Vanem wrote: > Tim Rühsen wrote: > > Thanks, Gisle. > > > > pushed with several additi

Re: [Bug-wget] Misuse of idn2_free()

2017-04-08 Thread Tim Rühsen
Thanks, Gisle. pushed with several additional fixes/cleanups regarding idn2. Regards, Tim On Samstag, 8. April 2017 10:09:22 CEST Gisle Vanem wrote: > The 'idn_decode()' function now simply uses 'xstrdup()'. > And in host.c + connect.c there are calls to 'idn2_free()' > on this pointer: > if

Re: [Bug-wget] [GSoC] Proposal: “Design and implementation of a framework for plugins.”

2017-04-03 Thread Tim Rühsen
On 04/02/2017 09:40 PM, Akash Rawal wrote: > > > On 04/02/2017 10:41 PM, Darshit Shah wrote: >> * Akash Rawal [170331 23:34]: >>> Hello, >>> >>> First of all, thanks for the initial review of my proposal! >>> >>> I have made some changes in response to the comments as well

Re: [Bug-wget] [GSoC] Git & Github workflow

2017-04-02 Thread Tim Rühsen
On Sonntag, 2. April 2017 19:01:04 CEST Avinash Sonawane wrote: > On Thu, Mar 23, 2017 at 9:08 PM, Avinash Sonawane wrote: > > If we get helpful responses, I will add this "contributing guide for > > GSoC students" to our wiki. > > As promised earlier, I just added a

[Bug-wget] (unencrypted) Article explaining Wget in German computer magazin c't

2017-03-31 Thread Tim Rühsen
Ups, sorry for message encryption On Freitag, 31. März 2017 14:49:45 CEST Tim Rühsen wrote: > On 03/31/2017 02:47 PM, Giuseppe Scrivano wrote: > > Hi Tim, > > > > Tim Rühsen <tim.rueh...@gmx.de> writes: > >> FYI, > >> > >> c't 8/2017 h

Re: [Bug-wget] Article explaining Wget in German computer magazin c't

2017-03-31 Thread Tim Rühsen
binIXjEbOxIW2.bin Description: PGP/MIME version identification encrypted.asc Description: OpenPGP encrypted message

[Bug-wget] Article explaining Wget in German computer magazin c't

2017-03-31 Thread Tim Rühsen
FYI, c't 8/2017 has a 4 paged article explaining Wget and several kinds of usages (German language only). Regards, Tim signature.asc Description: OpenPGP digital signature

Re: [Bug-wget] PATCH: Fix FTBFS on GNU/Hurd

2017-03-29 Thread Tim Rühsen
On 03/29/2017 01:33 PM, Svante Signell wrote: > On Sat, 2017-03-11 at 12:48 +0100, Tim Rühsen wrote: >> Hi Svante, >> >> On Freitag, 10. März 2017 14:20:56 CET Svante Signell wrote: >>> Hello, > ... >>> Thank you for your attention. >> >> You

Re: [Bug-wget] [GSoC] Add wget_robots_parse unit test

2017-03-28 Thread Tim Rühsen
On 03/28/2017 09:44 AM, Didik Setiawan wrote: > I have made a pull request about robots API unit test on github [1] as my GSoC > 2017 microproject attempt. > Any feedback will be appreciated. Thanks, Didek. I'll review soon on Github. BTW, anyone interested in work related to Wget2 should

Re: [Bug-wget] `make check` fails 4 tests on fresh wget2 clone

2017-03-27 Thread Tim Rühsen
On Donnerstag, 23. März 2017 11:21:37 CEST Darshit Shah wrote: > There are two points here, we should keep the mandatory dependencies at > a bare minimum. That is one of the features that made Wget 1.x more > popular with the embedded crowd. If someone does not care about > non-ascii domain names,

Re: [Bug-wget] [PATCH v4] (resend) Add --use-askpass=COMMAND support

2017-03-15 Thread Tim Rühsen
On Mittwoch, 7. September 2016 12:15:26 CEST Liam R. Howlett wrote: > * Tim Ruehsen [160907 04:49]: > > Hi Liam, > > > > I made a mistake and accidentally pushed your v4 patch to master a few > > days > > ago. > > > > Here is a fix for several issues (warnings, C89

Re: [Bug-wget] PATCH: Fix FTBFS on GNU/Hurd

2017-03-11 Thread Tim Rühsen
Hi Svante, On Freitag, 10. März 2017 14:20:56 CET Svante Signell wrote: > Hello, > > wget currently does not build from source on GNU/Hurd since Debian version > 1.18- 4. This is due to that HAVE_PTHREAD_RWLOCK_RDLOCK_PREFER_WRITER is > not defined by configure and then assumes that the function

Re: [Bug-wget] inet_ntop() in mswindows.c

2017-03-06 Thread Tim Rühsen
On Montag, 6. März 2017 16:45:57 CET Gisle Vanem wrote: > Just a detail, but in src/mswindows.c, there is: > > #ifdef ENABLE_IPV6 > /* An inet_ntop implementation that uses WSAAddressToString. > Prototype complies with POSIX 1003.1-2004. This is only used under > IPv6 because Wget

Re: [Bug-wget] Vulnerability Report - CRLF Injection in Wget Host Part

2017-03-06 Thread Tim Rühsen
On Dienstag, 7. März 2017 02:01:06 CET Orange Tsai wrote: > I am surprise that `http://u...@evil.com:8...@good.com` will connect to ` > evil.com`, not `good.com`. > Most of URL parser will recognize `good.com` is host part. Like this > advisory, https://curl.haxx.se/docs/adv_20161102J.html > It

Re: [Bug-wget] recursive_retrieve()

2017-03-04 Thread Tim Rühsen
On Freitag, 3. März 2017 13:18:38 CET João Bernardo Sousa wrote: > Hello. > > I'm getting this error when debugging "Removing file due to recursive > rejection criteria in recursive_retrieve()". > > I'll be glad if you could help me: > >

Re: [Bug-wget] Patch: Always surround the "WARC-Target-URI" value with angle brackets

2017-03-04 Thread Tim Rühsen
Thanks, Bejamin, your patch is applied (trivial, no FSF copyright assignment required). Regards, Tim On Freitag, 3. März 2017 09:00:57 CET Benjamin Esham wrote: > Hello, > > When producing WARC files, Wget records the requested URI in the > "WARC-Target-URI" field. I noticed that Wget encloses

Re: [Bug-wget] Test-504.py sometimes fails on slow machines

2017-02-14 Thread Tim Rühsen
On Dienstag, 14. Februar 2017 16:20:26 CET Adam Sampson wrote: > On Tue, Feb 14, 2017 at 04:03:13PM +, Adam Sampson wrote: > > Your patch compiles, but doesn't fix the broken test. tcpdump traces > > attached of the test succeeding and failing with the patch applied (it's > > exactly the same

[Bug-wget] Wget 1.19.1 released

2017-02-11 Thread Tim Rühsen
Tim Rühsen Tom Szilagyi Yousong Zhou Zhiming Wang The new version is available for download here: https://ftp.gnu.org/gnu/wget/wget-1.19.1.tar.gz https://ftp.gnu.org/gnu/wget/wget-1.19.1.tar.xz and the GPG detached signatures using the key 0x08302DB6A2670428: https://ftp.gnu.org/gnu/wget/wget

Re: [Bug-wget] [PATCH] Add support for --retry-on-http-error

2017-02-11 Thread Tim Rühsen
hope that is OK. Applied your patch. Thanks for your contribution ! Regards, Tim > > Thanks, > Tom > > On Thu, Feb 09, 2017 at 09:38:26PM +0100, Tim Rühsen wrote: > > Hi Tom, > > > > thanks for your work and for signing the FSF copyright assignment ! > >

Re: [Bug-wget] Wget 1.19 was't build on MerSDK.

2017-02-10 Thread Tim Rühsen
On Freitag, 10. Februar 2017 08:57:18 CET Tim Rühsen wrote: > On Freitag, 10. Februar 2017 03:41:36 CET lour...@openmailbox.org wrote: > > Hello! I tryed to build a fresh wget release, but got the following > > error: > > > > http://paste.fedoraproject.org/552005/48

Re: [Bug-wget] Wget 1.19 was't build on MerSDK.

2017-02-09 Thread Tim Rühsen
On Freitag, 10. Februar 2017 03:41:36 CET lour...@openmailbox.org wrote: > Hello! I tryed to build a fresh wget release, but got the following > error: > > http://paste.fedoraproject.org/552005/48668697/ > > But when i making package on armv7hl architechture, i don't have > anything errors: > >

Re: [Bug-wget] [PATCH] Add support for --retry-on-http-error

2017-02-09 Thread Tim Rühsen
Hi Tom, thanks for your work and for signing the FSF copyright assignment ! Just some smallish things: - Please amend the commit message to be in GNU style (see 'git log' for examples). The easiest for us maintainers is when you create the patch with 'git format-patch -1' and add it as

Re: [Bug-wget] Wget 1.19 released !

2017-02-07 Thread Tim Rühsen
Hi Dago, On Freitag, 3. Februar 2017 14:27:50 CET Dagobert Michelsen wrote: > Hi Tim, > > Am 03.02.2017 um 13:38 schrieb Tim Ruehsen : > > we are pleased to announce the new version of GNU wget 1.19. > > I just noticed a tiny issue: when there is a system-wide wgetrc which >

Re: [Bug-wget] Tilde issue with recursive download when IRI is enabled and a page uses Shift JIS

2017-02-07 Thread Tim Rühsen
trick, like $ cat shiftjis_text.html|iconv -f SHIFT-JIS -t utf-8 >utf8_text.html Now you should be able to copy URLs from that document. Ah yes, that only works on Unix/Linux/BSD systems. Regards, Tim > On Mon, Feb 6, 2017 at 6:29 PM, Andries E. Brouwer > > <andries.brou..

Re: [Bug-wget] Tilde issue with recursive download when IRI is enabled and a page uses Shift JIS

2017-02-06 Thread Tim Rühsen
On Montag, 6. Februar 2017 05:02:57 CET William Prescott wrote: > Hello, > > I'm encountering a problem when recursively downloading from a website when > the URL contains a tilde and the page encoding claims to be Shift JIS. > > I've tried both Wget 1.17.1 (from Ubuntu 16.04) and 1.19 (from

<    1   2   3   4   5   6   7   8   9   >