On 27. 11. 2019 10:50, Tim Rühsen wrote:
> On 11/26/19 4:00 PM, Tomas Hozza wrote:
>>
>>
>> On 20. 11. 2019 18:47, Tim Rühsen wrote:
>>> On 20.11.19 12:41, Tomas Hozza wrote:
>>>> On 7. 11. 2019 21:30, Tim Rühsen wrote:
>>>>> On 07.11.19 1
Hi Tim.
On 24. 3. 2020 15:01, Tim Rühsen wrote:
> Hi Tomas,
>
> On 24.03.20 14:24, Tomas Hozza wrote:
>> Hi.
>>
>> I would like to get feedback on a subtle change of behavior in wget
>> between version 1.14 and the current upstream version, which has
>> bee
[1]
http://git.savannah.gnu.org/cgit/wget.git/commit/?id=e4a8fe84e2b813b65d91aec29298eecabe4850a5
Regards,
Tomas
--
Tomas Hozza
Manager, Software Engineering - EMEA ENG Core Services
PGP: 1D9F3C2D
UTC+1 (CET)
Red Hat Inc. http://cz.redhat.com
>From 76ff257f3a0555867543d11c57414c6bc64e7307
On 20. 11. 2019 18:47, Tim Rühsen wrote:
> On 20.11.19 12:41, Tomas Hozza wrote:
>> On 7. 11. 2019 21:30, Tim Rühsen wrote:
>>> On 07.11.19 15:21, Tomas Hozza wrote:
>>>> Hi.
>>>>
>>>> In RHEL-8, we ship a wget version that suffers fr
On 8. 11. 2019 14:05, Tomas Hozza wrote:
> On 7. 11. 2019 20:53, Tim Rühsen wrote:
>> On 07.11.19 15:22, Tomas Hozza wrote:
>>> Hello.
>>>
>>> I would like to reuse upstream tests in testenv/ for testing official
>>> Fedora build of wget, inst
On 7. 11. 2019 21:30, Tim Rühsen wrote:
> On 07.11.19 15:21, Tomas Hozza wrote:
>> Hi.
>>
>> In RHEL-8, we ship a wget version that suffers from bug fixed by [1]. The
>> fix resolved issue with matching subdomains when no_proxy domain definition
>> was prefixed w
On 7. 11. 2019 20:53, Tim Rühsen wrote:
> On 07.11.19 15:22, Tomas Hozza wrote:
>> Hello.
>>
>> I would like to reuse upstream tests in testenv/ for testing official Fedora
>> build of wget, installed on the system. Currently tests hardcode path to
>> wget bina
ead of the code.
[1]
http://git.savannah.gnu.org/cgit/wget.git/commit/?id=fd85ac9cc623847e9d94d9f9241ab34e2c146cbf
Thank you.
Regards,
Tomas
--
Tomas Hozza
Associate Manager, Software Engineering - EMEA ENG Core Services
PGP: 1D9F3C2D
UTC+2 (CEST)
Red Hat Inc. http://cz.redhat.com
>From
running tests. This is
completely optional, and if not specified, tests work as they did before.
However if specified e.g. to "/usr/bin/wget", the distribution-specific build
of wget is tested instead.
Regards,
Tomas
--
Tomas Hozza
Associate Manager, Software Engineering - EMEA ENG Core Ser
also fixed man page to contain "TLSv1_3" in all listings of available
parameters for --secure-protocol
[1] https://lists.gnupg.org/pipermail/gnutls-devel/2018-July/008584.html
[2] https://nikmav.blogspot.com/2018/05/gnutls-and-tls-13.html
Signed-off-by: Tomas Hozza
---
doc/w
rate email.
My knowledge is that Red Hat has agreement with FSF covering all its employees.
Since I'm a Red Hat employee and I'm sending these changes as part of my job, I
consider this to be implied. I have contributed to wget in the past with the
same rationale.
Regards,
Tomas
>
>
from sources.
Regards,
Tomas
--
Tomas Hozza
Associate Manager, Software Engineering - EMEA ENG Core Services
PGP: 1D9F3C2D
UTC+1 (CET)
Red Hat Inc. http://cz.redhat.com
From f50c812648e496769d9cd55186091b51a80fca0e Mon Sep 17 00:00:00 2001
From: Tomas Hozza
Date: Mon, 30 Jul 2018
setting and leaves the
determination of the minimal supported TLS version on the server and
client.
More information about Fedora change can be found here:
https://fedoraproject.org/wiki/Changes/StrongCryptoSettings
Signed-off-by: Tomas Hozza
---
testenv/server/http/http_server.py | 1 -
1 file
When doing the change, please make sure that you change also the gnutls
implementation. Some distributions (e.g. Fedora) compile wget with gnutls
instead of openssl. I expect that the behavior should be consistent regardless
of the crypto library that is being used.
Regards,
Tomas
>>
>> Regards, Tim
>>
>
--
Tomas Hozza
Associate Manager, Software Engineering - EMEA ENG Core Services
PGP: 1D9F3C2D
UTC+1 (CET)
Red Hat Inc. http://cz.redhat.com
kle >>>> @gma
>>>>> il.com> wrote:
>>>>>> Hi!
>>>>>>
>>>>>> I am trying to compile wget on CentOS 7.4:
>>>>>>
>>>>>> CC version.o
>>>>>> CC ftp-opie.o
://www.lysator.liu.se/~nisse/archive/nettle-3.4.ta\
>> r.gz
>> Resolving www.lysator.liu.se (www.lysator.liu.se)... 130.236.254.11,
>> 2001:6b0:1\
>> 7:f0a0::b
>> Connecting to www.lysator.liu.se (www.lysator.liu.se)|130.236.254.11|:80...
>> con\
>> nected.
(conf_arg)(self)
File "/sources/testenv/conf/expected_files.py", line 54, in __call__
raise TestFailed('Expected file %s not found.' % file.name)
exc.test_failed.TestFailed: Expected file File1 not found.
FAIL Test--https.py (exit status: 1)
I didn't have time to inve
On 16.05.2017 12:00, Giuseppe Scrivano wrote:
> Hi Tomas,
>
> Tomas Hozza writes:
>
> > If you don't want to add new option, maybe just documenting the possibility
> > to turn off reading of .netrc would be good enough.
> >
> > Please let me know wh
> With Best Regards, Tim
>
>
>
> On 05/15/2017 04:53 PM, Tomas Hozza wrote:
>> Hello Tim.
>>
>> I run all the tests before sending patches and they all passed. If you can
>> send me more info about the failures, I could have a look at it.
>>
On 12.05.2017 22:12, Giuseppe Scrivano wrote:
> Hi Tomas,
>
> Tomas Hozza writes:
>
>> Although internally code uses option for (not) reading .netrc for
>> credentials, it was not possible to turn this behavior off on command
>> line. Note that it was possib
something to do with the
> environment that you reset in testenv/test/base_test.py:
>
> ret_code = call(params, env={"HOME": os.getcwd()})
>
> Maybe a bug that just comes out with a different locale/charset encoding.
>
>
> With Best Regards, Tim
>
>
>
>
ned-off-by: Tomas Hozza
---
testenv/Makefile.am | 3 ++
testenv/Test-auth-basic-netrc-pass-given.py | 68 +
testenv/Test-auth-basic-netrc-user-given.py | 68 +
testenv/Test-auth-basic-netrc.py
I'm sending couple of changes, including tests, which are result of Fedora Bug
https://bugzilla.redhat.com/show_bug.cgi?id=1425097. For details, please see
commit messages of each patch.
Tomas Hozza (3):
Added tests for HTTP authentication using credentials from .netrc
Fixed getti
://bugzilla.redhat.com/show_bug.cgi?id=1425097
Signed-off-by: Tomas Hozza
---
doc/wget.texi| 6
src/main.c | 3 ++
testenv/Makefile.am | 1 +
testenv/Test-auth-basic-no-netrc-fail.py | 59
4 files
ser login
is set to some value.
Also since both variables are dereferenced on lines above the changed
code, it does not really make sense to check if they are NULL.
This patch is based on fix from Bruce Jerrick .
Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=1425097
Signed-off-by: Tomas Ho
The --secure-protocol option accepts also values TLSv1_1 and TLSv1_2,
as mentioned in the man page. However the help message doesn't mention
these two values. This patch adds TLSv1_1 and TLSv1_2 as possible
values to the help message.
Signed-off-by: Tomas Hozza
---
src/main.c | 2 +-
1
here
> (test_url_rewrite): Fix 'created' value
> (test_hsts_read_database): Fix 'created' value
>
> Reported-by: Dagobert Michelsen
>
>
> Tim
>
> On Friday 27 November 2015 14:31:25 Tomas Hozza wrote:
>> Thanks for your response.
>>
>>
ue raised almost as soon
> as we released wget 1.17. It only affected 32-bit systems.
>
> Hopefully, it's already fixed on Git.
>
> Thanks.
> - AJ
>
> On Fri, 2015-11-27 at 13:26 +0100, Tomas Hozza wrote:
> > Hi.
> >
> > While updating the wget in Fedo
ue raised almost as soon
> as we released wget 1.17. It only affected 32-bit systems.
>
> Hopefully, it's already fixed on Git.
>
> Thanks.
> - AJ
>
> On Fri, 2015-11-27 at 13:26 +0100, Tomas Hozza wrote:
> > Hi.
> >
> > While updating the wget in Fedo
ue raised almost as soon
> as we released wget 1.17. It only affected 32-bit systems.
>
> Hopefully, it's already fixed on Git.
>
> Thanks.
> - AJ
>
> On Fri, 2015-11-27 at 13:26 +0100, Tomas Hozza wrote:
> > Hi.
> >
> > While updating the wget in Fedo
d
in src/hsts.c:689 is the failing line:
created = hsts_store_entry (s, SCHEME_HTTPS, "www.foo.com", 443, time(NULL) +
1234, true);
I didn't investigate further.
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
UTC+1 (CET)
Red Hat Inc.
running all the tests through
> > valgrind.
> >
> > [1]: https://scan.coverity.com/projects/555?tab=overview
It's good to know that wget is participating in the Coverity OSS scanning
initiative.
I won't have to duplicate the effort. Having a spare time in t
ith Coverity and share the results publicly if
you'd like.
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
- Original Message -
> On 17/07/14 13:49, Tomas Hozza wrote:
> > I agree. The patch didn't take any configuration possibility from the user.
> > The users would be able to configure whatever in the same way they were
> > before.
> >
> > Please really
too. However, if you run make
> check again, chances are the test will pass. :)
>
>
> On Sat, Jul 19, 2014 at 3:12 AM, Ángel González wrote:
> > On 17/07/14 13:49, Tomas Hozza wrote:
> >>
> >> I agree. The patch didn't take any configuration possibilit
- Original Message -
> Tomas Hozza writes:
>
> > - Original Message -
> >> On Thursday 10 July 2014 08:37:23 Tomas Hozza wrote:
> >> > - Original Message -
> >> > > On Tuesday 08 July 2014 16:14:42 Petr Pisar wrote:
>
- Original Message -
> On Friday 11 July 2014 04:30:04 Tomas Hozza wrote:
> > - Original Message -
> >
> > > On Thursday 10 July 2014 08:37:23 Tomas Hozza wrote:
> > > > - Original Message -
> > > >
> > &
- Original Message -
> On Thursday 10 July 2014 08:37:23 Tomas Hozza wrote:
> > - Original Message -
> > > On Tuesday 08 July 2014 16:14:42 Petr Pisar wrote:
> > > > On Tue, Jul 08, 2014 at 10:00:24AM -0400, Tomas Hozza wrote:
> > > > &g
- Original Message -
> Tomas Hozza writes:
>
> >> What do you think about extending --secure-protocol and having a runtime
> >> option instead of a compile time option ? Users could set the system wide
> >> default value in /etc/wgetrc and peopl
- Original Message -
> On Tuesday 08 July 2014 16:14:42 Petr Pisar wrote:
> > On Tue, Jul 08, 2014 at 10:00:24AM -0400, Tomas Hozza wrote:
> > > I'm afraid this is not suitable for us. We need to be able to define the
> > > policy somewhere in /etc, where t
- Original Message -
> On Tuesday 08 July 2014 04:43:20 Tomas Hozza wrote:
> > - Original Message -
> >
> > > On 07/07/14 21:46, Tomas Hozza wrote:
> > > > Hi.
> > > >
> > > > In Fedora we are moving to a system-wide p
- Original Message -
> On 07/07/14 21:46, Tomas Hozza wrote:
> > Hi.
> >
> > In Fedora we are moving to a system-wide policy of used
> > ciphers. [1] Therefore we need wget to be compiled with other
> > than hard-coded set of ciphers when using OpenSSL.
&
www.gnu.org/savannah-checkouts/gnu/libiconv/documentation/libiconv-1.13/iconv_open.3.html
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com
From d0c8fbf0da5e126dea0f719bacb8a9705ac18d1f Mon Sep 17 0
phers list when compiled with OpenSSL.
It can be used only if --with-ssl=openssl. If not
defined, the previously used (by wget) ciphers list is used.
[1] https://fedoraproject.org/wiki/Changes/CryptoPolicy
Regards,
--
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience
PGP: 1D9F3C2
ould clean it up and submit a patch.
I think that would be great. From my point of view, the new verbosity
level option makes more sense as it would not change the existing wget
behaviour.
Thanks for your reply and for mentioning your patch-set.
Regards,
Tomas Hozza
ample idea, the ability to pass the descriptor number to the --progress
option was proposed, for example "--progress=bar,1" or any other.
Although I think that the request seems to be valid, I personally think the
current behaviour is correct. It seems more like a feature request.
Regards,
Tomas Hozza
- Original Message -
> Very well, if this would be possible. Right now I have no idea how to print
> something like the above. I made Tomas Hozza's test with valgrind and wget
> having debug info. I got 18x (out of 20x) SIGBUS, but on completely different
> places in the code. Within the mi
- Original Message -
> On Tuesday 03 September 2013 03:17:56 Tomas Hozza wrote:
> > In Fedora I have a bug [1] from guy that is using wget
> > to test web server network load. He runs multiple
> > instances of wget to download some site recursively.
> > Someth
rashes in such a situations.
Thanks!
Regards,
Tomas Hozza
[1] https://bugzilla.redhat.com/show_bug.cgi?id=999647
I downloaded the site only twice. bakcups
variable should be int. I hope this is the last piece of puzzle to get
--backups documented and working.
Giuseppe, are you going to merge the necessary changes (and previous patches)
into git?
Thanks!
Regards,
Tomas Hozza
timeout option when used with SSL
Previously wget didn't honor the --timeout option if the remote host did
not answer SSL handshake
Signed-off-by: Tomas Hozza
---
src/ChangeLog | 4
src/openssl.c | 62 ++-
2 files changed,
e via FTP (remote file
permissions were not preserved).
Regards,
Tomas HozzaFrom d5133f6e8f19fad36d711c8b592608cac2b92c53 Mon Sep 17 00:00:00 2001
From: Tomas Hozza
Date: Thu, 11 Jul 2013 17:52:28 +0200
Subject: [PATCH] Document missing options and fix --preserve-permissions
Added documentatio
as expected, however it does
not apply cleanly on wget-1.14. But this is not a problem IMHO (it can
be easily tweaked to apply).
Thank you for documenting and fixing the option!
Regards,
Tomas Hozza
Hello.
I already proposed this bug in Savannah (https://savannah.gnu.org/bugs/?38554)
and will copy the discussion we already had there to answer some questions.
- BEGINNING
Wed 20 Mar 2013 11:52:09 AM GMT, original submission: (Tomas Hozza)
This problem
: [PATCH] Fix timeout option when used with SSL
Previously wget didn't honor the --timeout option if the remote host did
not answer SSL handshake
Signed-off-by: Tomas Hozza
---
src/openssl.c | 62 ++-
1 file changed, 53 insertions(
- Original Message -
> Tomas Hozza writes:
>
> > Options undocumented at all:
> > --backups
> > --no-backups
>
> I have two patches here for --backups, one related to VMS and untested.
>
> Could someone please proof-read the documentation bits
connect.c:404
My proposed patch is attached.
Regards,
Tomas HozzaFrom 613d8639c48b950f76d132b70d27e518ba6d6891 Mon Sep 17 00:00:00 2001
From: Tomas Hozza
Date: Fri, 26 Apr 2013 14:42:30 +0200
Subject: [PATCH] Fix using deadcode and possible use of NULL pointer
Fix for deadcode in unique_create() so
contains the version you would like
to scan.
Coverity itself also provides scanning for free for open-source
project. If you would be interested in that you can find
some information on Coverity page http://scan.coverity.com/.
Regards,
Tomas Hozza
Hi Giuseppe.
- Original Message -
> Hi Tomas,
>
> Tomas Hozza writes:
>
> > Is there any chance to get the rest documented any time soon?
>
> I am going to make a new release in the next weeks that include the
> features in the parallel-wget branch.
> I w
- Original Message -
> Tomas Hozza writes:
>
> > Hello.
> >
> > We at Red Hat did an inspection of wget-1.14 source, man page and
> > wget usage (--help) and discovered following errors:
> >
> > Missing in man present in usage:
> > --acc
options are not documented probably because they
are still defective:
--htmlify -> https://savannah.gnu.org/bugs/?23095
--no-htmlify -> https://savannah.gnu.org/bugs/?23096
I also created public Bug on Savannah
https://savannah.gnu.org/bugs/index.php?38835.
Regards,
Tomas Hozza
61 matches
Mail list logo