Re: [Bug-wget] GSoC'18: DNS over HTTPS.

[Darshit Shah]

Hi,

I'll get to a discussion about the proposal shortly, but in the meantime, may I
please request everyone to avoid continuing this email thread on
summer-of-c...@gnu.org?

That is a generic mailing list for organizing the Summer of Code program within
GNU.

The discussion about any particular project is off-topic there. It is
however,very much on-topic on bug-wget@gnu.org and we should continue this
discussion only there.

* Tim Rühsen  [180322 14:20]:
> On 03/22/2018 02:01 PM, Aniketh Gireesh wrote:
> > Further, In my opinion, I think it would be better as a different
> > library/directory. I think that would be a better refactoring method as
> > well as it would be easier to work on the codebase at a later point in
> > time. Further, as far as my understanding goes, libwget is a library
> > handling HTTP, helping in creating an HTTP request. It seems better to have
> > something different to handle DNS and other things regarding that. It would
> > feel like all cluttered up inside libwget.
> > 
> > If this is not the way we want it in Wget2, just let me know. I will change
> > the proposal as well as the plans for implementation :)
> 
> Since your code will likely use functions from libwget and the other way
> round, we should place it in libwget/. But if it makes your development
> easier during GSOC, feel free to put it into a separate directory.
> 
> For the future we have a splitting of libwget in several libraries in
> mind, but it currently has low priority. We may have some day
> libwget-common, libwget-doh, libwget-warc, ...
> 
> Regards, Tim
> 



-- 
Thanking You,
Darshit Shah
PGP Fingerprint: 7845 120B 07CB D8D6 ECE5 FF2B 2A17 43ED A91A 35B6


signature.asc
Description: PGP signature

Re: [Bug-wget] GSoC'18: DNS over HTTPS.

[Tim Rühsen]

On 03/22/2018 02:01 PM, Aniketh Gireesh wrote:
> Further, In my opinion, I think it would be better as a different
> library/directory. I think that would be a better refactoring method as
> well as it would be easier to work on the codebase at a later point in
> time. Further, as far as my understanding goes, libwget is a library
> handling HTTP, helping in creating an HTTP request. It seems better to have
> something different to handle DNS and other things regarding that. It would
> feel like all cluttered up inside libwget.
> 
> If this is not the way we want it in Wget2, just let me know. I will change
> the proposal as well as the plans for implementation :)

Since your code will likely use functions from libwget and the other way
round, we should place it in libwget/. But if it makes your development
easier during GSOC, feel free to put it into a separate directory.

For the future we have a splitting of libwget in several libraries in
mind, but it currently has low priority. We may have some day
libwget-common, libwget-doh, libwget-warc, ...

Regards, Tim



signature.asc
Description: OpenPGP digital signature

Re: [Bug-wget] GSoC'18: DNS over HTTPS.

[Daniel Stenberg]

On Thu, 22 Mar 2018, Aniketh Gireesh wrote:

Thanks Daniel for your inputs, I guess you would be okay if I contact you 
when get stuck somewhere during the implementation part/coding period. ;)


Absolutely. I'll try to help out and respond if I can and time permits!

Please do let me know if I should take care of anything else too regarding 
this project so that I could dig into it at the earliest and make the coding 
period as productive as possible :)


I've put together a little tool to help debugging that I call dns2doh which 
uses dig under the hood and can produce both DOH queries and DOH responses on 
the command line:


  https://github.com/bagder/dns2doh

With this, I've also written some basic CGIs on my https server to act as a 
DOH server and it has helped me to try out things like a server that denies A 
records but serves  records etc.



Oh, and if you want to check out or just compare how Firefox does DOH and want 
to know what knobs and options we have under the hood to support it, check out 
this gist that so far is basically the only docs of it that exists:


  https://gist.github.com/bagder/5e29101079e9ac78920ba2fc718aceec

DOH support in Firefox is still only available in Nightly and it might of 
course change a bit before it reaches the release version...


--

 / daniel.haxx.se

Re: [Bug-wget] GSoC'18: DNS over HTTPS.

[Aniketh Gireesh]

Hi Tim and Daniel,

I am really glad that you are satisfied with the way I intend to solve
this/add this feature. Thanks for finding the time to go through the
proposal too :)

I have added the few changes and suggestions mentioned by you to the
proposal as well. I will be looking into the implementation part of the
same real soon.

Thanks Daniel for your inputs, I guess you would be okay if I contact you
when get stuck somewhere during the implementation part/coding period. ;)
Please do let me know if I should take care of anything else too regarding
this project so that I could dig into it at the earliest and make the
coding period as productive as possible :)

Tim, I am really glad that you liked the proposal and met our project
requirements. It would be really fun working on this project.

> This link is absolutely not relevant for Wget2:
> 2. http://wget.addictivecode.org/OptionsHowto.html
> We should write up something similar for Wget2 to give contributors an
> easy start.

I thought of initiating such documentation with the understanding of the
codebase I achieve. I have added this to my proposal as well in the
documentation section. I will try to initiate this section with your help
if time allows us :)

ergh, I wanted the library name as libdns. It was a typo. Thanks for
pointing it out.
Further, In my opinion, I think it would be better as a different
library/directory. I think that would be a better refactoring method as
well as it would be easier to work on the codebase at a later point in
time. Further, as far as my understanding goes, libwget is a library
handling HTTP, helping in creating an HTTP request. It seems better to have
something different to handle DNS and other things regarding that. It would
feel like all cluttered up inside libwget.

If this is not the way we want it in Wget2, just let me know. I will change
the proposal as well as the plans for implementation :)

Thanks again for the review. If there are any further suggestions, just
shoot in. I will take a look :)

Cheers.
-- 
Aniketh Girish
Member at FOSS@Amrita 
Amrita University 
Github  | Blog
 | Website 

"For the Love of Code."

Re: [Bug-wget] GSoC'18: DNS over HTTPS.

[Tim Rühsen]

On 03/21/2018 07:11 PM, Aniketh Gireesh wrote:
> Hello everyone,
> 
> I'm Aniketh Girish, a computer science undergraduate from India. Just
> giving a small introduction about myself, I am quite convenient with open
> source contribution and I have done GSoC last year with KDE under Krita, a
> graphics libre software.
> 
> I was interested in a project inside Wget2 called DNS-over-HTTPS and I have
> prepared a proposal for the same[1].
> 
> Review from the community before submission is really vital and I wish if I
> could get a review on this so that I could improve on the proposal much
> more and gain better clarity about the project as well as learn about my
> mistakes.
> 
> Look forward towards your suggestions and comments :)

Hi Anikesh,

your proposal very well written with a good amount of details. I enjoyed
reading it, good work !

Daniel Stenberg already mentioned a few points and I guess he is
currently *the* expert for DoH client implementation.

There is not much to add from my side, just a few remarks.

This link is absolutely not relevant for Wget2:
  2. http://wget.addictivecode.org/OptionsHowto.html
We should write up something similar for Wget2 to give contributors an
easy start.

You mention two paths for the sources, wget2/libdns and wget2/dnslib.
Accidentally or did I miss something ?
You could also put the files into libwget/ - and skip building these
files in the Makefile.am using a 'conditional' from configure.ac.

So you also need a configure flag (e.g. --enable-dns-over-https
[default: on]).

Maybe you change the (protocol independent) '--dns-resolver' to a more
specific '--doh-resolver'.


With Best Regards, Tim



signature.asc
Description: OpenPGP digital signature

[Bug-wget] GSoC'18: DNS over HTTPS.

[Aniketh Gireesh]

Hello everyone,

I'm Aniketh Girish, a computer science undergraduate from India. Just
giving a small introduction about myself, I am quite convenient with open
source contribution and I have done GSoC last year with KDE under Krita, a
graphics libre software.

I was interested in a project inside Wget2 called DNS-over-HTTPS and I have
prepared a proposal for the same[1].

Review from the community before submission is really vital and I wish if I
could get a review on this so that I could improve on the proposal much
more and gain better clarity about the project as well as learn about my
mistakes.

Look forward towards your suggestions and comments :)

[1] -
https://docs.google.com/document/d/1B3j9Z11iPSoN5XshYJr1Jc7kxlgD6AY3D8v4YPBAXKc/edit?usp=sharing

Cheers.
-- 
Aniketh Girish
Member at FOSS@Amrita 
Amrita University 
Github  | Blog
 | Website 

"For the Love of Code."