[Bug-wget] [patch] configure: try pkg-config first for newer openssl's

2011-12-20 Thread Mike Frysinger
sorry, i have no idea htf to use bzr. it doesn't make sending e-mail simple like git, so there's something below that hopefully people can use. - revno: 2578 committer: Mike Frysinger branch nick: wget timestamp: Tue 2011-12-20 11:08:20 -0500 message: configur

Re: [Bug-wget] Filename to save to

2012-01-05 Thread Mike Frysinger
On Thursday 05 January 2012 17:29:48 Volker Kuhlmann wrote: > Many web servers offer files only as a result of some CGI processing or > some such mechanism, which doesn't have the filename to save to in the > URL. The filename is instead supplied as part of the http headers, like: > > Content-Le

Re: [Bug-wget] Filename to save to

2012-01-05 Thread Mike Frysinger
On Thursday 05 January 2012 22:17:47 Volker Kuhlmann wrote: > Reading the CVE description gives me the impression that the security > problem only exists if one was silly enough to allow overwriting > existing files not really. there are plenty of files which often don't exist but get automatica

Re: [Bug-wget] Filename to save to

2012-01-05 Thread Mike Frysinger
On Thursday 05 January 2012 23:04:19 Volker Kuhlmann wrote: > Content-Disposition: attachment; > filename=freetronics-EtherTen-02f9e4e.tar.gz > > Is there a way to get the job done with wget? `man wget` says --content-disposition -mike signature.asc Description: This is a digitally signed mes

Re: [Bug-wget] migration git repository

2012-05-09 Thread Mike Frysinger
On Wednesday 09 May 2012 16:42:32 Giuseppe Scrivano wrote: > I wanted to do this before the GSOC student was going to work on this > project and here we go: I have just migrated the wget repository to git. that is awesome. i can say that trying to submit patches to wget via bzr has been a huge p

Re: [Bug-wget] migration git repository

2012-05-09 Thread Mike Frysinger
On Wednesday 09 May 2012 16:42:32 Giuseppe Scrivano wrote: > You can clone the new repository by: > > git clone git://git.savannah.gnu.org/wget.git hrm, something is whacked here. `du` shows that the .git tree is 180MB! even if i `git format-patch` back to the origin, all those patches up to 6

Re: [Bug-wget] migration git repository

2012-05-11 Thread Mike Frysinger
On Friday 11 May 2012 17:48:51 Ángel González wrote: > On 10/05/12 22:07, Alex wrote: > > Sorry, don't know how to made correct reply to maillist from digest. > > > > After importing data from bazaar repository it's better to repack all > > data with recomputing deltas. I use > > git repack -A -F

Re: [Bug-wget] [PATCH] Added .gitignore and updated it with file list to ignore for GIT repo

2012-05-21 Thread Mike Frysinger
On Monday 21 May 2012 18:03:19 Sasikanth babu wrote: > On Sat, May 19, 2012 at 4:05 PM, Giuseppe Scrivano wrote: > > Sasikanth babu writes: > > > +/lib/.deps/ > > > +/lib/.gitignore > > > +/lib/Makefile > > > +/lib/Makefile.in > > > +/lib/arg-nonnull.h > > > +/lib/arpa/ > > > +/lib/asnprintf.o > >

[Bug-wget] [PATCH] detect openssl via pkg-config if it's available

2012-05-21 Thread Mike Frysinger
Newer versions of openssl ship with pkg-config files, so if we can detect it via those, do so. If that fails, fall back to the classic method. Signed-off-by: Mike Frysinger --- configure.ac | 55 --- 1 files changed, 32 insertions(+), 23

[Bug-wget] [PATCH] fix build warnings due to DEBUG_MALLOC

2012-05-21 Thread Mike Frysinger
The current cleanup_html_url code warns because it's marked static but no one calls it. Reading the code base, we see it only gets called when DEBUG_MALLOC is defined, so change the static markings to check that ifdef. The spider_cleanup has a similar problem. Signed-off-by: Mike Frys

[Bug-wget] [PATCH] fix build warnings with newer zlib

2012-05-21 Thread Mike Frysinger
with old/new versions. Signed-off-by: Mike Frysinger --- src/warc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/warc.c b/src/warc.c index 57fdcad..9b4329d 100644 --- a/src/warc.c +++ b/src/warc.c @@ -75,7 +75,7 @@ static FILE *warc_current_file; #ifdef HA

Re: [Bug-wget] [PATCH] fix build warnings with newer zlib

2012-05-24 Thread Mike Frysinger
On Thursday 24 May 2012 16:09:31 Giuseppe Scrivano wrote: > Mike Frysinger writes: > > The gz* API from zlib takes a "gzFile", not a "gzFile*". Older > > versions of zlib didn't trigger a warning due to how the funcs > > were written, but newer one

Re: [Bug-wget] [PATCH] detect openssl via pkg-config if it's available

2012-05-24 Thread Mike Frysinger
On Thursday 24 May 2012 16:31:04 Giuseppe Scrivano wrote: > Mike Frysinger writes: > > Newer versions of openssl ship with pkg-config files, so if we can detect > > it via those, do so. If that fails, fall back to the classic method. > > thanks for your contribution. It se

[Bug-wget] [PATCH v2] fix build warnings with newer zlib

2012-05-24 Thread Mike Frysinger
rc_current_gzfile to work warning free with old and new versions of zlib. In terms of generated code, it shouldn't make a difference as a pointer is the same size regardless of what it points to (struct, pointer, something else). Signed-off-by: Mike Frysinger --- v2 - update comm

Re: [Bug-wget] [PATCH] fix build warnings with newer zlib

2012-05-26 Thread Mike Frysinger
On Saturday 26 May 2012 08:09:27 Giuseppe Scrivano wrote: > Mike Frysinger writes: > > that doesn't make sense here. the zlib API has always defined gzFile, > > and has operated on that. it has never utilized gzFile*. the fact that > > it didn't warn in the p

Re: [Bug-wget] [PATCH] detect openssl via pkg-config if it's available

2012-08-06 Thread Mike Frysinger
On Thursday 24 May 2012 17:14:30 Mike Frysinger wrote: > On Thursday 24 May 2012 16:31:04 Giuseppe Scrivano wrote: > > Mike Frysinger writes: > > > Newer versions of openssl ship with pkg-config files, so if we can > > > detect it via those, do so. If that fail

[Bug-wget] [PATCH] detect openssl/pcre/libuuid/zlib via pkg-config if it's available

2012-08-27 Thread Mike Frysinger
Newer versions of these packages ship with pkg-config files, so if we can detect it via those, do so. If that fails, fall back to the old methods. Signed-off-by: Mike Frysinger --- configure.ac | 110 +- 1 file changed, 71 insertions

Re: [Bug-wget] [PATCH] fix build warnings due to DEBUG_MALLOC

2012-08-27 Thread Mike Frysinger
On Monday 21 May 2012 19:05:59 Mike Frysinger wrote: > The current cleanup_html_url code warns because it's marked static > but no one calls it. Reading the code base, we see it only gets > called when DEBUG_MALLOC is defined, so change the static markings > to check tha

Re: [Bug-wget] [PATCH] fix build warnings due to DEBUG_MALLOC

2012-08-30 Thread Mike Frysinger
On Tue, Aug 28, 2012 at 3:52 PM, Giuseppe Scrivano wrote: > Mike Frysinger writes: >> On Monday 21 May 2012 19:05:59 Mike Frysinger wrote: >>> The current cleanup_html_url code warns because it's marked static >>> but no one calls it. Reading the code base, we

Re: [Bug-wget] wget seems to be "out of touch" with security (fails on most (all?) http websites...(where browsers work)

2013-12-20 Thread Mike Frysinger
On Friday 20 December 2013 12:03:43 L Walsh wrote: > Perhaps wget isn't using the new location? openssl manages its cert locations itself, not wget. file a bug for your distro. -mike signature.asc Description: This is a digitally signed message part.

Re: [Bug-wget] wget seems to be "out of touch" with security (fails on most (all?) http websites...(where browsers work)

2013-12-21 Thread Mike Frysinger
On Saturday 21 December 2013 16:51:56 L Walsh wrote: > mancha wrote: > > L Walsh tlinx.org> writes: > >> I recently started using 1.14 of wget included with my distro's updates: > >> GNU Wget 1.14 built on linux-gnu. > >> > >> Trouble is, it gives security warnings on almost every https > >> site

[Bug-wget] [PATCH] sample.wgetrc: add links tot he manual

2013-12-22 Thread Mike Frysinger
--- doc/sample.wgetrc | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/sample.wgetrc b/doc/sample.wgetrc index eaf2bc8..ad86be3 100644 --- a/doc/sample.wgetrc +++ b/doc/sample.wgetrc @@ -5,7 +5,10 @@ ## You can use this file to change the default behaviour of wget or to

Re: [Bug-wget] wget-1.14 not compatible with ppc64le architecture

2013-12-26 Thread Mike Frysinger
On Thursday 26 December 2013 01:39:16 Madhu Pavan wrote: > IBM is introducing a new architecture - ppc64le (powerpc 64-bit Little > Endian) and I was looking at building "wget-1.14" on our ppc64le > environment and I found that "wget-1.14" would require a patch to either > config.guess or needs to

Re: [Bug-wget] [PATCH] Don't use --debug in Test--post-file.px

2014-01-23 Thread Mike Frysinger
On Thursday 23 January 2014 09:15:36 Lars Wendler wrote: > On Thu, 23 Jan 2014 18:56:06 +0530 Darshit Shah wrote: > >@Lars: It would be great if you could kindly generate a patch file with > >`git format-patch` and also add a ChangeLog entry along with it. > > My previous patch was generated by "g

Re: [Bug-wget] Debug symbols

2014-03-09 Thread Mike Frysinger
On Thu 06 Mar 2014 10:41:47 Jeff Janes wrote: > I've found that I can get debuggings symbols by manually forcing it, using: > > make CFLAGS='-g -O2 -Wall' i would generally advise against this in autoconf based projects. set your CFLAGS before running configure instead: ./configure CFLA

[Bug-wget] [PATCH] tests: fix skip exit code

2014-10-27 Thread Mike Frysinger
The test harness looks for exit code 77 to mark tests as skipped, not exit 2. Switch over so we get SKIP instead of FAIL. --- tests/WgetFeature.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/WgetFeature.pm b/tests/WgetFeature.pm index 0762314..118e79c 100644 --- a/te

[Bug-wget] [PATCH 4/5] use pkg-config to check openssl deps if available

2014-10-27 Thread Mike Frysinger
Newer versions of these packages ship with pkg-config files, so if we can detect it via those, do so. If that fails, fall back to the old methods. --- configure.ac | 100 --- 1 file changed, 54 insertions(+), 46 deletions(-) diff --git a/co

[Bug-wget] [PATCH 1/5] use pkg-config to check zlib deps if available

2014-10-27 Thread Mike Frysinger
Newer versions of these packages ship with pkg-config files, so if we can detect it via those, do so. If that fails, fall back to the old methods. --- configure.ac | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 3cbe618..8ec6c09 1006

[Bug-wget] [PATCH 2/5] use pkg-config to check libuuid deps if available

2014-10-27 Thread Mike Frysinger
Newer versions of these packages ship with pkg-config files, so if we can detect it via those, do so. If that fails, fall back to the old methods. Also add a configure flag to explicitly control its usage. --- configure.ac | 38 +- 1 file changed, 25 insertion

[Bug-wget] [PATCH 5/5] use pkg-config to check gnutls deps if available

2014-10-27 Thread Mike Frysinger
Newer versions of these packages ship with pkg-config files, so if we can detect it via those, do so. If that fails, fall back to the old methods. --- configure.ac | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/configure.ac b/configure.ac index

[Bug-wget] [PATCH] openssl: fix implicit decl warning

2014-10-27 Thread Mike Frysinger
Include the right header to fix: openssl.c: In function 'ssl_init': openssl.c:195:3: warning: implicit declaration of function 'ENGINE_load_builtin_engines' [-Wimplicit-function-declaration] ENGINE_load_builtin_engines(); ^ --- src/openssl.c | 1 + 1 file changed, 1 insertion(+) di

[Bug-wget] [PATCH 3/5] use pkg-config to check pcre deps if available

2014-10-27 Thread Mike Frysinger
Newer versions of these packages ship with pkg-config files, so if we can detect it via those, do so. If that fails, fall back to the old methods. Also add a configure flag to explicitly control its usage. --- configure.ac | 25 ++--- 1 file changed, 18 insertions(+), 7 delet

Re: [Bug-wget] [Bug-Wget] Patch Test-proxied-https-auth.px

2014-10-29 Thread Mike Frysinger
On 28 Oct 2014 11:47, Tim Ruehsen wrote: > I pushed it, since it fixes a bug anyways. it still seems to be racy for me -- passes only rarely. using wget 1.16 with just the one fix 3eff3ad69a46364475e1f4abdf9412cfa87e3d6c. example failure log: $ cat Test-proxied-https-auth.log --2014-10-29 15:5

Re: [Bug-wget] Several little patches / fixes

2014-10-31 Thread Mike Frysinger
On 30 Oct 2014 09:18, Tim Ruehsen wrote: > --- a/src/openssl.c > +++ b/src/openssl.c > @@ -570,6 +571,27 @@ pattern_match (const char *pattern, const char *string) >return *n == '\0'; > } > > +char *_get_rfc2253_formatted (X509_NAME *name) why not static ? -mike signature.asc Description:

Re: [Bug-wget] let's fix the openssl backend once and for all (was: Patch Test-proxied-https-auth.px)

2014-10-31 Thread Mike Frysinger
On 30 Oct 2014 12:18, Giuseppe Scrivano wrote: > Tim Rühsen writes: > > as I wrote to Mike: It is the OpenSSL code within Wget. Wget compiled with > > GnuTLS does not show any problems. > > and this remembers us that maintaining two different backends is not a > good idea. I am for just moving

Re: [Bug-wget] let's fix the openssl backend once and for all

2014-10-31 Thread Mike Frysinger
On 30 Oct 2014 19:47, Giuseppe Scrivano wrote: > Mike Frysinger writes: > > On 30 Oct 2014 12:18, Giuseppe Scrivano wrote: > >> Tim Rühsen writes: > >> > as I wrote to Mike: It is the OpenSSL code within Wget. Wget compiled > >> > with > >>

Re: [Bug-wget] [PATCH 1/5] use pkg-config to check zlib deps if available

2014-10-31 Thread Mike Frysinger
On 31 Oct 2014 16:50, Giuseppe Scrivano wrote: > Mike Frysinger writes: > > Newer versions of these packages ship with pkg-config files, so if we can > > detect it via those, do so. If that fails, fall back to the old methods. > > so far I always tried to stay as far aw

Re: [Bug-wget] [Bug-Wget] Policy on commit messages

2014-11-01 Thread Mike Frysinger
On 01 Nov 2014 14:05, Tim Rühsen wrote: > Am Samstag, 1. November 2014, 05:43:11 schrieb Darshit Shah: > > In the last few days we've seen a huge flurry of activity and a large number > > of patches have been committed to the code base. As someone who was > > traveling and hence unable to keep up w

Re: [Bug-wget] [PATCH 5/5] use pkg-config to check gnutls deps if available

2014-11-01 Thread Mike Frysinger
On 01 Nov 2014 14:11, Darshit Shah wrote: > If we're to merge these patches, all of them should be squashed into one > since > they all perform the same action. I've merged all the patches into a single > one > and added ChangeLog entry to its right place. If others agree, I'll push this > pat

Re: [Bug-wget] [Bug-Wget] Policy on commit messages

2014-11-02 Thread Mike Frysinger
On 02 Nov 2014 12:00, Tony Lewis wrote: > Tim Rühsen wrote: > > I guess with 'work from the distribution' you are talking about a tarball > > (created by 'make dist'). > > I suppose so -- since I haven't learned git yet, I didn't even know how you > created the tarball. autotool based projects cr

Re: [Bug-wget] [Bug-Wget] Configure flag to disable assert

2014-11-14 Thread Mike Frysinger
On 15 Nov 2014 00:31, Darshit Shah wrote: > +dnl Adds a --disable-aasert option to ./configure which can be used by distro "assert" -mike signature.asc Description: Digital signature

Re: [Bug-wget] [Bug-Wget] Configure flag to disable assert

2014-11-14 Thread Mike Frysinger
On 15 Nov 2014 10:24, Darshit Shah wrote: > On 11/14, Dagobert Michelsen wrote: > >> Am 14.11.2014 um 20:01 schrieb Darshit Shah: > >> Assertions are good programming practice. However, as the recent assert I > >> added shows us, they should not exist on the client side installations of > >> our

Re: [Bug-wget] Marking Release v1.17.1?

2015-12-08 Thread Mike Frysinger
On 08 Dec 2015 21:45, Darshit Shah wrote: > With my last set of patches, we have fixed all the issues reported / > identified > after the 1.17 release. Hence, maybe we should consider releasing a 1.17.1 > bugfix release? a bugfix release would be great. specifically, one that builds when IPv6

Re: [Bug-wget] Timezones

2017-03-07 Thread Mike Frysinger
On 07 Mar 2017 16:14, Josef Moellers wrote: > When a colleague checked timestamps handling in vsftpd, he found that > wget is expecting that timestamps received from ftp server have the same > timezone as the client. > > in src/ftp-ls.c:ftp_parse_unix_ls() > It reads time of modification from dire

Re: [Bug-wget] Timezones

2017-03-08 Thread Mike Frysinger
On 08 Mar 2017 08:38, Josef Moellers wrote: > On 07.03.2017 21:51, Mike Frysinger wrote: > > On 07 Mar 2017 16:14, Josef Moellers wrote: > >> When a colleague checked timestamps handling in vsftpd, he found that > >> wget is expecting that timestamps received fr

Re: [Bug-wget] Timezones

2017-03-08 Thread Mike Frysinger
On 08 Mar 2017 12:48, Tim Ruehsen wrote: > Just want to add that someone put much effort into detecting and parsing the > different types of listings (see ftp-ls.c). That is Unix, Windows, VMS, MacOS > (like Unix). All is local server time. > > > there's nothing reasonable wget can do here. > >

[Bug-wget] [PATCH] Include libunistring headers only when used

2017-03-20 Thread Mike Frysinger
The unistring functions are used only when an older version of libidn2 is used, so don't include its headers either w/newer libdin2 versions. --- src/iri.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/iri.c b/src/iri.c index 8be109e6961c..db87135bae1b 100644 --- a/

Re: [Bug-wget] Format-string mismatch in utils.c

2018-01-26 Thread Mike Frysinger
On 22 Dec 2017 00:38, Daniel Macks wrote: > Building wget-1.19.2 on OS X 10.13, I get: > > gcc -DHAVE_CONFIG_H -DSYSTEM_WGETRC=\"/sw/etc/wgetrc\" > -DLOCALEDIR=\"/sw/share/locale\" -I. -I../lib -I../lib -I/sw/include > -I/sw/include -I/sw/include -I/sw/include -I/sw/include -DNDEBUG -MT utils

[Bug-wget] [PATCH] Also remove -d (--debug) from .px tests

2009-10-14 Thread Mike Frysinger
# HG changeset patch # User Mike Frysinger # Date 1255483257 14400 # Node ID b8a368fe7fed3fcca31cf9102046d188024fbf7d # Parent ee7b9018a48319f23fa9efd2776b196401ca28ef Also remove -d (--debug) from .px tests. diff -r ee7b9018a483 -r b8a368fe7fed tests/Test-E-k-K.px --- a/tests/Test-E-k-K.px