[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 --- Comment #24 from Tom Sommer --- Any chance of getting this added into 2.4 or 2.5? -- You are receiving this mail because: You are the assignee for the bug. - To

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 --- Comment #23 from atten --- Tested on our acting reverse-proxy nginx, configured with this on the http listener: proxy_set_headerX-Forwarded-For $remote_addr; proxy_set_headerHost $http_host;

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 Yordan Gigov changed: What|Removed |Added Attachment #34741|0 |1 is

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 --- Comment #21 from Yordan Gigov --- Created attachment 34774 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34774=edit Implementation for 2.4 branch based on 2.4.25 tag Anyone wanting to use this feature for 2.4

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 --- Comment #20 from Yordan Gigov --- I have no way to test the ProxyProtocol addition, but I'm pretty sure I should have converted the server port using ntohs() when the protocol is version 2. That is lines 1056 and 1073

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 Yordan Gigov changed: What|Removed |Added Attachment #34711|0 |1 is

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 --- Comment #18 from Sander Hoentjen --- I have written something similar for ProxyProtocol instead of X-Forwarded-For, unfortunately I had not seen this issue here as I could have maybe used it as a base. My code is at

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 Yordan Gigov changed: What|Removed |Added CC||san...@hoentjen.eu

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 Yordan Gigov changed: What|Removed |Added Attachment #34709|0 |1 is

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 colad...@gmail.com changed: What|Removed |Added Attachment #34024|0 |1 is obsolete|

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 --- Comment #15 from Jean Weisbuch --- In my case, i would need this for a shared hosting platform, so i cant rely on the users having to modify their htaccess to use %{ENV:HTTPS} instead of %{HTTPS}, it has to be transparent

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 Jean Weisbuch changed: What|Removed |Added CC||j...@phpnet.org --

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 --- Comment #14 from colad...@gmail.com --- (In reply to Jean Weisbuch from comment #9) > Its unfortunately still not enough for the HTTPS variable to work with > mod_rewrite, such rewriterules will not work and create a redirect loop : >

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 --- Comment #13 from Yann Ylavic --- (In reply to Yann Ylavic from comment #11) > Why not rather use %{ENV:remoteip_env_https} in the RewriteCond? Or %{ENV:HTTPS} since the patch seems to set the "HTTPS" entry in the

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 --- Comment #12 from Yann Ylavic --- Comment on attachment 34518 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34518 using apr_itoa for integer conversion, removed comment setting remoteip-proxy-ip-list >From

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 --- Comment #11 from Yann Ylavic --- Why not rather use %{ENV:remoteip_env_https} in the RewriteCond? -- You are receiving this mail because: You are the assignee for the bug.

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 --- Comment #10 from Jean Weisbuch --- (In reply to Jean Weisbuch from comment #9) > Its unfortunately still not enough for the HTTPS variable to work with > mod_rewrite, such rewriterules will not work and create a redirect

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 --- Comment #9 from Jean Weisbuch --- Its unfortunately still not enough for the HTTPS variable to work with mod_rewrite, such rewriterules will not work and create a redirect loop : RewriteCond %{HTTPS} !=on

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 Peter H. changed: What|Removed |Added Attachment #34496|0 |1 is

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 martin.kof...@gmail.com changed: What|Removed |Added Attachment #34506|0 |1 is obsolete|

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 martin.kof...@gmail.com changed: What|Removed |Added Attachment #34504|0 |1 is obsolete|

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 --- Comment #5 from martin.kof...@gmail.com --- Created attachment 34504 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34504=edit reset scheme and port if next request to be processed is http; set scheme and port only from trusted

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 Peter H. changed: What|Removed |Added Attachment #34495|0 |1 is

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 --- Comment #3 from colad...@gmail.com --- This part worries me about your proposal r->server->server_scheme = config->secure_header_value; This is not guaranteed to always be "http" or "https". That variable is set by the user, because you

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 martin.kof...@gmail.com changed: What|Removed |Added CC||martin.kof...@gmail.com --

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 --- Comment #2 from Peter Hochbaum --- Created attachment 34495 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34495=edit like previous patch, but also setting r->server->port for correct redirections Extended

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 Peter Hochbaum changed: What|Removed |Added CC|

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 p.hochb...@dvz-mv.de changed: What|Removed |Added CC|p.hochb...@dvz-mv.de| -- You are receiving this

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 p.hochb...@dvz-mv.de changed: What|Removed |Added CC||p.hochb...@dvz-mv.de -- You

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 Christophe JAILLET changed: What|Removed |Added Keywords|

[Bug 59829] Detect HTTPS marker from reverse proxy

https://bz.apache.org/bugzilla/show_bug.cgi?id=59829 --- Comment #1 from colad...@gmail.com --- Created attachment 34249 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34249=edit Same as the other patch, but also change the SERVER_PORT environment variable -- You are receiving this mail