xiomara.jayas...@sun.com wrote:
Thumbs down -- sorry Tim, this fix breaks the product build.
Indeed it did. Sigh. I am working on a fix under bug-ID 6824595
"OpenJDK fix breaks product build for jdk7". No wonder everyone is
afraid to touch these Makefiles. My build checklist just got twi
Thumbs down -- sorry Tim, this fix breaks the product build.
-Xiomara
On 03/31/09 13:26, Tim Bell wrote:
I wrote:
One question - if the user goes to the trouble to set any of
ALT_BINARY_PLUGS_JARFILE, ALT_BINARY_PLUGS_PATH,
ALT_BUILD_BINARY_PLUGS_PATH, ALT_CLOSED_JDK_IMPORT_PATH
(See the
Changeset: 964cc8eb3232
Author:tbell
Date: 2009-03-31 15:27 -0700
URL: http://hg.openjdk.java.net/jdk7/build/jdk/rev/964cc8eb3232
6819847: build is broken for OpenJDK with plugs
Reviewed-by: jjg, robilad, ohair
! make/Makefile
! make/common/Defs.gmk
! make/common/shared/Sanity-Sett
2009/3/31 Joe Darcy :
> Andrew John Hughes wrote:
>>
>> 2009/3/31 Tim Bell :
>>>
>>> I wrote:
>>>
One question - if the user goes to the trouble to set any of
ALT_BINARY_PLUGS_JARFILE, ALT_BINARY_PLUGS_PATH,
ALT_BUILD_BINARY_PLUGS_PATH, ALT_CLOSED_JDK_IMPORT_PATH
(See the commen
Andrew John Hughes wrote:
2009/3/31 Tim Bell :
I wrote:
One question - if the user goes to the trouble to set any of
ALT_BINARY_PLUGS_JARFILE, ALT_BINARY_PLUGS_PATH,
ALT_BUILD_BINARY_PLUGS_PATH, ALT_CLOSED_JDK_IMPORT_PATH
(See the comments in jdk/make/common/Defs.gmk starting at line 127),
sho
I wrote:
The other case is if a user outside the Sun network sets
IMPORT_BINARY_PLUGS=true. Here they will need to set one of the
ALT_..._BINARY_PLUGS variables to point to the plugs anyway.
Andrew John Hughes wrote:
That suggests to me that outside Sun, there is no need for
IMPORT_BINARY_P
Tim Bell wrote:
> Review feedback convinced me to reverse that last statement.
>
> Here is round two - please take a look:
>
> http://cr.openjdk.java.net/~tbell/6819847/webrev.01/
>
> With these changes the default behavior is as if IMPORT_BINARY_PLUGS=false
Thanks Tim, the change looks good
2009/3/31 Tim Bell :
> I wrote:
>
>> One question - if the user goes to the trouble to set any of
>> ALT_BINARY_PLUGS_JARFILE, ALT_BINARY_PLUGS_PATH,
>> ALT_BUILD_BINARY_PLUGS_PATH, ALT_CLOSED_JDK_IMPORT_PATH
>> (See the comments in jdk/make/common/Defs.gmk starting at line 127),
>> should we assum
I wrote:
One question - if the user goes to the trouble to set any of
ALT_BINARY_PLUGS_JARFILE, ALT_BINARY_PLUGS_PATH,
ALT_BUILD_BINARY_PLUGS_PATH, ALT_CLOSED_JDK_IMPORT_PATH
(See the comments in jdk/make/common/Defs.gmk starting at line 127),
should we assume they must really, really want the
2009/3/31 Andrew Haley :
> Neale Ferguson wrote:
>> I¹m building the OpenJDK6 & 7 by way of the zeroJDK mechanism and am running
>> into problems.
>>
>> Using gij with icedtea6 I get:
>>
>> + CLASSPATH=/home/neale/ecj-3.4.1.jar
>> + /usr/bin/gij org.eclipse.jdt.internal.compiler.batch.Main -1.5 -no
Neale Ferguson wrote:
> I¹m building the OpenJDK6 & 7 by way of the zeroJDK mechanism and am running
> into problems.
>
> Using gij with icedtea6 I get:
>
> + CLASSPATH=/home/neale/ecj-3.4.1.jar
> + /usr/bin/gij org.eclipse.jdt.internal.compiler.batch.Main -1.5 -nowarn -g
> -d lib/hotspot-tools -
2009/3/31 Tim Bell :
> Andrew John Hughes wrote:
>
>> ERROR: Can't locate pre-built libraries.
>> Please check your access to
>>
>> /NOT-SET/re/jdk/1.7.0/promoted/latest/openjdk/binaryplugs/linux-amd64
>> and/or check your value of ALT_BINARY_PLUGS_PATH.
>>
>> Good to know it is in the
Andrew John Hughes wrote:
ERROR: Can't locate pre-built libraries.
Please check your access to
/NOT-SET/re/jdk/1.7.0/promoted/latest/openjdk/binaryplugs/linux-amd64
and/or check your value of ALT_BINARY_PLUGS_PATH.
Good to know it is in the queue though, as I was going
I¹m building the OpenJDK6 & 7 by way of the zeroJDK mechanism and am running
into problems.
Using gij with icedtea6 I get:
+ CLASSPATH=/home/neale/ecj-3.4.1.jar
+ /usr/bin/gij org.eclipse.jdt.internal.compiler.batch.Main -1.5 -nowarn -g
-d lib/hotspot-tools -source 1.5 -sourcepath
hotspot-tools:o
2009/3/31 Tim Bell :
>
>
>>> Kelly O'Hair wrote:
I didn't think openjdk7 could build without binary plugs.
But I've been a bit disconnected from the jdk work lately.
>
> Andrew John Hughes wrote:
>
>> I didn't either. The last build I tried using the hotspot-comp tree
>> (to test a
Kelly O'Hair wrote:
I didn't think openjdk7 could build without binary plugs.
But I've been a bit disconnected from the jdk work lately.
Andrew John Hughes wrote:
I didn't either. The last build I tried using the hotspot-comp tree
(to test a patch for twisti) needed pointing at some binar
2009/3/31 Tim Bell :
> Clearly this review is of interest to a wider audience.
>
> This fixes the build problem Jon found and reported as 6819847
>
> Until the fix is approved and pushed, the workaround is to add:
>
> IMPORT_BINARY_PLUGS=true
>
> to your build environment.
> Tim
>
> Orig
Clearly this review is of interest to a wider audience.
This fixes the build problem Jon found and reported as 6819847
Until the fix is approved and pushed, the workaround is to add:
IMPORT_BINARY_PLUGS=true
to your build environment.
Tim
Original Message
Subject: Please
Kelly O'Hair wrote:
>
> Seems ok to me, just a few observations:
>
> Do we need this:
>
> ifeq ($(DEBUG_CLASSFILES), true)
> ANT_OPTIONS += -Djavac.debug=true
> ANT_OPTIONS += -Djavac.debuglevel=source,lines,vars
> endif
>
> to be
>
> ifeq ($(DEBUG_CLASSFILES), true)
> ANT_OPTIONS += -Dj
2009/3/31 Jonathan Gibbons :
> Andrew,
> See this response sent by Tim on March 26.
> -- Jon
>
> Hi Neale:
>
> I’m trying to build the JDK for the first time. I grabbed the sources from
> the mercurial repository and followed the FAQ to perform the build. It
> builds a heap of stuff before it dies
Andrew,
See this response sent by Tim on March 26.
-- Jon
Hi Neale:
I’m trying to build the JDK for the first time. I grabbed the
sources from the mercurial repository and followed the FAQ to
perform the build. It builds a heap of stuff before it dies with
the following:
error: com.sun.
This is with jdk-7-ea-plug-b52-linux-x64-26_mar_2009.jar:
/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/bin/java -Xmx896m -Xms128m
-XX:PermSize=32m -XX:MaxPermSize=160m
"-Xbootclasspath/p:/local/openjdk7/jdk7/build/linux-amd64/langtools/dist/bootstrap/lib/javac.jar"
-jar
/local/openjdk7/jdk7
22 matches
Mail list logo