Re: Customized make file inclusion

2012-01-18 Thread David Holmes
FYI here is proposed webrev: http://cr.openjdk.java.net/~dholmes/7130909/webrev/ CR 7130909 was filed. David On 19/01/2012 1:30 PM, David Holmes wrote: Hi Kelly, On 19/01/2012 2:22 AM, Kelly O'Hair wrote: On Jan 17, 2012, at 7:17 PM, David Holmes wrote: On 18/01/2012 7:07 AM, Kelly O'Hai

Re: Customized make file inclusion

2012-01-18 Thread David Holmes
Hi Kelly, On 19/01/2012 2:22 AM, Kelly O'Hair wrote: On Jan 17, 2012, at 7:17 PM, David Holmes wrote: On 18/01/2012 7:07 AM, Kelly O'Hair wrote: Generally, I have no objection to this change. But instead of setting it to NO_SUCH_PATH, I would not set it at all, and avoid the $(shell) to se

Re: RFR: 7115200

2012-01-18 Thread David Holmes
Rickard, This looks okay to me (have you tested setting JAVASE_EMBEDDED?) For the record once 7130909 is pushed I'll be looking at moving the JFR build rules, and the SE Embedded build rules out of the Open repository. David On 18/01/2012 6:48 PM, Rickard Bäckman wrote: Please review the up

hg: jdk8/build/langtools: Added tag jdk8-b21 for changeset bcb21abf1c41

2012-01-18 Thread david . katleman
Changeset: 390a7828ae18 Author:katleman Date: 2012-01-13 10:05 -0800 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/390a7828ae18 Added tag jdk8-b21 for changeset bcb21abf1c41 ! .hgtags

hg: jdk8/build/jdk: Added tag jdk8-b21 for changeset 664fa4fb0ee4

2012-01-18 Thread david . katleman
Changeset: dda27c73d8db Author:katleman Date: 2012-01-13 10:05 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/dda27c73d8db Added tag jdk8-b21 for changeset 664fa4fb0ee4 ! .hgtags

hg: jdk8/build/jaxws: Added tag jdk8-b21 for changeset c266cab0e3ff

2012-01-18 Thread david . katleman
Changeset: 8d3df89b0f2d Author:katleman Date: 2012-01-13 10:05 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/8d3df89b0f2d Added tag jdk8-b21 for changeset c266cab0e3ff ! .hgtags

hg: jdk8/build/jaxp: Added tag jdk8-b21 for changeset d41eeadf5c13

2012-01-18 Thread david . katleman
Changeset: cf9d6ec44f89 Author:katleman Date: 2012-01-13 10:05 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/cf9d6ec44f89 Added tag jdk8-b21 for changeset d41eeadf5c13 ! .hgtags

hg: jdk8/build/hotspot: 73 new changesets

2012-01-18 Thread david . katleman
Changeset: ed621d125d02 Author:katleman Date: 2012-01-13 10:05 -0800 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ed621d125d02 Added tag jdk8-b21 for changeset 9952d1c439d6 ! .hgtags Changeset: 0841c0ec2ed6 Author:amurillo Date: 2011-12-23 15:29 -0800 URL:

hg: jdk8/build/corba: Added tag jdk8-b21 for changeset f157fc2a71a3

2012-01-18 Thread david . katleman
Changeset: a11d0062c445 Author:katleman Date: 2012-01-13 10:05 -0800 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/a11d0062c445 Added tag jdk8-b21 for changeset f157fc2a71a3 ! .hgtags

hg: jdk8/build: Added tag jdk8-b21 for changeset cc771d92284f

2012-01-18 Thread david . katleman
Changeset: 7ad075c80995 Author:katleman Date: 2012-01-13 10:05 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/7ad075c80995 Added tag jdk8-b21 for changeset cc771d92284f ! .hgtags

Re: Build openjdk in Ubuntu 11.10

2012-01-18 Thread Kelly O'Hair
Patch looks fine to me. -kto On Jan 13, 2012, at 9:54 AM, [email protected] wrote: > 2012/1/13 9:33 -0800, [email protected]: >> I am getting the following error when building openjdk 7.0 on ubuntu 11.10 >> But I already have the package libasound2-dev installed. > > This is

Re: Customized make file inclusion

2012-01-18 Thread Kelly O'Hair
On Jan 17, 2012, at 7:17 PM, David Holmes wrote: > On 18/01/2012 7:07 AM, Kelly O'Hair wrote: >> Generally, I have no objection to this change. >> >> But instead of setting it to NO_SUCH_PATH, I would not set it at all, and >> avoid the $(shell) to see if it >> exists completely. Just don't se

Re: RFR: 7115200

2012-01-18 Thread Rickard Bäckman
Please review the updated webrev, David Holmes pointed out that we shouldn't build JFR for the embedded environments. Webrev: http://cr.openjdk.java.net/~rbackman/7115200.u1/webrev/ Thanks Rickard On 01/17/2012 04:26 PM, Rickard Bäckman wrote: CR7115200: Add Java FlightRecorder phase 1 Makefi