Inline.
On 01/19/2012 11:00 PM, Kelly O'Hair wrote:
I tend to agree with Robert.
-kto
On Jan 19, 2012, at 9:14 AM, Robert Ottenhag wrote:
Rickard,
* make/com/oracle/Makefile:
- just skip the separate JFR variable and use "SUBDIRS += jfr" to add to the previously
defined SUBDIRS variable, o
I think that looks fine.
-kto
On Jan 18, 2012, at 9:29 PM, David Holmes wrote:
> FYI here is proposed webrev:
>
> http://cr.openjdk.java.net/~dholmes/7130909/webrev/
>
> CR 7130909 was filed.
>
> David
>
> On 19/01/2012 1:30 PM, David Holmes wrote:
>> Hi Kelly,
>>
>> On 19/01/2012 2:22 AM,
I tend to agree with Robert.
-kto
On Jan 19, 2012, at 9:14 AM, Robert Ottenhag wrote:
> Rickard,
>
> * make/com/oracle/Makefile:
> - just skip the separate JFR variable and use "SUBDIRS += jfr" to add to the
> previously defined SUBDIRS variable, or if necessary "SUBDIRS = jfr
> $(SUBDIRS)" i
Rickard,
* make/com/oracle/Makefile:
- just skip the separate JFR variable and use "SUBDIRS += jfr" to add to
the previously defined SUBDIRS variable, or if necessary "SUBDIRS = jfr
$(SUBDIRS)" if it is necessary to build it first, which I doubt.
+ ifndef OPENJDK
+ ifndef JAVASE_EMBEDDED
+
Yes, the patch looks good.
/Robert
On 01/18/2012 06:38 PM, Kelly O'Hair wrote:
Patch looks fine to me.
-kto
On Jan 13, 2012, at 9:54 AM, [email protected] wrote:
2012/1/13 9:33 -0800, [email protected]:
I am getting the following error when building openjdk 7.0 on ubunt
On 19/01/2012 8:03 PM, Rickard Bäckman wrote:
David,
thanks for the review.
I've tested with JAVASE_EMBEDDED=true and there is no jfr.jar in
j2sdk-image/jre/lib, the same is true with OPENJDK=true. Running without
those creates the jfr.jar in that directory.
I added another set of ifndef's to g
