hg: jdk8/build/corba: 7153266: Adjustments to corba strip property utility (neutral to builds)

2012-03-19 Thread kelly . ohair
Changeset: 0b94487a30c6 Author:erikj Date: 2012-03-19 13:03 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/0b94487a30c6 7153266: Adjustments to corba strip property utility (neutral to builds) Summary: Fixes to sync up with jdk8 build-infra project. Reviewed-by: ohair, t

Re: Review Request: 7141246 build-infra merge: Introduce new JVM_VARIANT* to control which kind of jvm gets built

2012-03-19 Thread David Holmes
On 19/03/2012 7:13 PM, Erik Joelsson wrote: Thanks for the reviews! On 2012-03-19 02:21, David Holmes wrote: Minor nit, when you say: # On 32 bit we build server and client, on 64 bit just server. the OS isn't actually relevant. If we ask for a 32-bit build then we build both client and serv

Re: Review Request: 7141246 build-infra merge: Introduce new JVM_VARIANT* to control which kind of jvm gets built

2012-03-19 Thread Erik Joelsson
Thanks for the reviews! On 2012-03-19 02:21, David Holmes wrote: Minor nit, when you say: # On 32 bit we build server and client, on 64 bit just server. the OS isn't actually relevant. If we ask for a 32-bit build then we build both client and server; if we ask for a 64-bit build then we bu