Request for Review: Add Mac OS X Instructions to README-builds.html

2012-04-25 Thread Edvard Wendelin
Hi, I'm working on some updates in the README-builds.html [1]. The first step is to add the Mac OS X platform. I have gathered the requirements from the Mac OS X port wiki [2][3]. It seems like Apple has dropped the Mac part of Mac OS X and now only call the product OS X Lion [4]. Question

Re: Request for Review: Execute the build logger with the help of a shell if the x permission is not set

2012-04-25 Thread Magnus Ihse Bursie
On 2012-04-23 18:01, Dmitry Samersoff wrote: Magnus, I'm second to Kelly. We shouldn't have executable scripts in repository. Ok, so here comes a new, even simpler patch. :-) http://cr.openjdk.java.net/~ihse/logger.sh-missing-x-permission/webrev.01/ /Magnus

Request for Review: Remove import of empty JNI header files

2012-04-25 Thread Magnus Ihse Bursie
There are a few files native files in AWT and Java2d, which include generated JNI header files, but the corresponding header files are empty, since the class contains neither native methods nor constants. All of them have probably been useful at one point in time, but then the Java code

Re: Request for Review: Execute the build logger with the help of a shell if the x permission is not set

2012-04-25 Thread Dmitry Samersoff
Magnus, Fix looks good for me. The only question - why we should patch both configure.ac and configure ? I believe we generate configure from configure.ac -Dmitry On 2012-04-25 17:32, Magnus Ihse Bursie wrote: On 2012-04-23 18:01, Dmitry Samersoff wrote: Magnus, I'm second to Kelly. We

Re: Request for Review: Add Mac OS X Instructions to README-builds.html

2012-04-25 Thread Scott Kovatch
On Apr 25, 2012, at 6:02 AM, Edvard Wendelin wrote: Hi, I'm working on some updates in the README-builds.html [1]. The first step is to add the Mac OS X platform. I have gathered the requirements from the Mac OS X port wiki [2][3]. It seems like Apple has dropped the Mac part of Mac

Re: Request for Review: Add Mac OS X Instructions to README-builds.html

2012-04-25 Thread Dalibor Topic
On 4/25/12 3:02 PM, Edvard Wendelin wrote: Hi, I'm working on some updates in the README-builds.html [1]. The first step is to add the Mac OS X platform. I have gathered the requirements from the Mac OS X port wiki [2][3]. It seems like Apple has dropped the Mac part of Mac OS X and now

Re: Request for Review: Execute the build logger with the help of a shell if the x permission is not set

2012-04-25 Thread Magnus Ihse Bursie
25 apr 2012 kl. 17:23 skrev Dmitry Samersoff dmitry.samers...@oracle.com: Magnus, Fix looks good for me. The only question - why we should patch both configure.ac and configure ? I believe we generate configure from configure.ac Yes we do, but we keep a generated configure checked in

Re: Request for Review: Execute the build logger with the help of a shell if the x permission is not set

2012-04-25 Thread Dmitry Samersoff
Magnus, On 2012-04-25 20:31, Magnus Ihse Bursie wrote: Hence, every time configure.ac is modified, configure will be updated as well. OK. Thank you for the explanation! -Dmitry /Magnus -Dmitry On 2012-04-25 17:32, Magnus Ihse Bursie wrote: On 2012-04-23 18:01, Dmitry Samersoff

Re: [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files

2012-04-25 Thread Phil Race
Looks fine. If its not a pain, 2d forest would probably be the most appropriate as 3/4 are 2D .. -phil. On 4/25/2012 8:27 AM, Chris Hegarty wrote: [ cc'ing awt-dev 2d-dev ] The change looks fine Magnus, though it may be best to push through the awt or 2d forest. Members of these groups,

Re: Request for Review: Execute the build logger with the help of a shell if the x permission is not set

2012-04-25 Thread Kelly O'Hair
I of course approve. ;^) We need some code phrase for me when you want a patch integrated into the jdk8/build forest. I'll deal with the CR, make the owner you in this case, and add any reviewers I have seen in the email thread. So how about a code phrase like Kelly, Please integrate this

hg: jdk8/build: Added tag jdk8-b35 for changeset 5285317ebb4e

2012-04-25 Thread david . katleman
Changeset: 6a6ba0a07f33 Author:katleman Date: 2012-04-19 12:18 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/6a6ba0a07f33 Added tag jdk8-b35 for changeset 5285317ebb4e ! .hgtags

hg: jdk8/build/hotspot: 22 new changesets

2012-04-25 Thread david . katleman
Changeset: dce0525b7ee5 Author:katleman Date: 2012-04-19 12:18 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/dce0525b7ee5 Added tag jdk8-b35 for changeset f621660a297b ! .hgtags Changeset: 4a32c51458b9 Author:amurillo Date: 2012-04-07 09:06 -0700 URL:

hg: jdk8/build/jaxws: Added tag jdk8-b35 for changeset e8afc16522e1

2012-04-25 Thread david . katleman
Changeset: 89b36c658e39 Author:katleman Date: 2012-04-19 12:18 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/89b36c658e39 Added tag jdk8-b35 for changeset e8afc16522e1 ! .hgtags

hg: jdk8/build/jdk: 66 new changesets

2012-04-25 Thread david . katleman
Changeset: f4a8153b3ce5 Author:katleman Date: 2012-04-19 12:18 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f4a8153b3ce5 Added tag jdk8-b35 for changeset 2e3e1356ffbd ! .hgtags Changeset: da54364b140c Author:dbuck Date: 2012-03-21 18:41 -0700 URL:

hg: jdk8/build/langtools: 7 new changesets

2012-04-25 Thread david . katleman
Changeset: 068207a80397 Author:katleman Date: 2012-04-19 12:19 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/068207a80397 Added tag jdk8-b35 for changeset defd666a7863 ! .hgtags Changeset: 55ae94116e89 Author:jjg Date: 2012-04-06 10:10 -0700 URL:

Re: [OpenJDK 2D-Dev] Request for Review: Remove import of empty JNI header files

2012-04-25 Thread Jim Graham
Can we remove these empty JNI classes from a list of javah classes somewhere so that we don't waste time generating the empty JNI headers? ...jim On 4/25/12 8:27 AM, Chris Hegarty wrote: [ cc'ing awt-dev 2d-dev ] The change looks fine Magnus, though it may be best to