Re: Mac problem(?), new build, --with-debug-level=slowdebug

2013-01-11 Thread David Chase
On 2013-01-10, at 3:56 AM, Staffan Larsen staffan.lar...@oracle.com wrote: See: http://bugs.sun.com/view_bug.do?bug_id=8004490 Patch: http://hg.openjdk.java.net/jdk8/build/rev/2d9bb72b4e34 /Staffan I tried the workaround in this patch, and it did not seem to result in a debuggable

Re: Review Request: 8006074: build-infra: Configure fails to find SetEnv.Cmd in microsoft sdk

2013-01-11 Thread Tim Bell
Erik: This small patch fixes a problem with configure, Cygwin and Microsoft SDK SetEnv.Cmd as reported in this mail: http://mail.openjdk.java.net/pipermail/build-infra-dev/2013-January/002911.html http://cr.openjdk.java.net/~erikj/8006074/webrev.root.01/ Looks good. Thanks for fixing

Review Request: 8006100: build-infra: Bundle up the correct images in jprt

2013-01-11 Thread Erik Joelsson
This fixes the bundles target for jprt so that overlay images are bundled up for solaris 64bit. http://cr.openjdk.java.net/~erikj/8006100/webrev.root.01/ Even if several people would like to do away with the overlay images, that change should be separate to switching to build-infra. /Erik

Re: Review Request: 8006100: build-infra: Bundle up the correct images in jprt

2013-01-11 Thread Tim Bell
Erik: This fixes the bundles target for jprt so that overlay images are bundled up for solaris 64bit. http://cr.openjdk.java.net/~erikj/8006100/webrev.root.01/ Looks good. Even if several people would like to do away with the overlay images, that change should be separate to switching to

Re: Review Request: 8006074: build-infra: Configure fails to find SetEnv.Cmd in microsoft sdk

2013-01-11 Thread Kelly O'Hair
Looks good. -kto On Jan 11, 2013, at 1:41 AM, Erik Joelsson wrote: This small patch fixes a problem with configure, Cygwin and Microsoft SDK SetEnv.Cmd as reported in this mail: http://mail.openjdk.java.net/pipermail/build-infra-dev/2013-January/002911.html

hg: jdk8/build: 2 new changesets

2013-01-11 Thread erik . joelsson
Changeset: db3984e4eb97 Author:erikj Date: 2013-01-10 12:20 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/db3984e4eb97 8005858: build-infra: Add missed comparison of sec-windows-bin.zip and friends to compare.sh Reviewed-by: tbell, ohair ! common/bin/compare.sh Changeset:

hg: jdk8/build/jdk: 8005856: build-infra: Remove special handling of base module classes header generation

2013-01-11 Thread erik . joelsson
Changeset: f92ab6dbbff8 Author:erikj Date: 2013-01-10 12:23 +0100 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/f92ab6dbbff8 8005856: build-infra: Remove special handling of base module classes header generation Reviewed-by: alanb, tbell, ohair Contributed-by:

Re: Review Request: 8006100: build-infra: Bundle up the correct images in jprt

2013-01-11 Thread Kelly O'Hair
Looks good. -kto On Jan 11, 2013, at 8:25 AM, Erik Joelsson wrote: This fixes the bundles target for jprt so that overlay images are bundled up for solaris 64bit. http://cr.openjdk.java.net/~erikj/8006100/webrev.root.01/ Even if several people would like to do away with the overlay

Re: Mac problem(?), new build, --with-debug-level=slowdebug

2013-01-11 Thread David Chase
Problem solved: /Developer consider harmful, at least on Mountain Lion. Removing that and using the compilers installed by XCode in /usr/bin did the trick. HOWEVER - it seems dubious to me that configure should ignore the environment specification of CXX. I tried the following, where

[8]Review Request: 7162007: Clean up i18n related caches

2013-01-11 Thread Naoto Sato
Hello, (To build-dev folks, I am sending this to you as the change includes one modification in make directory. It is just simply adding a new Java file, so I think it won't affect the new build-infra structure) Please review the changes for this issue:

Re: [8]Review Request: 7162007: Clean up i18n related caches

2013-01-11 Thread Kelly O'Hair
makefile change is fine, no need to change the new build makefiles at all. -kto On Jan 11, 2013, at 1:18 PM, Naoto Sato wrote: Hello, (To build-dev folks, I am sending this to you as the change includes one modification in make directory. It is just simply adding a new Java file, so I

Re: i18n dev [8]Review Request: 7162007: Clean up i18n related caches

2013-01-11 Thread Masayoshi Okutsu
Looks good to me. Masayoshi On 1/12/2013 6:18 AM, Naoto Sato wrote: Hello, (To build-dev folks, I am sending this to you as the change includes one modification in make directory. It is just simply adding a new Java file, so I think it won't affect the new build-infra structure) Please