RFR: 8011350 : hgforesth.sh fails if sh is not bash

2013-04-02 Thread Mike Duigou
Hello all; Further testing on JDK-8011342 revealed that hgforest.sh can fail if the sh shell is not bash. The problem appears to be due to mixing of -o -a and ! in [] test expressions. I have prepared a webrev here: http://cr.openjdk.java.net/~mduigou/JDK-8011350/0/webrev/common/bin/hgforest.s

Please review: JDK-8011348 "use of which in common/autoconf/autogen.sh is not portable"

2013-04-02 Thread Tim Bell
All - I regret the fact that I did not test the fix for 8009988 (see below) when I reviewed it. The script as written there assumes that the 'which' utility will return nothing if the command is not found. On some platforms (Solaris and Windows/Cygwin to name two), the return is more like '

hg: jdk8/build/langtools: 29 new changesets

2013-04-02 Thread david . katleman
Changeset: 35cef52b0023 Author:katleman Date: 2013-03-28 10:55 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/35cef52b0023 Added tag jdk8-b83 for changeset 22ba3f92d4ae ! .hgtags Changeset: eb0198033c5c Author:jfranck Date: 2013-03-13 22:03 +0100 URL:

hg: jdk8/build/nashorn: 16 new changesets

2013-04-02 Thread david . katleman
Changeset: fbbdef940138 Author:katleman Date: 2013-03-28 10:55 -0700 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/fbbdef940138 Added tag jdk8-b83 for changeset 053d7c55dc82 ! .hgtags Changeset: c54e218333be Author:sundar Date: 2013-03-12 18:12 +0530 URL: h

hg: jdk8/build/jdk: 50 new changesets

2013-04-02 Thread david . katleman
Changeset: 8cc500af2454 Author:katleman Date: 2013-03-28 10:55 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/8cc500af2454 Added tag jdk8-b83 for changeset ac519af51769 ! .hgtags Changeset: 07acfb90700b Author:malenkov Date: 2013-03-14 12:15 +0400 URL: htt

hg: jdk8/build/jaxp: Added tag jdk8-b83 for changeset a46d69a1a8ec

2013-04-02 Thread david . katleman
Changeset: f5f40094ffcc Author:katleman Date: 2013-03-28 10:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/f5f40094ffcc Added tag jdk8-b83 for changeset a46d69a1a8ec ! .hgtags

hg: jdk8/build/jaxws: 4 new changesets

2013-04-02 Thread david . katleman
Changeset: 54c29eb352e7 Author:katleman Date: 2013-03-28 10:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/54c29eb352e7 Added tag jdk8-b83 for changeset a1dcc0d83da1 ! .hgtags Changeset: 0ab59cba6167 Author:jjg Date: 2013-03-18 18:34 -0700 URL: http:/

hg: jdk8/build/hotspot: 35 new changesets

2013-04-02 Thread david . katleman
Changeset: e614fc564ded Author:katleman Date: 2013-03-28 10:54 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/e614fc564ded Added tag jdk8-b83 for changeset 1c8db54ee9f3 ! .hgtags Changeset: 59a41e1357ab Author:amurillo Date: 2013-03-23 10:06 -0700 URL:

hg: jdk8/build/corba: 5 new changesets

2013-04-02 Thread david . katleman
Changeset: 14f1babaf548 Author:katleman Date: 2013-03-28 10:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/14f1babaf548 Added tag jdk8-b83 for changeset a45bb25a67c7 ! .hgtags Changeset: c3ec80715805 Author:mfang Date: 2013-03-25 16:53 -0700 URL: http

hg: jdk8/build: 6 new changesets

2013-04-02 Thread david . katleman
Changeset: d409b4cdb74f Author:katleman Date: 2013-03-28 10:53 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/d409b4cdb74f Added tag jdk8-b83 for changeset 466685ba01bf ! .hgtags Changeset: 19a59a13b3ef Author:dholmes Date: 2013-03-14 01:41 -0400 URL: http://h

Re: RFR : 80111342 : hgforest.sh : 'python --version' not supported on older python

2013-04-02 Thread Brad Wetmore
Approved, thanks Mike! Brad On 4/2/2013 3:00 PM, Mike Duigou wrote: Hello all; Brad Wetmore noticed that yesterday's fix for 8011178 did not work on older versions of python which lack support for the --version long option. Enclosed is a patch which uses the more widely supported -V option

RFR : 80111342 : hgforest.sh : 'python --version' not supported on older python

2013-04-02 Thread Mike Duigou
Hello all; Brad Wetmore noticed that yesterday's fix for 8011178 did not work on older versions of python which lack support for the --version long option. Enclosed is a patch which uses the more widely supported -V option instead. Mike diff -r 760074bec012 common/bin/hgforest.sh --- a/common/

Re: Support building zero with the new build

2013-04-02 Thread Omair Majid
Hi, Updated patch at: http://cr.openjdk.java.net/~omajid/webrevs/zero-newbuild/02/ On 04/02/2013 05:21 AM, Erik Joelsson wrote: > I know it's not always obvious where things belong but I would put the > INCLUDE_SA logic in jdk-options.m4 somewhere close after the JVM_VARIANT > variables have been

hg: jdk8/build: 8011278: Allow using a system-installed giflib

2013-04-02 Thread omajid
Changeset: f3cdfb3d360d Author:omajid Date: 2013-04-02 14:13 -0400 URL: http://hg.openjdk.java.net/jdk8/build/rev/f3cdfb3d360d 8011278: Allow using a system-installed giflib Reviewed-by: andrew, prr ! common/autoconf/generated-configure.sh ! common/autoconf/libraries.m4

Re: Allow using a system-installed giflib

2013-04-02 Thread Omair Majid
On 04/02/2013 01:45 PM, Mike Duigou wrote: > Done! > > JDK-8011278 : Allow using a system-installed giflib > Thanks. I have pushed the changesets: http://hg.openjdk.java.net/jdk8/build/rev/f3cdfb3d360d http://hg.openjdk.java.net/jdk8/build/jdk/rev/9c76ea43d491 Cheers, Omair -- PGP Key: 664846

hg: jdk8/build/jdk: 8011278: Allow using a system-installed giflib

2013-04-02 Thread omajid
Changeset: 9c76ea43d491 Author:omajid Date: 2013-04-02 14:13 -0400 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9c76ea43d491 8011278: Allow using a system-installed giflib Reviewed-by: andrew, prr ! makefiles/CompileNativeLibraries.gmk ! src/share/native/sun/awt/splashscreen/

Re: Allow using a system-installed giflib

2013-04-02 Thread Mike Duigou
Done! JDK-8011278 : Allow using a system-installed giflib On Apr 2 2013, at 10:21 , Omair Majid wrote: > On 03/20/2013 03:49 AM, Erik Joelsson wrote: >> This looks good to me. Thanks! > > I would like to push this. Could I get a bug ID, please? > > Thanks, > Omair > -- > PGP Key: 66484681 (ht

Re: Allow using a system-installed giflib

2013-04-02 Thread Omair Majid
On 03/20/2013 03:49 AM, Erik Joelsson wrote: > This looks good to me. Thanks! I would like to push this. Could I get a bug ID, please? Thanks, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint = F072 555B 0A17 3957 4E95 0056 F286 F14F 6648 4681

[PATCH] Enable debug info on all libraries for OpenJDK builds

2013-04-02 Thread Andrew Hughes
With the new build system, the availability of debugging information in the JDK build is a complete mess, controlled by different flags from those that control the HotSpot build. Even when debugging is asked for, it is only turned on for a small number of libraries on GNU/Linux. On Windows, this

Re: Too many java source files are recompiled when one changes.

2013-04-02 Thread Jonathan Gibbons
On 04/02/2013 09:12 AM, Andrew Hughes wrote: - Original Message - sh ./configure --enable-sjavac -- Jon On 03/26/2013 03:43 PM, Martin Buchholz wrote: If I modify an ordinary JDK source file (like StringBuilder.java), then all files are recompiled, even those that don't have any compi

Re: new build system doesn't notice modified C source files.

2013-04-02 Thread Andrew Hughes
- Original Message - > On 2013-03-27 01:13, Martin Buchholz wrote: > > Sorry, false alarm. > > > > The build proceeded so quietly and quickly, (and my modified code worked > > the first time!) that I assumed it must have not been built at all, but I > > was wrong. Congratulations to the bu

Re: Too many java source files are recompiled when one changes.

2013-04-02 Thread Andrew Hughes
- Original Message - > sh ./configure --enable-sjavac > > -- Jon > > On 03/26/2013 03:43 PM, Martin Buchholz wrote: > > If I modify an ordinary JDK source file (like StringBuilder.java), then all > > files are recompiled, even those that don't have any compile-time > > dependency on Strin

Re: Review Request: 8006828: "SKIP_BOOT_CYCLE=false" must work in new building infrastructure

2013-04-02 Thread Tim Bell
On 04/02/13 02:54, Alan Bateman wrote: On 02/04/2013 10:32, Erik Joelsson wrote: On 2013-03-05 16:14, Erik Joelsson wrote: On 2013-02-20 15:20, Erik Joelsson wrote: Adding check for SKIP_BOOT_CYCLE=false in Jprt.gmk which adds the target bootcycle-images. Also fixing an issue with bootcycle-i

hg: jdk8/build: 8009988: build-infra: Fix configure output for zip debuginfo check

2013-04-02 Thread ahughes
Changeset: 15c1642967c9 Author:andrew Date: 2013-04-02 13:59 +0100 URL: http://hg.openjdk.java.net/jdk8/build/rev/15c1642967c9 8009988: build-infra: Fix configure output for zip debuginfo check Summary: No output from zip debuginfo option when default is used. Reviewed-by: tbell !

Re: Review Request: 8006828: "SKIP_BOOT_CYCLE=false" must work in new building infrastructure

2013-04-02 Thread Alan Bateman
On 02/04/2013 10:32, Erik Joelsson wrote: On 2013-03-05 16:14, Erik Joelsson wrote: On 2013-02-20 15:20, Erik Joelsson wrote: Adding check for SKIP_BOOT_CYCLE=false in Jprt.gmk which adds the target bootcycle-images. Also fixing an issue with bootcycle-images target that prevented them from c

Re: Review Request: 8006828: "SKIP_BOOT_CYCLE=false" must work in new building infrastructure

2013-04-02 Thread Erik Joelsson
On 2013-03-05 16:14, Erik Joelsson wrote: On 2013-02-20 15:20, Erik Joelsson wrote: Adding check for SKIP_BOOT_CYCLE=false in Jprt.gmk which adds the target bootcycle-images. Also fixing an issue with bootcycle-images target that prevented them from creating images. http://cr.openjdk.java.ne

Re: Support building zero with the new build

2013-04-02 Thread Erik Joelsson
On 2013-03-28 22:13, Omair Majid wrote: Hi, On 03/27/2013 10:05 AM, Roman Kennke wrote: Am Mittwoch, den 27.03.2013, 09:42 -0400 schrieb Omair Majid: Roman, how do you want to proceed? I'd go with Erik's suggestion and keep your part for JDK changes, and mine for the rest, if that is ok wit

Re: A couple of questions about the new build system

2013-04-02 Thread Erik Joelsson
On 2013-03-29 00:00, Phil Race wrote: > If you touch a header fie, the build is supposed to notice and "do the right thing". It did not do so. If I touched a C file, no problem, but not so for the header file. This was observed on Solaris 10 SPARC. I just tried: touch ../../jdk/src/share/

Re: RFR: JDK-8011187 : http://cr.openjdk.java.net/~mduigou/JDK-8011187/0/webrev/

2013-04-02 Thread Chris Hegarty
Looks fine to me too. I remember being confused by these targets before, nice to see this clean up. -Chris On 04/02/2013 08:48 AM, Alan Bateman wrote: On 01/04/2013 21:19, Mike Duigou wrote: Hello all; Another changeset for review in the series "JDK-8009683 Running regression tests with make

Re: RFR: JDK-8011187 : http://cr.openjdk.java.net/~mduigou/JDK-8011187/0/webrev/

2013-04-02 Thread Alan Bateman
On 01/04/2013 21:19, Mike Duigou wrote: Hello all; Another changeset for review in the series "JDK-8009683 Running regression tests with make". Many of the targets in jdk/test/Makefile are currently unused or were never used. These targets will be removed: perftest packtest vmsqe_* jck* I ha