Re: Preserving changeset authorship (was Re: PING: [PATCH] Enable debug info on all libraries for OpenJDK builds)

2013-05-21 Thread David Holmes
On 22/05/2013 6:47 AM, Andrew Hughes wrote: - Original Message - On 16/05/2013 1:31 AM, Andrew Hughes wrote: - Original Message - On 11/05/2013 2:53 AM, Andrew Hughes wrote: I have offered a very simple solution to that problem to which no-one has yet given any reason as to w

Re: BUILD_JOBJC woes on Mac

2013-05-21 Thread David Holmes
On 21/05/2013 9:50 PM, Erik Joelsson wrote: Looks good to me. So has a bug been filed yet? :) I think some further investigation is still needed because gensrc_jobjc is being used in some places and not others and I'd want to verify they are all supposed to be the same thing. David /Erik

Re: Windows configure "issues"

2013-05-21 Thread Mario Torre
I fully agree with this point of view. I don't think that this conflict with the idea of a wiki companion, this can be done and surely would be of help, but copy-paste instructions should be with the code. I also think that since we need to keep in sync the readme with the wiki, the problem with t

Re: Windows configure "issues"

2013-05-21 Thread mark . reinhold
2013/5/21 6:54 -0700, gnu.and...@redhat.com: >> On 05/21/2013 04:55 PM, Volker Simonis wrote: >>> I always felt that having the build instructions checked in into the >>> repository is somewhat to heavyweight. >> >> There are two good reasons to do this. >> >> Firstly, it's a free software tradit

Re: Windows configure "issues"

2013-05-21 Thread Andrew Hughes
- Original Message - > On Tue, May 21, 2013 at 9:00 PM, Andrew Haley wrote: > > > On 05/21/2013 04:55 PM, Volker Simonis wrote: > > > > > I always felt that having the build instructions checked in into the > > > repository is somewhat to heavyweight. > > > > There are two good reasons to

hg: jdk8/build/hotspot: 46 new changesets

2013-05-21 Thread david . katleman
Changeset: 6114c49b31b5 Author:amurillo Date: 2013-05-10 11:27 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/6114c49b31b5 8014279: new hotspot build - hs25-b33 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 712a1e9c91f3 Author:coleenp Date: 2013-05-

Re: Preserving changeset authorship (was Re: PING: [PATCH] Enable debug info on all libraries for OpenJDK builds)

2013-05-21 Thread Dalibor Topic
On 5/21/13 10:47 PM, Andrew Hughes wrote: > Why do they need to be run through jprt twice? > > external repo -> jprt -> hotspot-main > > seems sufficient to me. For the same reason jdk8-external wouldn't work. That's not how the flow of changes is set up to go - it's from the lowest rung upward

Re: Windows configure "issues"

2013-05-21 Thread Andrew Hughes
- Original Message - > On 05/21/2013 04:55 PM, Volker Simonis wrote: > > > I always felt that having the build instructions checked in into the > > repository is somewhat to heavyweight. > > There are two good reasons to do this. > > Firstly, it's a free software tradition: I expect to f

Re: Disable overrides during jdk build

2013-05-21 Thread Andrew Hughes
- Original Message - > On 13/05/2013 15:24, Maurizio Cimadamore wrote: > > I think it makes sense, esp. if the messages appear to be redundant. The > > compiler logic is very strict and there are cases where it comes down to > > guessing user intent and compilers are notoriously bad at doin

Re: Preserving changeset authorship (was Re: PING: [PATCH] Enable debug info on all libraries for OpenJDK builds)

2013-05-21 Thread Andrew Hughes
- Original Message - > On 16/05/2013 1:31 AM, Andrew Hughes wrote: > > - Original Message - > >> On 11/05/2013 2:53 AM, Andrew Hughes wrote: > >> > >>> I have offered a very simple solution to that problem to which no-one has > >>> yet > >>> given any reason as to why we should not

hg: jdk8/build/nashorn: 19 new changesets

2013-05-21 Thread david . katleman
Changeset: 4ce88eec5078 Author:katleman Date: 2013-05-16 12:16 -0700 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/4ce88eec5078 Added tag jdk8-b90 for changeset 67ca019e3713 ! .hgtags Changeset: b754fb89367d Author:jlaskey Date: 2013-04-30 10:05 -0300 URL:

hg: jdk8/build/langtools: 45 new changesets

2013-05-21 Thread david . katleman
Changeset: 9717b9523d46 Author:katleman Date: 2013-05-16 12:16 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/9717b9523d46 Added tag jdk8-b90 for changeset e19283cd30a4 ! .hgtags Changeset: abd153854f16 Author:jjg Date: 2013-05-03 09:56 -0700 URL: ht

hg: jdk8/build/jaxp: 8 new changesets

2013-05-21 Thread david . katleman
Changeset: f39d61028d2f Author:katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/f39d61028d2f Added tag jdk8-b90 for changeset 668acc0e1034 ! .hgtags Changeset: 452e1a182907 Author:dfuchs Date: 2013-05-06 18:50 +0200 URL: http

hg: jdk8/build/jaxws: Added tag jdk8-b90 for changeset 3e5b9ea5ac35

2013-05-21 Thread david . katleman
Changeset: 0bb1a9fa56b0 Author:katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/0bb1a9fa56b0 Added tag jdk8-b90 for changeset 3e5b9ea5ac35 ! .hgtags

hg: jdk8/build/hotspot: Added tag jdk8-b90 for changeset 1ae0472ff3a0

2013-05-21 Thread david . katleman
Changeset: 1cdbd42c3e49 Author:katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/1cdbd42c3e49 Added tag jdk8-b90 for changeset 1ae0472ff3a0 ! .hgtags

hg: jdk8/build: 5 new changesets

2013-05-21 Thread david . katleman
Changeset: 83b519cafa68 Author:katleman Date: 2013-05-16 12:13 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/83b519cafa68 Added tag jdk8-b90 for changeset 69b773a221b9 ! .hgtags Changeset: e2eb6bc06621 Author:mduigou Date: 2013-05-08 21:42 -0700 URL: http://h

hg: jdk8/build/corba: Added tag jdk8-b90 for changeset c8286839d0df

2013-05-21 Thread david . katleman
Changeset: 8f7ffb296385 Author:katleman Date: 2013-05-16 12:14 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/8f7ffb296385 Added tag jdk8-b90 for changeset c8286839d0df ! .hgtags

Re: Windows configure "issues"

2013-05-21 Thread Volker Simonis
On Tue, May 21, 2013 at 9:00 PM, Andrew Haley wrote: > On 05/21/2013 04:55 PM, Volker Simonis wrote: > > > I always felt that having the build instructions checked in into the > > repository is somewhat to heavyweight. > > There are two good reasons to do this. > > Firstly, it's a free software t

Re: MacOS build tool selections for JDK8

2013-05-21 Thread David DeHaven
>>> JPRT as far as I know only uses 10.7 systems for builds. The 10.8 systems >>> can only be used for testing. >> Since we have added the compiler and link args described earlier in this >> thread to jdk8 makefiles, I believe we have enabled 10.8 for building jdk8 >> too now. At least we inten

Re: Windows configure "issues"

2013-05-21 Thread Andrew Haley
On 05/21/2013 04:55 PM, Volker Simonis wrote: > I always felt that having the build instructions checked in into the > repository is somewhat to heavyweight. There are two good reasons to do this. Firstly, it's a free software tradition: I expect to find a README with build instructions in the r

[PATCH] Provide debugging information for programs

2013-05-21 Thread Andrew Hughes
Hi all, The following webrevs: Root: http://cr.openjdk.java.net/~andrew/build/debugging/webrev.02/ JDK: http://cr.openjdk.java.net/~andrew/build/debugging/webrev.03/ 1. Enable debugging on programs for OpenJDK builds (unclear why this is disabled; the comment says "Programs don't get the debug

Re: MacOS build tool selections for JDK8

2013-05-21 Thread Kelly O'Hair
On May 21, 2013, at 2:18 AM, Erik Joelsson wrote: >> JPRT as far as I know only uses 10.7 systems for builds. The 10.8 systems >> can only be used for testing. > Since we have added the compiler and link args described earlier in this > thread to jdk8 makefiles, I believe we have enabled 10.8 f

hg: jdk8/build: 8014508: Fix log levels in make

2013-05-21 Thread erik . joelsson
Changeset: eea249c1ecee Author:erikj Date: 2013-05-21 13:18 +0200 URL: http://hg.openjdk.java.net/jdk8/build/rev/eea249c1ecee 8014508: Fix log levels in make Reviewed-by: tbell ! NewMakefile.gmk ! common/autoconf/spec.gmk.in

hg: jdk8/build/jdk: 8011346: build-infra: While Constructing Javadoc information, JSpinner.java error: package sun.util.locale.provider does not exist

2013-05-21 Thread erik . joelsson
Changeset: 2868607646a0 Author:erikj Date: 2013-05-21 17:02 +0200 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/2868607646a0 8011346: build-infra: While Constructing Javadoc information, JSpinner.java error: package sun.util.locale.provider does not exist Reviewed-by: dholmes,

Re: RFR: 8014970: Use open man pages when DISABLE_COMMERCIAL_FEATURES=true

2013-05-21 Thread Tim Bell
On 05/21/13 08:30 AM, Omair Majid wrote: On 05/21/2013 10:22 AM, Erik Joelsson wrote: Open part of this review. Moving logic for choosing open or oracle man pages to closed makefile. http://cr.openjdk.java.net/~erikj/8014970/webrev.jdk.01/ Looks okay to me. Cheers, Omair Looks good to me as

Re: RFR: 8014970: Use open man pages when DISABLE_COMMERCIAL_FEATURES=true

2013-05-21 Thread Omair Majid
On 05/21/2013 10:22 AM, Erik Joelsson wrote: > Open part of this review. Moving logic for choosing open or oracle man > pages to closed makefile. > > http://cr.openjdk.java.net/~erikj/8014970/webrev.jdk.01/ Looks okay to me. Cheers, Omair -- PGP Key: 66484681 (http://pgp.mit.edu/) Fingerprint

Re: Windows configure "issues"

2013-05-21 Thread Kelly O'Hair
A voice from the past rings out through the forests of repositories, squirting ancient wisdom into the clouds... ;^) Yes, yes, I have indeed gone insane. ;^) The intent with the README-build.html document was as a purely "OpenJDK" document, there should be no "Oracle specific" instructions

Re: Windows configure "issues"

2013-05-21 Thread Volker Simonis
On Tue, May 21, 2013 at 12:43 PM, David Chase wrote: > I saw that and tried that, but it declared that "you must be Administrator > to install this". I thought I was, I as installing all sorts of other > software, but no go. I found your instructions, but they weren't > Oracle-sourced instructio

RFR: 8014970: Use open man pages when DISABLE_COMMERCIAL_FEATURES=true

2013-05-21 Thread Erik Joelsson
Open part of this review. Moving logic for choosing open or oracle man pages to closed makefile. http://cr.openjdk.java.net/~erikj/8014970/webrev.jdk.01/ /Erik

Re: BUILD_JOBJC woes on Mac

2013-05-21 Thread Erik Joelsson
Looks good to me. /Erik On 2013-05-21 13:30, Alan Bateman wrote: On 21/05/2013 10:53, Erik Joelsson wrote: In the old build, JObjC.jar was built completely differently from all other java classes, by an ant script. We kept the source/target 1.5 when converting to the new build to keep the bui

Re: BUILD_JOBJC woes on Mac

2013-05-21 Thread Alan Bateman
On 21/05/2013 10:53, Erik Joelsson wrote: In the old build, JObjC.jar was built completely differently from all other java classes, by an ant script. We kept the source/target 1.5 when converting to the new build to keep the builds equal. I very much doubt there is a reason for it now though. I

Re: BUILD_JOBJC woes on Mac

2013-05-21 Thread David Holmes
On 21/05/2013 7:53 PM, Erik Joelsson wrote: In the old build, JObjC.jar was built completely differently from all other java classes, by an ant script. We kept the source/target 1.5 when converting to the new build to keep the builds equal. I very much doubt there is a reason for it now though. I

Re: Windows configure "issues"

2013-05-21 Thread David Chase
I saw that and tried that, but it declared that "you must be Administrator to install this". I thought I was, I as installing all sorts of other software, but no go. I found your instructions, but they weren't Oracle-sourced instructions, so it seemed like it was not my problem. This is not j

Re: BUILD_JOBJC woes on Mac

2013-05-21 Thread Erik Joelsson
In the old build, JObjC.jar was built completely differently from all other java classes, by an ant script. We kept the source/target 1.5 when converting to the new build to keep the builds equal. I very much doubt there is a reason for it now though. It looks like left over legacy to me. The

Re: Windows configure "issues"

2013-05-21 Thread Erik Joelsson
On 2013-05-21 11:44, Erik Joelsson wrote: On 2013-05-19 22:58, David Chase wrote: This is for Windows 7, following instructions, mostly vanilla. I restarted after all the various installations. I'm "following" the instructions at http://hg.openjdk.java.net/jdk8/jdk8/raw-file/tip/README-buil

Re: Windows configure "issues"

2013-05-21 Thread Erik Joelsson
On 2013-05-19 22:58, David Chase wrote: This is for Windows 7, following instructions, mostly vanilla. I restarted after all the various installations. I'm "following" the instructions at http://hg.openjdk.java.net/jdk8/jdk8/raw-file/tip/README-builds.html The non-vanilla step, inspired by th

Re: MacOS build tool selections for JDK8

2013-05-21 Thread Erik Joelsson
On 2013-05-16 06:18, David Holmes wrote: On 16/05/2013 10:22 AM, David Katleman wrote: On 5/13/2013 8:59 AM, David DeHaven wrote: If it were my choice, Mac OS X 10.8 would be the base OS with Xcode 4.6.1 (current) with clang as the officially supported compiler and with an option to use gcc.

Re: BUILD_JOBJC woes on Mac

2013-05-21 Thread Alan Bateman
On 21/05/2013 08:36, David Holmes wrote: While that is probably true, it seems to me that the cause of the problem here is that the javac source path includes /u/alanb/ws/tl/build/macosx-x86_64-normal-server-release/jdk/gensrc - and that seems wrong to me. It comes from CompileJavaClasses.gm

Re: Windows configure "issues"

2013-05-21 Thread Volker Simonis
As you noticed, Visual Studio Express only contains the 32-bit Compiler. You have to download and install the "Windows SDK for Windows 7 and .NET Framework 4" from http://www.microsoft.com/download/en/details.aspx?id=8279to get the 64-bit compiler (this will also install the IA64 cross compiler jus

Re: Why is CUPS required?

2013-05-21 Thread Volker Simonis
Hi Victor, actually you only need the CUPS headers, so the dependencies on CUPS are really not a big problem, even on exotic platforms. Just download and unpack cups (e.g. http://www.cups.org/software.php?VERSION=1.6.2&FILE=1.6.1/cups-1.6.1-source.tar.gz) unpack it, create a symlink in the created

Re: BUILD_JOBJC woes on Mac

2013-05-21 Thread David Holmes
On 21/05/2013 5:15 PM, Alan Bateman wrote: On 21/05/2013 06:00, David Holmes wrote: Hi Alan, That log looks correct to me. can you verify if the missing types are indeed within: /u/alanb/ws/jdk7u-dev/build/macosx-x86_64/j2sdk-image/jre/lib/rt.jar ? David That's the boot JDK so it isn't goi

Re: BUILD_JOBJC woes on Mac

2013-05-21 Thread Alan Bateman
On 21/05/2013 06:00, David Holmes wrote: Hi Alan, That log looks correct to me. can you verify if the missing types are indeed within: /u/alanb/ws/jdk7u-dev/build/macosx-x86_64/j2sdk-image/jre/lib/rt.jar ? David That's the boot JDK so it isn't going to have types that are new in jdk8. So