Re: [8] Review Request for 8007292 : Add JavaFX internal packages to package.access

Hi Sean, Not a full review. On 9/10/2013 5:52 AM, Sean Mullan wrote: Please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8007292 This bug requires build changes and a new build tool to add additional restricted packages to the java.security file which are

Re: Review Request: 8014742: Port "Server JRE" to JDK 8

I know of some people who might object to the removal of AccessBridge from the server JDK, but besides that the changes look reasonable. The bug title says JRE but a JDK is built (minus src.zip)--is it intended to be JDK or JRE distribution? Mike On Oct 8 2013, at 15:49 , Amy Wang wrote: > H

Re: code review round 0 for Full Debug Symbols on MacOS X hotspot (7165611)

Sorry for the delay in getting back to this. I've been side tracked by other tasks. I've made all the changes needed to address most of the comments below, but I still have to double check and test... On 10/1/13 8:52 PM, David Holmes wrote: Hi Dan, Overall thumbs up. Thanks! A couple of

Review Request: 8014742: Port "Server JRE" to JDK 8

Hi, All, Please help review the following changes for the bug 8014742: Port "Server JRE" to JDK 8 The changes are at http://cr.openjdk.java.net/~katleman/8014742/webrev.root.01 http://cr.openjdk.java.net/~katleman/8014742/webrev.jdk.01 Thank you! Amy

hg: jdk8/build/hotspot: 43 new changesets

Changeset: 24250c363d7f Author:amurillo Date: 2013-09-26 13:41 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/24250c363d7f 8025536: new hotspot build - hs25-b53 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 899ecf76b570 Author:dsimms Date: 2013-09-2

hg: jdk8/build/langtools: Added tag jdk8-b110 for changeset 41541097533a

Changeset: af6244ba81b6 Author:katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/langtools/rev/af6244ba81b6 Added tag jdk8-b110 for changeset 41541097533a ! .hgtags

hg: jdk8/build/nashorn: Added tag jdk8-b110 for changeset d49a8c2173f5

Changeset: 75fd3486e584 Author:katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/nashorn/rev/75fd3486e584 Added tag jdk8-b110 for changeset d49a8c2173f5 ! .hgtags

hg: jdk8/build/jdk: 2 new changesets

Changeset: 9f57d2774603 Author:katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/9f57d2774603 Added tag jdk8-b110 for changeset 54e099776f08 ! .hgtags Changeset: 719befd87c7b Author:katleman Date: 2013-10-08 13:10 -0700 URL: ht

hg: jdk8/build/jaxp: Added tag jdk8-b110 for changeset 4c84c5b447b0

Changeset: 17ee0d3e97fd Author:katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxp/rev/17ee0d3e97fd Added tag jdk8-b110 for changeset 4c84c5b447b0 ! .hgtags

hg: jdk8/build/jaxws: Added tag jdk8-b110 for changeset cc682329886b

Changeset: 32edc7a2c866 Author:katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jaxws/rev/32edc7a2c866 Added tag jdk8-b110 for changeset cc682329886b ! .hgtags

hg: jdk8/build/corba: Added tag jdk8-b110 for changeset 3d2b7ce93c5c

Changeset: 85c1c94e7235 Author:katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/85c1c94e7235 Added tag jdk8-b110 for changeset 3d2b7ce93c5c ! .hgtags

hg: jdk8/build/hotspot: Added tag jdk8-b110 for changeset 6209b0ed51c0

Changeset: ebfa5793d349 Author:katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/hotspot/rev/ebfa5793d349 Added tag jdk8-b110 for changeset 6209b0ed51c0 ! .hgtags

hg: jdk8/build: 2 new changesets

Changeset: 669e3e3d4459 Author:katleman Date: 2013-10-02 13:26 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/669e3e3d4459 Added tag jdk8-b110 for changeset 4faa09c7fe55 ! .hgtags Changeset: d086227bfc45 Author:katleman Date: 2013-10-08 13:09 -0700 URL: http:/

[8] Review Request for 8007292 : Add JavaFX internal packages to package.access

Please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8007292 This bug requires build changes and a new build tool to add additional restricted packages to the java.security file which are not part of OpenJDK. These packages are only added when doing a build i

RE: Code conventions for the build system

I have not experimented with RECIPEPREFIX. I have tried other workarounds. I've modified make to recognize 8 spaces as equivalent to a tab. I think there was only one place in all of JDK 7 where a non-rule line got confused with a rule. I'm now trying to use an alternate character for a tab

Re: RFR: JDK-8001931 The new build system whitespace cleanup

I found a couple of more places with the same issue, all in the jdk repository. New webrev for jdk: http://cr.openjdk.java.net/~ihse/JDK-8001931-build-infra-whitespace-cleanup/jdk/webrev.02 Webrev showing diff between this and previous webrev: http://cr.openjdk.java.net/~ihse/JDK-8001931-bui

Re: Code conventions for the build system

On 2013-10-08 14:08, Salter, Thomas A wrote: Was there any thought given to using this GNU Make feature to get rid of significant tab characters, or is it not even possible in all the supported build environments? Some of the legacy systems I deal with don't handle tab characters well. From:

Re: RFR: JDK-8001931 The new build system whitespace cleanup

Resending, since it seems to have disappeared on the way. Sorry if it reaches you twice. On 2013-10-08 11:53, Volker Simonis wrote: I've just started looking into this, but if I understand point 5: 5) Non-shell commands in a recipe (e.g. comments and make directives like ifdef) must not start

Re: Code conventions for the build system

Was there any thought given to using this GNU Make feature to get rid of significant tab characters, or is it not even possible in all the supported build environments? Some of the legacy systems I deal with don't handle tab characters well. From: http://www.gnu.org/software/make/manual/make.h

Re: RFR (S): JDK-8025921 Make LOG=debug output more readable

On 2013-10-07 17:52, Erik Joelsson wrote: Unfortunately, the patch failed when I tried submitting it. Usage of the ListPathsSafely macro in SetupArchive is a bit different and needs to be adjusted. Here is a webrev that I have verified to work: http://cr.openjdk.java.net/~erikj/8025921/webrev.

Re: RFR JDK-8025920 webrev.ksh does not provide any details about changes in zip files

Thanks for the review. The fix was pushed to jkd8/build repo. See: On 7 Oct 2013, at 23:57, Mike Duigou wrote: > Looks good to me. Thanks for this contribution! > > Mike > > On Oct 4 2013, at 07:49 , Tomas Hurka wrote: > >> Hi Kumar, >>

Re: RFR: JDK-8001931 The new build system whitespace cleanup

Hi, First of all just a little hint to other reviewers - only the "patch"-view really shows all the changes. All the other views (Cdiffs, Udiffs, Sdiffs, Frames) show much less and are sometimes even empty! I've just started looking into this, but if I understand point 5: 5) Non-shell commands i

Re: Code conventions for the build system

Hi Magnus, great work! I completely agree with all points and especially like the indentation level of two spaces:) Thanks, Volker On Tue, Oct 8, 2013 at 9:40 AM, Magnus Ihse Bursie wrote: > Whitespace and indentation in makefiles is a more problematic area than for > other languages. Even whi

RFR: JDK-8001931 The new build system whitespace cleanup

Based on the code conventions posted earlier, Erik and I have made a complete overhaul on the use of whitespace and indentation in the new build system. We set up an important limitation on this change: *only* whitespace should be changed. This self-imposed limitation helped us verify that no

Code conventions for the build system

Whitespace and indentation in makefiles is a more problematic area than for other languages. Even while most of the time whitespace is not significant, sometimes is is. This might be considered a design flaw in make, but that's not something we can do anything about. In particular, initial tabs