Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread David Holmes
Hi Roman, Commenting on the hotspot changes ... On 8/01/2015 9:01 PM, Roman Kennke wrote: Hi Erik, I'm CC-ing hotspot-dev for review of Hotspot code related changes. Yes, some additional changes to Hotspot are required. This is the full set of changes needed to build and run Shark:

Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread David Holmes
On 8/01/2015 9:05 PM, Roman Kennke wrote: Oh and notice that if you try to build it yourself, use a version of LLVM 3.5. In 3.5, C++11 is used/required, and OpenJDK doesn't support C++11 yet. (are there any plans about this?) I'd recommend LLVM 3.4.2. C++11? We still have workarounds for

Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread Roman Kennke
Am Donnerstag, den 08.01.2015 um 21:20 +1000 schrieb David Holmes: On 8/01/2015 9:05 PM, Roman Kennke wrote: Oh and notice that if you try to build it yourself, use a version of LLVM 3.5. In 3.5, C++11 is used/required, and OpenJDK doesn't support C++11 yet. (are there any plans about

Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread Erik Joelsson
Hello Roman, Thanks for the full patch! I discovered a problem with the top repo patch. When autoconf (using m4) evaluates your change, the brackets disappear. To fix this, more brackets need to be added. Here is a version that works for me that will make the correct sed expression appear in

Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread Andrew Haley
On 01/08/2015 11:38 AM, Erik Joelsson wrote: Hello Roman, Thanks for the full patch! I discovered a problem with the top repo patch. When autoconf (using m4) evaluates your change, the brackets disappear. To fix this, more brackets need to be added. Here is a version that works for me

Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread Andrew Haley
On 01/08/2015 11:31 AM, Roman Kennke wrote: I guess for my purposes it's good enough to pass some GCC flag to turn on C++11 support, so that the new LLVM headers can be used. That's all that I need. But does that work without further changes? Andrew.

Re: RFR 8068650: https://bugs.openjdk.java.net/browse/JDK-8068650

2015-01-08 Thread Jim Laskey (Oracle)
+1 On Jan 8, 2015, at 2:52 AM, A. Sundararajan sundararajan.athijegannat...@oracle.com wrote: Hi, Please review http://cr.openjdk.java.net/~sundar/8068650/ for https://bugs.openjdk.java.net/browse/JDK-8068650 This issue was caused by another makefile fix to generate docs for nashorn.

Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread Erik Joelsson
Hello Roman, This addition looks good to me. Thinking about what the others said, it might be inconvenient to have all this be pushed to different forests. I tried applying all the changes to jdk9/hs-rt, but I can't seem to build zeroshark.. Did you have more hotspot changes to be able to

Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread Roman Kennke
Hi Erik, I'm CC-ing hotspot-dev for review of Hotspot code related changes. Yes, some additional changes to Hotspot are required. This is the full set of changes needed to build and run Shark: http://cr.openjdk.java.net/~rkennke/shark-build-hotspot/webrev.01/ In detail: - In the Makefile fix

Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread Roman Kennke
Oh and notice that if you try to build it yourself, use a version of LLVM 3.5. In 3.5, C++11 is used/required, and OpenJDK doesn't support C++11 yet. (are there any plans about this?) I'd recommend LLVM 3.4.2. Roman Am Donnerstag, den 08.01.2015 um 11:03 +0100 schrieb Erik Joelsson: Hello

Re: [PATCH] Fix Shark build in JDK9

2015-01-08 Thread Erik Joelsson
On 2015-01-08 12:54, Andrew Haley wrote: On 01/08/2015 11:38 AM, Erik Joelsson wrote: I tried building locally (Ubuntu 14.04 with llvm 3.4) but it failed with undefined references at link time: /usr/lib/llvm-3.4/lib/libLLVMSupport.a(Process.o): In function

Re: RFR 8068650: https://bugs.openjdk.java.net/browse/JDK-8068650

2015-01-08 Thread Erik Joelsson
Looks good to me. /Erik On 2015-01-08 07:52, A. Sundararajan wrote: Hi, Please review http://cr.openjdk.java.net/~sundar/8068650/ for https://bugs.openjdk.java.net/browse/JDK-8068650 This issue was caused by another makefile fix to generate docs for nashorn. I'm cc'ing nashorn-dev and

RFR: JDK-8042707: Source changes needed to build JDK 9 with Visual Studio 2013 (VS2013)

2015-01-08 Thread Erik Joelsson
Hello, Please review this patch, which adds support for building with different versions of Visual Studio and in particular adds support for VS2013. In order to control which version to use, I've introduced a new configure parameter --with-toolchain-version. On windows, this parameter will

Re: Building openjdk 8 on Mac OS X

2015-01-08 Thread David DeHaven
Yes, I just found this out the hard way yesterday (and many other patches are required too). Is there any chance OS X fixes can make it upstream? This basically requires backporting JDK-8043340 to jdk8u, which I've been poking at here and there but have not had the time to really