Request for guidance on using possible future sets of javac options

2015-02-05 Thread Joseph D. Darcy
Hello, As a continuation of the warnings effort, I'd like to see doclint checking selectively enabled during the main build of the Java sources in the jdk repo by javac. As the name implies, the javac "-Xdoclint" argument enables structural checking of javadoc comments by javac. For the java

Re: README-builds.html update

2015-02-05 Thread Omair Majid
* Magnus Ihse Bursie [2015-02-03 08:48]: > In a somewhat related area: I've been toying with the idea of rewriting the > build-readme in markdown instead, and just generate the html file. Updating > proper, consistent html formatting for a document like this is quite > painful, and we never seem t

Re: RFR: JDK-8062223: Upgrading to ccache 1.3.10 disables the use of ccache

2015-02-05 Thread Erik Joelsson
On 2015-01-30 12:01, Magnus Ihse Bursie wrote: On 2015-01-30 11:51, Erik Joelsson wrote: Hello, New webrev: http://cr.openjdk.java.net/~erikj/8062223/webrev.root.02/ Fixed the anti pattern. Sort of. :-) You still ignore the flag silently if it is not supported. I would prefer if a AC_MSG_W

Re: RFR: JDK-8072106 Properly handle dependencies for deleted header files

2015-02-05 Thread Erik Joelsson
Looks good to me, but if it's possible, please split that huge echo line. Adding a $$(strip ) will likely remove any extra white space introduced by the split and indentation. /Erik On 2015-02-04 13:23, Magnus Ihse Bursie wrote: On 2015-02-04 02:28, David Holmes wrote: On 3/02/2015 11:25 PM,

Re: RFR: JDK-8072107: New dependency introduced by deploy.dll and awt.dll (msvcp100.dll)

2015-02-05 Thread Magnus Ihse Bursie
On 2015-02-05 11:54, Erik Joelsson wrote: Hello, Please review this small fix for a big problem. In JDK-8042707, I tired, but apparently failed, to keep the build functioning with VS2010 just like before. The mistake affecting awt.dll was a misspelled variable in flags.m4. I have built with t

RFR: JDK-8072107: New dependency introduced by deploy.dll and awt.dll (msvcp100.dll)

2015-02-05 Thread Erik Joelsson
Hello, Please review this small fix for a big problem. In JDK-8042707, I tired, but apparently failed, to keep the build functioning with VS2010 just like before. The mistake affecting awt.dll was a misspelled variable in flags.m4. I have built with this change and verified that msvcp100.dll

Re: RFR: 8072116: [Solaris] : Fix for 8071710 needs to be updated for build dependency checking

2015-02-05 Thread Magnus Ihse Bursie
On 2015-02-04 22:16, Phil Race wrote: Was there an implicit nod that the 8 fix was OK if I updated it as below, or was my reply too buried in the email for anyone to notice the update. Sorry, I missed it. Looks good. Thank you for sorting out this mess! /Magnus The updated 8 fix is (as previ