Re: Unused DEBUG_CLASSFILES variable in makefiles

2015-02-11 Thread Omair Majid
Hi, * Omair Majid [2014-11-18 11:57]: > * Magnus Ihse Bursie [2014-10-13 07:49]: > > On 2014-10-13 10:57, Erik Joelsson wrote: > > >I think it's still used by the hotspot makefiles (sa-jdi.jar). Seems weird > > >that we still set it in configure but then ignore the value in the jdk > > >build. I

Re: RFR: JDK-8072904: building jdk9 with jdk9 boot jdk can cause failure or incorrect results

2015-02-11 Thread David Holmes
On 11/02/2015 9:35 PM, Erik Joelsson wrote: Hello, New webrev: http://cr.openjdk.java.net/~erikj/8072904/webrev.hotspot.02/ On 2015-02-11 10:53, David Holmes wrote: Hi Erik, On 11/02/2015 7:23 PM, Erik Joelsson wrote: Hello, Please review this change to how javah is run on sa classes. Since

Re: Build jdk9 on os x, No compiler1

2015-02-11 Thread Mihail Stoynov
Hello Magnus, David, Step 1 and 2 failed, step 3 succeeded, thank you. Mihail Bulgarian JUG On Wed, Feb 11, 2015 at 10:25 AM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > On 2015-02-11 01:35, David Holmes wrote: > >> On 11/02/2015 4:43 AM, Mihail Stoynov wrote: >> >>> Hi, >>> I'm

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-11 Thread Staffan Larsen
> On 11 feb 2015, at 12:15, David Holmes wrote: > > On 11/02/2015 8:36 PM, Staffan Larsen wrote: >> >>> On 11 feb 2015, at 09:39, David Holmes wrote: >>> >>> On 11/02/2015 6:34 PM, Staffan Larsen wrote: > On 11 feb 2015, at 09:27, Magnus Ihse Bursie > mailto:magnus.ihse.bur...@o

Re: RFR: JDK-8072904: building jdk9 with jdk9 boot jdk can cause failure or incorrect results

2015-02-11 Thread Erik Joelsson
Hello, New webrev: http://cr.openjdk.java.net/~erikj/8072904/webrev.hotspot.02/ On 2015-02-11 10:53, David Holmes wrote: Hi Erik, On 11/02/2015 7:23 PM, Erik Joelsson wrote: Hello, Please review this change to how javah is run on sa classes. Since the sa classes in JDK 9 are now in a module

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-11 Thread David Holmes
On 11/02/2015 8:36 PM, Staffan Larsen wrote: On 11 feb 2015, at 09:39, David Holmes wrote: On 11/02/2015 6:34 PM, Staffan Larsen wrote: On 11 feb 2015, at 09:27, Magnus Ihse Bursie mailto:magnus.ihse.bur...@oracle.com>> wrote: On 2015-02-11 09:23, David Holmes wrote: On 11/02/2015 6:09 P

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-11 Thread Staffan Larsen
> On 11 feb 2015, at 09:39, David Holmes wrote: > > On 11/02/2015 6:34 PM, Staffan Larsen wrote: >> >>> On 11 feb 2015, at 09:27, Magnus Ihse Bursie >>> mailto:magnus.ihse.bur...@oracle.com>> >>> wrote: >>> >>> On 2015-02-11 09:23, David Holmes wrote: On 11/02/2015 6:09 PM, Magnus Ihse Bu

Re: RFR: JDK-8072904: building jdk9 with jdk9 boot jdk can cause failure or incorrect results

2015-02-11 Thread David Holmes
Hi Erik, On 11/02/2015 7:23 PM, Erik Joelsson wrote: Hello, Please review this change to how javah is run on sa classes. Since the sa classes in JDK 9 are now in a module instead of sa-jdi.jar, they are (at least currently) available from the default bootclasspath. This means that just setting

RFR: JDK-8072904: building jdk9 with jdk9 boot jdk can cause failure or incorrect results

2015-02-11 Thread Erik Joelsson
Hello, Please review this change to how javah is run on sa classes. Since the sa classes in JDK 9 are now in a module instead of sa-jdi.jar, they are (at least currently) available from the default bootclasspath. This means that just setting -classpath to javah will not properly override the

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-11 Thread David Holmes
On 11/02/2015 6:34 PM, Staffan Larsen wrote: On 11 feb 2015, at 09:27, Magnus Ihse Bursie mailto:magnus.ihse.bur...@oracle.com>> wrote: On 2015-02-11 09:23, David Holmes wrote: On 11/02/2015 6:09 PM, Magnus Ihse Bursie wrote: On 2015-02-11 02:35, David Holmes wrote: Hi Magnus, On 11/02/201

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-11 Thread Staffan Larsen
> On 11 feb 2015, at 09:27, Magnus Ihse Bursie > wrote: > > On 2015-02-11 09:23, David Holmes wrote: >> On 11/02/2015 6:09 PM, Magnus Ihse Bursie wrote: >>> On 2015-02-11 02:35, David Holmes wrote: Hi Magnus, On 11/02/2015 12:23 AM, Magnus Ihse Bursie wrote: > Here is an add

Re: Correct way to copy os specific files over general shared files

2015-02-11 Thread Erik Joelsson
Hello Sergey, Yes, for files being copied with the COPY directive to SetupJavaCompilation (which is what you describe), it will automatically pick the most specific file found. The order is defined by the order the src root directories are defined. Basically gensrc>os>ostype>shared (with clos

Re: [9] Review Request: 8072665 SoundLibraries.gmk and SoundDefs.h: remove isSigned8() dead code

2015-02-11 Thread Magnus Ihse Bursie
On 2015-02-09 17:19, Erik Joelsson wrote: Hello, Build change looks good to me. Nice to see this big chunk logic removed. Build change looks good to me too. /Magnus

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-11 Thread Magnus Ihse Bursie
On 2015-02-11 09:23, David Holmes wrote: On 11/02/2015 6:09 PM, Magnus Ihse Bursie wrote: On 2015-02-11 02:35, David Holmes wrote: Hi Magnus, On 11/02/2015 12:23 AM, Magnus Ihse Bursie wrote: Here is an addition to the build system, that will compile native libraries and executables and make

Re: Build jdk9 on os x, No compiler1

2015-02-11 Thread Magnus Ihse Bursie
On 2015-02-11 01:35, David Holmes wrote: On 11/02/2015 4:43 AM, Mihail Stoynov wrote: Hi, I'm trying to build jdk9 on osx, without any customizations: $ hg clone http://hg.openjdk.java.net/jdk9/dev jdk9.hg $ cd jdk9.hg $ chmod u+x get_source.sh $ ./get_source.sh $ chmod u+x configure $ ./con

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-11 Thread David Holmes
On 11/02/2015 6:09 PM, Magnus Ihse Bursie wrote: On 2015-02-11 02:35, David Holmes wrote: Hi Magnus, On 11/02/2015 12:23 AM, Magnus Ihse Bursie wrote: Here is an addition to the build system, that will compile native libraries and executables and make them available for JTReg tests written in

Re: RFR: JDK-8072842 Add support for building native JTReg tests

2015-02-11 Thread Magnus Ihse Bursie
On 2015-02-11 02:35, David Holmes wrote: Hi Magnus, On 11/02/2015 12:23 AM, Magnus Ihse Bursie wrote: Here is an addition to the build system, that will compile native libraries and executables and make them available for JTReg tests written in Java. Sorry I'm missing the basics here: when do