Thanks, looks good to me now.
/Erik
On 2015-03-26 16:11, Magnus Ihse Bursie wrote:
On 2015-03-26 15:21, Erik Joelsson wrote:
Hello,
This looks like a nice cleanup.
Thanks! :-)
New webrev that hopefully addresses all issues below is here:
http://cr.openjdk.java.net/~ihse/JDK-8076060-improv
On 2015-03-26 15:21, Erik Joelsson wrote:
Hello,
This looks like a nice cleanup.
Thanks! :-)
New webrev that hopefully addresses all issues below is here:
http://cr.openjdk.java.net/~ihse/JDK-8076060-improve-make-bootstrap/webrev.02
Comments inline.
Init.gmk
40: When would topdir not be
Hello,
This looks like a nice cleanup. A couple of questions and notes.
Init.gmk
40: When would topdir not be set?
56, 59, 188, 215: Please break lines if possible
63: What kind of error messages?
192: Why does MAKEOVERRIDES need to be reset? Is it automatically
propagated to submake and we
On 2015-03-25 15:44, Pete Brunet wrote:
On 3/25/15 3:01 AM, Erik Joelsson wrote:
Hello Peter,
The new source layout and Lib-jdk.accessibility.gmk look much better.
Thanks!
Regarding the .def files, I was mistaken and missed that they were
referenced in the LDFLAGS, they were indeed used in th
On 2015-03-25 23:42, David Holmes wrote:
New webrev:
http://cr.openjdk.java.net/~dholmes/8072740/webrev.v2/
This doesn't define the ALT_JVMCFG_SRC in the open file - which makes
more sense for the clean up.
I was unsure if $(wildcard xxx) would behave okay if xxx was an
undefined variable,
The process of actually starting to build the proper targets in Main.gmk
is not straightforward. Somewhat similar to how configure prepares the
ground for make, the initial part of the make logic needs to handle the
make process "bootstrapping".
Unfortunately, this logic has been spread out in
On 26/03/2015 5:57 PM, Erik Joelsson wrote:
Hello David,
This version looks good to me. Regarding wildcard, AFAIK, your usage of
the function is correct. It will just go through the list of strings,
expand them and see if the files exist. For each file that does exist,
it will add it to the retu
Thanks Erik!
David
On 26/03/2015 6:00 PM, Erik Joelsson wrote:
Looks good to me.
/Erik
On 2015-03-26 06:24, David Holmes wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8072740
webrev: http://cr.openjdk.java.net/~dholmes/8072740/webrev.8u/
Simple fix, contributed by Dean Long, that al
Looks good to me.
/Erik
On 2015-03-26 06:24, David Holmes wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8072740
webrev: http://cr.openjdk.java.net/~dholmes/8072740/webrev.8u/
Simple fix, contributed by Dean Long, that allows the jvm.cfg file to
be located in the "closed" location. The
Hello David,
This version looks good to me. Regarding wildcard, AFAIK, your usage of
the function is correct. It will just go through the list of strings,
expand them and see if the files exist. For each file that does exist,
it will add it to the return list. If given an empty list, it will j
10 matches
Mail list logo
