Thanks for reviews everyone!
On 2016-08-09 03:00, David Holmes wrote:
Hi Erik,
On 9/08/2016 2:04 AM, Erik Joelsson wrote:
Hello,
The hotspot native libraries on macosx are currently being packaged as
"universal binaries" (while all other libraries and executables are
not). There seems to be
Hi Erik,
On 9/08/2016 2:04 AM, Erik Joelsson wrote:
Hello,
The hotspot native libraries on macosx are currently being packaged as
"universal binaries" (while all other libraries and executables are
not). There seems to be no point in doing so since we only build for one
architecture anyway. I b
Historical note: During the MacOS X port project, the "universal binaries"
support was removed at one point (I think Jim Melvin did that work) and
I later restored it. There was grumbling in the community about there only
being 64-bit Server VM support for MacOS X in OpenJDK so I restored the
univ
Erik:
The hotspot native libraries on macosx are currently being packaged as
"universal binaries" (while all other libraries and executables are
not). There seems to be no point in doing so since we only build for one
architecture anyway. I believe this is just something that was never
cleaned u
Your changes look good to me.
Thanks.
> On 8 Aug 2016, at 14:46, Weijun Wang wrote:
>
> Please review the code changes at
>
> http://cr.openjdk.java.net/~weijun/8162739/webrev.00/
>
> A new -cacerts option is added to keytool so there is no need to provide the
> full cacerts path on the co
Hello,
The hotspot native libraries on macosx are currently being packaged as
"universal binaries" (while all other libraries and executables are
not). There seems to be no point in doing so since we only build for one
architecture anyway. I believe this is just something that was never
clean
Build change looks fine.
/Erik
On 2016-08-08 15:46, Weijun Wang wrote:
Please review the code changes at
http://cr.openjdk.java.net/~weijun/8162739/webrev.00/
A new -cacerts option is added to keytool so there is no need to
provide the full cacerts path on the command line.
lib/security
Please review the code changes at
http://cr.openjdk.java.net/~weijun/8162739/webrev.00/
A new -cacerts option is added to keytool so there is no need to provide
the full cacerts path on the command line. lib/security/cacerts is
considered an implementation detail and subject to change.
Th
