RE: RFR: JEP draft for Linux/s3990x port

2016-10-04 Thread Lindenmaier, Goetz
Hi Vladimir, This webrev contains all the changes to hotspot needed for the port: http://cr.openjdk.java.net/~goetz/wr16/8166730-linuxs390-all/hotspot.wr01/ It includes http://cr.openjdk.java.net/~goetz/wr16/8166560-basic_s390/hotspot.wr03/ http://cr.openjdk.java.net/~goetz/wr16/8166561-basic_C

Re: RFR: JDK-8150736: Excessive disk space used by build system

2016-10-04 Thread Magnus Ihse Bursie
On 2016-10-04 13:20, Erik Joelsson wrote: New webrev: http://cr.openjdk.java.net/~erikj/8150736/webrev.02/ Looks great. Ship it! :) /Magnus On 2016-10-04 11:03, Magnus Ihse Bursie wrote: On 2016-10-03 10:22, Erik Joelsson wrote: Hello, On 2016-10-01 14:13, David Holmes wrote: Hi Erik,

Re: RFR: JDK-8164120: The minimal VM should be stripped using --strip-unneeded

2016-10-04 Thread Magnus Ihse Bursie
On 2016-10-04 11:30, Erik Joelsson wrote: That was intended but I discovered that the whole thing was wrong. The default strip flag we use on Linux "-g" and the new flag we set for minimal "--strip-unneeded" are the mutually exclusive, so whatever ends up last on the command line wins. Since th

Re: RFR: JDK-8150736: Excessive disk space used by build system

2016-10-04 Thread Erik Joelsson
New webrev: http://cr.openjdk.java.net/~erikj/8150736/webrev.02/ On 2016-10-04 11:03, Magnus Ihse Bursie wrote: On 2016-10-03 10:22, Erik Joelsson wrote: Hello, On 2016-10-01 14:13, David Holmes wrote: Hi Erik, This is a big change that is hard to digest. I assume the actual images themse

Re: RFR: 8166790: Add stress test GCBasher

2016-10-04 Thread Leonid Mesnik
Very nice. Thank you for implementing this. Leonid On 04.10.2016 12:42, Erik Helin wrote: On 2016-09-30, Leonid Mesnik wrote: Hi I think that it would be better to split this test into 4 tests. Currently this test is going to be skipped if any specific GCare set. Or it could even fail if any

Re: RFR: 8166790: Add stress test GCBasher

2016-10-04 Thread Erik Helin
On 2016-09-30, Leonid Mesnik wrote: > Hi > > I think that it would be better to split this test into 4 tests. Currently > this test is going to be skipped if any specific GCare set. Or it could even > fail if any G1 specific options is set without setting G1 explicitly. > > So there is no way to

Re: RFR: JDK-8164120: The minimal VM should be stripped using --strip-unneeded

2016-10-04 Thread Erik Joelsson
That was intended but I discovered that the whole thing was wrong. The default strip flag we use on Linux "-g" and the new flag we set for minimal "--strip-unneeded" are the mutually exclusive, so whatever ends up last on the command line wins. Since the new flag is an override, we should treat

Re: RFR: JDK-8150736: Excessive disk space used by build system

2016-10-04 Thread Magnus Ihse Bursie
On 2016-10-03 10:22, Erik Joelsson wrote: Hello, On 2016-10-01 14:13, David Holmes wrote: Hi Erik, This is a big change that is hard to digest. I assume the actual images themselves are unaffected by this change? I understand that and I have been working on this for some time in the backg

Re: RFR: JDK-8150736: Excessive disk space used by build system

2016-10-04 Thread David Holmes
On 3/10/2016 6:22 PM, Erik Joelsson wrote: Hello, On 2016-10-01 14:13, David Holmes wrote: Hi Erik, This is a big change that is hard to digest. I assume the actual images themselves are unaffected by this change? I understand that and I have been working on this for some time in the backgr

Re: RFR: JDK-8164120: The minimal VM should be stripped using --strip-unneeded

2016-10-04 Thread David Holmes
Hi Erik, On 3/10/2016 11:53 PM, Erik Joelsson wrote: (adding hotspot-dev) On 2016-10-03 15:52, Erik Joelsson wrote: Hello, Please review this small change, which adds --strip-unneeded when stripping the minimal VM on Linux, which reduces size on x86 builds with around 1.2MB. Bug: https://bu

Re: RFR: JDK-8164120: The minimal VM should be stripped using --strip-unneeded

2016-10-04 Thread Magnus Ihse Bursie
On 2016-10-03 15:52, Erik Joelsson wrote: Hello, Please review this small change, which adds --strip-unneeded when stripping the minimal VM on Linux, which reduces size on x86 builds with around 1.2MB. Bug: https://bugs.openjdk.java.net/browse/JDK-8164120 Webrev: http://cr.openjdk.java.net/

Re: RFR: JDK-8166948: Exploded image too slow to be usable

2016-10-04 Thread Magnus Ihse Bursie
On 2016-09-30 16:06, Erik Joelsson wrote: Hello, I missed adding a dependency for the cross compilation case. The change is in Main.gmk, adding the line: + buildtools-modules: create-buildjdk New webrev: http://cr.openjdk.java.net/~erikj/8166948/webrev.02/ Looks good to me. /Magnus

Re: RFR for JDK-8165482 java in ldoms, with cpu-arch=generic has problems

2016-10-04 Thread David Holmes
Hi Martin, On 30/09/2016 8:03 PM, Martin Walsh wrote: On 23/09/2016 14:34, Martin Walsh wrote: On 20/09/2016 08:42, Erik Joelsson wrote: Hello, On 2016-09-20 03:28, David Holmes wrote: Hi Martin, Build changes must be reviewed by the build team - now cc'd Thanks for forwarding David, I c