Re: Building latest jdk9 dev on Mac OS X 10.12.1 - Undefined symbols (_libiconv) causing build to fail?

2016-12-16 Thread Patrick Reinhart
Fantastic, I finally have build again :-) -Patrick > Am 16.12.2016 um 16:12 schrieb Martijn Verburg : > > Hi Michel, > > That helps actually - confirms that it's like my unique set up, a reverse > of the usual WFM! > > Cheers, > Martijn > > On Thu, 15 Dec 2016 at 23:47, Michel Trudeau > wrot

Re: RFR: 8171366 macOS: Do not run failure handler commands that require Developer mode access

2016-12-16 Thread Igor Ignatyev
Looks good to me. Thanks, — Igor > On Dec 16, 2016, at 5:10 PM, Staffan Larsen wrote: > > Good point. New webrev: http://cr.openjdk.java.net/~sla/8171366/webrev.01/ > > > Thanks! > >> On 16 Dec 2016, at 15:05, Erik Joelsson wrote: >> >>

Re: RFR: 8171366 macOS: Do not run failure handler commands that require Developer mode access

2016-12-16 Thread Erik Joelsson
Looks good. /Erik On 2016-12-16 15:10, Staffan Larsen wrote: Good point. New webrev: http://cr.openjdk.java.net/~sla/8171366/webrev.01/ Thanks! On 16 Dec 2016, at 15:05, Erik Joelsson > wrote: I would

Re: Building latest jdk9 dev on Mac OS X 10.12.1 - Undefined symbols (_libiconv) causing build to fail?

2016-12-16 Thread Martijn Verburg
Hi Michel, That helps actually - confirms that it's like my unique set up, a reverse of the usual WFM! Cheers, Martijn On Thu, 15 Dec 2016 at 23:47, Michel Trudeau wrote: > > > > > Just a reference point. > > > > > > I updated to the latest Sierra update and latest Xcode update yesterday > > a

Re: Building latest jdk9 dev on Mac OS X 10.12.1 - Undefined symbols (_libiconv) causing build to fail?

2016-12-16 Thread Martijn Verburg
Hi Phil, Good call! But yes I had done that. It may be down to a potential issue with a macports install of libconv. Nothing like debugging native line for Christmas 🙂. Cheers, Martijn On Thu, 15 Dec 2016 at 23:44, Phil Race wrote: > A complete stab in the dark, but did you install the xcode

Re: RFR: 8171366 macOS: Do not run failure handler commands that require Developer mode access

2016-12-16 Thread Staffan Larsen
Good point. New webrev: http://cr.openjdk.java.net/~sla/8171366/webrev.01/ Thanks! > On 16 Dec 2016, at 15:05, Erik Joelsson wrote: > > I would recommend using the -q flag to grep instead of piping to /dev/null. > Otherwise I think this loo

Re: RFR: 8171366 macOS: Do not run failure handler commands that require Developer mode access

2016-12-16 Thread Erik Joelsson
I would recommend using the -q flag to grep instead of piping to /dev/null. Otherwise I think this looks ok. /Erik On 2016-12-16 14:45, Staffan Larsen wrote: The failure handler (test/failure_handler) runs a number of commands when it detects a timeout in one of the tests. On OS X some of th

RFR: 8171366 macOS: Do not run failure handler commands that require Developer mode access

2016-12-16 Thread Staffan Larsen
The failure handler (test/failure_handler) runs a number of commands when it detects a timeout in one of the tests. On OS X some of these commands require "Developer mode" (like getting a core file). If "Developer mode" is not enabled, the tools will open a modal dialog. This is problematic when

Re: RFR: JDK-8171310: Gtest libjvm.so is always stripped

2016-12-16 Thread Erik Joelsson
On 2016-12-15 21:29, Thomas Stüfe wrote: Short question, how do you generate and apply a webrev patch spanning multiple forest branches? If you have the trees extension, there is a parameter to webrev, "-f" (for forest, historical reasons..) that does this. /Erik