Re: RFR: JDK-8172670: AOT Platform Support for Windows and Mac OS X x64 (Linux and Solaris too)

2017-02-08 Thread Mandy Chung
> On Feb 8, 2017, at 11:29 AM, Bob Vandette wrote: > > JDK > —— > > http://cr.openjdk.java.net/~bobv/8172670/jdk/webrev.01/ > The jdk change looks fine. If any change to module-info.java.extra in JDK 9 for jdk.vm.compiler, we should make sure the same change

Re: RFR: JDK-8172670: AOT Platform Support for Windows and Mac OS X x64 (Linux and Solaris too)

2017-02-08 Thread Vladimir Kozlov
On 2/8/17 11:29 AM, Bob Vandette wrote: SUMMARY: Please review the following set of changes that adds Ahead-of-time compilation support for Mac OSX and Windows x64 in JDK 10. Linux and Solaris x64 AOT support has also been updated to be consistent with the new 100% Java based binary

RFR: JDK-8172670: AOT Platform Support for Windows and Mac OS X x64 (Linux and Solaris too)

2017-02-08 Thread Bob Vandette
SUMMARY: Please review the following set of changes that adds Ahead-of-time compilation support for Mac OSX and Windows x64 in JDK 10. Linux and Solaris x64 AOT support has also been updated to be consistent with the new 100% Java based binary container support included in this changeset.

Re: RFR: JDK-8174172: Race when building java.base.jmod

2017-02-08 Thread Mandy Chung
> On Feb 8, 2017, at 3:39 AM, Alan Bateman wrote: > > On 08/02/2017 11:33, Erik Joelsson wrote: > >> When building java.base.jmod, we use --hash-modules to include hashes of all >> the non upgradeable jmods in java.base.jmod. The make dependencies are setup >> to

Re: RFR: JDK-8174172: Race when building java.base.jmod

2017-02-08 Thread Alan Bateman
On 08/02/2017 11:33, Erik Joelsson wrote: When building java.base.jmod, we use --hash-modules to include hashes of all the non upgradeable jmods in java.base.jmod. The make dependencies are setup to make sure all non upgradeable jmods are built before java.base.jmod. In some cases, this risks

RFR: JDK-8174172: Race when building java.base.jmod

2017-02-08 Thread Erik Joelsson
When building java.base.jmod, we use --hash-modules to include hashes of all the non upgradeable jmods in java.base.jmod. The make dependencies are setup to make sure all non upgradeable jmods are built before java.base.jmod. In some cases, this risks failing because we have a non upgradeable

Re: RFR [XS] : jspawnhelper build settings cleanup

2017-02-08 Thread Erik Joelsson
Hello Matthias, Thanks for taking this on! You can still remove "INCLUDE_FILES := jspawnhelper.c". Another thing that struck me when looking at this is the inconsistency of sometimes using $(MODULE) and sometimes explicitly using java.base in the paths. I think $(MODULE) is better in this

RFR [XS] : jspawnhelper build settings cleanup

2017-02-08 Thread Baesken, Matthias
Hello all , Erik suggested to do further cleanups in make/launcher/Launcher-java.base.gmk In the jspawnhelper build section. Those were the suggestions : * Inline BUILD_JSPAWNHELPER_SRC, JSPAWNHELPER_CFLAGS, BUILD_JSPAWNHELPER_DST_DIR and LINK_JSPAWNHELPER_OBJECTS. Since these variables