Re: RFR: JDK-8176509 Use pandoc for converting build readme to html

2017-03-13 Thread Erik Joelsson
Looks good. /Erik On 2017-03-13 09:32, Magnus Ihse Bursie wrote: On 2017-03-13 09:17, Erik Joelsson wrote: Hello, Nice to see this handled by make. In UpdateBuildDocs.gmk, the test for PANDOC can be moved out of the macro body and just be executed once. I started out that way, but thought

Re: RFR: JDK-8176509 Use pandoc for converting build readme to html

2017-03-13 Thread Magnus Ihse Bursie
On 2017-03-13 09:17, Erik Joelsson wrote: Hello, Nice to see this handled by make. In UpdateBuildDocs.gmk, the test for PANDOC can be moved out of the macro body and just be executed once. I started out that way, but thought the check more properly belonged in the function. But then again, th

Re: RFR: JDK-8176509 Use pandoc for converting build readme to html

2017-03-13 Thread Erik Joelsson
Hello, Nice to see this handled by make. In UpdateBuildDocs.gmk, the test for PANDOC can be moved out of the macro body and just be executed once. In the recipe, you call CheckLineLength, which I don't see defined anywhere, but then the logic just after the call looks like what would be the i