Re: RFR 8167227: Simplify the JDK 9 API-specification overview page (docs only)

2017-06-19 Thread John Rose
On Jun 18, 2017, at 3:47 AM, mark.reinh...@oracle.com wrote: > > Current output, for reference: > http://download.java.net/java/jdk9/docs/api/overview-summary.html > Yes, the language changes are good. (From a non-legal

Re: Request Review JDK-8182492: docs bundle needs legal notices for 3rd party libraries distributed for javadoc search

2017-06-19 Thread Jonathan Gibbons
Looks good to me. -- Jon On 06/19/2017 10:17 AM, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182492/webrev.00/ JDK docs build enables javadoc search that distributes jquery and jszip. The docs bundle needs to include legal notices for these 3rd party libraries. In

Request Review JDK-8182492: docs bundle needs legal notices for 3rd party libraries distributed for javadoc search

2017-06-19 Thread Mandy Chung
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8182492/webrev.00/ JDK docs build enables javadoc search that distributes jquery and jszip. The docs bundle needs to include legal notices for these 3rd party libraries. In addition, pako.md is missing and fixed in this patch. Mandy

Re: [PATCH] linux-sparc build fixes

2017-06-19 Thread Erik Helin
On 06/19/2017 09:06 AM, John Paul Adrian Glaubitz wrote: On Mon, Jun 19, 2017 at 08:59:38AM +0200, Erik Helin wrote: I'm asking because running the testsuite on Linux sparc64 will only be possible with all four patches applied as they are build fixes. Running the testsuite on Linux x86_64

Re: RFR 8167227: Simplify the JDK 9 API-specification overview page (docs only)

2017-06-19 Thread mark . reinhold
2017/6/19 10:41:09 +0200, erik.joels...@oracle.com: > Looks good to me. > > The change to the log message is a bit weird. Was this meant as a > temporary way for finding the output file? Good catch -- yes, that was temporary. I'll remove it. Thanks, - Mark

Re: RFR 8167227: Simplify the JDK 9 API-specification overview page (docs only)

2017-06-19 Thread Erik Joelsson
Looks good to me. The change to the log message is a bit weird. Was this meant as a temporary way for finding the output file? /Erik On 2017-06-18 12:47, mark.reinh...@oracle.com wrote: http://cr.openjdk.java.net/~mr/rev/8182408/ https://bugs.openjdk.java.net/browse/JDK-8182408 This is a

Re: RFR: JDK-8179537 Update testing.md for more clarity regarding JTReg configuration

2017-06-19 Thread Erik Joelsson
Looks good. /Erik On 2017-06-16 23:44, Magnus Ihse Bursie wrote: Jon pointed out in private conversation that the test suite should be written "JTReg", not "JTreg". I've updated both the new text and all old instances. New webrev:

Re: [PATCH] linux-sparc build fixes

2017-06-19 Thread John Paul Adrian Glaubitz
On Mon, Jun 19, 2017 at 08:59:38AM +0200, Erik Helin wrote: > > I'm asking because running the testsuite on Linux sparc64 will only be > > possible with all four patches applied as they are build fixes. Running > > the testsuite on Linux x86_64 will be possible, of course. > > Ok, this is the

Re: [PATCH] linux-sparc build fixes

2017-06-19 Thread Erik Helin
On 06/18/2017 01:40 AM, John Paul Adrian Glaubitz wrote: > Hi Erik! > > On 06/14/2017 02:04 PM, John Paul Adrian Glaubitz wrote: >> On Wed, Jun 14, 2017 at 01:50:06PM +0200, Erik Helin wrote: >>> thanks for contributing and signing the OCA! >> >> Thanks for reviewing my patches ;-). > > My OCA