Re: [RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

2017-09-27 Thread John Paul Adrian Glaubitz
On 09/27/2017 09:57 PM, John Paul Adrian Glaubitz wrote:> On 09/27/2017 08:51 PM, Kim Barrett wrote: Looks good. Please update the copyright in oopMap.cpp. Done [1]. Just a second, please. I just ran into build errors. Please don't merge as is. Adrian -- .''`. John Paul Adrian Glaubitz

Re: [RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

2017-09-27 Thread John Paul Adrian Glaubitz
Hi Kim! On 09/27/2017 08:51 PM, Kim Barrett wrote: Looks good. Please update the copyright in oopMap.cpp. Done [1]. Adrian [1] http://cr.openjdk.java.net/~glaubitz/8186578/webrev.03/ -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - [email protected] `. `' Freie Univers

Re: [RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

2017-09-27 Thread Magnus Ihse Bursie
Build change looks good. /Magnus On 2017-09-27 18:40, John Paul Adrian Glaubitz wrote: Hello! Zero currently fails to build on linux-sparc since there are two instances where SPARC-specific defines conflict with the Zero code. One instance is src/hotspot/share/compiler/oopMap.cpp where a he

Re: [RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

2017-09-27 Thread Kim Barrett
> On Sep 27, 2017, at 12:40 PM, John Paul Adrian Glaubitz > wrote: > > Hello! > > Zero currently fails to build on linux-sparc since there are two instances > where > SPARC-specific defines conflict with the Zero code. > > […] > The webrev to fix the Zero build on SPARC includes both changes

Re: [RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

2017-09-27 Thread Andrew Haley
On 27/09/17 17:47, John Paul Adrian Glaubitz wrote: > On 09/27/2017 06:46 PM, Andrew Haley wrote: >> On 27/09/17 17:40, John Paul Adrian Glaubitz wrote: >>> The webrev to fix the Zero build on SPARC includes both changes and can be >>> found >>> in [1]. >> >> That looks right, but I think the rele

Re: [RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

2017-09-27 Thread John Paul Adrian Glaubitz
On 09/27/2017 06:46 PM, Andrew Haley wrote: On 27/09/17 17:40, John Paul Adrian Glaubitz wrote: The webrev to fix the Zero build on SPARC includes both changes and can be found in [1]. That looks right, but I think the release JDK 9 is done. We'll have to stage the fix for the JDK 9 updates p

Re: [RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

2017-09-27 Thread Andrew Haley
On 27/09/17 17:40, John Paul Adrian Glaubitz wrote: > The webrev to fix the Zero build on SPARC includes both changes and can be > found > in [1]. That looks right, but I think the release JDK 9 is done. We'll have to stage the fix for the JDK 9 updates project. -- Andrew Haley Java Platform L

[RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

2017-09-27 Thread John Paul Adrian Glaubitz
Hello! Zero currently fails to build on linux-sparc since there are two instances where SPARC-specific defines conflict with the Zero code. One instance is src/hotspot/share/compiler/oopMap.cpp where a header is uncondtionally included for SPARC which is not available for Zero. It turns out tha

Re: RFR: JDK-8188034 InitSupport does not properly include closed file

2017-09-27 Thread Erik Joelsson
Ouch, looks good. /Erik On 2017-09-27 15:41, Magnus Ihse Bursie wrote: After the forest consolidation, InitSupport.gmk does not properly include the closed file, since it's not using the normal inclusion mechanism (due to the SPEC not being available yet). Bug: https://bugs.openjdk.java.net

Re: RFR: JDK-8188034 InitSupport does not properly include closed file

2017-09-27 Thread Tim Bell
Magnus: After the forest consolidation, InitSupport.gmk does not properly include the closed file, since it's not using the normal inclusion mechanism (due to the SPEC not being available yet). Bug: https://bugs.openjdk.java.net/browse/JDK-8188034 Patch inline: diff --git a/make/InitSupport.gmk

RFR: JDK-8188034 InitSupport does not properly include closed file

2017-09-27 Thread Magnus Ihse Bursie
After the forest consolidation, InitSupport.gmk does not properly include the closed file, since it's not using the normal inclusion mechanism (due to the SPEC not being available yet). Bug: https://bugs.openjdk.java.net/browse/JDK-8188034 Patch inline: diff --git a/make/InitSupport.gmk b/make/

Re: permission issues when running make

2017-09-27 Thread Maurizio Cimadamore
ah - got it the script I use for rsyncing was excluding all stuff in build/** - meaning that I ended up with an inconsistent spec.gmk. Apparently, the name of this variable changed: http://hg.openjdk.java.net/jdk10/master/rev/92fd0e04e0e1 And so my sync setup flaw was exposed. Sorry for the

Re: permission issues when running make

2017-09-27 Thread Maurizio Cimadamore
On a problematic repo I tried to compare the spec.gmk before/after the configure run - there's a difference which seems to be causing this issue: The buggy spec.gmk (which causes the permission issues) has this: BUILD_OUTPUT:=/w/master/build/linux-x86_64-normal-server-release # Colon left out t

Re: permission issues when running make

2017-09-27 Thread David Holmes
On 27/09/2017 8:19 PM, Maurizio Cimadamore wrote: On 27/09/17 10:51, David Holmes wrote: On 27/09/2017 7:46 PM, Maurizio Cimadamore wrote: Hi, I sometimes encounter this (consolidated repo only): $ make /usr/bin/tee: /bin/mkdir: /build.logcannot create directory ‘/make-support’: Permission de

Re: permission issues when running make

2017-09-27 Thread Maurizio Cimadamore
On 27/09/17 10:51, David Holmes wrote: On 27/09/2017 7:46 PM, Maurizio Cimadamore wrote: Hi, I sometimes encounter this (consolidated repo only): $ make /usr/bin/tee: /bin/mkdir: /build.logcannot create directory ‘/make-support’: Permission denied: Permission denied /usr/bin/tee: /build.lo

Re: RFR: JDK-8188013 symbolgenerator targets jdk 9 source

2017-09-27 Thread Jan Lahoda
Looks good. Jan On 27.9.2017 11:29, Magnus Ihse Bursie wrote: In make/langtools/src/classes/build/tools/symbolgenerator/TransitiveDependencies.java, javac gets called with a fixed command line. This includes the arguments "-source 9 -target 9". While this was fine for jdk9, in jdk10 this result

Re: permission issues when running make

2017-09-27 Thread David Holmes
On 27/09/2017 7:46 PM, Maurizio Cimadamore wrote: Hi, I sometimes encounter this (consolidated repo only): $ make /usr/bin/tee: /bin/mkdir: /build.logcannot create directory ‘/make-support’: Permission denied: Permission denied /usr/bin/tee: /build.log: Permission denied Building target 'defa

permission issues when running make

2017-09-27 Thread Maurizio Cimadamore
Hi, I sometimes encounter this (consolidated repo only): $ make /usr/bin/tee: /bin/mkdir: /build.logcannot create directory ‘/make-support’: Permission denied: Permission denied /usr/bin/tee: /build.log: Permission denied Building target 'default (exploded-image)' in configuration 'linux-x86_

Re: RFR: JDK-8188012 Nashorn build targets version 9 source

2017-09-27 Thread David Holmes
On 27/09/2017 7:26 PM, Magnus Ihse Bursie wrote: On 2017-09-27 10:55, David Holmes wrote: On 27/09/2017 6:30 PM, Magnus Ihse Bursie wrote: The nashorn java code requires a somewhat convoluted compilation. As a result, we use a special java compiler setup, GENERATE_NEWBYTECODE_DEBUG. This e

Re: running tests from make causes spurious repo changes

2017-09-27 Thread Erik Joelsson
On 2017-09-27 11:36, Erik Joelsson wrote: Ah good find and I stand corrected. That relative path check does need to change for this to continue working as before. What I don't understand is why the chmod is needed and why it's only done when not running from a hg repo. We don't allow executa

Re: running tests from make causes spurious repo changes

2017-09-27 Thread Erik Joelsson
Ah good find and I stand corrected. That relative path check does need to change for this to continue working as before. What I don't understand is why the chmod is needed and why it's only done when not running from a hg repo. We don't allow executable files in the repository so if +x was req

Re: RFR: JDK-8188013 symbolgenerator targets jdk 9 source

2017-09-27 Thread Erik Joelsson
Looks good to me. /Erik On 2017-09-27 11:29, Magnus Ihse Bursie wrote: In make/langtools/src/classes/build/tools/symbolgenerator/TransitiveDependencies.java, javac gets called with a fixed command line. This includes the arguments "-source 9 -target 9". While this was fine for jdk9, in jdk1

RFR: JDK-8188013 symbolgenerator targets jdk 9 source

2017-09-27 Thread Magnus Ihse Bursie
In make/langtools/src/classes/build/tools/symbolgenerator/TransitiveDependencies.java, javac gets called with a fixed command line. This includes the arguments "-source 9 -target 9". While this was fine for jdk9, in jdk10 this results in the following warning: warning: [options] bootstrap cla

Re: running tests from make causes spurious repo changes

2017-09-27 Thread Maurizio Cimadamore
I did a bit of digging on this one, I found out that the permissions are indeed changed by make - see test/TestCommon.gmk: # Prep for output # Change execute permissions on shared library files. # Files in repositories should never have execute permissions, but # there are some tests that have p

Re: RFR: JDK-8188012 Nashorn build targets version 9 source

2017-09-27 Thread Sundararajan Athijegannathan
We run nasgen tool on the generated nashorn .class files to post-process. nasgen used to run on boot JDK in the past (if I recall right). I'm fine with current change is okay - so long as nasgen works fine & nashorn tests run fine. Please note that nashorn tests are run with "ant". cd $jd

Re: RFR: JDK-8188012 Nashorn build targets version 9 source

2017-09-27 Thread Magnus Ihse Bursie
On 2017-09-27 10:55, David Holmes wrote: On 27/09/2017 6:30 PM, Magnus Ihse Bursie wrote: The nashorn java code requires a somewhat convoluted compilation. As a result, we use a special java compiler setup, GENERATE_NEWBYTECODE_DEBUG. This explicitly lists -source 9 -target 9, which generate

Re: RFR: JDK-8188012 Nashorn build targets version 9 source

2017-09-27 Thread David Holmes
On 27/09/2017 6:30 PM, Magnus Ihse Bursie wrote: The nashorn java code requires a somewhat convoluted compilation. As a result, we use a special java compiler setup, GENERATE_NEWBYTECODE_DEBUG. This explicitly lists -source 9 -target 9, which generates this warning: warning: [options] boots

Re: RFR: JDK-8188012 Nashorn build targets version 9 source

2017-09-27 Thread Erik Joelsson
Looks good. /Erik On 2017-09-27 10:30, Magnus Ihse Bursie wrote: The nashorn java code requires a somewhat convoluted compilation. As a result, we use a special java compiler setup, GENERATE_NEWBYTECODE_DEBUG. This explicitly lists -source 9 -target 9, which generates this warning: warni

RFR: JDK-8188012 Nashorn build targets version 9 source

2017-09-27 Thread Magnus Ihse Bursie
The nashorn java code requires a somewhat convoluted compilation. As a result, we use a special java compiler setup, GENERATE_NEWBYTECODE_DEBUG. This explicitly lists -source 9 -target 9, which generates this warning: warning: [options] bootstrap class path not set in conjunction with -sour