Boot JDK version; was Re: RFR: JDK-8188312 Use CDS if present when running the Boot JDK during build

This thread brings up the question ... when are we going to switch to JDK 9 as the required boot JDK? Is there any compelling reason to -not- upgrade yet? -- Jon On 10/3/17 1:37 PM, Magnus Ihse Bursie wrote: It might be the case that we should not really continue with this as long as we hav

Re: RFR: JDK-8188312 Use CDS if present when running the Boot JDK during build

On 10/5/17 2:35 AM, Magnus Ihse Bursie wrote: On 2017-10-05 11:07, Claes Redestad wrote: On 2017-10-05 10:59, Magnus Ihse Bursie wrote: How often is -Xbootclasspath/p used? Why not use "-XX:-VerifySharedSpaces -XX:SharedArchiveFile=local.jsa -Xshare:auto"? That way you will have the star

RE: Building OpenJDK9 on MSYS2

Hi Magnus, So first of all, here is the current patch, which I was not able to attach: https://pastebin.com/pwT4Ynxc >> That's surprising, since gcc is prefixed with fixpath, which it should not. Actually you DO need fixpath IMHO. This is a mingw64 version of the gcc (/C/msys64/mingw64/bin/gcc),

Re: RFR: JDK-8188814 Simplify IncludeCustomExtension

Looks good. /Erik On 2017-10-05 12:02, Magnus Ihse Bursie wrote: Now that we only have a single repo, the first argument to IncludeCustomExtension is no longer needed. I looked at some more ambitious ways to simplify IncludeCustomExtension. Getting make to automatically retrieve the name o

Re: RFR: JDK-8188312 Use CDS if present when running the Boot JDK during build

On 2017-10-05 11:35, Magnus Ihse Bursie wrote: Using -Xshare:auto should mean any case where a CDS archive can't be used (for whatever reason) should be silently ignored.  I'd be more worried if -Xshare:on didn't fail in this case! But we're actively disabling verification of the CDS archive

Re: RFR: JDK-8188814 Simplify IncludeCustomExtension

Looks good. Thanks, David On 5/10/2017 8:02 PM, Magnus Ihse Bursie wrote: Now that we only have a single repo, the first argument to IncludeCustomExtension is no longer needed. I looked at some more ambitious ways to simplify IncludeCustomExtension. Getting make to automatically retrieve the

Re: Building OpenJDK9 on MSYS2

On 2017-10-05 11:59, Peter Budai wrote: Hi Magnus and Erik, I really appreciate your quick feedback. I assumed that it won’t be easy, but I just don’t feel I should give up now  - maybe later when I see the real scale of work. So bear with me for a time being. Attached is a patch which alr

Re: Building OpenJDK9 on MSYS2

On 5/10/2017 8:00 PM, Peter Budai wrote: Now the attachment as well… Attachments get stripped by the mail list servers. David Sent from Mail for Windows 10 From: Peter Budai Sent: Thursday, October 5, 2017 11:59

RFR: JDK-8188814 Simplify IncludeCustomExtension

Now that we only have a single repo, the first argument to IncludeCustomExtension is no longer needed. I looked at some more ambitious ways to simplify IncludeCustomExtension. Getting make to automatically retrieve the name of the file is just so tantalizingly close to possible, but ultima

RE: Building OpenJDK9 on MSYS2

Now the attachment as well… Sent from Mail for Windows 10 From: Peter Budai Sent: Thursday, October 5, 2017 11:59 AM To: Magnus Ihse Bursie; Erik Joelsson

RE: Building OpenJDK9 on MSYS2

Hi Magnus and Erik, I really appreciate your quick feedback. I assumed that it won’t be easy, but I just don’t feel I should give up now - maybe later when I see the real scale of work. So bear with me for a time being. Attached is a patch which already includes Magnus’ changes, plus a few whi

Re: RFR: JDK-8188312 Use CDS if present when running the Boot JDK during build

On 2017-10-05 11:07, Claes Redestad wrote: On 2017-10-05 10:59, Magnus Ihse Bursie wrote: How often is -Xbootclasspath/p used? Why not use "-XX:-VerifySharedSpaces -XX:SharedArchiveFile=local.jsa -Xshare:auto"? That way you will have the start-up benefit if possible. My worry here is that

Re: Building OpenJDK9 on MSYS2

On 2017-10-05 10:10, Erik Joelsson wrote: Hello Peter, On 2017-10-04 21:15, Peter Budai wrote: Hi Magnus, Thanks for the quick reply I’ll check these patches with msys2. Let me specify with more details what I’d like to achieve: I’d like to build OpenJDK9 with MSYS2 MINGW64 environment usin

Re: RFR: JDK-8188312 Use CDS if present when running the Boot JDK during build

On 2017-10-05 10:59, Magnus Ihse Bursie wrote: How often is -Xbootclasspath/p used? Why not use "-XX:-VerifySharedSpaces -XX:SharedArchiveFile=local.jsa -Xshare:auto"? That way you will have the start-up benefit if possible. My worry here is that -Xshare:auto will not work correctly if -Xb

Re: RFR: JDK-8188312 Use CDS if present when running the Boot JDK during build

On 2017-10-04 16:43, Ioi Lam wrote: On 10/4/17 2:01 AM, Magnus Ihse Bursie wrote: On 2017-10-04 10:47, Magnus Ihse Bursie wrote: On 2017-10-04 02:36, Ioi Lam wrote: If you use SharedArchiveFile, you should set -XX:-VerifySharedSpaces at the same time. Long story short -- for security, we

Re: Building OpenJDK9 on MSYS2

Hello Peter, On 2017-10-04 21:15, Peter Budai wrote: Hi Magnus, Thanks for the quick reply I’ll check these patches with msys2. Let me specify with more details what I’d like to achieve: I’d like to build OpenJDK9 with MSYS2 MINGW64 environment using gcc toolchain. (I’m not sure how familia

Re: RFR: JDK-8188768 Fix interaction between make and autoconf after consolidation

Hello David, On 2017-10-04 23:22, David Holmes wrote: Hi Magnus, On 4/10/2017 10:40 PM, Magnus Ihse Bursie wrote: Since the forest consolidation, multiple "paper-cut" issues have appeared. This patch will deal with the following issues: * Changes in autoconf files will no longer cause make