Re: macOS High Sierra, version 10.13.2 configure: error: Could not find freetype! You might be able to fix this by running 'brew install freetype'

2018-02-12 Thread Erik Joelsson
Hello, I just tried this myself and configure is automatically picking up my freetype from brew in /usr/local/opt/freetype/. Looking at my log, this is done using pkg-config from brew. So you could try installing pkg-config (brew install pkg-config). You can also try adding

macOS High Sierra, version 10.13.2 configure: error: Could not find freetype! You might be able to fix this by running 'brew install freetype'

2018-02-12 Thread mbl
OS: macOS High Sierra, version 10.13.2 Repo : https://github.com/dmlloyd/openjdk.git Branch : jdk/jdk mbldeMacBook-Pro:openjdk mbl$ bash ./configure --with-boot-jdk=/Library/Java/JavaVirtualMachines/jdk9.0.4.jdk/Home configure: Configuration created at Mon Feb 12 14:43:36 CST 2018. configure:

Re: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build

2018-02-12 Thread Thomas Stüfe
On Mon, Feb 12, 2018 at 4:41 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > On 2018-02-12 15:32, Thomas Stüfe wrote: > >> Hi all, >> >> may I have a sponsor please? I am not sure whether I am allowed to push >> myself, and if yes, to which repository. >> > > Since the removal of

Re: RFR: JDK-8197571 Change storage location for generated-configure.sh

2018-02-12 Thread Thomas Stüfe
On Mon, Feb 12, 2018 at 4:38 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > > On 2018-02-12 14:57, Thomas Stüfe wrote: > > > > On Mon, Feb 12, 2018 at 2:53 PM, Magnus Ihse Bursie < > magnus.ihse.bur...@oracle.com> wrote: > >> On 2018-02-12 14:47, Thomas Stüfe wrote: >> >> Hi

Re: RFR: JDK-8197571 Change storage location for generated-configure.sh

2018-02-12 Thread Magnus Ihse Bursie
On 2018-02-12 14:57, Thomas Stüfe wrote: On Mon, Feb 12, 2018 at 2:53 PM, Magnus Ihse Bursie > wrote: On 2018-02-12 14:47, Thomas Stüfe wrote: Hi Magnus, Thanks a lot for fixing this! I tried my

Re: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build

2018-02-12 Thread Magnus Ihse Bursie
On 2018-02-12 15:32, Thomas Stüfe wrote: Hi all, may I have a sponsor please? I am not sure whether I am allowed to push myself, and if yes, to which repository. Since the removal of generated-configure.sh you don't need a sponsor just because you touch autoconf files. So for jdk/jdk, you're

Re: RFR: JDK-8197571 Change storage location for generated-configure.sh

2018-02-12 Thread Tim Bell
Magnus: Looks good to me as well. /Tim On 02/12/18 06:31, Volker Simonis wrote: Hi Magnus, thanks for doing this change. It was actually on my TODO list but I somehow forgot about it :) The change looks good. Thumb up from me, Volker On Mon, Feb 12, 2018 at 2:09 PM, Magnus Ihse Bursie

Re: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build

2018-02-12 Thread Thomas Stüfe
Please disregard my last mail, the change has just been pushed. Thanks, Thomas On Mon, Feb 12, 2018 at 3:32 PM, Thomas Stüfe wrote: > Hi all, > > may I have a sponsor please? I am not sure whether I am allowed to push > myself, and if yes, to which repository. > > I

Re: RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build

2018-02-12 Thread Thomas Stüfe
Hi all, may I have a sponsor please? I am not sure whether I am allowed to push myself, and if yes, to which repository. I have three reviewers already. Thank you! Thomas On Thu, Feb 8, 2018 at 3:42 PM, Thomas Stüfe wrote: > Hi, > > may I please have reviews for

Re: RFR: JDK-8197571 Change storage location for generated-configure.sh

2018-02-12 Thread Volker Simonis
Hi Magnus, thanks for doing this change. It was actually on my TODO list but I somehow forgot about it :) The change looks good. Thumb up from me, Volker On Mon, Feb 12, 2018 at 2:09 PM, Magnus Ihse Bursie wrote: > In JDK-8195689, the generated-configure.sh was

Re: RFR: JDK-8196356: Changes to m4 files don't trigger autoconf execution at build time

2018-02-12 Thread Magnus Ihse Bursie
On 2018-02-10 12:29, Thomas Stüfe wrote: On Sat, Feb 10, 2018 at 9:12 AM, Alan Bateman wrote: On 08/02/2018 17:49, Erik Joelsson wrote: The check for when to generate the generated configure script is not working quite as expected. It currently only compares

Re: RFR: JDK-8197571 Change storage location for generated-configure.sh

2018-02-12 Thread Thomas Stüfe
On Mon, Feb 12, 2018 at 2:53 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > On 2018-02-12 14:47, Thomas Stüfe wrote: > > Hi Magnus, > > Thanks a lot for fixing this! I tried my configuration as described in > earlier mails, and the configure scripts gets now created in the

Re: RFR: JDK-8197571 Change storage location for generated-configure.sh

2018-02-12 Thread Magnus Ihse Bursie
On 2018-02-12 14:47, Thomas Stüfe wrote: Hi Magnus, Thanks a lot for fixing this! I tried my configuration as described in earlier mails, and the configure scripts gets now created in the output directory as expected. Some notes: - would it be possible to write out the path name of the

Re: RFR: JDK-8197571 Change storage location for generated-configure.sh

2018-02-12 Thread Thomas Stüfe
Hi Magnus, Thanks a lot for fixing this! I tried my configuration as described in earlier mails, and the configure scripts gets now created in the output directory as expected. Some notes: - would it be possible to write out the path name of the generated configure shell script? - No concern of

RFR: JDK-8197571 Change storage location for generated-configure.sh

2018-02-12 Thread Magnus Ihse Bursie
In JDK-8195689, the generated-configure.sh was no longer checked in, but locally generated. The selected location for generation ($TOPDIR/.build) was not unproblematic for some use cases. This patch attempts remedy this. The new behaviour will be this:  * If run from $TOPDIR, the storage

Re: RFR: JDK-8196356: Changes to m4 files don't trigger autoconf execution at build time

2018-02-12 Thread Thomas Stüfe
Hi Magnus, On Mon, Feb 12, 2018 at 12:50 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > On 2018-02-10 23:39, Martin Buchholz wrote: > >> I agree. Once you make something lazy-initted you have a concurrency >> problem. And there's no CAS or lock on the filesystem. What

Re: RFR: JDK-8196356: Changes to m4 files don't trigger autoconf execution at build time

2018-02-12 Thread Alan Bateman
On 12/02/2018 11:42, Magnus Ihse Bursie wrote: Why would hidden files be confusing? Or, rephrased, how is this any more confusing than other hidden directories, such as .idea or .jib? I modelled the behaviour on jib. In fact, I was considering using the same directory (.jib), but since the

Re: RFR: JDK-8196356: Changes to m4 files don't trigger autoconf execution at build time

2018-02-12 Thread Magnus Ihse Bursie
On 2018-02-10 23:39, Martin Buchholz wrote: I agree. Once you make something lazy-initted you have a concurrency problem. And there's no CAS or lock on the filesystem. What happens if two configure processes run at exactly the same time, perhaps even with different versions of autoconf? If

Re: RFR: JDK-8196356: Changes to m4 files don't trigger autoconf execution at build time

2018-02-12 Thread Magnus Ihse Bursie
On 2018-02-10 09:12, Alan Bateman wrote: On 08/02/2018 17:49, Erik Joelsson wrote: The check for when to generate the generated configure script is not working quite as expected. It currently only compares timestamps if the local repository has any local changes in the make/autoconf

Re: RFR 8190378: Java EE and CORBA modules removal

2018-02-12 Thread Martijn Verburg
One could almost shed a tear - of joy! This is exactly the use case for the module system that the developer community at large will understand. Thanks for this change and a leaner meaner JDK. Cheers, Martijn On 8 February 2018 at 13:37, Lance Andersen wrote: > > >