Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

> On Mar 24, 2018, at 6:03 AM, Magnus Ihse Bursie > wrote: > > https://bugs.openjdk.java.net/browse/JDK-8200193 -- for jdk.security.auth There is only one function to export and it already has JNIEXPORT, so you can just remove the new $(LIBJAAS_CFLAGS) [1]. Are you going to update your webr

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

Hi Magnus, I appreciate what you are trying to do here but there are reasons this kind of cleanup keeps getting deferred :) - it's not trivial and deals with really old code that isn't always clear. You may have bitten off more than you want to chew here. (And I'm strapped for time to work th

Re: a.out left in root directory when configuring --with-toolchain-type=clang

https://bugs.openjdk.java.net/browse/JDK-8200267 On 2018-03-27 12:35, Martin Buchholz wrote: I notice that running bash ./configure ... leaves an a.out file in the root directory of the jdk, but only after adding configure flags --with-toolchain-type=clang --with-toolchain-path=/usr/lib/llvm-3

a.out left in root directory when configuring --with-toolchain-type=clang

I notice that running bash ./configure ... leaves an a.out file in the root directory of the jdk, but only after adding configure flags --with-toolchain-type=clang --with-toolchain-path=/usr/lib/llvm-3.9/bin (i.e. not when building with default gcc) Probably there's a test compilation whose outp

Re: RFR: 8199138: Add RISC-V support to Zero

On Tue, 2018-03-27 at 17:46 +0900, John Paul Adrian Glaubitz wrote: > On 03/27/2018 05:23 PM, Edward Nevill wrote: > > Sorry for the delay. I was doing another test build on qemu which takes > > about 3 days. > > > > > What confuses me: Why RISCV here and not RISCV64? > > In particular this hun

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

Hi Magnus, just a cursory look, will look in greater detail tomorrow. This is good, thanks for doing this. As I wrote offlist, please remove the painfully wrong AIX "workarounds". I do not know why we did this - the original code is quite old - my assumption is that dlsym(RTLD_NEXT) was not work

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

Build change looks good. I will let someone more informed look at the code changes. /Erik On 2018-03-27 02:42, Magnus Ihse Bursie wrote: When I was about to update jsig.c, I noticed that the four copies for aix, linux, macosx and solaris were basically the same, with only small differences.

Re: RFR: 8199138: Add RISC-V support to Zero

On Tue, 2018-03-27 at 17:46 +0900, John Paul Adrian Glaubitz wrote: > On 03/27/2018 05:23 PM, Edward Nevill wrote: > > @@ -1733,6 +1733,9 @@ > > #ifndef EM_AARCH64 > >#define EM_AARCH64183 /* ARM AARCH64 */ > > #endif > > +#ifndef EM_RISCV /* RISCV *

RE: 8200246 : AIX build fails after adjustments of src/hotspot/share/trace/traceEventClasses.xsl

Thanks Leo . We have tested the same here locally in our OpenJDK night builds . Best regards, Matthias > -Original Message- > From: Leo Korinth [mailto:[email protected]] > Sent: Dienstag, 27. März 2018 14:02 > To: Baesken, Matthias ; 'build- > [email protected]' ; 'hotspot- > d

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

Hi Magnus, I will take a look at this tomorrow. There are some open bugs on jsig regarding the number of signals it can handle on different platforms IIRC. Also the Solaris differences may not be needed as the pthread functions can be used without any concern in most cases. Thanks, David On

Re: RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

On 03/27/2018 06:42 PM, Magnus Ihse Bursie wrote: > * Linux and macosx used a uint32_t/uint64_t instead of sigset_t for jvmsigs, > as aix and solaris do. This is a less robust solution, and the added checks > show > that it has failed in the past. Now all platforms use sigset_t/sigismember(). Ah

RFR (M): JDK-8200298 Unify all unix versions of libjsig/jsig.c

When I was about to update jsig.c, I noticed that the four copies for aix, linux, macosx and solaris were basically the same, with only small differences. Some of the differences were not even well motivated, but were likely the result of this code duplication causing the code to diverge. A be

Re: RFR: 8199138: Add RISC-V support to Zero

On 03/27/2018 05:23 PM, Edward Nevill wrote: > Sorry for the delay. I was doing another test build on qemu which takes about > 3 days. > > Please review the following webrev > > http://cr.openjdk.java.net/~enevill/8199138/webrev.02 > > This has the following additional changes over the previous

Re: RFR: 8199138: Add RISC-V support to Zero

Hi, On Tue, 2018-03-27 at 14:10 +0900, John Paul Adrian Glaubitz wrote: > On 03/24/2018 02:26 AM, Magnus Ihse Bursie wrote: > > > > On 2018-03-20 14:54, Edward Nevill wrote: > > > Thanks for this. I have updated the webrev with the above comment. > > > > > > http://cr.openjdk.java.net/~enevill/8

RE: 8200246 : AIX build fails after adjustments of src/hotspot/share/trace/traceEventClasses.xsl

Hi Matthias, looks good to me, too. Best regards Christoph From: Baesken, Matthias Sent: Dienstag, 27. März 2018 09:23 To: Thomas Stüfe Cc: [email protected]; [email protected]; Simonis, Volker ; Doerr, Martin ; Langer, Christoph Subject: RE: 8200246 : AIX build fails aft

RE: 8200246 : AIX build fails after adjustments of src/hotspot/share/trace/traceEventClasses.xsl

Hi Thomas , thanks for the review . Can I have a second review please ? Best regards, Matthias From: Thomas Stüfe [mailto:[email protected]] Sent: Montag, 26. März 2018 20:14 To: Baesken, Matthias Cc: [email protected]; [email protected]; Simonis, Volker ; Doerr, Mart