RFR: 8201357: ALSA_CFLAGS is needed; was dropped in JDK-8071469

Hi Magnus, please review: 8201357: ALSA_CFLAGS is needed; was dropped in JDK-8071469 http://cr.openjdk.java.net/~martin/webrevs/jdk/ALSA_CFLAGS/ https://bugs.openjdk.java.net/browse/JDK-8201357

Re: Supported platforms

On 10/04/2018 2:40 AM, Mario Torre wrote: On Mon, Apr 9, 2018 at 6:12 PM, Simon Nash wrote: Thanks for this. I think I should clarify what I mean by a supported platform. This would be a platform for which bugs affecting the ability to build a working OpenJDK binary for

Re: [11] RFR: 8189784: Parsing with Java 9 AKST timezone returns the SystemV variant of the timezone

Thanks, Erik. Modified GensrcCLDR.gmk as suggested: http://cr.openjdk.java.net/~naoto/8189784/webrev.03/ Naoto On 4/9/18 4:15 PM, Erik Joelsson wrote: Hello Naoto, Looks good, just a style issue. When breaking a recipe line, please add 4 additional spaces (after the tab) for continuation

slowproduct build

Sometimes I want to debug the product build (I can't bother with turning off all the trueInDebug options in the hotspot globals.hpp). The only way that I have found to do this is:     configure --with-native-debug-symbols=internal     mv spec.gmk spec.gmk.old     cat spec.gmk | sed -e

Re: [11] RFR: 8189784: Parsing with Java 9 AKST timezone returns the SystemV variant of the timezone

Hello Naoto, Looks good, just a style issue. When breaking a recipe line, please add 4 additional spaces (after the tab) for continuation indent [1]. In this case I would also advocate breaking the line sooner to make side by side comparisons easier in the future. /Erik [1]

[11] RFR: 8189784: Parsing with Java 9 AKST timezone returns the SystemV variant of the timezone

Hello, Please review the changes to the following issue: https://bugs.openjdk.java.net/browse/JDK-8189784 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8189784/webrev.02/ There were two causes of the issue. One was that j.t.f.ZoneName contained hard coded mappings

Re: RFR: JDK-8201236 Straighten out dtrace build logic

On 2018-04-06 17:23, Erik Joelsson wrote: Looks good in general. In JvmDtraceObjects.gmk, comment on line 38 needs to be updated. Nice spotting! It was left-over from before. I deleted it, the paragraph above said the same thing but correctly. /Magnus /Erik On 2018-04-06 03:57, Magnus

Re: Supported platforms

On Mon, Apr 9, 2018 at 6:12 PM, Simon Nash wrote: > Thanks for this. I think I should clarify what I mean by a supported > platform. This would be a platform for which bugs affecting the ability > to build a working OpenJDK binary for that platform would be considered > valid

Re: RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols

this through submit[1] and got the following results. SwingSet2 works fine for me on F27. I'm currently running some more tests on RHEL 7. - Mach5 mach5-one-sgehwolf-JDK-8196516-20180409-1036-17877: Builds PASSED. Testing FAILURE. 0 Failed Tests Mach5 Tasks Results Summary NA: 0

Re: Supported platforms

On 09/04/2018 08:55, Magnus Ihse Bursie wrote: Simon, On 2018-04-08 16:30, Simon Nash wrote: On 05/04/2018 02:26, b...@juanantonio.info wrote: Many thanks with the link about the Platforms supported: http://www.oracle.com/technetwork/java/javase/documentation/jdk10certconfig-4417031.html

Re: RFR: JDK-8201263: Traling backslash in VS120COMNTOOLS leads to ugly error message when running tests

Looks good. /Erik On 2018-04-06 21:24, Mikael Vidstedt wrote: Testing revealed that the fix solved the immediate problem of removing the error message, but a similar problem occurred when the resulting JTREG_BASIC_OPTIONS variable is then used. Specifically the problem is that the path

Re: Supported platforms

Hi Magnus, > -Original Message- > Date: Mon, 9 Apr 2018 09:55:09 +0200 > From: Magnus Ihse Bursie > To: Simon Nash , b...@juanantonio.info > Cc: build-dev@openjdk.java.net, hotspot-dev developers > >

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

Hi Matthias, On 09/04/2018 15:38, Baesken, Matthias wrote: Hi Alexey,thanks for the diff provided by you, and for the explanations . I created a second webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8201226.1/ - it adds the diff provided by you(hope that’s fine

RE: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

Hi Alexey,thanks for the diff provided by you, and for the explanations . I created a second webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8201226.1/ - it adds the diff provided by you(hope that’s fine with you) -changes 2 launchers

Re: RFR: JDK-8201267: Disable warnings for VS2017 to enable building

Erik: On 04/09/18 00:56, Magnus Ihse Bursie wrote: On 2018-04-07 01:04, Erik Joelsson wrote: We are rather close to being able to build the JDK using VS2017. There are still some warnings that need to be disabled (separate issues filed to fix them) and some other minor build tweaks that has

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

Hi Matthias, Magnus, The problem is with JNICALL added to the functions. JNICALL expands to __stdcall [1] on Windows. On 64 bit, the modifier has no effect and is ignored. On 32 bit, the modifier changes the way parameters are pass and the function name is decorated with an underscore and

RFR: 8196516: libfontmanager must be built with LDFLAGS allowing unresolved symbols

this through submit[1] and got the following results. SwingSet2 works fine for me on F27. I'm currently running some more tests on RHEL 7. - Mach5 mach5-one-sgehwolf-JDK-8196516-20180409-1036-17877: Builds PASSED. Testing FAILURE. 0 Failed Tests Mach5 Tasks Results Summary

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

Also, I'm not sure if I said it, but I think your original webrev looks good. /Magnus > 9 apr. 2018 kl. 13:38 skrev Baesken, Matthias : > > I did not add JNICALL decorations to any libzip functions , please see > my webrev : > >

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

Those were added by my patch that removed the map files. /Magnus > 9 apr. 2018 kl. 13:38 skrev Baesken, Matthias : > > I did not add JNICALL decorations to any libzip functions , please see > my webrev : > >

RE: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

I did not add JNICALL decorations to any libzip functions , please see my webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8201226/ > , the problem here > is the added JNICALL decoration, which affects only win32 (and incorrectly, > that is). so I wonder which added JNICALL

Re: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

Reinstating the -export command line options is not the way forward here. As I understood it from private conversation with Alexey, the problem here is the added JNICALL decoration, which affects only win32 (and incorrectly, that is). /Magnus 9 apr. 2018 kl. 12:46 skrev Baesken, Matthias

RE: 8201226 missing JNIEXPORT / JNICALL at some places in function declarations/implementations - was : RE: missing JNIEXPORT / JNICALL at some places in function declarations/implementations

> > I think adding prototype of ZIP_CRC32 to zip_util.h is unnecessary as > this function is correctly decorated in CRC32.c and is exported. > Hi Alexey, you are correct on this one . The added declaration does not help with the "Corrupted ZIP library" error . This one can be fixed

Re: Supported platforms

On 09.04.2018 09:55, Magnus Ihse Bursie wrote: There is actually no such thing as a "supported OpenJDK platform". While I hope things may change in the future, OpenJDK as an organization does not publicize any list of "supported" platforms. Oracle publishes a list of platforms they support,

Re: Supported platforms

Simon, On 2018-04-08 16:30, Simon Nash wrote: On 05/04/2018 02:26, b...@juanantonio.info wrote: Many thanks with the link about the Platforms supported: http://www.oracle.com/technetwork/java/javase/documentation/jdk10certconfig-4417031.html This appears to be a list of the platforms that

Re: RFR: JDK-8201267: Disable warnings for VS2017 to enable building

On 2018-04-07 01:04, Erik Joelsson wrote: We are rather close to being able to build the JDK using VS2017. There are still some warnings that need to be disabled (separate issues filed to fix them) and some other minor build tweaks that has surfaced now that Hotspot builds successfully. With