Re: RFR: 8201274: Launch Single-File Source-Code Programs

On 4/25/18 8:53 AM, Jonathan Gibbons wrote: On 04/12/2018 10:20 PM, mandy chung wrote: This looks quite good to me.  One small comment on the source launcher Main class: 122 } catch (InvocationTargetException e) { 123 // leave VM to handle the stacktrace, in the

Re: RFR: 8201274: Launch Single-File Source-Code Programs

On 04/12/2018 10:20 PM, mandy chung wrote: On 4/13/18 4:15 AM, Jonathan Gibbons wrote: Please review an initial implementation for the feature described in JEP 330: Launch Single-File Source-Code Programs. The work is described in the JEP and CSR, and falls into various parts: * The part

Re: RFR: 8179887 - Build failure with glibc >= 2.24: error: 'int readdir_r(DIR*, dirent*, dirent**)' is deprecated

> On Apr 23, 2018, at 3:51 AM, Michal Vala wrote: > > Hi, > > following discussion "RFR: build pragma error with gcc 4.4.7"[1], I'm posting > updated patch replacing deprecated readdir_r with readdir. Bug ID is > JDK-8179887 [2]. > > webrev:

Re: strange configure error on Linux Mint 18.3

On 04/24/2018 06:24 PM, Thomas Stüfe wrote: > Thanks Adrian! > > I installed the build prereqs and now I am fine. Great. I'm glad I was able to help :). > Wiki is good, btw. I have written down instructions for bootstrapping various compilers in Debian since that happens every time we are

Re: RFR: JDK-8202200: set INCLUDE_SA to false on s390x by default -was : RE: INCLUDE_SA/serviceability agent - support on s390x

Looks good to me, Matthias. Thank you, Jini. On 4/24/2018 9:39 PM, Baesken, Matthias wrote: Hi Jini, the removal of the mentioned headers leads to build errors so we better keep it . Error is when the headers are removed :

Re: strange configure error on Linux Mint 18.3

Thanks Adrian! I installed the build prereqs and now I am fine. Wiki is good, btw. Best Regards, Thomas On Tue, Apr 24, 2018 at 3:51 PM, John Paul Adrian Glaubitz wrote: > On 04/24/2018 03:25 PM, Thomas Stüfe wrote: >>> >>> Have you tried "apt build-dep

RFR: JDK-8202200: set INCLUDE_SA to false on s390x by default -was : RE: INCLUDE_SA/serviceability agent - support on s390x

Hi Jini, the removal of the mentioned headers leads to build errors so we better keep it . Error is when the headers are removed : /nb/linuxs390x/nightly/jdk/src/hotspot/share/runtime/vmStructs.cpp:100:31: fatal error: vmStructs_s390.hpp: No such file or directory #include

Re: INCLUDE_SA/serviceability agent - support on s390x

Hi Matthias, Your change looks good to me. It might make sense to also remove the following lines from: src/jdk.hotspot.agent/linux/native/libsaproc/libproc.h 78 #if defined(s390x) 79 #include 80 #endif I am not sure if the following files are required either:

Re: strange configure error on Linux Mint 18.3

On 04/24/2018 03:25 PM, Thomas Stüfe wrote: Have you tried "apt build-dep openjdk-9"? This should install all the necessary build dependencies. This is cool! I did not know that. Unfortunately it seems not to work on my box: thomas@mint18 /shared/projects/openjdk/jdk-jdk/source $ sudo

Re: strange configure error on Linux Mint 18.3

Hi Adrian, On Tue, Apr 24, 2018 at 3:01 PM, John Paul Adrian Glaubitz wrote: > Hi Thomas! > > On 04/24/2018 02:50 PM, Thomas Stüfe wrote: >> >> I got a configure error on a fresh, virgin Linux Mint 18.3 install. I >> have not yet installed anything on that box (the

Re: strange configure error on Linux Mint 18.3

Hi Thomas! On 04/24/2018 02:50 PM, Thomas Stüfe wrote: I got a configure error on a fresh, virgin Linux Mint 18.3 install. I have not yet installed anything on that box (the only thing I installed is autoconf). Have you tried "apt build-dep openjdk-9"? This should install all the necessary

strange configure error on Linux Mint 18.3

Hi all, I got a configure error on a fresh, virgin Linux Mint 18.3 install. I have not yet installed anything on that box (the only thing I installed is autoconf). This fails at a point where normally I would get suggestions about which tools to install with apt-get (which, btw, is really nice).

Re: RFR: build pragma error with gcc 4.4.7

On 04/24/2018 06:11 AM, David Holmes wrote: On 24/04/2018 1:27 PM, Andrew Hughes wrote: On 23 April 2018 at 20:19, Kim Barrett wrote: On Apr 21, 2018, at 11:18 AM, Andrew Hughes wrote: On 19 March 2018 at 23:23, Kim Barrett

Contribution to make/Docs.gmk

Hi, "make/Docs.gmk", JDK_MODULES is only sorted with DOCS_MODULES, where It should also filter-out MODULES_FILTER for javadocs modules. # All modules to have docs generated by docs-jdk-api target >> -JDK_MODULES := $(sort $(DOCS_MODULES)) >> +JDK_MODULES := $(sort $(filter-out