[11] Review Request: 8203308 Remove the appletviewer classes

2018-05-21 Thread Sergey Bylokhov
Hello. Please review the fix for jdk11. Bug: https://bugs.openjdk.java.net/browse/JDK-8203308 Webrev: http://cr.openjdk.java.net/~serb/8203308/webrev.00 Description: - Implementation of the AppletViewer was removed - Tests in sun/applet were removed and TEST.ROOT/TEST.groups were updated - Sm

Re: RFR: JDK-8203497: Bump Jib format version to 1.2

2018-05-21 Thread Tim Bell
Erik: The jib format version is defined in jib-profiles.js. It is used by Jib to identify correct parsing of the file and adjust behavior of Jib if necessary. This version needs to be bumped to 1.2. Bug: https://bugs.openjdk.java.net/browse/JDK-8203497 Webrev: http://cr.openjdk.java.net/~erikj

RFR: JDK-8203497: Bump Jib format version to 1.2

2018-05-21 Thread Erik Joelsson
The jib format version is defined in jib-profiles.js. It is used by Jib to identify correct parsing of the file and adjust behavior of Jib if necessary. This version needs to be bumped to 1.2. Bug: https://bugs.openjdk.java.net/browse/JDK-8203497 Webrev: http://cr.openjdk.java.net/~erikj/82034

Re: RFR(L): 8199255: [TESTBUG] Open source VM testbase default methods tests

2018-05-21 Thread Erik Joelsson
Build changes look ok. /Erik On 2018-05-21 11:34, Mikhailo Seledtsov wrote: Please review this change that will open source VM default method tests. These tests have been used internally for a while, and are now being open sourced. Since this is not an creation of new tests, we would like to

RFR(L): 8199255: [TESTBUG] Open source VM testbase default methods tests

2018-05-21 Thread Mikhailo Seledtsov
Please review this change that will open source VM default method tests. These tests have been used internally for a while, and are now being open sourced. Since this is not an creation of new tests, we would like to keep the changes during this review to a minimum required for open sourcing th

Re: RFR 8203454: Minimal, Zero builds fail after JDK-8202377 (Modularize C2 barriers)

2018-05-21 Thread Erik Joelsson
Looks good. /Erik On 2018-05-19 04:57, Erik Österlund wrote: Hi Aleksey, Looks good. Thanks, /Erik On 2018-05-19 13:52, Aleksey Shipilev wrote: Okay, this also works for Zero, Minimal and server: diff -r 5ec7380f671d make/hotspot/lib/JvmFeatures.gmk --- a/make/hotspot/lib/JvmFeatures.gmk 

Re: [OpenJDK 2D-Dev] RFR(xxxs): 8200052: libjavajpeg: Fix compile warning in jchuff.c

2018-05-21 Thread Alex Kashchenko
Hi, On 05/21/2018 10:14 AM, Thomas Stüfe wrote: On Mon, May 21, 2018 at 11:07 AM, John Paul Adrian Glaubitz wrote: On 05/18/2018 07:09 PM, Thomas Stüfe wrote: The amount of work you have to put into this far outbalances the amount of work the OpenJDK maintainers would have to spend when (if e

Re: [OpenJDK 2D-Dev] RFR(xxxs): 8200052: libjavajpeg: Fix compile warning in jchuff.c

2018-05-21 Thread Thomas Stüfe
On Mon, May 21, 2018 at 11:07 AM, John Paul Adrian Glaubitz wrote: > On 05/18/2018 07:09 PM, Thomas Stüfe wrote: >> The amount of work you have to put into this far outbalances the >> amount of work the OpenJDK maintainers would have to spend when (if >> ever) they were to merge down upstream libj

Re: [OpenJDK 2D-Dev] RFR(xxxs): 8200052: libjavajpeg: Fix compile warning in jchuff.c

2018-05-21 Thread John Paul Adrian Glaubitz
On 05/18/2018 07:09 PM, Thomas Stüfe wrote: > The amount of work you have to put into this far outbalances the > amount of work the OpenJDK maintainers would have to spend when (if > ever) they were to merge down upstream libjpeg. You might have more luck if you replaced libjpeg with libjpeg-turbo

Re: [OpenJDK 2D-Dev] RFR(xxxs): 8200052: libjavajpeg: Fix compile warning in jchuff.c

2018-05-21 Thread Adam Farley8
Thanks for the compliment, but I plan to leave this open for a little while longer. I have already heard back from the 6x community, and they say they are no longer associated with the IJG group (jpegclub.org) that creates 9x. Unless we see the potential for an upstream merge from the sourcefor