Hi Erik,
Thanks for reviewing and sponsoring.
2018-05-31 0:39 GMT+08:00 Erik Joelsson :
> I'll sponsor it.
>
> /Erik
>
>
>
> On 2018-05-29 23:13, Ao Qi wrote:
>>
>> Could someone help to create a bug etc?
>>
>> Thanks,
>> Ao Qi
>> Magnus Ihse Bursie 于2018年5月25日周五 下午
>> 3:42写道：
>>
>>> On 2018-05-
Igor,
It looks good.
Thank you a lot for taking care about this!
Thanks,
Serguei
On 5/23/18 12:44, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev/8199380/webrev.00/
2370 lines changed: 2370 ins; 0 del; 0 mod;
Hi all,
could you please review this patch which open sources AOD tes
Erik:
In my recent cleanup change for the nashorn build, I accidentally
removed a line that caused the nasgen tool to never run. This is causing
a bunch of nashorn tests to fail in tier2. I had run tier1-3 on an
earlier version of the patch, but forgot to rerun after the last edit.
Bug: https:/
In my recent cleanup change for the nashorn build, I accidentally
removed a line that caused the nasgen tool to never run. This is causing
a bunch of nashorn tests to fail in tier2. I had run tier1-3 on an
earlier version of the patch, but forgot to rerun after the last edit.
Bug: https://bugs
I reviewed the delta-webrev (v3). Looks good. Thanks for fixing
missing newlines in launcher.properties
Mandy
On 5/30/18 12:00 PM, Jonathan Gibbons wrote:
Please review a minor update to the proposed implementation of JEP 330.
The primary change is to disallow the use of the "shebang" featur
Please review a minor update to the proposed implementation of JEP 330.
The primary change is to disallow the use of the "shebang" feature in
Java source files
(i.e. files whose name ends in ".java") as recently proposed on this
list [1].
There is some additional minor cleanup to the launcher
Thank you for persevering with this. Please submit a webrev with this
change .. I think you can leave out the change to jerror.h in the jpeg6b
case.
-phil.
On 05/30/2018 09:08 AM, Adam Farley8 wrote:
Hi Phil,
I spoke with the jpegclub rep "Guido", and he was very helpful.
He agreed to accep
Hi Erik,
On Wed, 2018-05-30 at 09:09 -0700, Erik Joelsson wrote:
> Hello,
>
> On 2018-05-30 03:00, David Holmes wrote:
> > Hi Severin,
> >
> > On 30/05/2018 7:15 PM, Severin Gehwolf wrote:
> > > Hi,
> > >
> > > Could I please get a review of this one-liner fix for a bootcycle-
> > > images buil
I'll sponsor it.
/Erik
On 2018-05-29 23:13, Ao Qi wrote:
Could someone help to create a bug etc?
Thanks,
Ao Qi
Magnus Ihse Bursie 于2018年5月25日周五 下午
3:42写道：
On 2018-05-24 03:08, Ao Qi wrote:
Hi Erik,
Thanks for your comments. I made a new patch:
$ hg diff
diff -r 31361382634b make/autoconf/b
Looks good.
/Erik
On 2018-05-30 00:13, David Buck wrote:
Hi!
Please review this very simple fix. The backport for JDK-8034788 [0]
did a lot of refactoring and moved the some code from toolchain.m4 to
flags.m4. Unfortunately, it also unintentionally rolled back my
backport of JDK-8187045 [1
Hello,
On 2018-05-30 03:00, David Holmes wrote:
Hi Severin,
On 30/05/2018 7:15 PM, Severin Gehwolf wrote:
Hi,
Could I please get a review of this one-liner fix for a bootcycle-
images build of the Zero variant (on x86_64)? The proposed change is to
use the big java settings (over small) for t
Hi Phil,
I spoke with the jpegclub rep "Guido", and he was very helpful.
He agreed to accept a code change, but recommended an error instead of a
while check.
-- Line 808:
< while (bits[j] == 0)
< j--;
---
> while (bits[j] == 0) {
> if (j
Hello
Looks good.
/Tim
On 05/30/18 00:13, David Buck wrote:
Hi!
Please review this very simple fix. The backport for JDK-8034788 [0] did
a lot of refactoring and moved the some code from toolchain.m4 to
flags.m4. Unfortunately, it also unintentionally rolled back my backport
of JDK-8187045 [1
Hi Severin,
On 30/05/2018 7:15 PM, Severin Gehwolf wrote:
Hi,
Could I please get a review of this one-liner fix for a bootcycle-
images build of the Zero variant (on x86_64)? The proposed change is to
use the big java settings (over small) for the jdk.compiler's
annotation processing. Thoughts?
Hi,
Could I please get a review of this one-liner fix for a bootcycle-
images build of the Zero variant (on x86_64)? The proposed change is to
use the big java settings (over small) for the jdk.compiler's
annotation processing. Thoughts?
diff --git a/make/gensrc/Gensrc-jdk.internal.vm.compiler.gm
Hi!
Please review this very simple fix. The backport for JDK-8034788 [0] did
a lot of refactoring and moved the some code from toolchain.m4 to
flags.m4. Unfortunately, it also unintentionally rolled back my backport
of JDK-8187045 [1] when it moved this chunk of code. As a result, this
is onl
16 matches
Mail list logo
