Re: Linux + Clang + execstack

2018-09-18 Thread Martin Buchholz
Unfortunately, my gmail marked Arthur's emails to this thread as spam, with ensuing confusion. I retargeted this fix to the new bug 8209817: stack is executable when building with Clang on Linux http://cr.openjdk.java.net/~martin/webrevs/jdk/noexecstack/

Re: [12] RFR: 8209880: tzdb.dat is not reproducibly built

2018-09-18 Thread Alex Kashchenko
Hi, On 09/18/2018 07:22 PM, Erik Joelsson wrote: Looks good to me. I guess it's hard to prove that the output is now stable, but time will tell. /Erik On 2018-09-18 10:41, Naoto Sato wrote: Hello, Please review the fix to the following issue:

Re: [12] RFR: 8209880: tzdb.dat is not reproducibly built

2018-09-18 Thread Erik Joelsson
Looks good to me. I guess it's hard to prove that the output is now stable, but time will tell. /Erik On 2018-09-18 10:41, Naoto Sato wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8209880 The proposed changeset is located at:

[12] RFR: 8209880: tzdb.dat is not reproducibly built

2018-09-18 Thread Naoto Sato
Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8209880 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8209880/webrev.00/ The fix is to remove the use of HashSet/Map which is not guaranteed to preserve the same order on

Re: RFR: 8209093 - JEP 340: One AArch64 Port, Not Two

2018-09-18 Thread Simon Nash
On 18/09/2018 14:17, Bob Vandette wrote: I only did some basic testing of the hard-float abi. Bell SW has offered to do more extensive testing as part of this JEP. I have no way of knowing if any of the other profiles are being used but I would think it’s worth keeping them in the event that

Re: RFR: 8210647: libsaproc is being compiled without optimization.

2018-09-18 Thread Thomas Stüfe
A fix is waiting for review: https://bugs.openjdk.java.net/browse/JDK-8210836 Best Regards, Thomas On Tue, Sep 18, 2018 at 5:09 PM, Anthony Scarpino wrote: > I encountered this too when I build with ‘make’; however if I build through > JIB the error didn’t occur. > > Tony > >> On Sep 18, 2018,

Re: RFR: 8210647: libsaproc is being compiled without optimization.

2018-09-18 Thread Anthony Scarpino
I encountered this too when I build with ‘make’; however if I build through JIB the error didn’t occur. Tony > On Sep 18, 2018, at 2:08 AM, Thomas Stüfe wrote: > > Hi Severin, > > I get reproducable build errors with your fix on my machine (Ubuntu 16.4). > > When I build release (no special

Re: RFF (12): JDK-8207954: Data for --release 11

2018-09-18 Thread Jan Lahoda
On 17.9.2018 20:54, Jonathan Gibbons wrote: Jan, OK for the code changes. Thanks. I still think it would be nice to see makefile support for generating these files, as compared to comments in source coe, but that can be handled separately. Ok, I'll work on that. Thanks, Jan --

Re: RFR: 8209093 - JEP 340: One AArch64 Port, Not Two

2018-09-18 Thread Bob Vandette
I only did some basic testing of the hard-float abi. Bell SW has offered to do more extensive testing as part of this JEP. I have no way of knowing if any of the other profiles are being used but I would think it’s worth keeping them in the event that someone wants to try to build/test these

Re: RFR: 8210647: libsaproc is being compiled without optimization.

2018-09-18 Thread Thomas Stüfe
Hi Severin, On Tue, Sep 18, 2018 at 11:24 AM, Severin Gehwolf wrote: > Hi Thomas, > > On Tue, 2018-09-18 at 11:08 +0200, Thomas Stüfe wrote: >> Hi Severin, >> >> I get reproducable build errors with your fix on my machine (Ubuntu 16.4). >> >> When I build release (no special build options), I

Re: RFR: 8210647: libsaproc is being compiled without optimization.

2018-09-18 Thread Severin Gehwolf
Hi Thomas, On Tue, 2018-09-18 at 11:08 +0200, Thomas Stüfe wrote: > Hi Severin, > > I get reproducable build errors with your fix on my machine (Ubuntu 16.4). > > When I build release (no special build options), I get: > >

Re: RFR: 8210647: libsaproc is being compiled without optimization.

2018-09-18 Thread Thomas Stüfe
Hi Severin, I get reproducable build errors with your fix on my machine (Ubuntu 16.4). When I build release (no special build options), I get: /shared/projects/openjdk/jdk-jdk/source/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c: In function ‘read_exec_segments’: