Unrelated to the proposed change, the test/hotspot/jtreg/Makefile
contains this line:
30
31 USE_JTREG_VERSION := 4.1
That would appear to be somewhat out of date, or (more likely) not used.
-- Jon
On 10/10/2018 09:01 AM, Erik Joelsson wrote:
Looks good.
A side effect of this is that if
> 12 okt. 2018 kl. 18:16 skrev Erik Joelsson :
>
>
>> On 2018-10-12 01:37, Magnus Ihse Bursie wrote:
>> Hi Erik,
>>
>> Thank you for preserving through this, so we finally can move to 100%
>> run-test!
>>
>>> On 2018-10-12 00:29, Erik Joelsson wrote:
>>>
>>> Hello,
>>>
>>> (adding servicea
Hi Erik,
On Fri, 2018-10-12 at 09:09 -0700, Erik Joelsson wrote:
> Looks good to me.
>
> I wonder why only this library has that flag. Perhaps something that
> should be applied more generally or not at all? (In a followup of
> course)
Thanks for the review!
I suppose the original intention wa
On 2018-10-12 01:37, Magnus Ihse Bursie wrote:
Hi Erik,
Thank you for preserving through this, so we finally can move to 100%
run-test!
On 2018-10-12 00:29, Erik Joelsson wrote:
Hello,
(adding serviceability-dev and hotspot-dev for test changes)
Bug: https://bugs.openjdk.java.net/browse
Looks good to me.
I wonder why only this library has that flag. Perhaps something that
should be applied more generally or not at all? (In a followup of course)
/Erik
On 2018-10-12 02:20, Severin Gehwolf wrote:
Hi,
Please review this fix for a build failure of saproc.dll on Windows 32
bit.
Hi Martin,
On Fri, 2018-10-12 at 10:52 +, Doerr, Martin wrote:
> Hi Severin,
>
> thank you for providing this fix so quickly. It looks good to me.
Thanks for testing and the review.
> I was able to build jdk11u with this patch.
>
> Just for information:
> I'm using Visual Studio 2013 and c
Hi Severin,
thank you for providing this fix so quickly. It looks good to me.
I was able to build jdk11u with this patch.
Just for information:
I'm using Visual Studio 2013 and configure with --disable-warnings-as-errors.
(Otherwise I got
Creating support/modules_cmds/jdk.hotspot.agent/jhsdb.exe
Hi,
Please review this fix for a build failure of saproc.dll on Windows 32
bit. For 32 bit Windows builds flag -RTC1 gets added unconditionally.
Yet, as per compiler doc[1] it should only be added for development
builds. This causes a build failure post JDK-8210647 as in
release/fastdebug variant
Hi Erik,
Thank you for preserving through this, so we finally can move to 100%
run-test!
On 2018-10-12 00:29, Erik Joelsson wrote:
Hello,
(adding serviceability-dev and hotspot-dev for test changes)
Bug: https://bugs.openjdk.java.net/browse/JDK-8212028
Webrev: http://cr.openjdk.java.net/~
