RFR: 8213569: Bump minimum boot jdk to JDK 11

2018-11-11 Thread Mikael Vidstedt
Please review this change which bumps the minimum boot jdk to JDK 11 (see [1] for Boot-JDK policy). bug: https://bugs.openjdk.java.net/browse/JDK-8213569 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8213569/webrev.00/open/webrev/

Re: RFR: 8213591 : running bin/idea.sh in Cygwin: generated project cannot be imported - was : RE: bin/idea.sh and Cygwin

2018-11-11 Thread Thomas Stüfe
Hi Michal, I can sponsor for you. @Matthias: yould you test on your Box too if this patch works? Best Regards, Thomas On Mon, Nov 12, 2018 at 5:24 AM Michal Vala wrote: > > Hi Thomas, > > thanks! I've tested on Windows 2012, vs2013. > > Anyone with latest Windows 10 to test this? > > Also I'd

Re: RFR: 8213622 - Windows VS2013 build failure - "'snprintf': identifier not found"

2018-11-11 Thread David Holmes
Hi Michal, On 12/11/2018 2:18 PM, Michal Vala wrote: On 11/10/18 12:07 AM, David Holmes wrote: cc'ing JC Beyler as this was his code. On 10/11/2018 4:35 AM, Kim Barrett wrote: On Nov 9, 2018, at 11:43 AM, Michal Vala wrote: Hi, please review following patch fixing build failure on Window

Re: RFR: 8213622 - Windows VS2013 build failure - "'snprintf': identifier not found"

2018-11-11 Thread Kim Barrett
> On Nov 9, 2018, at 6:07 PM, David Holmes wrote: > > cc'ing JC Beyler as this was his code. > > On 10/11/2018 4:35 AM, Kim Barrett wrote: >>> On Nov 9, 2018, at 11:43 AM, Michal Vala wrote: >>> >>> Hi, >>> >>> please review following patch fixing build failure on Windows with VS2013 >>> too

Re: RFR: 8213591 : running bin/idea.sh in Cygwin: generated project cannot be imported - was : RE: bin/idea.sh and Cygwin

2018-11-11 Thread Michal Vala
Hi Thomas, thanks! I've tested on Windows 2012, vs2013. Anyone with latest Windows 10 to test this? Also I'd like to ask someone to sponsor this, as I'm just an author. On 11/9/18 7:09 PM, Thomas Stüfe wrote: Hi Michal, I tested this and it now works nicely for me (win7, vs2017, with curren

Re: RFR: 8213622 - Windows VS2013 build failure - "'snprintf': identifier not found"

2018-11-11 Thread Michal Vala
On 11/10/18 12:07 AM, David Holmes wrote: cc'ing JC Beyler as this was his code. On 10/11/2018 4:35 AM, Kim Barrett wrote: On Nov 9, 2018, at 11:43 AM, Michal Vala wrote: Hi, please review following patch fixing build failure on Windows with VS2013 toolchain. Not sure we're still suppo

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2018-11-11 Thread Andy Herrick
yes of the nine build system issues brought up by Magnus and Erik (listed in JDK-8212936 ) , only one has been addressed so far. This is at the top of the list of remaining issues we will be working ont: The following additional issues are targeted to be address in the next few weeks: JDK-8212

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

2018-11-11 Thread Alan Bateman
On 10/11/2018 21:59, Magnus Ihse Bursie wrote: I can't see that you've addressed any of the build system changes Erik and I requested? Or is this just a preliminary review, and you intend to go at least one more round before attempting to push? If so, this was not very clear to me. I see Andy