Hi Magnus,
Thanks a lot for your review and helpful comments.
The patch[1] had been tested with Apache NetBeans IDE 9.0 (Build
incubator-netbeans-release-334-on-20180708) on a Linux_64 (amd64) machine.
I've noticed that all files under the specified root will be scanned
automatically when the
> On Jan 15, 2019, at 5:35 AM, Magnus Ihse Bursie
> wrote:
>
> Hi Shura,
>
> I see that this is pushed already, but I still have some questions and/or
> follow-up requests:
>
> 1) Do you expect the jcov-test-* targets to be used often? We've recently ran
> into problems with having too ma
I agree, though, they aren't quite the same, they convert in different
directions.
/Erik
On 2019-01-15 05:18, Magnus Ihse Bursie wrote:
In the future, we should probably consider to make a support function
for those "convert a list of paths between windows and unix" blocks; I
think we have ro
Hi Magnus and Erik,
I have added the link to the repository to README and I have removed
the link to the mailing list thread. I have also recreated the GitHub
repository. Now it is a fork of the mentioned repository with two extra
commits containing README and the build scripts.
New webrev URL: h
On 15/01/2019 00:51, Ichiroh Takiguchi wrote:
Hello Alan.
Could you review the fix again ?
Bug: https://bugs.openjdk.java.net/browse/JDK-8214533
Change: https://cr.openjdk.java.net/~itakiguchi/8214533/webrev.01/
I added IBM29626C charset as standard way.
Please give any suggestion and quest
On 2018-12-25 16:19, Jakub Vaněk wrote:
Hi,
please review this webrev. It is a successor of the softfloat-3 [patch]
thread (first email
http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2018-November/031311.html
)
Changes since the last patch (v6):
- renamed --with-softloat* to --with
On 2019-01-03 08:22, Fu Jie wrote:
Thanks Alan for your review and valuable advice.
I think it's worth keeping a NB project in the repo since it seems
more convenient for IDE developers.
And to keep configurations.xml current is also important.
I made a patch to fix the issue mentioned by Ala
Hi Shura,
I see that this is pushed already, but I still have some questions
and/or follow-up requests:
1) Do you expect the jcov-test-* targets to be used often? We've
recently ran into problems with having too many top-level targets, and
the large amount of targets generated for the jcov-t
In the future, we should probably consider to make a support function
for those "convert a list of paths between windows and unix" blocks; I
think we have roughly the same code in say 5 or 6 locations now...
/Magnus
On 2019-01-09 19:14, Erik Joelsson wrote:
The WSL support in the build does no
Hi Andy,
This is looking really sweet from a build perspective!
Just a few minor nits:
* In Launcher-jdk.jpackage.gmk, please indent the else clause ("$(eval
$(call SetupBuildLauncher, jpackage ") two spaces.
* In Lib-jdk.jpackage.gmk, I think there's still room to prune some more
unnec
On 2018-11-05 15:54, Alan Bateman wrote:
On 05/11/2018 14:21, Magnus Ihse Bursie wrote:
Hi,
Fix looks good, but maybe we should have a regression test of
GetJREPath()?
/Magnus
The fix looks okay but I'm puzzled as to how Eclipse is running into
this. Do they locate/call libjli/GetJREPath
Please do. The lib/jli remnants has been lingering on too far in too
many places. Just be clear in the bug/commit title that this is not just
for AIX.
FWIW, your fix looks good to me.
/Magnus
On 2019-01-15 12:12, Lindenmaier, Goetz wrote:
Ah... a small add on:
There is one other reference t
12 matches
Mail list logo
