Re: Proposal: JDK-8217896: Make better use of LCPUs when building on AIX

2019-01-29 Thread David Holmes
On 30/01/2019 3:05 am, Erik Joelsson wrote: Hello, I'm OK with this, but since I can't verify it at all, I would be more comfortable if one of the other AIX users would review this as well. Ditto. I did some googling on this and pmcycles is flagged as maybe being deprecated in the future

Re: RFR: JDK-8204564: Need better error output when GenerateLinkOptData fails

2019-01-29 Thread Tim Bell
Erik: Some recent build failures reminded me of this issue and increased the need to fix it ASAP to be able to diagnose them. GenerateLinkOptData.gmk runs a java tool to generate data which is later used to optimize the JDK image with jlink. The problem here is that the tool needs to print some

Re: building on WSL

2019-01-29 Thread Jonathan Gibbons
Erik, Thanks for all the info. That really helps ... especially the bit about building for Linux, which I couldn't infer from the --help. FWIW, at this time, you cannot use the existing `bin/jtreg` script in WSL when using a Windows binary to run jtreg: it needs to set the .exe suffix. I'll

RFR: JDK-8204564: Need better error output when GenerateLinkOptData fails

2019-01-29 Thread Erik Joelsson
Hello, Some recent build failures reminded me of this issue and increased the need to fix it ASAP to be able to diagnose them. GenerateLinkOptData.gmk runs a java tool to generate data which is later used to optimize the JDK image with jlink. The problem here is that the tool needs to print

Re: building on WSL

2019-01-29 Thread Erik Joelsson
Hello Jon, On 2019-01-29 16:42, Jonathan Gibbons wrote: This is a question for those folk that have been working on, and more importantly, using, the recently-support for WSL. I'm coming up to speed up actually using WSL myself, so that I can test the various new stuff going into jtreg.

building on WSL

2019-01-29 Thread Jonathan Gibbons
This is a question for those folk that have been working on, and more importantly, using, the recently-support for WSL. I'm coming up to speed up actually using WSL myself, so that I can test the various new stuff going into jtreg. What is the typical way to build OpenJDK for Windows, with

Re: test/hotspot/jtreg/runtime/CompressedOops/UseCompressedOops.java failing with -XX:+UseShenandoahGC on x86_64

2019-01-29 Thread Joseph D. Darcy
On 1/28/2019 8:16 AM, Roman Kennke wrote: Isn't anything pushed to 12 (kindof) automatically pushed to 13 too, eventually? Yes; Jesper regularly syncs changes from 12 into 13. At times this requires addressing merge conflicts, etc. HTH, -Joe

Re: Proposal: JDK-8217896: Make better use of LCPUs when building on AIX

2019-01-29 Thread Erik Joelsson
Hello, I'm OK with this, but since I can't verify it at all, I would be more comfortable if one of the other AIX users would review this as well. /Erik On 2019-01-29 05:08, Andrew Leonard wrote: Hi, Please can I get a sponsor for this build performance enhancement on AIX, by better

Re: [XS] RFR : 8217979: lib-freetype related configure messages contain wrong configure flag names

2019-01-29 Thread Phil Race
+1 -phil. On 1/29/19 8:54 AM, Baesken, Matthias wrote: Thanks ! May I get a second review please ? Best regards, Matthias -Original Message- From: Erik Joelsson Sent: Dienstag, 29. Januar 2019 17:57 To: Baesken, Matthias ; 'build- d...@openjdk.java.net' Subject: Re: [XS] RFR :

RE: [XS] RFR : 8217979: lib-freetype related configure messages contain wrong configure flag names

2019-01-29 Thread Baesken, Matthias
Thanks ! May I get a second review please ? Best regards, Matthias > -Original Message- > From: Erik Joelsson > Sent: Dienstag, 29. Januar 2019 17:57 > To: Baesken, Matthias ; 'build- > d...@openjdk.java.net' > Subject: Re: [XS] RFR : 8217979: lib-freetype related configure messages >

Re: RFR JDK-8217761: Enhance run-test-prebuilt jib profile to support running tests with JCov

2019-01-29 Thread Erik Joelsson
Hello, On 2019-01-29 03:12, Magnus Ihse Bursie wrote: If you are going down this road, you'll need to verify that JCOV_IMAGE_DIR is not empty in RunTests. So keep the ifneq statement, but with an $(error ...) instead. Otherwise we'll just fail spectacularly and incomprehensible later on.

Re: [XS] RFR : 8217979: lib-freetype related configure messages contain wrong configure flag names

2019-01-29 Thread Erik Joelsson
Looks good. /Erik On 2019-01-29 06:24, Baesken, Matthias wrote: Hello, please review this small fix. It changes wrong configure output messages related to freetype . Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8217979 http://cr.openjdk.java.net/~mbaesken/webrevs/8217979.0/

Re: RFR: JDK-8217723 Switch ld from bfd to gold on gcc toolchain

2019-01-29 Thread Volker Simonis
When I last tried gold a few years ago on ppc64 (and ia64, just for the reference :) it didn't work because it didn't support all the required relocations. However, a current experiment with "GNU gold (GNU Binutils for Ubuntu 2.26.1) 1.11" on Ubuntu 16.04/ppc64le succeeded and improved the link

[XS] RFR : 8217979: lib-freetype related configure messages contain wrong configure flag names

2019-01-29 Thread Baesken, Matthias
Hello, please review this small fix. It changes wrong configure output messages related to freetype . Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8217979 http://cr.openjdk.java.net/~mbaesken/webrevs/8217979.0/ Thanks, Matthias

Proposal: JDK-8217896: Make better use of LCPUs when building on AIX

2019-01-29 Thread Andrew Leonard
Hi, Please can I get a sponsor for this build performance enhancement on AIX, by better determining the number of LCPUs on smt AIX machines: https://cr.openjdk.java.net/~aleonard/8217896/webrev.00/ My testing shows up to 30% improved build times when leveraging the available LCPUs. Many

RE: JDK-8217880 AIX build issue about JDK-8214533

2019-01-29 Thread Ichiroh Takiguchi
To reviewers, Thank you for reviewing in a short time. Best regards, Ichiroh Takiguchi On 2019-01-29 20:20, Lindenmaier, Goetz wrote: Pushed. Best regards, Goetz -Original Message- From: Ichiroh Takiguchi Sent: Dienstag, 29. Januar 2019 11:30 To: Lindenmaier, Goetz Cc: build-dev

RE: JDK-8217880 AIX build issue about JDK-8214533

2019-01-29 Thread Lindenmaier, Goetz
Pushed. Best regards, Goetz > -Original Message- > From: Ichiroh Takiguchi > Sent: Dienstag, 29. Januar 2019 11:30 > To: Lindenmaier, Goetz > Cc: build-dev ; ppc-aix-port-dev d...@openjdk.java.net>; core-libs-...@openjdk.java.net; Baesken, Matthias > > Subject: RE: JDK-8217880 AIX

Re: RFR JDK-8217761: Enhance run-test-prebuilt jib profile to support running tests with JCov

2019-01-29 Thread Magnus Ihse Bursie
If you are going down this road, you'll need to verify that JCOV_IMAGE_DIR is not empty in RunTests. So keep the ifneq statement, but with an $(error ...) instead. Otherwise we'll just fail spectacularly and incomprehensible later on. /Magnus > 28 jan. 2019 kl. 18:47 skrev Erik Joelsson : >

RE: JDK-8217880 AIX build issue about JDK-8214533

2019-01-29 Thread Baesken, Matthias
Looks good to me . The patch fixed the AIX build. Best regards, Matthias > -Original Message- > From: Ichiroh Takiguchi > Sent: Dienstag, 29. Januar 2019 11:30 > To: Lindenmaier, Goetz > Cc: build-dev ; ppc-aix-port-dev port-...@openjdk.java.net>; core-libs-...@openjdk.java.net;

Re: RFR: JDK-8217910: Slow linking with devkit on Linux

2019-01-29 Thread Magnus Ihse Bursie
> 28 jan. 2019 kl. 23:17 skrev Erik Joelsson : > > Hello, > > While investigating performance with different linkers and linker > configuration, we discovered that the devkit linker on Linux (both bfd and > gold) was a lot slower than the native linker on Ubuntu (23s vs 12s for bfd > to

Re: RFR: JDK-8217880 AIX build issue about JDK-8214533

2019-01-29 Thread Magnus Ihse Bursie
> 29 jan. 2019 kl. 02:21 skrev Ichiroh Takiguchi : > > Hello. > > Sorry about build issue for JDK-8214533. > > EUC_JP was extra entry on make/data/charsetmapping/stdcs-aix. > > Bug:https://bugs.openjdk.java.net/browse/JDK-8217880 > Change:

RE: JDK-8217880 AIX build issue about JDK-8214533

2019-01-29 Thread Ichiroh Takiguchi
Hello Goetz. Thank you for build testing. Yes, I need a sponsor. If possible, could you handle it ? Thanks, Ichiroh Takiguchi On 2019-01-29 19:17, Lindenmaier, Goetz wrote: Hi, this looks good, the build works with this patch. Do you need a sponsor? Best regards, Goetz. -Original

RE: JDK-8217880 AIX build issue about JDK-8214533

2019-01-29 Thread Lindenmaier, Goetz
Hi, this looks good, the build works with this patch. Do you need a sponsor? Best regards, Goetz. > -Original Message- > From: Ichiroh Takiguchi > Sent: Dienstag, 29. Januar 2019 02:21 > To: Lindenmaier, Goetz > Cc: build-dev ; ppc-aix-port-dev d...@openjdk.java.net>;